[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

This revision was automatically updated to reflect the committed changes. Closed by commit rL320966: Reduce x86 register context boilerplate. (authored by labath, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41245 Files:

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

labath added inline comments. Comment at: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3496 + + auto Decompressor = llvm::object::Decompressor::create( + section->GetName().GetStringRef(), tzik wrote: > This adds new dependency to LLVM Object

[Lldb-commits] [PATCH] D41069: NPL: Clean up handling of inferior exit

This revision was automatically updated to reflect the committed changes. Closed by commit rL320961: NPL: Clean up handling of inferior exit (authored by labath, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41069 Files:

[Lldb-commits] [lldb] r320967 - Add LLVMObject dependency to our ObjectFileELF plugin

Author: labath Date: Mon Dec 18 02:51:03 2017 New Revision: 320967 URL: http://llvm.org/viewvc/llvm-project?rev=320967=rev Log: Add LLVMObject dependency to our ObjectFileELF plugin Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/CMakeLists.txt Modified:

[Lldb-commits] [lldb] r320966 - Reduce x86 register context boilerplate.

Author: labath Date: Mon Dec 18 02:50:59 2017 New Revision: 320966 URL: http://llvm.org/viewvc/llvm-project?rev=320966=rev Log: Reduce x86 register context boilerplate. Summary: The x86 FPR struct was defined as a struct containing a union between two members: XSAVE and FXSAVE. This patch makes

[Lldb-commits] [lldb] r320961 - NPL: Clean up handling of inferior exit

Author: labath Date: Mon Dec 18 01:44:29 2017 New Revision: 320961 URL: http://llvm.org/viewvc/llvm-project?rev=320961=rev Log: NPL: Clean up handling of inferior exit Summary: lldb-server was sending the "exit" packet (W??) twice. This happened because it was handling both the pre-exit

[Lldb-commits] [PATCH] D41070: llgs: Propagate the environment when launching the inferior from command line

This revision was automatically updated to reflect the committed changes. Closed by commit rL320984: llgs: Propagate the environment when launching the inferior from command line (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D41070?vs=126367=127349#toc

[Lldb-commits] [lldb] r320985 - Fix regression in jModulesInfo packet handling

Author: labath Date: Mon Dec 18 06:31:44 2017 New Revision: 320985 URL: http://llvm.org/viewvc/llvm-project?rev=320985=rev Log: Fix regression in jModulesInfo packet handling The recent UUID cleanups exposed a bug in the parsing code for the jModulesInfo response, which was passing wrong value

[Lldb-commits] [lldb] r320984 - llgs: Propagate the environment when launching the inferior from command line

Author: labath Date: Mon Dec 18 06:31:39 2017 New Revision: 320984 URL: http://llvm.org/viewvc/llvm-project?rev=320984=rev Log: llgs: Propagate the environment when launching the inferior from command line Summary: We were failing to propagate the environment when lldb-server was started with a

[Lldb-commits] [PATCH] D41352: debugserver: Propagate environment in launch-mode (pr35671)

labath created this revision. labath added reviewers: jasonmolenda, clayborg. Herald added a subscriber: JDevlieghere. Make sure we propagate environment when starting debugserver with a pre-loaded inferior. AFAIK, RNBRunLoopLaunchInferior is only called in pre-loaded inferior scenario, so we can

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

asmith added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:393 // try really hard not to use a regex match. - bool is_regex = false; - if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) { -// Trying to compile an invalid regex

[Lldb-commits] [PATCH] D41359: Add Utility/Environment class for handling... environments

zturner added inline comments. Comment at: include/lldb/Utility/Environment.h:70-72 + std::pair insert(llvm::StringRef KeyEqValue) { +return insert(KeyEqValue.split('=')); + } Why'd you decide to go with inserting an entire pre-formatted

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:393 // try really hard not to use a regex match. - bool is_regex = false; - if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) { -// Trying to compile an invalid regex

[Lldb-commits] [PATCH] D41352: debugserver: Propagate environment in launch-mode (pr35671)

labath added a comment. In https://reviews.llvm.org/D41352#958549, @clayborg wrote: > We already have an option for this named "--forward-env". It might be better > to fix this by adding the "--forward-env" argument to the debugserver launch > during testing? When we launch through LLDB, it

[Lldb-commits] [lldb] r321016 - Fix more inconsistent line endings. NFC.

Author: dim Date: Mon Dec 18 11:46:56 2017 New Revision: 321016 URL: http://llvm.org/viewvc/llvm-project?rev=321016=rev Log: Fix more inconsistent line endings. NFC. Modified: lldb/trunk/www/build.html lldb/trunk/www/test.html Modified: lldb/trunk/www/build.html URL:

[Lldb-commits] [PATCH] D41359: Add Utility/Environment class for handling... environments

labath added inline comments. Comment at: include/lldb/Target/Platform.h:636 - virtual size_t GetEnvironment(StringList ); + virtual Environment GetEnvironment(); clayborg wrote: > Do we want to return by value? Not a const reference? This object can come

[Lldb-commits] [PATCH] D41359: Add Utility/Environment class for handling... environments

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. ok as long as we don't want to return const reference when returning Environment values in getters and setters. Comment at: include/lldb/Target/Platform.h:636 -

[Lldb-commits] [PATCH] D41352: debugserver: Propagate environment in launch-mode (pr35671)

clayborg added a comment. We already have an option for this named "--forward-env". It might be better to fix this by adding the "--forward-env" argument to the debugserver launch during testing? When we launch through LLDB, it forwards all environment variables manually. Maybe we add a

[Lldb-commits] [PATCH] D41359: Add Utility/Environment class for handling... environments

labath marked an inline comment as done. labath added inline comments. Comment at: include/lldb/Utility/Environment.h:70-72 + std::pair insert(llvm::StringRef KeyEqValue) { +return insert(KeyEqValue.split('=')); + } zturner wrote: > Why'd

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

I agree that's better long term, but this code was already there, and the patch makes things strictly better than before (literally just fixes a crash in existing code). So I think we can agree that this should be fixed, but as it's a bigger change I don't think it should hold up fixing a crash.

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

ok, good starting point then. We can submit another patch to add the find types by regex functionality. Greg > On Dec 18, 2017, at 9:54 AM, Zachary Turner wrote: > > I agree that's better long term, but this code was already there, and the > patch makes things strictly

[Lldb-commits] [PATCH] D41352: debugserver: Propagate environment in launch-mode (pr35671)

clayborg added a comment. I am ok either way, but I do want to make sure Jason gets input before we do anything. He might be out for a few weeks over the break, so there might be a delay. https://reviews.llvm.org/D41352 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D41352: debugserver: Propagate environment in launch-mode (pr35671)

jasonmolenda added a comment. I guess I don't have an opinion on this one. The correct way to pass environment variables to the inferior is through SBLaunchInfo::SetEnvironmentEntries or in cmd line lldb, process launch -v ENV=val. A test that assumes an environment variable set in lldb will

[Lldb-commits] [lldb] r321051 - Tweak to the debugserver entitlements setup in the xcode project

Author: jmolenda Date: Mon Dec 18 17:41:47 2017 New Revision: 321051 URL: http://llvm.org/viewvc/llvm-project?rev=321051=rev Log: Tweak to the debugserver entitlements setup in the xcode project file. For macos builds specifically, use the macosx entitlements files; for all other builds, use the

[Lldb-commits] [PATCH] D41359: Add Utility/Environment class for handling... environments

labath updated this revision to Diff 127384. labath added a comment. re-clang-format the patch https://reviews.llvm.org/D41359 Files: include/lldb/API/SBLaunchInfo.h include/lldb/Host/Host.h include/lldb/Interpreter/Args.h include/lldb/Target/Platform.h