This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL330247: Report more precise error message when attach fails
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: labath
Date: Wed Apr 18 04:56:21 2018
New Revision: 330247
URL: http://llvm.org/viewvc/llvm-project?rev=330247=rev
Log:
Report more precise error message when attach fails
Summary:
If the remote stub sends a specific error message instead of just a E??
code, we can use this to display a
Author: jdevlieghere
Date: Wed Apr 18 10:08:49 2018
New Revision: 330275
URL: http://llvm.org/viewvc/llvm-project?rev=330275=rev
Log:
[LIT] Have lit run the lldb test suite
This is the first in what will hopefully become a series of patches to
replace the driver logic in dotest.py with LIT. The
alur updated this revision to Diff 142962.
https://reviews.llvm.org/D45628
Files:
packages/Python/lldbsuite/test/linux/compressed-debug-info/Makefile
packages/Python/lldbsuite/test/linux/compressed-debug-info/TestCompressedDebugInfo.py
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
Some minor comments, almost ready to go. Do you have commit access or you need
somebody to push this on your behalf?
Comment at:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330275: [LIT] Have lit run the lldb test suite (authored by
JDevlieghere, committed by ).
Herald added a subscriber: jkorous.
Changed prior to commit:
lemo marked an inline comment as done.
lemo added a comment.
In https://reviews.llvm.org/D45700#1070491, @amccarth wrote:
> LGTM, but consider highlighting the side effect to `target` when the factory
> makes a Placeholder module.
Good observation: taking a step back, the factory introduces
alur marked 3 inline comments as done.
alur added a comment.
Thank you, I do need someone to push this on my behalf.
https://reviews.llvm.org/D45628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
Very nice!
https://reviews.llvm.org/D45628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
lemo updated this revision to Diff 142960.
https://reviews.llvm.org/D45700
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py
amccarth accepted this revision.
amccarth added a comment.
I actually preferred the factory solution.
What I intended to express is that the modification of the target doesn't seems
like it should be inside the PlaceholderModule class, so whether you use a
factory or not doesn't really address
lemo added subscribers: amccarth, clayborg, labath, zturner.
lemo marked an inline comment as done.
lemo added a comment.
Greg/Pavel, does the latest revision look good to you? Thanks!
https://reviews.llvm.org/D45700
___
lldb-commits mailing list
Greg/Pavel, does the latest revision look good to you? Thanks!
On Wed, Apr 18, 2018 at 10:31 AM, Leonard Mosescu via Phabricator <
revi...@reviews.llvm.org> wrote:
> lemo marked an inline comment as done.
> lemo added a comment.
>
> In https://reviews.llvm.org/D45700#1070491, @amccarth wrote:
>
labath added inline comments.
Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:1166
+ // The dlopen succeeded!
+ if (token != 0x0)
+return process->AddImageToken(token);
jingham wrote:
> labath wrote:
> > Use LLDB_INVALID_IMAGE_TOKEN here?
>
Author: lemo
Date: Wed Apr 18 16:10:46 2018
New Revision: 330302
URL: http://llvm.org/viewvc/llvm-project?rev=330302=rev
Log:
Improve LLDB's handling of non-local minidumps
Normally, LLDB is creating a high-fidelity representation of a live
process, including a list of modules and sections, with
clayborg added a comment.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D45700
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
16 matches
Mail list logo