labath added a comment.
In https://reviews.llvm.org/D46588#1102363, @aprantl wrote:
> > The advantage of the second one is that we will have the ability to
> > inject commands which depend on the results of previous commands (something
> > that I think we will need, sooner or later).
>
> That
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
It would still be interesting to align remove_dots with the "standard
practice", but it looks like that would end up being a big project. I think we
can live with tweak on our side in this cas
labath added a comment.
In https://reviews.llvm.org/D46934#1101963, @aprantl wrote:
> Does that mean we can now also remove the #ifdef __APPLE__ from the
> objectfile unit tests?
Which ones do you mean? I wasn't aware we had any. The thing I know of, which
would be interesting to enable is t
labath updated this revision to Diff 147286.
labath added a comment.
This is the version with new symbolic constants. I put them in a new file, as I
couldn't think of a better place for them.
I didn't want to put them in a too generic place as I don't think we should
encourage their use (we shoul
Author: labath
Date: Thu May 17 04:36:08 2018
New Revision: 332596
URL: http://llvm.org/viewvc/llvm-project?rev=332596&view=rev
Log:
[DWARF] Have HashedNameToDIE store a DataExtractor by value
Summary:
The DataExtractors are cheap to copy so there is no reason to store them
by reference. Also, in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332596: [DWARF] Have HashedNameToDIE store a DataExtractor
by value (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D46888
Fi
JDevlieghere added a comment.
Looks good to me, but I'll defer to Greg as I've never actually touched this
code myself.
https://reviews.llvm.org/D46889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
clayborg added a comment.
Looks fine. Just one question on keeping the DWARFIndex::Create() functions so
they all have the same signature.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:40
+
+std::unique_ptr AppleIndex::Create(
+Module &module, DWARFDataExtract
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:40
+
+std::unique_ptr AppleIndex::Create(
+Module &module, DWARFDataExtractor apple_names,
clayborg wrote:
> Move all AppleIndex stuff to a dedicated .cpp file?
Do we w
JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, clayborg, davide.
In r265181 the test for the NSCFBoolean data formatter was removed.
Later, in r279353 and r279446 a new implementation was provided for the
formatter, which I believe never worked (and this wasn't caught b
labath added a comment.
Thank you for the review. I'll have the updated diff shortly. In the mean time,
here are my responses.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:40
+
+std::unique_ptr AppleIndex::Create(
+Module &module, DWARFDataExtractor apple_nam
labath updated this revision to Diff 147326.
labath added a comment.
- s/AppleIndex/AppleDWARFIndex
- move things to separate files
https://reviews.llvm.org/D46889
Files:
source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp
source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.h
source/Plugins/S
clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1984
GetObjectFile()->GetModule()->GetMutex());
- Index();
-}
Yikes, who was
aprantl added a comment.
My overall mental image of lldb-mi is very incomplete, but I'm imagining
lldb-mi as having one thread that wakes up every n milliseconds checks for
command input and then calls into the SBAPI to handle the commands. If that is
how it works, then one very simple thing we
aprantl added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextDarwinConstants.h:18
+ KERNEL_SUCCESS = 0,
+ KERNEL_INVALID_ARGUMENT = 4,
+};
I think I would prefer
#ifndef KERN_INVALID_ARGUMENT
#define KERN_INVALID_ARGUMENT 4
#endif
aprantl added a comment.
In https://reviews.llvm.org/D46934#1102867, @labath wrote:
> In https://reviews.llvm.org/D46934#1101963, @aprantl wrote:
>
> > Does that mean we can now also remove the #ifdef __APPLE__ from the
> > objectfile unit tests?
>
>
> Which ones do you mean? I wasn't aware we h
Author: gclayton
Date: Thu May 17 09:12:38 2018
New Revision: 332618
URL: http://llvm.org/viewvc/llvm-project?rev=332618&view=rev
Log:
FileSpec objects that resolve to "." should have "." in m_filename and
m_directory empty.
After switching to LLVM normalization, if we init FileSpec with "." we
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332618: FileSpec objects that resolve to "."
should have "." in m_filename and… (authored by gclayton, committed
by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
polyakov.alex added a comment.
In https://reviews.llvm.org/D46588#1103180, @aprantl wrote:
> My overall mental image of lldb-mi is very incomplete, but I'm imagining
> lldb-mi as having one thread that wakes up every n milliseconds checks for
> command input and then calls into the SBAPI to han
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D47014
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
aprantl added a comment.
For the experiment you can probably just stick it into
`CMICmnLLDBDebugger::InitSBDebugger()`.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
Author: stella.stamenova
Date: Thu May 17 09:58:00 2018
New Revision: 332629
URL: http://llvm.org/viewvc/llvm-project?rev=332629&view=rev
Log:
[lit, lldbsuite] Disable tests that are failing because of pr21765 and pr24489
Summary: These three tests are failing on Windows and looking into the
fai
labath updated this revision to Diff 147341.
labath added a comment.
- Use #ifndef approach for handling the constants.
https://reviews.llvm.org/D46934
Files:
lit/Modules/lc_version_min.yaml
source/Initialization/CMakeLists.txt
source/Initialization/SystemInitializerCommon.cpp
source/Pl
clayborg added a comment.
In https://reviews.llvm.org/D46588#1103237, @aprantl wrote:
> For the experiment you can probably just stick it into
> `CMICmnLLDBDebugger::InitSBDebugger()`.
But don't do it here permanently...
Repository:
rL LLVM
https://reviews.llvm.org/D46588
_
polyakov.alex added a comment.
In https://reviews.llvm.org/D46588#1103237, @aprantl wrote:
> For the experiment you can probably just stick it into
> `CMICmnLLDBDebugger::InitSBDebugger()`.
Yep, after that, test is passing with only `CHECK` directives.
Repository:
rL LLVM
https://reviews.
This has broken the unit tests. Looks like a bad merge that did not take
into account the refactoring in r332088.
On Thu, 17 May 2018 at 17:16, Phabricator via Phabricator <
revi...@reviews.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by com
labath added subscribers: clayborg, davide, jingham, zturner.
labath added a comment.
This has broken the unit tests. Looks like a bad merge that did not take
into account the refactoring in r332088.
Repository:
rL LLVM
https://reviews.llvm.org/D46783
__
The patch in the differential is off, this is the fixed version of this patch?
> On May 17, 2018, at 10:09 AM, Pavel Labath wrote:
>
> This has broken the unit tests. Looks like a bad merge that did not take
> into account the refactoring in r332088.
> On Thu, 17 May 2018 at 17:16, Phabricator
clayborg updated this revision to Diff 147345.
clayborg added a comment.
Updated to what was committed.
https://reviews.llvm.org/D46783
Files:
source/Utility/FileSpec.cpp
unittests/Utility/FileSpecTest.cpp
Index: unittests/Utility/FileSpecTest.cpp
=
I just updated the differential with the actual patch. If you tried to apply
the old one, then try it again with the latest diff I just uploaded
> On May 17, 2018, at 10:09 AM, Pavel Labath wrote:
>
> This has broken the unit tests. Looks like a bad merge that did not take
> into account the r
clayborg added a comment.
I did run unit tests and they all passed here?
https://reviews.llvm.org/D46783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Sorry, I was wrong about the cause, but the bots are red nonetheless. My bet is
it's the last `{"", "."},` test, which is not working because of an early
return in SetFile. TBH, I am not sure we would want that to work anyway, as we
too treat an empty filespec specially
labath added a comment.
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/23447
https://reviews.llvm.org/D46783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
Author: gclayton
Date: Thu May 17 10:18:11 2018
New Revision: 332633
URL: http://llvm.org/viewvc/llvm-project?rev=332633&view=rev
Log:
Fix buildbots after it 332618
Modified:
lldb/trunk/unittests/Utility/FileSpecTest.cpp
Modified: lldb/trunk/unittests/Utility/FileSpecTest.cpp
URL:
http://l
Fixed with
svn commit unittests/Utility/FileSpecTest.cpp
Sendingunittests/Utility/FileSpecTest.cpp
Transmitting file data .done
Committing transaction...
Committed revision 332633.
> On May 17, 2018, at 10:18 AM, Pavel Labath via Phabricator
> wrote:
>
> labath added a comment.
>
> h
clayborg added a subscriber: labath.
clayborg added a comment.
Fixed with
svn commit unittests/Utility/FileSpecTest.cpp
Sendingunittests/Utility/FileSpecTest.cpp
Transmitting file data .done
Committing transaction...
Committed revision 332633.
https://reviews.llvm.org/D46783
clayborg added a comment.
Fixed with:
svn commit unittests/Utility/FileSpecTest.cpp
Sendingunittests/Utility/FileSpecTest.cpp
Transmitting file data .done
Committing transaction...
Committed revision 332633.
https://reviews.llvm.org/D46783
aprantl added a comment.
Okay, that sounds promising! Then let's proceed this way:
- Add a new command line option to lldb-mi that is called `--synchronous` with
a help text "Block until each command has finished executing. Used for testing
only." and use it in this test
- continue writing as m
clayborg created this revision.
clayborg added reviewers: labath, zturner, davide.
Herald added subscribers: JDevlieghere, aprantl, mgorny.
PathMappingList was broken for relative and empty paths after normalization
changes in FileSpec. There were also no tests for PathMappingList so I added
tho
zturner added inline comments.
Comment at: source/Target/PathMappingList.cpp:76
++m_mod_id;
- m_pairs.push_back(pair(path, replacement));
+ m_pairs.push_back(pair(NormalizePath(path), NormalizePath(replacement)));
if (notify && m_callback)
Slightly more i
clayborg updated this revision to Diff 147354.
clayborg added a comment.
Fix issues found by Zach.
https://reviews.llvm.org/D47021
Files:
include/lldb/Target/PathMappingList.h
lldb.xcodeproj/project.pbxproj
source/Target/PathMappingList.cpp
source/Target/Target.cpp
unittests/Utility/C
clayborg marked 7 inline comments as done.
clayborg added a comment.
Marked things as done.
https://reviews.llvm.org/D47021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: stella.stamenova
Date: Thu May 17 14:34:24 2018
New Revision: 332670
URL: http://llvm.org/viewvc/llvm-project?rev=332670&view=rev
Log:
[Windows, Process] Fix an issue in windows thread handling that was causing
LLDB to hang
Summary: The function ResumeThread on Windows returns a DWORD wh
Author: stella.stamenova
Date: Thu May 17 14:42:37 2018
New Revision: 332671
URL: http://llvm.org/viewvc/llvm-project?rev=332671&view=rev
Log:
[Windows, Process] LLDB reads wrong registers on 64bit Windows
Summary: LLDB reads wrong registers on 64bit Windows because
RegisterContextWindows_x64::G
44 matches
Mail list logo
