Great, thanks for the update.
I'll wait then. There's also an assertion failure in DebugInfo/MSF,
which was, incidentally, caused by another test we added yesterday. I
think it might be related (be in your area).
Thanks,
--
Davide
On Thu, Oct 11, 2018 at 9:47 AM Zachary Turner wrote:
>
> I'm
On Wed, Oct 10, 2018 at 9:40 AM Zachary Turner via lldb-commits
wrote:
>
> Author: zturner
> Date: Wed Oct 10 09:39:07 2018
> New Revision: 344154
>
> URL: http://llvm.org/viewvc/llvm-project?rev=344154=rev
> Log:
> Create a SymbolFile plugin for cross-platform PDB access.
>
Hey Zach, I'm afraid
grimar updated this revision to Diff 169177.
grimar marked 4 inline comments as done.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D52689
Files:
lit/Breakpoint/Inputs/implicit_const_form_support.yaml
lit/Breakpoint/implicit_const_form_support.test
grimar added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:23
+ DWARFAttribute(dw_attr_t attr, dw_form_t form,
+ DWARFFormValue::ValueType value)
+ : m_attr(attr), m_form(form), m_value(value) {}
clayborg
aleksandr.urakov added a comment.
Thanks a lot for so detailed answer, it helps!
So we need to parse a FPO program and to convert it in a DWARF expression too.
The problem here (in the DIA case) is that I don't know how to retrieve the
required FPO range (we have a symbol context when creating
aleksandr.urakov updated this revision to Diff 169181.
https://reviews.llvm.org/D53086
Files:
lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp
lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script
Index: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script
aleksandr.urakov added subscribers: zturner, jasonmolenda, labath.
aleksandr.urakov added a comment.
As for aligned stack cross-platform problems, I mean also problems with stack
unwinding. They seem to appear on non-Windows too. It's because
`x86AssemblyInspectionEngine` doesn't support stack
aleksandr.urakov added a comment.
Otherwise LGTM!
Comment at: unittests/Utility/StatusTest.cpp:68-74
+ EXPECT_STREQ("Access is denied. ", s.AsCString());
+
+ s.SetError(ERROR_IPSEC_IKE_TIMED_OUT, ErrorType::eErrorTypeWin32);
+ EXPECT_STREQ("Negotiation timed out ",
aleksandr.urakov added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:801-804
+ if (m_filespec_ap.get())
+return m_filespec_ap->GetSize();
+
+ m_filespec_ap.reset(new FileSpecList());
I'm afraid of a race condition here.
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
LGTM after https://reviews.llvm.org/D53094 will be done!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53096
___
clayborg added a comment.
Down to just modifying the DWARFFormValue constructor to be able to take a CU
only. Looks good.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:241-242
+for (uint32_t i = 0; i < numAttributes; ++i) {
+
Author: ioeric
Date: Thu Oct 11 07:44:12 2018
New Revision: 344250
URL: http://llvm.org/viewvc/llvm-project?rev=344250=rev
Log:
[lldb] rename MinOS::minor to MinOS::minor_version etc. NFC
The constructor initializer minor(...)/major(...) can be confused with system
macros `#define minor(...)` on
grimar updated this revision to Diff 169209.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D52689
Files:
lit/Breakpoint/Inputs/implicit_const_form_support.yaml
lit/Breakpoint/implicit_const_form_support.test
Author: ioeric
Date: Thu Oct 11 07:52:33 2018
New Revision: 344252
URL: http://llvm.org/viewvc/llvm-project?rev=344252=rev
Log:
[lldb] Surpress copy-elison warning.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
Modified:
grimar created this revision.
grimar added reviewers: LLDB, clayborg.
Herald added a subscriber: JDevlieghere.
The patch implements the support for DW_RLE_base_address and DW_RLE_offset_pair
.debug_rnglists entries
https://reviews.llvm.org/D53140
Files:
I'm working on a fix for this and several other issues right now. For this
one I think we just need to add -- on the command line.
On Thu, Oct 11, 2018 at 9:36 AM Davide Italiano
wrote:
> On Wed, Oct 10, 2018 at 9:40 AM Zachary Turner via lldb-commits
> wrote:
> >
> > Author: zturner
> >
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for making the changes. Looks good!
https://reviews.llvm.org/D52689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg added a comment.
See inlined comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:150-151
+case DW_RLE_base_address: {
+ dw_addr_t base = data.GetMaxU64(offset_ptr, addrSize);
+ rangeList.push_back({DW_RLE_base_address, base, 0});
+
stella.stamenova created this revision.
stella.stamenova added reviewers: zturner, asmith.
Herald added a subscriber: lldb-commits.
This is another string/byte conversion issue between Python 2 and 3. In Python
2, the subprocess communication expects a byte string, but in Python 3, it
expects
Author: jmolenda
Date: Thu Oct 11 11:37:53 2018
New Revision: 344275
URL: http://llvm.org/viewvc/llvm-project?rev=344275=rev
Log:
Don't mark an LC_BUILD_VERSION as giving us a
correct version if it has a major verison 0.
Modified:
thanks.
On Thu, Oct 11, 2018 at 11:47 AM Zachary Turner via lldb-commits
wrote:
>
> Author: zturner
> Date: Thu Oct 11 11:45:44 2018
> New Revision: 344279
>
> URL: http://llvm.org/viewvc/llvm-project?rev=344279=rev
> Log:
> Revert SymbolFileNativePDB plugin.
>
> This was originally causing some
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This looks great, thanks for making this work, it will be SO helpful for
debugging std::function uses.
https://reviews.llvm.org/D52851
___
Author: zturner
Date: Thu Oct 11 11:45:44 2018
New Revision: 344279
URL: http://llvm.org/viewvc/llvm-project?rev=344279=rev
Log:
Revert SymbolFileNativePDB plugin.
This was originally causing some test failures on non-Windows
platforms, which required fixes in the compiler and linker. After
Author: zturner
Date: Thu Oct 11 11:01:55 2018
New Revision: 344269
URL: http://llvm.org/viewvc/llvm-project?rev=344269=rev
Log:
Better support for POSIX paths in PDBs.
While it doesn't make a *ton* of sense for POSIX paths to be
in PDBs, it's possible to occur in real scenarios involving
cross
Author: jmolenda
Date: Thu Oct 11 11:41:34 2018
New Revision: 344277
URL: http://llvm.org/viewvc/llvm-project?rev=344277=rev
Log:
Fix this comment so it is consistent with all the others.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteAppleBridge.cpp
Modified:
davide accepted this revision.
davide added a comment.
LGTM too. Thanks for taking the time to address the comments.
https://reviews.llvm.org/D52851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
shafik updated this revision to Diff 169259.
shafik marked an inline comment as done.
shafik added a comment.
Removing uneeded code and making test NO_DEBUG_INFO_TESTCASE
https://reviews.llvm.org/D52851
Files:
include/lldb/Target/CPPLanguageRuntime.h
shafik added a comment.
@jingham removed code and made it NO_DEBUG_INFO_TESTCASE
https://reviews.llvm.org/D52851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a subscriber: aprantl.
zturner added a comment.
https://reviews.llvm.org/D53002
Is the thread I'm referring to.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://reviews.llvm.org/D53002
Is the thread I'm referring to.
On Thu, Oct 11, 2018 at 2:59 PM Zachary Turner via Phabricator <
revi...@reviews.llvm.org> wrote:
> zturner added a subscriber: vsk.
> zturner added a comment.
>
> See the other email thread. The bots have been broken since
stella.stamenova added a comment.
The failing bots are not windows bots but Linux bots. It looks like you only
updated the configurations for xcode.
I think the file that needs to be updated is:
zorg\buildbot\builders\LLDBBuilder.py
https://reviews.llvm.org/D53175
Does this look reasonable to you? I'm not sure how to test this.
diff --git a/zorg/buildbot/builders/LLDBBuilder.py
b/zorg/buildbot/builders/LLDBBuilder.py
index 5a1b2e87..62152924 100644
--- a/zorg/buildbot/builders/LLDBBuilder.py
+++ b/zorg/buildbot/builders/LLDBBuilder.py
@@ -270,6 +270,7 @@
jasonmolenda added a comment.
(obviously this would only be the behavior if a filecheck path was not
specified)
https://reviews.llvm.org/D53175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
zturner added a comment.
In https://reviews.llvm.org/D53086#1263001, @zturner wrote:
> In https://reviews.llvm.org/D53086#1261697, @aleksandr.urakov wrote:
>
> > Thanks a lot for so detailed answer, it helps!
> >
> > So we need to parse a FPO program and to convert it in a DWARF expression
> >
vsk created this revision.
vsk added reviewers: stella.stamenova, zturner.
This allows bots which haven't updated to pass in --filecheck to dotest.py to
run more tests. FileCheck-dependent tests will continue to fail.
https://reviews.llvm.org/D53175
Files:
Why is FileCheck missing in the first place?
On Thu, Oct 11, 2018 at 3:13 PM Vedant Kumar via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsk created this revision.
> vsk added reviewers: stella.stamenova, zturner.
>
> This allows bots which haven't updated to pass in --filecheck to
Can we get the Xcode build to generate lldb-dotest, just like the cmake build
does? That way there's no need to duplicate build system logic into dotest.py.
It would just live in one place, and we'd all invoke lldb-dotest the same way.
vedant
> On Oct 11, 2018, at 3:53 PM, Jason Molenda via
zturner added a comment.
In https://reviews.llvm.org/D53086#1261697, @aleksandr.urakov wrote:
> Thanks a lot for so detailed answer, it helps!
>
> So we need to parse a FPO program and to convert it in a DWARF expression
> too. The problem here (in the DIA case) is that I don't know how to
vsk added a comment.
In https://reviews.llvm.org/D50478#1262710, @stella.stamenova wrote:
> Unfortunately, the bots are broken because of the FileCheck issue, so I can't
> confirm with them, but I see a number of these tests fail in our local
> testing. Some fail on both Windows and Linux and
See the other email thread. The bots have been broken since September, all
of them complain about missing FileCheck executable
On Thu, Oct 11, 2018 at 2:58 PM Vedant Kumar via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsk added a comment.
>
> In https://reviews.llvm.org/D50478#1262710,
zturner added a subscriber: vsk.
zturner added a comment.
See the other email thread. The bots have been broken since September, all
of them complain about missing FileCheck executable
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50478
___
Author: jmolenda
Date: Thu Oct 11 17:53:55 2018
New Revision: 344323
URL: http://llvm.org/viewvc/llvm-project?rev=344323=rev
Log:
Remove references to source/Plugins/SymbolFile/NativePDB.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
It's probably not, it's just that the --filecheck arg is missing. I wrote
things this way because I was advised that dotest.py shouldn't assume where
FileCheck is on the filesystem.
vedant
> On Oct 11, 2018, at 3:22 PM, Zachary Turner wrote:
>
> Why is FileCheck missing in the first place?
>
stella.stamenova added a comment.
I spent a bit more time on this and I think I have a better idea of what's
happening.
Vedant added functionality so that we can use FileCheck-style checks inside
non-lit LLDB tests. Part of that change was to require a parameter --filecheck
to be passed when
> On Oct 11, 2018, at 3:30 PM, Stella Stamenova via Phabricator
> wrote:
>
> stella.stamenova added a comment.
>
> I spent a bit more time on this and I think I have a better idea of what's
> happening.
>
> Vedant added functionality so that we can use FileCheck-style checks inside
>
45 matches
Mail list logo
