zturner added a comment.
In https://reviews.llvm.org/D54454#1296358, @jingham wrote:
> You were probably speaking loosely, but to be clear, the code you are
> changing doesn't get used for expressions - i.e. the expression command -
> unless I'm missing something.
>
> This little mini-parser
jingham added a comment.
Those seem legit things to try to capture, though a little esoteric. Since
"frame variable" and "target variable" didn't support these constructs before
you should certainly add some tests for that.
The frame variable parser also supports:
(lldb) frame variable
shafik added a comment.
@zturner I would not be against discussing using pass by value for small
objects going forward. I don't currently have a good feeling for at what
sizes/data types the right trade-off is at though.
Repository:
rL LLVM
https://reviews.llvm.org/D54003
clayborg added a comment.
In https://reviews.llvm.org/D54454#1296392, @zturner wrote:
> BTW, I will have to see if it's possible to write a test for this. Even when
> I compiled and built a program with DWARF on Linux, the `target variable
> Pi` example didn't "just work" for me, because
jingham added a comment.
We do also handle [], though it isn't obvious to me after a quick glance where
that gets done. This is a little cheesy because the name of the child that we
are finding with [0] is actually "[0]", so you just have to be careful not to
consume that when you consume the
zturner added a comment.
In https://reviews.llvm.org/D54454#1296377, @jingham wrote:
> Those seem legit things to try to capture, though a little esoteric. Since
> "frame variable" and "target variable" didn't support these constructs before
> you should certainly add some tests for that.
>
>
jingham created this revision.
jingham added reviewers: clayborg, jasonmolenda.
Herald added subscribers: lldb-commits, abidh, atanasyan, kbarton, javed.absar,
nemanjai.
For reasons that are unclear to me, when the ABIXXX::CreateInstance function is
called to make a new ABI for a given process
clayborg added a comment.
Anything that takes a process shared pointer should be per process. A long time
ago these plug-ins didn't take process, and as time went on they did take a
process:
306633 jmolenda ABI(lldb::ProcessSP process_sp) {
306633 jmolenda if (process_sp.get())
jingham added a comment.
You were probably speaking loosely, but to be clear, the code you are changing
doesn't get used for expressions - i.e. the expression command - unless I'm
missing something.
This little mini-parser is for doing things like:
(lldb) frame variable foo.bar
We don't use
zturner added a comment.
BTW, I will have to see if it's possible to write a test for this. Even when I
compiled and built a program with DWARF on Linux, the `target variable
Pi` example didn't "just work" for me, because `FindGlobalVariables`
wasn't returning the variable. So I think this
jingham added a comment.
A dotest test can be xfailed if the debug format is not PDB, right? At least
we can xfail them for all the DWARF variants so it should be possible to do
that for PDB as well. So you should be able to write a test for this and then
just xfail it till the DWARF parser
zturner created this revision.
zturner added reviewers: aleksandr.urakov, lemo.
clang-cl does not emit these, but MSVC does, so we need to be able to handle
them.
Because clang-cl does not generate them, it was a bit hard to write a test. So
what I had to do was get an PDB file with some
clayborg added a comment.
Since we only handle . and -> this general idea seems ok to me. Do we even need
a regex then? Maybe just search for first of ".-"?
https://reviews.llvm.org/D54454
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM, my guess is that this was Greg's code originally. He may have made a
singleton object out of caution.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54460
I know when I stepped through it with the Pi example, it was returning all
matches, but not filtering down the results based on the template parameter
first, so you’d get back every instantiation but the template parameter
would be treated as a subexpression.
I think the SymbolFile plugin should
zturner added a subscriber: clayborg.
zturner added a comment.
I know when I stepped through it with the Pi example, it was returning all
matches, but not filtering down the results based on the template parameter
first, so you’d get back every instantiation but the template parameter
would be
zturner added a comment.
> If there were ever anything per-process that effected the ABI plugin's
> behavior (for instance if it relied on a Process property) you could very
> well use the wrong processes setting. Even worse, since the ABI's hold onto a
> process through a weak pointer, if the
lemo accepted this revision.
lemo added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:329
+std::pair GetIntegralTypeInfo(TypeIndex ti, TpiStream ) {
+ if (ti.isSimple()) {
zturner created this revision.
zturner added reviewers: clayborg, jingham, labath.
Herald added subscribers: JDevlieghere, aprantl.
When we evaluate a variable name as part of an expression, we run a regex
against it so break it apart. The intent seems to be that we want to get the
main
sgraenitz added a comment.
Yes, considered it, but was not sure whether it's a good idea to bloat the
general mechanism in LLVM to match the requirements for a single subproject. Do
you think other projects would benefit from it?
My reasoning was: Passing through target-specific parameters to
Author: alexfh
Date: Mon Nov 12 05:41:42 2018
New Revision: 346651
URL: http://llvm.org/viewvc/llvm-project?rev=346651=rev
Log:
Fix an unused variable warning. NFC
Modified:
lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp
Modified:
aleksandr.urakov added a comment.
This change looks reasonable to me for solving the problem with the current
`LF_NESTTYPE` approach. But I'm not sure... Now we all the same need to analyze
mangled names and make a decision based on this. Does the current `LF_NESTTYPE`
approach still has
On Mon, Nov 12, 2018 at 6:42 PM Zachary Turner wrote:
> Clang only. But I don’t think we can ever replace it with an assert,
> debug info is basically user input, so we have to be able to handle every
> manner of malformed input. In fact, when this bug is fixed in clang, i
> will probably try
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D44060
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
davide requested changes to this revision.
davide added inline comments.
This revision now requires changes to proceed.
Comment at: source/Plugins/Language/ObjC/NSException.cpp:161-168
+static ConstString g___name("name");
+static ConstString g___reason("reason");
davide requested changes to this revision.
davide added inline comments.
This revision now requires changes to proceed.
Comment at: source/Plugins/Language/ObjC/NSArray.cpp:446-451
+ } else if (class_name == g_NSCallStackArray) {
+Status error;
+value =
On Mon, Nov 12, 2018 at 6:51 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> This change looks reasonable to me for solving the problem with the
> current `LF_NESTTYPE` approach. But I'm not sure... Now we all the same
> need to
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
This is trivial. I don't know why we didn't do this before.
https://reviews.llvm.org/D54431
___
lldb-commits mailing list
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Thanks for addressing my comments.
https://reviews.llvm.org/D44081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346693: [lldb] Add ninja to svn:ignore (authored
by kuba.brecka, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54431?vs=173697=173720#toc
Author: kuba.brecka
Date: Mon Nov 12 11:06:15 2018
New Revision: 346693
URL: http://llvm.org/viewvc/llvm-project?rev=346693=rev
Log:
[lldb] Add "ninja" to svn:ignore
Differential Revision: https://reviews.llvm.org/D54431
Modified:
lldb/trunk/ (props changed)
Propchange: lldb/trunk/
kubamracek marked an inline comment as done.
kubamracek added a comment.
Thanks for the review!
https://reviews.llvm.org/D43884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346695: [lldb] Extract more fields from NSException
values (authored by kuba.brecka, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D43884
Files:
Author: kuba.brecka
Date: Mon Nov 12 11:12:31 2018
New Revision: 346695
URL: http://llvm.org/viewvc/llvm-project?rev=346695=rev
Log:
[lldb] Extract more fields from NSException values
This patch teaches LLDB about more fields on NSException Obj-C objects,
specifically we can now retrieve the
labath created this revision.
labath added reviewers: clayborg, jankratochvil, JDevlieghere.
While parsing a childless compile unit DIE we could crash if the DIE was
followed by any extra data (such as a superfluous end-of-children
marker). This happened because the break-on-depth=0 check was
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D43884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: kuba.brecka
Date: Mon Nov 12 11:05:16 2018
New Revision: 346692
URL: http://llvm.org/viewvc/llvm-project?rev=346692=rev
Log:
[lldb] Fix the typo (replace underscore with dash) in svn:ignore on test/ and
add "lldb-test-build.noindex" to ignored files
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346692: [lldb] Fix the typo (replace underscore with
dash) in svn:ignore on test/ and… (authored by kuba.brecka, committed by ).
Changed prior to commit:
Author: davide
Date: Mon Nov 12 11:08:19 2018
New Revision: 346694
URL: http://llvm.org/viewvc/llvm-project?rev=346694=rev
Log:
Revert "Extract construction of DataBufferLLVM into FileSystem"
It broke the lldb sanitizer bots.
Modified:
lldb/trunk/include/lldb/Host/FileSystem.h
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346669: [ClangASTContext] Extract VTable pointers from C++
objects (authored by aleksandr.urakov, committed by ).
Herald
Author: aleksandr.urakov
Date: Mon Nov 12 08:23:50 2018
New Revision: 346669
URL: http://llvm.org/viewvc/llvm-project?rev=346669=rev
Log:
[ClangASTContext] Extract VTable pointers from C++ objects
This patch processes the case of retrieving a virtual base when the object is
already read from the
Author: aleksandr.urakov
Date: Mon Nov 12 08:45:55 2018
New Revision: 346672
URL: http://llvm.org/viewvc/llvm-project?rev=346672=rev
Log:
[PDB] Fix `vbases.test` requirement
Differential revision: https://reviews.llvm.org/D53506
Modified:
lldb/trunk/lit/SymbolFile/PDB/vbases.test
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346673: [lldb] Fix code requires global
destructor warning in g_architecture_mutex (authored by kuba.brecka,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
aleksandr.urakov added a comment.
I also have some strange failures on Windows x86 (I run tests from x64_86 MSVC
command line). If I locally revert this commit and 3 fix commits right after
this one, then all seems to work. Here is the failure:
C:\Work\llvm\build_x86\bin>llvm-lit.py -v
aleksandr.urakov added a comment.
But all compiles without errors if I run this manually:
clang-cl -m32 /Z7 /c /GS-
C:\Work\llvm\tools\lldb\lit\SymbolFile\PDB/Inputs/SimpleTypesTest.cpp /o
C:\Work\llvm\build_x86\tools\lldb\lit\SymbolFile\PDB\Output/SimpleTypesTest.cpp.enums.obj
Repository:
kubamracek marked an inline comment as done.
kubamracek added inline comments.
Comment at: source/Plugins/Language/ObjC/NSException.cpp:161-168
+static ConstString g___name("name");
+static ConstString g___reason("reason");
static ConstString
kubamracek updated this revision to Diff 173695.
https://reviews.llvm.org/D44081
Files:
packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py
source/Plugins/Language/ObjC/NSArray.cpp
source/Plugins/Language/ObjC/ObjCLanguage.cpp
Index:
kubamracek marked an inline comment as done.
kubamracek added inline comments.
Comment at: source/Plugins/Language/ObjC/NSArray.cpp:446-451
+ } else if (class_name == g_NSCallStackArray) {
+Status error;
+value = process_sp->ReadUnsignedIntegerFromMemory(
+
kubamracek created this revision.
kubamracek added reviewers: davide, aprantl.
https://reviews.llvm.org/D54431
Files:
.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Your explanation makes sense, good catch. Thanks for fixing this!
https://reviews.llvm.org/D54417
___
lldb-commits mailing list
clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:65
typedef std::vector CompileUnitColl;
+ typedef llvm::DenseMap TypeSignatureMap;
Author: friss
Date: Mon Nov 12 09:59:30 2018
New Revision: 346684
URL: http://llvm.org/viewvc/llvm-project?rev=346684=rev
Log:
Remove the last CURRENT_ARCH reference in Xcode's build scripts.
In the same spirit as r346443.
Modified:
lldb/trunk/scripts/Xcode/lldbbuild.py
Modified:
Author: stefan.graenitz
Date: Mon Nov 12 08:22:24 2018
New Revision: 346667
URL: http://llvm.org/viewvc/llvm-project?rev=346667=rev
Log:
[CMake] Fix: add_host_subdirectory source/Host/macosx
Summary: Typo introduced with https://reviews.llvm.org/D47929
Reviewers: teemperor
Subscribers: mgorny,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346668: [CMake] Allow version overrides with
-DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX (authored by stefan.graenitz, committed
by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
kubamracek updated this revision to Diff 173692.
https://reviews.llvm.org/D43884
Files:
packages/Python/lldbsuite/test/lang/objc/exceptions/Makefile
packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py
packages/Python/lldbsuite/test/lang/objc/exceptions/main.m
Author: kuba.brecka
Date: Mon Nov 12 09:25:23 2018
New Revision: 346679
URL: http://llvm.org/viewvc/llvm-project?rev=346679=rev
Log:
[lldb] Refactor ObjC/NSException.cpp (cleanup, avoid code duplication). NFC.
- Refactor reading of NSException fields into ExtractFields method to avoid
code
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346679: [lldb] Refactor ObjC/NSException.cpp (cleanup,
avoid code duplication). NFC. (authored by kuba.brecka, committed by ).
Herald added a subscriber: teemperor.
Changed prior to commit:
Author: kuba.brecka
Date: Mon Nov 12 08:52:58 2018
New Revision: 346673
URL: http://llvm.org/viewvc/llvm-project?rev=346673=rev
Log:
[lldb] Fix "code requires global destructor" warning in g_architecture_mutex
Differential Revision: https://reviews.llvm.org/D44060
Modified:
kubamracek created this revision.
kubamracek added reviewers: davide, aprantl.
Herald added a subscriber: arphaman.
https://reviews.llvm.org/D54432
Files:
.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
beanz added a comment.
I can certainly foresee other LLVM-based projects needing entitlements, so I am
very much in favor of adding `ENTITLEMENTS` and `FORCE` options onto
`llvm_codesign`.
https://reviews.llvm.org/D54352
___
lldb-commits mailing
beanz added inline comments.
Comment at: cmake/modules/AddLLVM.cmake:795
- llvm_codesign(${name})
+ llvm_codesign(TARGET ${name} ENTITLEMENTS ${ARG_ENTITLEMENTS} FORCE)
endmacro(add_llvm_executable name)
sgraenitz wrote:
> Would we want to pass `FORCE` to
sgraenitz added a comment.
Please find the alternative proposal in https://reviews.llvm.org/D54443 (llvm)
and https://reviews.llvm.org/D5 (lldb).
https://reviews.llvm.org/D54352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sgraenitz added a comment.
`debugserver` was not that simple. For now only `lldb-server` as an example.
Comment at: cmake/modules/AddLLDB.cmake:109
list(APPEND LLVM_LINK_COMPONENTS ${ARG_LINK_COMPONENTS})
- add_llvm_executable(${name} ${ARG_UNPARSED_ARGUMENTS})
+
sgraenitz added inline comments.
Comment at: cmake/modules/AddLLVM.cmake:795
- llvm_codesign(${name})
+ llvm_codesign(TARGET ${name} ENTITLEMENTS ${ARG_ENTITLEMENTS} FORCE)
endmacro(add_llvm_executable name)
Would we want to pass `FORCE` to
kubamracek updated this revision to Diff 173747.
kubamracek retitled this revision from "[lldb] Add GetCurrentException and
GetCurrentExceptionBacktrace APIs to SBThread" to "[lldb] Add
GetCurrentException APIs to SBThread, add frame recognizer for
objc_exception_throw for Obj-C runtimes".
sgraenitz created this revision.
sgraenitz added reviewers: beanz, bogner.
Herald added a subscriber: mgorny.
Allow code-signing with entitlements. FORCE may be used to avoid an error when
replacing existing signatures.
Repository:
rL LLVM
https://reviews.llvm.org/D54443
Files:
sgraenitz created this revision.
sgraenitz added reviewers: beanz, bogner.
Herald added a subscriber: mgorny.
This is using the mechanism proposed in https://reviews.llvm.org/D54443 to pass
the entitlements file for lldb-server to llvm_codesign.
https://reviews.llvm.org/D5
Files:
Author: jdevlieghere
Date: Mon Nov 12 13:24:50 2018
New Revision: 346707
URL: http://llvm.org/viewvc/llvm-project?rev=346707=rev
Log:
Re-land "Extract construction of DataBufferLLVM into FileSystem"
This fixes some UB in isLocal detected by the sanitized bot.
Modified:
Author: kuba.brecka
Date: Mon Nov 12 13:26:03 2018
New Revision: 346708
URL: http://llvm.org/viewvc/llvm-project?rev=346708=rev
Log:
[lldb] Add synthetic frontend for _NSCallStackArray
An Obj-C array type _NSCallStackArray is used in NSException backtraces. This
patch adds a synthetic frontend
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346708: [lldb] Add synthetic frontend for
_NSCallStackArray (authored by kuba.brecka, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44081?vs=173695=173749#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346667: [CMake] Fix: add_host_subdirectory
source/Host/macosx (authored by stefan.graenitz, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54335
Author: stefan.graenitz
Date: Mon Nov 12 08:22:28 2018
New Revision: 346668
URL: http://llvm.org/viewvc/llvm-project?rev=346668=rev
Log:
[CMake] Allow version overrides with -DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX
Summary:
This follows the approach in Clang. If no overrides are given,
sgraenitz added a comment.
Ok, I will have a look and prepare a draft.
https://reviews.llvm.org/D54352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
73 matches
Mail list logo
