[Lldb-commits] [lldb] 874b649 - [lldb] Add missing include to ObjCLanguage.cpp to fix build

Author: Raphael Isemann Date: 2019-11-12T10:21:49+01:00 New Revision: 874b6495b5fd6d7e2dc91d6a756eea67486ea7bb URL: https://github.com/llvm/llvm-project/commit/874b6495b5fd6d7e2dc91d6a756eea67486ea7bb DIFF:

[Lldb-commits] [lldb] ec4c96d - [lldb][NFC] Simplify a return in ThreadPlanStepInRange::DefaultShouldStopHereCallback

Author: Raphael Isemann Date: 2019-11-12T10:58:54+01:00 New Revision: ec4c96d68566debcc4588c4189b4ef8a5f78729a URL: https://github.com/llvm/llvm-project/commit/ec4c96d68566debcc4588c4189b4ef8a5f78729a DIFF:

[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process

This revision was automatically updated to reflect the committed changes. Closed by commit rG77cc246412ca: [lldb] [Process/NetBSD] Use PT_STOP to stop the process [NFCI] (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70120: [lldb][NFC] Let CompilerType::DumpTypeValue take a option struct instead of a huge list of options

labath added a comment. I can't say I'm a fan of one-shot argument pack structures... For instance, one thing that's lost by this particular implementation is the implicit "nonnull" annotations on the arguments conferred by the references (the data extractor is already "nonnull", the stream

[Lldb-commits] [PATCH] D70074: [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cc853b416a2: [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 52f3a2f - [lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable

Author: Raphael Isemann Date: 2019-11-12T10:04:32+01:00 New Revision: 52f3a2faf92c4d8efd0e626d52d5f64b7c5d468f URL: https://github.com/llvm/llvm-project/commit/52f3a2faf92c4d8efd0e626d52d5f64b7c5d468f DIFF:

[Lldb-commits] [PATCH] D70070: [lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG52f3a2faf92c: [lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3130a88 - [lldb][test] Macros in expressions require DWARF 5

Author: Tatyana Krasnukha Date: 2019-11-12T13:58:06+03:00 New Revision: 3130a88137ddc6ee277c4e896f235cf93d883dfa URL: https://github.com/llvm/llvm-project/commit/3130a88137ddc6ee277c4e896f235cf93d883dfa DIFF:

[Lldb-commits] [PATCH] D69704: [lldb] Add IsTypeSystemCompatible method to SBModule to allow checking compatibility between language versions

teemperor updated this revision to Diff 228873. teemperor added a comment. - Renamed to IsDebugInfoCompatible - Pass on llvm::Error error message to caller. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69704/new/ https://reviews.llvm.org/D69704 Files:

[Lldb-commits] [PATCH] D70134: dotest: Add a way for the run_to_* helpers to register dylibs

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This is fine. I wondered a bit about whether it would be generally useful to add the 'dylibs that have to be copied' to the SBLaunchInfo? It has some other platform'y like things. I'm

[Lldb-commits] [PATCH] D69704: [lldb] Add IsDebugInfoCompatible method to SBModule to allow checking compatibility between language versions

jingham added a comment. In D69704#1742494 , @labath wrote: > I think this is fine. > > In D69704#1741588 , @jingham wrote: > > > If, for instance, we decided to use .pcm files as a serialization form for > > type

[Lldb-commits] [lldb] 9691549 - [ObjectFileMachO] Fix the build for __arm64__.

Author: Davide Italiano Date: 2019-11-12T11:10:36-08:00 New Revision: 96915495f9fcbd47bf3f893200e3f5a8e30d0d9e URL: https://github.com/llvm/llvm-project/commit/96915495f9fcbd47bf3f893200e3f5a8e30d0d9e DIFF:

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

jingham added a comment. It looks like all the continue routines in lldbvscode_testcase.py use self.vscode.wait_for_stopped() after setting the target going. Would that fix the problem here? Without knowing anything about the protocol VSCode is using, I can't say that's right. But if launch

[Lldb-commits] [lldb] 91e94a7 - [LLDB][Formatters] Re-enable std::function formatter with fixes to improve non-cached lookup performance

Author: shafik Date: 2019-11-12T11:30:18-08:00 New Revision: 91e94a7015f14f78809e875c43acbd341d081479 URL: https://github.com/llvm/llvm-project/commit/91e94a7015f14f78809e875c43acbd341d081479 DIFF: https://github.com/llvm/llvm-project/commit/91e94a7015f14f78809e875c43acbd341d081479.diff LOG:

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228937. wallace added a comment. set a return list limit of 50 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69873/new/ https://reviews.llvm.org/D69873 Files:

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [lldb] fbb228c - [LLDB] Always remove debugserver from LLVM_DISTRIBUTION_COMPONENTS

Author: Jonas Devlieghere Date: 2019-11-12T12:58:26-08:00 New Revision: fbb228c7d222b991bed20d674e3b43143848fb95 URL: https://github.com/llvm/llvm-project/commit/fbb228c7d222b991bed20d674e3b43143848fb95 DIFF:

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik updated this revision to Diff 228923. shafik added a comment. Applying clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69913/new/ https://reviews.llvm.org/D69913 Files: lldb/include/lldb/Symbol/CompileUnit.h

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

This revision was automatically updated to reflect the committed changes. Closed by commit rG91e94a7015f1: [LLDB][Formatters] Re-enable std::function formatter with fixes to improve non… (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D69704: [lldb] Add IsDebugInfoCompatible method to SBModule to allow checking compatibility between language versions

teemperor requested review of this revision. teemperor marked an inline comment as done. teemperor added a comment. Marking this as changes needed that I don't land this without applying Pavel's comment. Comment at: lldb/source/API/SBModule.cpp:700-704 + if

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht created this revision. rupprecht added reviewers: JDevlieghere, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds several 5C/5D escape codes that allow moving forward/backward words similar to bash command line navigation. On my terminal, `ctrl+v

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

JDevlieghere added a comment. This is very nice, thanks! Any chance we could test this with a pexpect test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70137/new/ https://reviews.llvm.org/D70137

[Lldb-commits] [PATCH] D70050: [lldb] [test] Add a test for watchpoint set error handling on NetBSD

mgorny abandoned this revision. mgorny added a comment. Combined into D70023 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70050/new/ https://reviews.llvm.org/D70050 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

mgorny planned changes to this revision. mgorny marked an inline comment as done. mgorny added inline comments. Herald added a subscriber: dexonsmith. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:281 +NativeThreadNetBSD& t =

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny updated this revision to Diff 228955. mgorny added a comment. Herald added a reviewer: jfb. Included fixed tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70025/new/ https://reviews.llvm.org/D70025 Files:

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

mgorny updated this revision to Diff 228954. mgorny marked an inline comment as done. mgorny edited the summary of this revision. mgorny added a comment. Herald added a reviewer: jfb. Herald added a subscriber: jfb. Included fixed tests + new test from D70050 .

[Lldb-commits] [PATCH] D70120: [lldb][NFC] Let CompilerType::DumpTypeValue take a option struct instead of a huge list of options

teemperor created this revision. teemperor added reviewers: labath, davide. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This function has 8 parameters which makes its function calls hard to read. It also doesn't help that half the parameters are just

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

labath created this revision. labath added reviewers: clayborg, kusmour, jankratochvil. Herald added a project: LLDB. The test used a non-stopping "run" command to launch the process. This is different from the regular launch with no extra launch commands, which uses eLaunchFlagStopAtEntry to

[Lldb-commits] [PATCH] D69704: [lldb] Add IsTypeSystemCompatible method to SBModule to allow checking compatibility between language versions

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is fine. In D69704#1741588 , @jingham wrote: > If, for instance, we decided to use .pcm files as a serialization form for > type info

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

mgorny updated this revision to Diff 228907. mgorny added a comment. Herald added a reviewer: jfb. Included updated on test suite status. I've only un-XFAIL-ed tests that are definitely (well, most likely) fixed. I didn't change the status of tests that are flaky (e.g. concurrent tests that

[Lldb-commits] [PATCH] D70106: Performance: Add a set of visited SymbolFiles to other the FindFiles variant.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b73dcdc9656: Performance: Add a set of visited SymbolFiles to the other FindFiles variant. (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D70134: dotest: Add a way for the run_to_* helpers to register dylibs

friss created this revision. friss added a reviewer: jingham. Herald added a project: LLDB. To run the testsuite remotely the executable needs to be uploaded to the target system. The Target takes care of this by default. When the test uses additional shared libraries, those won't be handled by

[Lldb-commits] [PATCH] D69704: [lldb] Add IsTypeSystemCompatible method to SBModule to allow checking compatibility between language versions

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/module_compability/TestModuleDebugInfoCompatible.py:61 +self.assert_compatible(exe_module, lldb.eLanguageTypeC_plus_plus_11) +self.assert_compatible(exe_module,

[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

vsk updated this revision to Diff 228920. vsk marked 3 inline comments as done. vsk added a comment. - Add doxygen comments describing {Direct,Indirect}CallEdge & address the rest of Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70100/new/

[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

vsk updated this revision to Diff 228921. vsk added a comment. - Remove a few more redundant Optional initializations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70100/new/ https://reviews.llvm.org/D70100 Files: lldb/include/lldb/Symbol/Function.h

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I agree - as there is currently: self.verify_commands('launchCommands', output, launchCommands) # Verify the "stopCommands" here self.continue_to_next_stop() BTW I did not

[Lldb-commits] [lldb] 3b73dcd - Performance: Add a set of visited SymbolFiles to the other FindFiles variant.

Author: Adrian Prantl Date: 2019-11-12T09:38:37-08:00 New Revision: 3b73dcdc9656e156c4380454150b8986c5b9aad1 URL: https://github.com/llvm/llvm-project/commit/3b73dcdc9656e156c4380454150b8986c5b9aad1 DIFF: https://github.com/llvm/llvm-project/commit/3b73dcdc9656e156c4380454150b8986c5b9aad1.diff

[Lldb-commits] [lldb] 6aa60b0 - [lldb] Fix more -Wdeprecated-copy warnings

Author: Pavel Labath Date: 2019-11-12T14:39:47+01:00 New Revision: 6aa60b0514865751ea9dd208236db60eb69aaf1e URL: https://github.com/llvm/llvm-project/commit/6aa60b0514865751ea9dd208236db60eb69aaf1e DIFF: https://github.com/llvm/llvm-project/commit/6aa60b0514865751ea9dd208236db60eb69aaf1e.diff

[Lldb-commits] [lldb] 1dfb1a8 - [lldb] Fix some warnings in the python plugin

Author: Pavel Labath Date: 2019-11-12T14:39:34+01:00 New Revision: 1dfb1a85e7cbc37bf6fff9bb046c6e8be0c26b8e URL: https://github.com/llvm/llvm-project/commit/1dfb1a85e7cbc37bf6fff9bb046c6e8be0c26b8e DIFF: https://github.com/llvm/llvm-project/commit/1dfb1a85e7cbc37bf6fff9bb046c6e8be0c26b8e.diff

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGa6c40f56aed1: Revert Fix lookup of symbols at the same address with no size vs. size (authored by omjavaid). Changed

[Lldb-commits] [lldb] a6c40f5 - Revert "Fix lookup of symbols at the same address with no size vs. size"

Author: Muhammad Omair Javaid Date: 2019-11-12T19:02:17+05:00 New Revision: a6c40f56aed1556a80867209b6846f7eedc4dc78 URL: https://github.com/llvm/llvm-project/commit/a6c40f56aed1556a80867209b6846f7eedc4dc78 DIFF:

[Lldb-commits] [lldb] bd7d9a8 - [lldb] Check if we actually have a Clang type in ObjCLanguage::GetPossibleFormattersMatches

Author: Raphael Isemann Date: 2019-11-12T09:59:04+01:00 New Revision: bd7d9a85b8b09c945b98d374cc37cb374db012e6 URL: https://github.com/llvm/llvm-project/commit/bd7d9a85b8b09c945b98d374cc37cb374db012e6 DIFF:

[Lldb-commits] [lldb] 6cc853b - [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType

Author: Raphael Isemann Date: 2019-11-12T10:02:59+01:00 New Revision: 6cc853b416a2b0d0b435d145988c5d3b6faaa712 URL: https://github.com/llvm/llvm-project/commit/6cc853b416a2b0d0b435d145988c5d3b6faaa712 DIFF:

[Lldb-commits] [lldb] 34ca6e1 - [LLDB] Remove debug message in AddLLDB.cmake

Author: Jonas Devlieghere Date: 2019-11-12T15:33:03-08:00 New Revision: 34ca6e1fbef54465d623ffc8d55e824054913509 URL: https://github.com/llvm/llvm-project/commit/34ca6e1fbef54465d623ffc8d55e824054913509 DIFF:

[Lldb-commits] [lldb] 056c319 - [LLDB] Only set FRAMEWORK when we're actually building a framework.

Author: Jonas Devlieghere Date: 2019-11-12T15:42:07-08:00 New Revision: 056c3197694881379cb75a3cb1bd6a511d044714 URL: https://github.com/llvm/llvm-project/commit/056c3197694881379cb75a3cb1bd6a511d044714 DIFF:

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht updated this revision to Diff 228972. rupprecht added a comment. - Add a pexpect test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70137/new/ https://reviews.llvm.org/D70137 Files:

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht added a comment. In D70137#1742766 , @JDevlieghere wrote: > This is very nice, thanks! > > Any chance we could test this with a pexpect test? Absolutely. It was waaay more complicated than I expected due to funny escaping somewhere between

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D70137#1743032 , @rupprecht wrote: > In D70137#1742766 , @JDevlieghere > wrote: > > > This is

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

clayborg added a comment. --stop-at-entry only really works for Darwin since its posix_spawn has a flag that will stop it at the entry point before anything executes. On linux, does this flag do anything? Comment at:

[Lldb-commits] [PATCH] D70134: dotest: Add a way for the run_to_* helpers to register dylibs

clayborg added a comment. In D70134#1742647 , @jingham wrote: > This is fine. > > I wondered a bit about whether it would be generally useful to add the > 'dylibs that have to be copied' to the SBLaunchInfo? It has some other > platform'y like things.

[Lldb-commits] [lldb] 7ba2864 - [Reproducer] Discard reproducer directory if not generated.

Author: Jonas Devlieghere Date: 2019-11-12T20:16:33-08:00 New Revision: 7ba28644a1eeb554e818644556f98abfc0795b02 URL: https://github.com/llvm/llvm-project/commit/7ba28644a1eeb554e818644556f98abfc0795b02 DIFF:

[Lldb-commits] [lldb] a247bd1 - [LLDB] Fix/silence CMake developer warning for LLDB framework.

Author: Jonas Devlieghere Date: 2019-11-12T14:17:19-08:00 New Revision: a247bd1f274e49ea83b2ad39c6ff062753e9e779 URL: https://github.com/llvm/llvm-project/commit/a247bd1f274e49ea83b2ad39c6ff062753e9e779 DIFF:

[Lldb-commits] [PATCH] D70154: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

omjavaid created this revision. omjavaid added a reviewer: labath. This patch fixes whitespace/tabs mismatch in lldb/packages/Python/lldbsuite/test/make/Makefile.rules https://reviews.llvm.org/D70154 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.rules Index:

[Lldb-commits] [PATCH] D70134: dotest: Add a way for the run_to_* helpers to register dylibs

jingham added a comment. In D70134#1743075 , @clayborg wrote: > In D70134#1742647 , @jingham wrote: > > > This is fine. > > > > I wondered a bit about whether it would be generally useful to add the > > 'dylibs

[Lldb-commits] [lldb] 9b95835 - [LLDB] Add core definition for armv8l and armv7l

Author: Muhammad Omair Javaid Date: 2019-11-13T05:40:09+05:00 New Revision: 9b958356983afffaf56788f37bdab9213369fa45 URL: https://github.com/llvm/llvm-project/commit/9b958356983afffaf56788f37bdab9213369fa45 DIFF:

[Lldb-commits] [PATCH] D69904: [arm] Add core definition for armv8l and armv7l

omjavaid marked an inline comment as done. omjavaid added a comment. I have updated the patch as suggested and will move out the triple fix and whitespace issue in separate patches. Committing remaining changes shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69904/new/

[Lldb-commits] [PATCH] D69904: [arm] Add core definition for armv8l and armv7l

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9b958356983a: [LLDB] Add core definition for armv8l and armv7l (authored by omjavaid). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

omjavaid created this revision. omjavaid added reviewers: labath, jasonmolenda, clayborg. Herald added a subscriber: kristof.beyls. This patch fixes a bug where when target triple created from elf information is arm-*-linux-eabihf and platform triple is armv8l-*-linux-gnueabihf. Merging both