[Lldb-commits] [PATCH] D70241: [lldb] remove unsigned Stream::operator<< overloads

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. I recently re-discovered that the unsinged stream operators of the lldb_private::Stream class have a surprising behavior in that they print the number

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

davide added a comment. In D68179#1745614 , @tetsuo-cpp wrote: > Thanks for looking at this. I will need someone to commit it for me. > However, I've been having issues with the test suite on my MacBook. > `check-lldb-unit` works for me but `check-llvm`

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp marked an inline comment as done. tetsuo-cpp added a comment. Thanks for looking at this. I will need someone to commit it for me. However, I've been having issues with the test suite on my MacBook. `check-lldb-unit` works for me but `check-llvm` and `check-lldb` are hitting issues

[Lldb-commits] [lldb] 6e3ecd1 - [lldb] Fix dwo variant of TestLibCxxFunction

Author: Pavel Labath Date: 2019-11-14T16:29:36+01:00 New Revision: 6e3ecd18847cb5c5bbe41d23428e1aa57ed1b339 URL: https://github.com/llvm/llvm-project/commit/6e3ecd18847cb5c5bbe41d23428e1aa57ed1b339 DIFF: https://github.com/llvm/llvm-project/commit/6e3ecd18847cb5c5bbe41d23428e1aa57ed1b339.diff

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

labath created this revision. labath added reviewers: jingham, clayborg. Herald added a project: LLDB. labath added a comment. Note: I am certain that there will be things which will fail for these kinds of "processes" -- there's plenty of `!= LLDB_INVALID_PID` checks, but most of them seem to

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

labath added a comment. Note: I am certain that there will be things which will fail for these kinds of "processes" -- there's plenty of `!= LLDB_INVALID_PID` checks, but most of them seem to be on the launch/attach code paths which are not exercised here. I am fine with fixing these as they

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp updated this revision to Diff 229291. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 Files: lldb/tools/debugserver/source/JSON.cpp lldb/tools/debugserver/source/JSON.h lldb/unittests/debugserver/CMakeLists.txt

[Lldb-commits] [PATCH] D70215: Use ForEachExternalModule in ParseTypeFromClangModule (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM minus some small changes. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:127 + /// Apply a lambda to each external lldb::Module referenced by this + ///

[Lldb-commits] [PATCH] D70215: Use ForEachExternalModule in ParseTypeFromClangModule (NFC)

This revision was automatically updated to reflect the committed changes. aprantl marked an inline comment as done. Closed by commit rG0e45e60c6f31: Use ForEachExternalModule in ParseTypeFromClangModule (NFC) (authored by aprantl). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 83f5287 - Rename DWO -> Clang module to avoid confusion. (NFC)

Author: Adrian Prantl Date: 2019-11-14T09:13:49-08:00 New Revision: 83f5287567bcdf1b5de244229fba4e552b7d0054 URL: https://github.com/llvm/llvm-project/commit/83f5287567bcdf1b5de244229fba4e552b7d0054 DIFF: https://github.com/llvm/llvm-project/commit/83f5287567bcdf1b5de244229fba4e552b7d0054.diff

[Lldb-commits] [PATCH] D70241: [lldb] remove unsigned Stream::operator<< overloads

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. 拾 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70241/new/ https://reviews.llvm.org/D70241

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht updated this revision to Diff 229349. rupprecht marked an inline comment as done. rupprecht added a comment. - Fix test comment - Use `expect` helper from lldbpexpect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70137/new/

[Lldb-commits] [lldb] 0352007 - Convert UpdateExternalModuleListIfNeeded to use early exits.

Author: Adrian Prantl Date: 2019-11-14T09:35:06-08:00 New Revision: 0352007fdb3f6ae1eaedbff53e018ad1e364720e URL: https://github.com/llvm/llvm-project/commit/0352007fdb3f6ae1eaedbff53e018ad1e364720e DIFF: https://github.com/llvm/llvm-project/commit/0352007fdb3f6ae1eaedbff53e018ad1e364720e.diff

[Lldb-commits] [PATCH] D70252: [Docs] Add Python caveats under the development section

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aadsm, davide. JDevlieghere added a project: LLDB. Herald added subscribers: abidh, arphaman. This adds a page named Caveats with a section on some of the things to be aware of related to Python. It's a question we've seen

[Lldb-commits] [lldb] 0e45e60 - Use ForEachExternalModule in ParseTypeFromClangModule (NFC)

Author: Adrian Prantl Date: 2019-11-14T08:58:31-08:00 New Revision: 0e45e60c6f316d095d878aea3c098202b39b5bee URL: https://github.com/llvm/llvm-project/commit/0e45e60c6f316d095d878aea3c098202b39b5bee DIFF: https://github.com/llvm/llvm-project/commit/0e45e60c6f316d095d878aea3c098202b39b5bee.diff

[Lldb-commits] [lldb] dcb5bd9 - Fix incorrect comment.

Author: Adrian Prantl Date: 2019-11-14T09:55:24-08:00 New Revision: dcb5bd91095fc2a009a777e4d7eefb127f057634 URL: https://github.com/llvm/llvm-project/commit/dcb5bd91095fc2a009a777e4d7eefb127f057634 DIFF: https://github.com/llvm/llvm-project/commit/dcb5bd91095fc2a009a777e4d7eefb127f057634.diff

Re: [Lldb-commits] [lldb] 6e3ecd1 - [lldb] Fix dwo variant of TestLibCxxFunction

Pavel, Thank you for fixing this! > On Nov 14, 2019, at 7:30 AM, Pavel Labath via lldb-commits > wrote: > > > Author: Pavel Labath > Date: 2019-11-14T16:29:36+01:00 > New Revision: 6e3ecd18847cb5c5bbe41d23428e1aa57ed1b339 > > URL: >

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/terminal/TestEditline.py:37-38 + +# Run help for different commands for escape variants to make sure each +# one matches uniquely (the

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

merge_guards_bot added a comment. Build result: pass - 60015 tests passed, 0 failed and 722 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [lldb] 4229f70 - [LLDB] Make a clear distinction between usage & development docs

Author: Jonas Devlieghere Date: 2019-11-14T09:04:28-08:00 New Revision: 4229f70d226b381ca82b49c7f66d7e33b73be9fd URL: https://github.com/llvm/llvm-project/commit/4229f70d226b381ca82b49c7f66d7e33b73be9fd DIFF:

[Lldb-commits] [lldb] 268e11f - Convert condition to early exit (NFC)

Author: Adrian Prantl Date: 2019-11-14T09:38:49-08:00 New Revision: 268e11f95d331a6268f08bf94ce86d04efbb7baa URL: https://github.com/llvm/llvm-project/commit/268e11f95d331a6268f08bf94ce86d04efbb7baa DIFF: https://github.com/llvm/llvm-project/commit/268e11f95d331a6268f08bf94ce86d04efbb7baa.diff

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

labath added a comment. Looks good to me. If I was writing the test, I'd probably just make it do a string->json->string round-trip and then verify the final string. But this is fine too... Comment at: lldb/unittests/debugserver/JSONTest.cpp:16-17 +void TestJSON(JSONValue

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2e65447b3cb: [lldb][Editline] Support ctrl+left/right arrow word navigation. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D70137?vs=229349=229373#toc Repository: rG

Re: [Lldb-commits] [lldb] 0877dd1 - [Driver] Force llvm to install its handlers before lldb's

> On Nov 11, 2019, at 6:12 AM, Pavel Labath wrote: > > On 09/11/2019 03:05, v...@apple.com wrote: >>> On Nov 8, 2019, at 1:17 AM, Pavel Labath wrote: >>> >>> On 08/11/2019 01:33, via lldb-commits wrote: Hey JF, Pavel, We're still seeing crashes due to SIGPIPE

[Lldb-commits] [PATCH] D70252: [Docs] Add Python caveats under the development section

aadsm added a comment. Thank you for writing this up! I was thinking how I would find this.. I don't see myself clicking on the "Caveats" link (could also be a me problem though). Could we also add a link to it in this section? https://lldb.llvm.org/resources/build.html#id22. Something like

[Lldb-commits] [lldb] f2e6544 - [lldb][Editline] Support ctrl+left/right arrow word navigation.

Author: Jordan Rupprecht Date: 2019-11-14T11:41:11-08:00 New Revision: f2e65447b3cb6340883957e033e77095a025ebdc URL: https://github.com/llvm/llvm-project/commit/f2e65447b3cb6340883957e033e77095a025ebdc DIFF:

[Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

aprantl created this revision. aprantl added reviewers: jingham, JDevlieghere. Herald added a reviewer: jdoerfert. This feature is mostly there to aid debugging of Clang module issues, since the only useful actual the end-user can to is to recompile their program. Dsymutil prints a similar

[Lldb-commits] [lldb] 3b142bc - [LLDB] Fix more -Wdocumentation issues (NFC)

Author: Jonas Devlieghere Date: 2019-11-14T14:31:44-08:00 New Revision: 3b142bc9ff14869726e4fff27ba6f925aa7b5be4 URL: https://github.com/llvm/llvm-project/commit/3b142bc9ff14869726e4fff27ba6f925aa7b5be4 DIFF:

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai updated this revision to Diff 229418. xiaobai added a comment. Herald added a project: LLDB. Rebased Moved this change to the monorepo layout Moved `ClangASTContext::GetScratch` to the ClangASTContext header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 95c770f - [Utility] Remove a dead header [PPC64LE_ehframe_Registers.h]

Author: Davide Italiano Date: 2019-11-14T15:29:47-08:00 New Revision: 95c770fbfb14b07e1af7c2d427c16745617d9f1f URL: https://github.com/llvm/llvm-project/commit/95c770fbfb14b07e1af7c2d427c16745617d9f1f DIFF:

[Lldb-commits] [lldb] f4f47da - [Reproducer] Enable crash reports for reproducer tests

Author: Jonas Devlieghere Date: 2019-11-14T14:16:41-08:00 New Revision: f4f47da530729161a73d71791ada3ab58886b9dd URL: https://github.com/llvm/llvm-project/commit/f4f47da530729161a73d71791ada3ab58886b9dd DIFF:

[Lldb-commits] [PATCH] D70281: Fix -Wunused-result warnings in LLDB

rnk created this revision. rnk added a reviewer: amccarth. Herald added a project: LLDB. Three uses of try_lock intentionally ignore the result. Make that explicit with a void cast. Add what appears to be a missing return in the clang expression parser code. It's a functional change, but

[Lldb-commits] [PATCH] D70281: Fix -Wunused-result warnings in LLDB

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. It's too bad that pattern is repeated three times, including the explanatory comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

vsk created this revision. vsk added reviewers: JDevlieghere, jfb, labath. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: LLVM. Allow clients of the llvm library to opt-in to one-shot SIGPIPE handling, instead of exiting with an IO error by default. This prevents "IO

[Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Host/common/Host.cpp:300 va_end(args); + + // Log to log channel. This allows testcases to grep for log output. On macOS,

[Lldb-commits] [PATCH] D70281: Fix -Wunused-result warnings in LLDB

jingham added a comment. There's a PP above each instance of this code explaining why it's okay if we don't get the API lock, since that's a bit of a tricky point. So if you want to add a comment, it would be better to say "see explanation above". Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D70154: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

omjavaid added a comment. In D70154#1743904 , @labath wrote: > It looks like you're replacing everything with tabs. I suppose that's fine, > as that is the prevalent local convention, but it might be better to go for > spaces, as we don't use tabs

[Lldb-commits] [PATCH] D70154: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9f30f2ecba5: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

omjavaid added a comment. In D63540#1744110 , @jankratochvil wrote: > It is still the same (no arm32 regression) with > `16bdcc809c72c639a2888b6b859dca88453e3c28` and this patch reapplied. Hi Jan, This issue manifests itself only when lldb test suite

[Lldb-commits] [PATCH] D70177: [lldb] Fix that trailing backslashes in source lines break the Clang highlighter

teemperor updated this revision to Diff 229241. teemperor added a comment. - Turns out \r is also a new line that can be escaped, so that is now also handled. Also moved to a variable storing the line ending instead of three bools. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f9f30f2 - [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

Author: Muhammad Omair Javaid Date: 2019-11-14T13:53:58+05:00 New Revision: f9f30f2ecba520fa1ce33ae7c27c807a0e7199be URL: https://github.com/llvm/llvm-project/commit/f9f30f2ecba520fa1ce33ae7c27c807a0e7199be DIFF:

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. Getting `ld.lld: error: failed to open ../../../../bin/clang-10: Cannot allocate memory` when trying to build `lldb` natively on arm32 (the same error happens both for `clang` and for `lldb`). Apparently memory is not a problem but the linker runs out of its

[Lldb-commits] [lldb] ea2ba51 - [lldb][NFC] Simplify IOHandler constructor/destructor setup

Author: Raphael Isemann Date: 2019-11-14T09:59:00+01:00 New Revision: ea2ba51b0b2f5bc0bea650bf64e5cbd63476563f URL: https://github.com/llvm/llvm-project/commit/ea2ba51b0b2f5bc0bea650bf64e5cbd63476563f DIFF:

Re: [Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

On Thu, 14 Nov 2019 at 15:04, Jan Kratochvil via Phabricator < revi...@reviews.llvm.org> wrote: > jankratochvil added a comment. > > Getting `ld.lld: error: failed to open ../../../../bin/clang-10: Cannot > allocate memory` when trying to build `lldb` natively on arm32 (the same > error happens

[Lldb-commits] [lldb] e03a06b - Fix typos in docs. NFC

Author: Diana Picus Date: 2019-11-14T12:11:57+01:00 New Revision: e03a06b348ba49d774aa948f97bce3fac638a797 URL: https://github.com/llvm/llvm-project/commit/e03a06b348ba49d774aa948f97bce3fac638a797 DIFF: https://github.com/llvm/llvm-project/commit/e03a06b348ba49d774aa948f97bce3fac638a797.diff

[Lldb-commits] [lldb] 8715ffd - [lldb] Fix that trailing backslashes in source lines break the Clang highlighter

Author: Raphael Isemann Date: 2019-11-14T11:11:20+01:00 New Revision: 8715ffdf1aafbfca7c3d7f1622fe586243f31df1 URL: https://github.com/llvm/llvm-project/commit/8715ffdf1aafbfca7c3d7f1622fe586243f31df1 DIFF:

[Lldb-commits] [PATCH] D70177: [lldb] Fix that trailing backslashes in source lines break the Clang highlighter

This revision was automatically updated to reflect the committed changes. Closed by commit rG8715ffdf1aaf: [lldb] Fix that trailing backslashes in source lines break the Clang highlighter (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

mgorny updated this revision to Diff 229279. mgorny added a comment. Made dbregs copied only if any watchpoints are enabled, and added error handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70023/new/ https://reviews.llvm.org/D70023 Files: