[Lldb-commits] [PATCH] D70363: [lldb] [Process/NetBSD] Implement thread name getting

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.cpp:122 + if (::sysctl(mib, 5, nullptr, , nullptr, 0) == -1 || size == 0) { +LLDB_LOG(log, "sysctl() for LWP info size failed: {0}", strerror(errno)); +return "";

[Lldb-commits] [PATCH] D70363: [lldb] [Process/NetBSD] Implement thread name getting

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/thread-name/main.cpp:13 + ::pthread_setname_np(::pthread_self(), "%s", +

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

labath accepted this revision. labath added a comment. I wouldn't use the word "happy", but I think this is fine. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70277/new/ https://reviews.llvm.org/D70277 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

labath added a comment. In D70314#1747850 , @teemperor wrote: > In D70314#1747711 , @labath wrote: > > > Semi-random idea: Instead of running the expression through the command > > line and then unpacking the

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for getting to the bottom of this. Adding the \n check is fine. The "expect" function was meant to be an pexpect equivalent of the "expect" function in regular tests (which also just

[Lldb-commits] [PATCH] D70363: [lldb] [Process/NetBSD] Implement thread name getting

mgorny updated this revision to Diff 229765. mgorny marked 3 inline comments as done. mgorny added a comment. Implemented review suggestions. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70363/new/ https://reviews.llvm.org/D70363 Files:

[Lldb-commits] [PATCH] D70363: [lldb] [Process/NetBSD] Implement thread name getting

This revision was automatically updated to reflect the committed changes. Closed by commit rG23a766dcad47: [lldb] [Process/NetBSD] Implement thread name getting (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8924d6403eb: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

Hi Jan, This is known problem and fix is posted here https://reviews.llvm.org/D70155 Please use cmake argument -DLLVM_HOST_TRIPLE=arm-linux-gnueabihf as a workaround. Thanks! On Fri, 15 Nov 2019 at 21:27, Jan Kratochvil via Phabricator < revi...@reviews.llvm.org> wrote: > jankratochvil added

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. Thanks for the reviews! @davide could you please commit this on my behalf? Thanks for the advice. I intend to continue working on LLDB when I can so I will spend some time to fix the test suite on my Mac. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70381: Mark PR44037 tests as XFAIL on AArch64 Linux dwo

rovka created this revision. rovka added reviewers: omjavaid, aprantl, labath. Herald added a subscriber: kristof.beyls. These tests are failing with various assertion failures, but they all throw the following error message first: error: a.out 0x002d: adding range [0x14-0x24) which has a

[Lldb-commits] [PATCH] D70381: Mark PR44037 tests as XFAIL on AArch64 Linux dwo

rovka updated this revision to Diff 229794. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70381/new/ https://reviews.llvm.org/D70381 Files: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

mstorsjo created this revision. mstorsjo added reviewers: labath, zturner, amccarth, aleksandr.urakov. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. When running the lldb command line debugger in a console, it can be convenient to get the output of the debuggee inline in

[Lldb-commits] [PATCH] D70386: [lldb-server] Use LLDB_LOG_ERROR to consume Error<> even if logging is disabled

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. thanks Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70386/new/ https://reviews.llvm.org/D70386 ___

[Lldb-commits] [PATCH] D70388: [lldb] Remove ClangExpressionDeclMap::ResolveUnknownTypes

teemperor created this revision. Herald added subscribers: lldb-commits, JDevlieghere, abidh, aprantl. Herald added a project: LLDB. This is some really shady code. It's supposed to kick in after an expression already failed and then try to look up "unknown types" that for some undocumented

[Lldb-commits] [PATCH] D70386: [lldb-server] Use LLDB_LOG_ERROR to consume Error<> even if logging is disabled

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D70386 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationReplayServer.cpp

[Lldb-commits] [PATCH] D70381: Mark PR44037 tests as XFAIL on AArch64 Linux dwo

labath resigned from this revision. labath added a comment. Looks fine to me, but I am not running aarch64 tests. You might want to check of @omjavaid is running them and whether he's ok with that. Otherwise, you can just manage the decorators yourself without any special reviews. CHANGES

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor planned changes to this revision. teemperor marked an inline comment as done. teemperor added a comment. In D70314#1749427 , @labath wrote: > In D70314#1747850 , @teemperor wrote: > > > In D70314#1747711

[Lldb-commits] [lldb] 869d904 - [lldb][NFC] Cleanup comments in ClangASTSource.h

Author: Raphael Isemann Date: 2019-11-18T14:17:35+01:00 New Revision: 869d904df76c9e74e040b072b4bc8114fd20f5bc URL: https://github.com/llvm/llvm-project/commit/869d904df76c9e74e040b072b4bc8114fd20f5bc DIFF:

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

labath added a comment. > The same behaviour also seems possible to enable by setting the > eLaunchFlagDisableSTDIO flag somehow, but I wasn't able to figure out how to > set that when calling the normal lldb.exe. You can set this flag via the `-n`/`--disable-stdio` flag of "process launch".

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2480-2482 +self.expect_expr(var, result_value=result_value, result_type=result_type, run_type=self.ExpressionCommandType.EXPRESSION) +self.expect_expr(var,

[Lldb-commits] [lldb] 10b8514 - [lldb] Fix JSON parser to allow empty arrays

Author: Alex Cameron Date: 2019-11-18T15:12:55+01:00 New Revision: 10b851434324f82e9ad11d39f501f2d8b921642a URL: https://github.com/llvm/llvm-project/commit/10b851434324f82e9ad11d39f501f2d8b921642a DIFF: https://github.com/llvm/llvm-project/commit/10b851434324f82e9ad11d39f501f2d8b921642a.diff

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2480-2482 +self.expect_expr(var, result_value=result_value, result_type=result_type, run_type=self.ExpressionCommandType.EXPRESSION)

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya created this revision. poya added a reviewer: davide. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Remove hardcoded string prefix length assumption causing issues when concatenating summary for NSURL in NSURLSummaryProvider. Provider relies on

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b851434324: [lldb] Fix JSON parser to allow empty arrays (authored by tetsuo-cpp, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. In D49466#1681534 , @phosek wrote: > @dankm is it OK if we take over this change to push it forward? At this point sure. Unless it's accepted as-is now, then I don't have a commit bit to finish it off. Repository: rG LLVM

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. Whoops. There are extra changes here I didn't mean to submit :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 229835. dankm added a comment. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. - Address feedback from @Lekensteyn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 229837. dankm added a comment. - Address feedback from @Lekensteyn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 Files:

[Lldb-commits] [lldb] 0aed648 - [Docs] Add Python caveats under the development section

Author: Jonas Devlieghere Date: 2019-11-18T09:15:00-08:00 New Revision: 0aed648649775bfe29b01f7ad9b072f92df7c448 URL: https://github.com/llvm/llvm-project/commit/0aed648649775bfe29b01f7ad9b072f92df7c448 DIFF:

[Lldb-commits] [PATCH] D70252: [Docs] Add Python caveats under the development section

This revision was automatically updated to reflect the committed changes. Closed by commit rG0aed64864977: [Docs] Add Python caveats under the development section (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70252/new/

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

davide added a comment. While I review this, can you create a corresponding change to `swift.org` which tests this? [I don't think we have a way of triggering this from pure Obj-C, but I may be wrong]. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

mstorsjo added a comment. Thanks for the excellent explanations of the situation so far. I'll have a look at how it behaves with input and other aspects of console sharing. You might be right that it can cause some issues, as I did run into cases where the main lldb console UI hung if the

[Lldb-commits] [PATCH] D70409: [Docs] Add reproducer documentation.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/docs/resources/reproducers.rst:73 + + > lldb --replay /path/to/reproducer + vsk wrote: > Is it valid to type: `lldb --capture --replay /path/to/reproducer`? This

[Lldb-commits] [lldb] d4f18f1 - Replace bitfield in lldb::Type with byte-sized members. (NFC)

Author: Adrian Prantl Date: 2019-11-18T10:00:26-08:00 New Revision: d4f18f11d372bd02127424ae6a8f8a30f77a0426 URL: https://github.com/llvm/llvm-project/commit/d4f18f11d372bd02127424ae6a8f8a30f77a0426 DIFF: https://github.com/llvm/llvm-project/commit/d4f18f11d372bd02127424ae6a8f8a30f77a0426.diff

[Lldb-commits] [PATCH] D70409: [Docs] Add reproducer documentation.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a reviewer: jfb. Herald added subscribers: abidh, arphaman. Herald added a project: LLDB. This adds a page about LLDB reproducers. It describes how to use the reproducers on the command line and lists some of

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

davide added a comment. Thanks again for your contribution! This change broke one test. Can you please investigate? RESULT: FAILED (0 passes, 3 failures, 0 errors, 1 skipped, 0 expected failures, 0 unexpected successes) Testing Time: 316.58s

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4624e83ce7b1: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling (authored by vsk). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

clayborg added a comment. > When running the lldb command line debugger in a console, it can be > convenient to get the output of the debuggee inline in the same console. agreed. It just did the default behavior of launching in a command.exe since that is what windows does by default. > The

[Lldb-commits] [lldb] 4624e83 - [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

Author: Vedant Kumar Date: 2019-11-18T10:27:27-08:00 New Revision: 4624e83ce7b124545b55e45ba13f2d900ed65654 URL: https://github.com/llvm/llvm-project/commit/4624e83ce7b124545b55e45ba13f2d900ed65654 DIFF: https://github.com/llvm/llvm-project/commit/4624e83ce7b124545b55e45ba13f2d900ed65654.diff

[Lldb-commits] [PATCH] D70409: [Docs] Add reproducer documentation.

vsk added a comment. Herald added a subscriber: dexonsmith. I like it! Comment at: lldb/docs/resources/reproducers.rst:9 + +Reproducers in LLDB are an attempt to improve the experience for both the users +encountering these bugs and the developers working on resolving them.

[Lldb-commits] [PATCH] D70409: [Docs] Add reproducer documentation.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Thanks for writing this up! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70409/new/ https://reviews.llvm.org/D70409

[Lldb-commits] [PATCH] D70381: Mark PR44037 tests as XFAIL on AArch64 Linux dwo

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Thanks rovka. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70381/new/ https://reviews.llvm.org/D70381 ___ lldb-commits

[Lldb-commits] [PATCH] D70386: [lldb-server] Use LLDB_LOG_ERROR to consume Error<> even if logging is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG926d283893ae: [lldb-server] Use LLDB_LOG_ERROR to consume Error even if logging is disabled (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

labath added a comment. Thanks. This behavior makes sense to me. @jasonmolenda, @clayborg, do you see any problems with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/ https://reviews.llvm.org/D70155 ___ lldb-commits

[Lldb-commits] [PATCH] D70409: [Docs] Add reproducer documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf19ea6ea5f8c: [Docs] Add reproducer documentation (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D70409?vs=229917=229947#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] a921f58 - Revert "[CMake] Re-enable -Wno-gnu-anonymous-struct & -Wno-nested-anon-types."

Author: Jonas Devlieghere Date: 2019-11-18T17:00:35-08:00 New Revision: a921f587f7b0df7dc37ff44117321cfa7849edb6 URL: https://github.com/llvm/llvm-project/commit/a921f587f7b0df7dc37ff44117321cfa7849edb6 DIFF:

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

jasonmolenda added a comment. It might be worth adding an extra conditional to check for a buffer of 0 bytes returned. I haven't checked if ReadAllRegisters() would return success if a 0-length register context was received. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

jasonmolenda created this revision. jasonmolenda added a reviewer: clayborg. jasonmolenda added a project: LLDB. jasonmolenda added a comment. It might be worth adding an extra conditional to check for a buffer of 0 bytes returned. I haven't checked if ReadAllRegisters() would return success if

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

omjavaid updated this revision to Diff 229971. omjavaid added a comment. Added a unittest as suggested by @labath. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/ https://reviews.llvm.org/D70155 Files: lldb/source/Utility/ArchSpec.cpp

[Lldb-commits] [lldb] f19ea6e - [Docs] Add reproducer documentation

Author: Jonas Devlieghere Date: 2019-11-18T16:03:06-08:00 New Revision: f19ea6ea5f8c0a05bf7638dad857c70f9236b6e8 URL: https://github.com/llvm/llvm-project/commit/f19ea6ea5f8c0a05bf7638dad857c70f9236b6e8 DIFF:

[Lldb-commits] [PATCH] D70415: Complete complete types early when importing types from Clang module DWARF.

aprantl created this revision. aprantl added reviewers: jingham, shafik, jasonmolenda, clayborg. Herald added a project: LLDB. This affects -gmodules only. Under normal operation pcm_type is a shallow forward declaration that gets completed later. This is necessary to support cyclic data

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

amccarth added a comment. labath has added great context here, and I generally agree with clayborg's ideal of optimal behavior. That said, if memory serves, getting that behavior on Windows can be quite challenging, so I'm not sure if it's worth the effort. Repository: rLLDB LLDB CHANGES