[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. Thanks for the explanation. I have some ideas on this below, though I am not sure if I know enough about the problem to be able to tell which ones are feasible. In D76471#1933923 , @aprantl wrote: > Thanks, Pavel, these are all

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 added a comment. @jankratochvil When I use `LLVM_USE_SANITIZER=Address` and then run `ninja check-lldb` I get other errors: $ ninja check-lldb -j 1 [1/1981] Building DiagnosticDriverKinds.inc... FAILED: tools/clang/include/clang/Basic/DiagnosticDriverKinds.inc cd

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

labath added a comment. In D74636#1934466 , @wallace wrote: > I added some tests cases to show why I used "settings set target.inherit-env". > > There are currently two ways to launch a process. Either with the plain > "program" argument, > or with the

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/new/ https://reviews.llvm.org/D76470

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert g_vsc.launch_info to a local variable

anton.kolesov created this revision. anton.kolesov added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This field inside of the global variable can be a simple local variable because it is used in only one function: request_launch.

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert g_vsc.launch_info to a local variable

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a good idea. Could you do the same for `attach_info` (it looks like it should be possible)? Otherwise, one is left wondering about what's the difference... Repository: rG LLVM

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Thanks for the quick fix, verified that the crash is fixed on trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. I do not have the testsuite running with ASAN (it is also failing for me) but I expected to at least run by hand ASAN-built LLDB for the code modified by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 added a comment. > run by hand ASAN-built LLDB for the code modified by this patch. How do I do that? This is my first PR to llvm, so I am not aware of the tools. Please bear with me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:318 + /// Synthesize a clang::Module and return its ID or a default-constructed ID. +

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert g_vsc.launch_info to a local variable

labath added a comment. In D76593#1936757 , @anton.kolesov wrote: > In D76593#1936337 , @labath wrote: > > > Sounds like a good idea. Could you do the same for `attach_info` (it looks > > like it should be

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4a6e63ea123: [lldb/Target] Rework the way the inferior environment is created (authored by friss). Changed prior to commit: https://reviews.llvm.org/D76470?vs=251813=252052#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd7b45057ca9: [lldb/API] Make Launch(Simple) use args and env from target properties (authored by friss). Changed prior to commit: https://reviews.llvm.org/D76045?vs=249834=252051#toc Repository: rG

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

This revision was automatically updated to reflect the committed changes. Closed by commit rG9228a9efc6c5: [lldb/Target] Initialize new targets environment variables from target.env-vars (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert g_vsc.launch_info to a local variable

anton.kolesov added a comment. In D76593#1936337 , @labath wrote: > Sounds like a good idea. Could you do the same for `attach_info` (it looks > like it should be possible)? Otherwise, one is left wondering about what's > the difference... I have that

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252026. kwk added a comment. - check for valid UUID - less verbose mkdir and rm output - More explicit test and documentation - fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/

[Lldb-commits] [PATCH] D76280: [lldb] Mark expressions that couldn't be parsed or executed as failed expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a4905ae2d65: [lldb] Mark expressions that couldnt be parsed or executed as failed… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [lldb] cd7b450 - [lldb/API] Make Launch(Simple) use args and env from target properties

Author: Fred Riss Date: 2020-03-23T07:58:33-07:00 New Revision: cd7b45057ca9bc72b99a0abc6c9be25e0f72fbcf URL: https://github.com/llvm/llvm-project/commit/cd7b45057ca9bc72b99a0abc6c9be25e0f72fbcf DIFF: https://github.com/llvm/llvm-project/commit/cd7b45057ca9bc72b99a0abc6c9be25e0f72fbcf.diff

[Lldb-commits] [lldb] 9228a9e - [lldb/Target] Initialize new targets environment variables from target.env-vars

Author: Fred Riss Date: 2020-03-23T07:58:33-07:00 New Revision: 9228a9efc6c57a932d936ebb214f6ff5bafe79ff URL: https://github.com/llvm/llvm-project/commit/9228a9efc6c57a932d936ebb214f6ff5bafe79ff DIFF: https://github.com/llvm/llvm-project/commit/9228a9efc6c57a932d936ebb214f6ff5bafe79ff.diff

[Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

Author: Fred Riss Date: 2020-03-23T07:58:34-07:00 New Revision: b4a6e63ea12309bf667d1569a20ec5b081cbf2a4 URL: https://github.com/llvm/llvm-project/commit/b4a6e63ea12309bf667d1569a20ec5b081cbf2a4 DIFF: https://github.com/llvm/llvm-project/commit/b4a6e63ea12309bf667d1569a20ec5b081cbf2a4.diff

[Lldb-commits] [lldb] 6a4905a - [lldb] Mark expressions that couldn't be parsed or executed as failed expressions

Author: Raphael Isemann Date: 2020-03-23T15:28:17+01:00 New Revision: 6a4905ae2d65a2883112bf8cbf83c35c0c03f410 URL: https://github.com/llvm/llvm-project/commit/6a4905ae2d65a2883112bf8cbf83c35c0c03f410 DIFF:

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath @fche2 @jankratochvil I've implemented the logic to ignore invalid UUIDs and the ones that are too short. Can you have another look please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43 + buildID.GetBytes().size() == + sizeof(llvm::support::ulittle32_t)) // .gnu_debuglink crc32 +return llvm::createStringError(llvm::inconvertibleErrorCode(),

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252054. kwk marked 2 inline comments as done. kwk added a comment. - Remove commented out code - Remove lldb/packages/Python/lldbsuite/test/httpserver.py in favor of lit test - Removed commented out left-over code Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252059. kwk added a comment. - Adjust buildID verification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

The new testing for “inherit-env=false” is failing on Windows. I skipped the test for now. Could it be that it never worked there? (In which case XFail would be a better resolution) Does anyone have easy access to a Windows build to try it out? Thanks, Fred > On Mar 23, 2020, at 7:59 AM, Fred

[Lldb-commits] [lldb] 7e10581 - [lldb/testsuite] Skip part of TestSettings.py on windows

Author: Fred Riss Date: 2020-03-23T09:15:16-07:00 New Revision: 7e10581e8c15af39e6f0820768c5d43587f9088d URL: https://github.com/llvm/llvm-project/commit/7e10581e8c15af39e6f0820768c5d43587f9088d DIFF: https://github.com/llvm/llvm-project/commit/7e10581e8c15af39e6f0820768c5d43587f9088d.diff

[Lldb-commits] [PATCH] D76626: [lldb/Reproducers] Collect files imported by command script import

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, aprantl. Files imported by the script interpreter aren't opened by LLDB so they don't end up in the reproducer. The solution is to explicitly add them to the FileCollector. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. In D76569#1936796 , @shivammittal99 wrote: > How do I do that? This is my first PR to llvm, so I am not aware of the > tools. Please bear with me. No big deal, just compile it with `-DLLVM_USE_SANITIZER=Address` as you

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai added a comment. In D74023#1933427 , @jhenderson wrote: > @HsiangKai, have you noticed that there are some test failures according to > the harbourmaster bot? They look like they could be related to this somehow. @jhenderson, yes, I found

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

aprantl added a comment. In D76569#1936796 , @shivammittal99 wrote: > > run by hand ASAN-built LLDB for the code modified by this patch. > > How do I do that? This is my first PR to llvm, so I am not aware of the > tools. Please bear with me. FYI,

[Lldb-commits] [lldb] ae37e22 - [lldb/Reproducers] Mark reproducer test directory as unsupported on Windows

Author: Jonas Devlieghere Date: 2020-03-23T09:54:11-07:00 New Revision: ae37e2285d233f28217e4e95a3ff71059c7ee8c7 URL: https://github.com/llvm/llvm-project/commit/ae37e2285d233f28217e4e95a3ff71059c7ee8c7 DIFF:

[Lldb-commits] [PATCH] D76476: Add formatter for libc++ std::unique_ptr

This revision was automatically updated to reflect the committed changes. Closed by commit rGa567d6809e15: [DataFormatters] Add formatter for libc++ std::unique_ptr (authored by shafik). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D76476?vs=251783=252112#toc

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert g_vsc.launch_info to a local variable

clayborg accepted this revision. clayborg added a comment. Yes, this works now that we are creating the target in this function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76593/new/ https://reviews.llvm.org/D76593

[Lldb-commits] [lldb] a567d68 - [DataFormatters] Add formatter for libc++ std::unique_ptr

Author: shafik Date: 2020-03-23T11:48:20-07:00 New Revision: a567d6809e1514f34975d746bb1c93301792a74c URL: https://github.com/llvm/llvm-project/commit/a567d6809e1514f34975d746bb1c93301792a74c DIFF: https://github.com/llvm/llvm-project/commit/a567d6809e1514f34975d746bb1c93301792a74c.diff LOG:

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 updated this revision to Diff 252125. shivammittal99 added a comment. Remove conditional and move raw_command_string line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569/new/ https://reviews.llvm.org/D76569 Files:

[Lldb-commits] [lldb] 67d67eb - Internal expressions shouldn't increment the result variable numbering.

Author: Jim Ingham Date: 2020-03-23T13:30:37-07:00 New Revision: 67d67ebe8f2535c5de75c62820f7713f87d07307 URL: https://github.com/llvm/llvm-project/commit/67d67ebe8f2535c5de75c62820f7713f87d07307 DIFF: https://github.com/llvm/llvm-project/commit/67d67ebe8f2535c5de75c62820f7713f87d07307.diff

[Lldb-commits] [PATCH] D76532: Internal expressions should not increment the next result variable numbering

This revision was automatically updated to reflect the committed changes. Closed by commit rG67d67ebe8f25: Internal expressions shouldnt increment the result variable numbering. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace added a comment. TBH I'd prefer to have consistency across all these options regardless of how the target is launched. That means modifying the defaults of the target settings that can be specified via launch.json arguments. What do you think, @clayborg? Repository: rG LLVM Github

[Lldb-commits] [lldb] b6ae893 - [lldb/PlatformDarwin] Always delete destination file first in PutFile

Author: Fred Riss Date: 2020-03-23T14:34:17-07:00 New Revision: b6ae8937e031cde2e70e6a83d46c21e940fdf4ac URL: https://github.com/llvm/llvm-project/commit/b6ae8937e031cde2e70e6a83d46c21e940fdf4ac DIFF: https://github.com/llvm/llvm-project/commit/b6ae8937e031cde2e70e6a83d46c21e940fdf4ac.diff

[Lldb-commits] [PATCH] D76450: [lldb/PlatformDarwin] Always delete destination file first in PutFile

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ae8937e031: [lldb/PlatformDarwin] Always delete destination file first in PutFile (authored by friss). Changed prior to commit: https://reviews.llvm.org/D76450?vs=251461=252146#toc Repository: rG

[Lldb-commits] [lldb] 318a0ca - Revert "Create basic SBEnvironment class"

Author: Walter Erquinigo Date: 2020-03-23T18:20:10-07:00 New Revision: 318a0caf9acc8c4ec778ba4f0bbd115a8244bb85 URL: https://github.com/llvm/llvm-project/commit/318a0caf9acc8c4ec778ba4f0bbd115a8244bb85 DIFF:

[Lldb-commits] [lldb] ca69be2 - Create basic SBEnvironment class

Author: Walter Erquinigo Date: 2020-03-23T19:23:33-07:00 New Revision: ca69be218c03b1528b1439c4ca56074e434c094d URL: https://github.com/llvm/llvm-project/commit/ca69be218c03b1528b1439c4ca56074e434c094d DIFF:

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

MaskRay added a comment. commit fd868f517d2c5ca8c0f160dbec0857b14ecf74c1 should be associated with `Differential Revision: https://reviews.llvm.org/D76111`. The revert of fd868f517d2c5ca8c0f160dbec0857b14ecf74c1

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

jarin created this revision. jarin added a reviewer: teemperor. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. Detection of C strings does not work well for pointers. If the value object holding a (char*) pointer does not have an address (e.g., if it is a temp), the value

[Lldb-commits] [PATCH] D76529: [lldb-vscode] Add missing launchCommands entry in the package.json

wallace updated this revision to Diff 252150. wallace added a comment. Use clayborg's wording. Thanks, milord. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76529/new/ https://reviews.llvm.org/D76529 Files: lldb/tools/lldb-vscode/package.json

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

clayborg added a comment. I would either add the option to SBLaunchInfo so it can be specified, or execute the command. If the target is created, it is setting a target specific setting. If had to pick I would add the API to SBLaunchInfo. Whenever I see something that can't be done through the

[Lldb-commits] [lldb] fd868f5 - Create basic SBEnvironment class

Author: Walter Erquinigo Date: 2020-03-23T17:59:06-07:00 New Revision: fd868f517d2c5ca8c0f160dbec0857b14ecf74c1 URL: https://github.com/llvm/llvm-project/commit/fd868f517d2c5ca8c0f160dbec0857b14ecf74c1 DIFF: