[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a comment. @jankratochvil thanks for this thorough review. I have to think about one comment more precisely but the rest was fixed. Comment at: lldb/source/Host/common/DebugInfoD.cpp:50 + "invalid build ID: %s", +

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk updated this revision to Diff 252510. kwk marked 10 inline comments as done. kwk added a comment. - Add newline to end of FindDebuginfod.cmake - Describe empty string returned from debuginfod::findSource() - Don't treat build IDs of len <= 8 as an error but simply as not found - move inexpensi

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 252505. HsiangKai added a comment. Rebase on master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp lldb/source/Plugins/ObjectFile/

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert launch_info and attach_info to local variables

labath accepted this revision. labath added a comment. still lgtm, just make sure to clang-format before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76593/new/ https://reviews.llvm.org/D76593 ___

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

kwk added a comment. LGTM but I haven't tested it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

kwk requested changes to this revision. kwk added a comment. This revision now requires changes to proceed. I agree with @friss that there is a change in behavior. I'm not sure it is fixable with what I wrote but I think so. Comment at: lldb/include/lldb/Target/Language.h:191

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

labath added a reviewer: jingham. labath requested changes to this revision. labath added a subscriber: jingham. labath added a comment. This revision now requires changes to proceed. Adding @jingham. Jim, what do you make of this patch and the feature overall? I know I said this looks "mostly go

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. You already mention that in the commit message, but it may be nice to also mention somewhere near the test case that these kinds of "URL"s can occur when and connecting to and andr

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

teemperor updated this revision to Diff 252517. teemperor retitled this revision from "[lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType" to "[lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert". tee

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

labath added a comment. Ok, you really want to collect the full dsym, then who am I to stop you. :) But implementing that collection in the FileCollector does not seem right, because at the filesystem level, dsyms are not special (which is why you needed to reverse-engineer them from the path).

[Lldb-commits] [lldb] 7754b65 - [lldb][NFC] lldb_assert->lldbassert in ClangExpressionParser

Author: Raphael Isemann Date: 2020-03-25T14:10:48+01:00 New Revision: 7754b652b3bf0c4b63cccf6e0d4066503684e94a URL: https://github.com/llvm/llvm-project/commit/7754b652b3bf0c4b63cccf6e0d4066503684e94a DIFF: https://github.com/llvm/llvm-project/commit/7754b652b3bf0c4b63cccf6e0d4066503684e94a.dif

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 252562. HsiangKai added a comment. Fix Harbormaster test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp lldb/source/Plugi

[Lldb-commits] [lldb] c726753 - [lldb] add lit.local.cfg for breakpad tests

Author: Pavel Labath Date: 2020-03-25T17:00:46+01:00 New Revision: c72675394a8592dbe9733c6eef305d094f7f8119 URL: https://github.com/llvm/llvm-project/commit/c72675394a8592dbe9733c6eef305d094f7f8119 DIFF: https://github.com/llvm/llvm-project/commit/c72675394a8592dbe9733c6eef305d094f7f8119.diff

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

On Wed, Mar 25, 2020 at 9:10 AM Pavel Labath wrote: > On 25/03/2020 01:04, Adrian McCarthy wrote: > > I took a stab at this, but I'm not seeing any new test failures. > > That is odd. > > I was doing some stuff on windows today, so I figured I'd take a stab at > this. I was kind of right that the

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

On Wed, Mar 25, 2020 at 9:49 AM Adrian McCarthy wrote: > > > On Wed, Mar 25, 2020 at 9:10 AM Pavel Labath wrote: > >> On 25/03/2020 01:04, Adrian McCarthy wrote: >> > I took a stab at this, but I'm not seeing any new test failures. >> >> That is odd. >> >> I was doing some stuff on windows today

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 252591. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp llvm/include/llvm/Binar

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

aprantl added a comment. I only have a bunch of superficial comments but this seems reasonable as far as I can tell. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1988 +bool add_this_entry = false; if (EXPORT_SYMBOL_FLAGS_REEXPORT & e.entry.fla

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1254 + auto parent_desc = ast_source->getSourceDescriptor(parent.GetValue()); + std::tie(module, created) = m_module_map_up->findOrCreat

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay updated this revision to Diff 252622. emrekultursay added a comment. - Added comments to Android-specific test cases, as suggested by labath@. - Reformatted lines that exceeded 80 chars. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay added a comment. I don't have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

JDevlieghere updated this revision to Diff 252649. JDevlieghere added a comment. Make the whole thing generic. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76672/new/ https://reviews.llvm.org/D76672 Files: lldb/include/lldb/Host/FileSystem.h lldb/include/

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

jingham added a reviewer: clayborg. jingham added a comment. Greg originally designed the macOS equivalent of this, so I've added him. I totally agree that you should only do wide searches for source files when there's no way to get a narrower context. Even "source list" could use the current

[Lldb-commits] [PATCH] D76803: Remove m_last_file_sp from SourceManager

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. emrekultursay updated this revision to Diff 252675. emrekultursay added a comment. emrekultursay updated this revision to Diff 252677. No changes emrekultursay added a comment. Adding 3rd

[Lldb-commits] [PATCH] D76803: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252677. emrekultursay added a comment. Adding 3rd commit to diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76803/new/ https://reviews.llvm.org/D76803 Files: lldb/include/lldb/Core/Debugger.h lldb

[Lldb-commits] [PATCH] D76803: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252675. emrekultursay added a comment. No changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76803/new/ https://reviews.llvm.org/D76803 Files: lldb/include/lldb/Core/SourceManager.h lldb/source/Co

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. emrekultursay added a child revision: D76806: Remove m_last_file_sp from SourceManager. Lookup and subsequent insert was done using uninitialized FileSpec object, which caused the cache to

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. emrekultursay added a child revision: D76805: Fix SourceManager::SourceFileCache insertion. LLDB memory-maps large source files, and at the same time, caches all source files in the Source

[Lldb-commits] [PATCH] D76803: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252679. emrekultursay added a comment. - Remove m_last_file_sp from SourceManager Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76803/new/ https://reviews.llvm.org/D76803 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ...and replace it with m_last_file_spec instead. When Source Cache is enabled, the value stored in m_last_file_sp is already in the Source Cache, and caching it again in SourceManager bring

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil accepted this revision. jankratochvil added a comment. The ASan GCC report was valid ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94299#c6 ) but that was really just the first/previous version of the patch. I will try to check why clang ASan does not report it (and also GCC ASan

[Lldb-commits] [PATCH] D76808: Fix handling of bit-fields when there is a base class when parsing DWARF

shafik created this revision. shafik added reviewers: aprantl, labath. shafik added a reviewer: vsk. When parsing DWARF and laying out bit-fields we currently don't take into account whether we have a base class or not. Currently if the first field is a bit-field but the bit offset is due a fiel

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

JDevlieghere added a comment. Testing the effect of this change might be hard, but please add or extend an existing test to check that you can set and read the new property. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76804/new/ https://reviews.

[Lldb-commits] [PATCH] D76808: Fix handling of bit-fields when there is a base class when parsing DWARF

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Couple of minor suggestions inside. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2671 // If we have a gap between the last_field_

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252702. emrekultursay added a comment. fix link warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.org/D76805 Files: lldb/source/Core/SourceManager.cpp Index: lldb/

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

JDevlieghere added a comment. Could we add a unit test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.org/D76805 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

jingham added a comment. IIUC, you should be able to test the actual effect you are trying to achieve by having a large source file, running "source list" to get it into the File Manager, then try to open the source file for writing in a process in a subshell that won't have the same mmap. Tha

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham created this revision. jingham added reviewers: clayborg, labath, friss. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jingham added a parent revision: D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID. This is the final patch

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

emrekultursay added a comment. I did not see any existing tests that validate setting/reading of properties. Can you point to me if you know any that exists? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76804/new/ https://reviews.llvm.org/D76804

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252734. emrekultursay added a comment. Herald added a subscriber: mgorny. Add unit tests for SourceManager::SourceFileCache Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere created this revision. JDevlieghere added reviewers: stella.stamenova, NathanielMcVicar. Herald added a subscriber: mgorny. For multi-generator builds like MSVC and Xcode, the install source and destination of the `lldb-python-scripts` target contains configuration dependent paths a

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda updated this revision to Diff 252756. jasonmolenda added a comment. Update patch with Adrian's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76758/new/ https://reviews.llvm.org/D76758 Files: lldb/source/Plugins/ObjectFi

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda marked 11 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:4499 +std::sort(external_sym_trie_entries.begin(), + external_sym_trie_entries.end(), sort_by_address); +

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda marked 2 inline comments as done. jasonmolenda added a comment. Thanks Adrian, great comments, incorporated most of them. The use of the block to search the trie entries when eliminating duplication between nlist/tries was a good idea, much cleaner now. Comment