[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

labath added a comment. Since the option of going to the "host platform" was discussed already and rejected, I think a new discussion is in order before going back to it. What are the exact circumstances where you did not get a PlatformDarwin object? Note that I am not opposed (and I never was)

Re: [Lldb-commits] [lldb] 58c7bf2 - Update LLDB filespec tests for remove_dots change

On 05/05/2020 02:27, Reid Kleckner via lldb-commits wrote: > I am not sure if "C:..\.." should become "C:" or "C:\", though. The new > output doesn't precisely match the TODO message, but it seems > appropriate given the specification of remove_dots and how .. traversals > work at the root director

[Lldb-commits] [PATCH] D79404: Fix error handling after [] in 'frame variable'

jarin created this revision. jarin added reviewers: teemperor, labath. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. jarin retitled this revision from "Fix handling of [] in 'frame variable'" to "Fix error handling after [] in 'frame variable'". This fixes a bug

[Lldb-commits] [PATCH] D79384: RFC: Add an API that allows iterating over a debug map's OSO's Modules

labath added a comment. My understanding is that these OSO modules are supposed to be a hidden implementation detail of SymbolFileDWARF(DebugMap) and that they should not leak out the main module. For example, we make sure to always rewrite any addresses that come out of the oso modules to be i

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

labath accepted this revision. labath added a comment. I note that the call to exit(1) bypasses some of the finalization code in (most notably, `reset_stdin_termios`). That does not seem ideal, but it looks like a pre-existing problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7882

[Lldb-commits] [PATCH] D79404: Fix error handling after [] in 'frame variable'

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79404/new/ https://reviews.llvm.org/D79404 _

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

labath added a comment. In D78801#2017413 , @paolosev wrote: > Please, let me know if this is a step in the right direction, in your opinion. I believe it is. I think that creating ThreadWasm objects would make it even better (and address a lot of Greg'

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

labath added a comment. In D78801#2019384 , @clayborg wrote: > Interesting approach to DWARF expression evaluation, though it might be > simpler to leave the DWARFExpression as it is, and have the plug-in part only > handle unknown opcodes. Right now if

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D79308#2017377 , @jarin wrote: > Yeah, I considered something like that, but then I thought it would be better > if the "other" thread only runs cod

[Lldb-commits] [PATCH] D79404: Fix error handling after [] in 'frame variable'

jarin added a comment. Do you think Raphael would want to review this as well? If you think it is not necessary, could you land the patch for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79404/new/ https://reviews.llvm.org/D79404 _

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin updated this revision to Diff 262082. jarin added a comment. ... and remove the extra braces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp lldb/source/Plugins/Process/L

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin updated this revision to Diff 262081. jarin marked an inline comment as done. jarin added a comment. Addressed reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin updated this revision to Diff 262087. jarin marked 2 inline comments as done. jarin added a comment. ... now also fixed the 'volatile'. It took only three patches to copy four lines of code by hand. Not bad, huh? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://re

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin added inline comments. Comment at: lldb/test/API/functionalities/thread/break_step_other/TestThreadBreakStepOther.py:21 +class ThreadBreakStepOtherTestCase(TestBase): +mydir = TestBase.compute_mydir(__file__) + labath wrote: > You can add `NO_DEBUG_INF

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

labath added a comment. In D74136#1983467 , @kwk wrote: > I'd be happy to hear about your comments @labath because I'm kind of stuck in > what I can think of. I will obviously rename `SearchFilterByModuleListAndCU` > but that can come in a child revision

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

labath added inline comments. Comment at: lldb/test/API/functionalities/thread/break_step_other/TestThreadBreakStepOther.py:21 +class ThreadBreakStepOtherTestCase(TestBase): +mydir = TestBase.compute_mydir(__file__) + jarin wrote: > labath wrote: > > You can

[Lldb-commits] [PATCH] D75607: [lldb] Use llvm::MC for register numbers in AArch64 ABIs

labath added a comment. Thanks for trying this out. Do you by any chance have any ideas why would lldb assign a dwarf number to the pc register when neither llvm nor the arm64 abi do not specify a pc register number? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [lldb] c05f354 - [lldb/unittest] Avoid relying on compiler character encoding in unicode test

Author: Vedant Kumar Date: 2020-05-05T09:18:35-07:00 New Revision: c05f35443c3bc6dc69e060c766b23669a33e14ac URL: https://github.com/llvm/llvm-project/commit/c05f35443c3bc6dc69e060c766b23669a33e14ac DIFF: https://github.com/llvm/llvm-project/commit/c05f35443c3bc6dc69e060c766b23669a33e14ac.diff

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. This looks good to me. If a similar API made sense on Module, I guess it can live on SymboleFile. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79273/new/ https://reviews.llvm.org/D792

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

teemperor added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:786 + module_sp->RegisterXcodeSDK(sdk, sysroot); + return {sdk}; +} I think we can early-exit here? CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

aprantl marked an inline comment as done. aprantl added a comment. In D79364#2019818 , @labath wrote: > Since the option of going to the "host platform" was discussed already and > rejected, I think a new discussion is in order before going back to it. Wh

[Lldb-commits] [lldb] 61d5b0e - [lldb/Driver] Exit with a non-zero exit code in case of error in batch mode.

Author: Jonas Devlieghere Date: 2020-05-05T11:01:44-07:00 New Revision: 61d5b0e66394d61947d61861685b4223214f023e URL: https://github.com/llvm/llvm-project/commit/61d5b0e66394d61947d61861685b4223214f023e DIFF: https://github.com/llvm/llvm-project/commit/61d5b0e66394d61947d61861685b4223214f023e.d

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

aprantl updated this revision to Diff 262176. aprantl added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79273/new/ https://reviews.llvm.org/D79273 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Symbol/SymbolFile.h lldb/include/lldb/Target/Platform.h lldb/so

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

aprantl updated this revision to Diff 262178. aprantl added a comment. Updated the wrong review... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79273/new/ https://reviews.llvm.org/D79273 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Symbol/SymbolFile.h lldb/source/Cor

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

This revision was automatically updated to reflect the committed changes. Closed by commit rG61d5b0e66394: [lldb/Driver] Exit with a non-zero exit code in case of error in batch mode. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

aprantl updated this revision to Diff 262184. aprantl added a comment. Removed the Platform detour. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79364/new/ https://reviews.llvm.org/D79364 Files: lldb/include/lldb/Target/Platform.h lldb/source/Core/Module.cpp lldb/source/Plugins/

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

jarin reopened this revision. jarin added a comment. This revision is now accepted and ready to land. Reopening for further investigation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 _

[Lldb-commits] [lldb] 48e5eed - [TestIndirectSymbols] This now runs and works on iOS (arm64).

Author: Davide Italiano Date: 2020-05-05T13:14:05-07:00 New Revision: 48e5eedab3aa170f880b333d5e38bbc6e72d4b8b URL: https://github.com/llvm/llvm-project/commit/48e5eedab3aa170f880b333d5e38bbc6e72d4b8b DIFF: https://github.com/llvm/llvm-project/commit/48e5eedab3aa170f880b333d5e38bbc6e72d4b8b.dif

[Lldb-commits] [lldb] d606dcc - [TestIndirectSymbol] This tests an Apple-specific feature.

Author: Davide Italiano Date: 2020-05-05T13:14:05-07:00 New Revision: d606dcc65254b13e6238b69d8185d3667e850522 URL: https://github.com/llvm/llvm-project/commit/d606dcc65254b13e6238b69d8185d3667e850522 DIFF: https://github.com/llvm/llvm-project/commit/d606dcc65254b13e6238b69d8185d3667e850522.dif

[Lldb-commits] [PATCH] D79384: RFC: Add an API that allows iterating over a debug map's OSO's Modules

aprantl updated this revision to Diff 262208. aprantl added a comment. Completely different implementation :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79384/new/ https://reviews.llvm.org/D79384 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/source/Plugins/SymbolFile/DWARF/

[Lldb-commits] [PATCH] D79404: Fix error handling after [] in 'frame variable'

teemperor accepted this revision. teemperor added a comment. I don't think I know this code better than Pavel, but this also LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79404/new/ https://reviews.llvm.org/D79404 _

[Lldb-commits] [lldb] 11af2bf - [lldb/Test] Update expressions.test for non-zero exit code

Author: Jonas Devlieghere Date: 2020-05-05T14:06:47-07:00 New Revision: 11af2bf0e0bc4d0946bef90e1d8c3df847a94843 URL: https://github.com/llvm/llvm-project/commit/11af2bf0e0bc4d0946bef90e1d8c3df847a94843 DIFF: https://github.com/llvm/llvm-project/commit/11af2bf0e0bc4d0946bef90e1d8c3df847a94843.d

[Lldb-commits] [lldb] 5034102 - Log the NSError str and object description on app launch fail

Author: Jason Molenda Date: 2020-05-05T15:51:50-07:00 New Revision: 5034102b249f850109ccd7b2c8a02a246edcd95a URL: https://github.com/llvm/llvm-project/commit/5034102b249f850109ccd7b2c8a02a246edcd95a DIFF: https://github.com/llvm/llvm-project/commit/5034102b249f850109ccd7b2c8a02a246edcd95a.diff

[Lldb-commits] [lldb] 0274c79 - [lldb/Utils] Serialize exit code in lldb-repro.py

Author: Jonas Devlieghere Date: 2020-05-05T16:05:49-07:00 New Revision: 0274c797c65a720010aee7f40cff621cd993ba15 URL: https://github.com/llvm/llvm-project/commit/0274c797c65a720010aee7f40cff621cd993ba15 DIFF: https://github.com/llvm/llvm-project/commit/0274c797c65a720010aee7f40cff621cd993ba15.d

[Lldb-commits] [PATCH] D76906: [lldb] Fixing the bug that the "log timer" has no tab completion

gedatsu217 added a comment. I performed a factory reset for OS upgrade and rebuild LLDB, and solved this problem. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76906/new/ https://reviews.llvm.org/D76906 _