[Lldb-commits] [PATCH] D79623: [LLDB] Add Linux SVE Ptrace macros.

kristof.beyls created this revision. kristof.beyls added a reviewer: omjavaid. Herald added subscribers: lldb-commits, tschuett. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79623 Files:

[Lldb-commits] [lldb] 710fa2c - [lldb] Make module-ownership.mm test more robust against AST node ordering

Author: Raphael Isemann Date: 2020-05-08T13:44:13+02:00 New Revision: 710fa2c4ee346e1ec2db66ac5fdf6909e79d9a8c URL: https://github.com/llvm/llvm-project/commit/710fa2c4ee346e1ec2db66ac5fdf6909e79d9a8c DIFF:

[Lldb-commits] [lldb] 7283ec0 - [lldb] Fix RecordDecl match string in module-ownership.mm to get the test running again

Author: Raphael Isemann Date: 2020-05-08T15:05:19+02:00 New Revision: 7283ec017049862423934187e35d69123774bbdc URL: https://github.com/llvm/llvm-project/commit/7283ec017049862423934187e35d69123774bbdc DIFF:

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

mib updated this revision to Diff 262823. mib edited the summary of this revision. mib added a comment. - Added a virtual method to create an empty struct type `TypeSystem::GetEmptyStructType` (if someone can think of a better name, I'm open to suggestions) - Refactored

[Lldb-commits] [lldb] 13a1b3c - [lldb] Prevent objc-root-class warning when compiling module-ownership.mm test

Author: Raphael Isemann Date: 2020-05-08T14:41:01+02:00 New Revision: 13a1b3c1e6f40ec8459280eaae82fd3b0ed7b3a7 URL: https://github.com/llvm/llvm-project/commit/13a1b3c1e6f40ec8459280eaae82fd3b0ed7b3a7 DIFF:

[Lldb-commits] [lldb] 8cb86ea - [lldb/test][Darwin] Ask dyld where the real python is

Author: Vedant Kumar Date: 2020-05-08T10:22:58-07:00 New Revision: 8cb86ead77417f889bf32a8f83da299215f78545 URL: https://github.com/llvm/llvm-project/commit/8cb86ead77417f889bf32a8f83da299215f78545 DIFF: https://github.com/llvm/llvm-project/commit/8cb86ead77417f889bf32a8f83da299215f78545.diff

[Lldb-commits] [PATCH] D79607: [lldb/test][Darwin] Ask dyld where the real python is

This revision was automatically updated to reflect the committed changes. Closed by commit rG8cb86ead7741: [lldb/test][Darwin] Ask dyld where the real python is (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79607/new/

[Lldb-commits] [PATCH] D79603: Add an API to construct an XcodeSDK from an SDK type.

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/XcodeSDK.cpp:145 +bool XcodeSDK::Info::operator==(const Info ) const { + return std::tie(type, version, internal) == +

[Lldb-commits] [lldb] ae920a8 - Add an API to construct an XcodeSDK from an SDK type.

Author: Adrian Prantl Date: 2020-05-08T10:47:13-07:00 New Revision: ae920a81ffa3c7e3c14de131d0d55abd31bbff7d URL: https://github.com/llvm/llvm-project/commit/ae920a81ffa3c7e3c14de131d0d55abd31bbff7d DIFF: https://github.com/llvm/llvm-project/commit/ae920a81ffa3c7e3c14de131d0d55abd31bbff7d.diff

[Lldb-commits] [lldb] 7cf4ab1 - [lldb][modules] Disable Clang Modules in source/Host directory on macOS

Author: Raphael Isemann Date: 2020-05-08T18:13:58+02:00 New Revision: 7cf4ab13af8aa3183e551b3319399cddd9384948 URL: https://github.com/llvm/llvm-project/commit/7cf4ab13af8aa3183e551b3319399cddd9384948 DIFF:

[Lldb-commits] [PATCH] D79632: [lldb][modules] Disable Clang Modules in source/Host directory on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cf4ab13af8a: [lldb][modules] Disable Clang Modules in source/Host directory on macOS (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I don't see a huge problem with things like `__lldb_autogen_nspair` as it's a single obviously generated type hardcoded into LLDB. But this really generic approach here can

[Lldb-commits] [PATCH] D79603: Add an API to construct an XcodeSDK from an SDK type.

aprantl updated this revision to Diff 262883. aprantl added a comment. Remove redundant static_assert. It was only needed in the other function because that one used cascading ifs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79603/new/ https://reviews.llvm.org/D79603 Files:

[Lldb-commits] [PATCH] D79603: Add an API to construct an XcodeSDK from an SDK type.

aprantl updated this revision to Diff 262884. aprantl added a comment. (Upload the full patch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79603/new/ https://reviews.llvm.org/D79603 Files: lldb/include/lldb/Utility/XcodeSDK.h lldb/source/Utility/XcodeSDK.cpp

[Lldb-commits] [lldb] 52712d3 - Re-land "get rid of PythonInteger::GetInteger()"

Author: Lawrence D'Anna Date: 2020-05-08T10:57:10-07:00 New Revision: 52712d3ff7a2f7bcf737996d6ab59ef2cc29c20d URL: https://github.com/llvm/llvm-project/commit/52712d3ff7a2f7bcf737996d6ab59ef2cc29c20d DIFF:

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

This revision was automatically updated to reflect the committed changes. Closed by commit rG52712d3ff7a2: Re-land get rid of PythonInteger::GetInteger() (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D78462?vs=259916=262908#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D79603: Add an API to construct an XcodeSDK from an SDK type.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae920a81ffa3: Add an API to construct an XcodeSDK from an SDK type. (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7b1f1cf - [lldb] Remove 'use_synthetic' parameters in ValueObject code

Author: Raphael Isemann Date: 2020-05-08T21:17:32+02:00 New Revision: 7b1f1cf1cf71ed143673a981074da642cfcde56e URL: https://github.com/llvm/llvm-project/commit/7b1f1cf1cf71ed143673a981074da642cfcde56e DIFF:

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss created this revision. friss added reviewers: labath, teemperor. Herald added a project: LLDB. The comment in the Editine.h header made it sound like editline was just unable to handle terminal resizing. We were not ever telling editline that the terminal had changed size, which might

[Lldb-commits] [lldb] eb7d32e - [lldb/Test] Update TestProcessList.py for reproducer replay

Author: Jonas Devlieghere Date: 2020-05-08T13:14:18-07:00 New Revision: eb7d32e46fe184fdfcb52e0a25973e713047e305 URL: https://github.com/llvm/llvm-project/commit/eb7d32e46fe184fdfcb52e0a25973e713047e305 DIFF:

[Lldb-commits] [PATCH] D79645: [lldb/test] Fix for flakiness in TestNSDictionarySynthetic

shafik added inline comments. Comment at: lldb/test/API/lldbtest.py:123 # In Python 2, string objects can contain Unicode characters. -out = out.decode('utf-8') -err = err.decode('utf-8') +out = out.decode('utf-8', 'replace') +

[Lldb-commits] [PATCH] D79645: [lldb/test] Fix for flakiness in TestNSDictionarySynthetic

vsk created this revision. vsk added reviewers: JDevlieghere, jingham, shafik. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TestNSDictionarySynthetic sets up an NSURL which does not initialize its _baseURL member. When the test runs and we print out the NSURL, we print

[Lldb-commits] [PATCH] D79568: [lldb] Remove 'use_synthetic' parameters in ValueObject code

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b1f1cf1cf71: [lldb] Remove use_synthetic parameters in ValueObject code (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D79646: [Reproducers] Serialize process arguments in ProcessInfo

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, LLDB. While debugging why `TestProcessList.py` failed during passive replay, I remembered that we don't serialize the arguments for ProcessInfo. This is necessary to make the test pass and to make `platform

[Lldb-commits] [PATCH] D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files

jankratochvil created this revision. jankratochvil added reviewers: JDevlieghere, labath. jankratochvil added a project: LLDB. D55859 and D63339 prevented needless dependencies on system symbol files. This testcase was

[Lldb-commits] [PATCH] D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files

JDevlieghere added a comment. Thanks Jan, LGTM. For now this appears to be the only test doing this, but if we end up having more of those we should probably abstract that away behind a helper that gives you an array with the executable and the setup commands. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D79645: [lldb/test] Fix for flakiness in TestNSDictionarySynthetic

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. We discussed adding this during the original review, but I left it out because we could always add it if we needed it. Turns out we do! Repository: rG LLVM Github

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

jingham added a comment. We certainly shouldn't duplicate the code for CommandObjectPlatformShell. Why don't you just add a "m_use_host_platform" ivar to CommandObjectPlatformShell, and make two instances of CommandObjectPlatformShell, one with m_use_host_platform set to false and added as a

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

jingham added a comment. I do something similar with CommandObjectThreadStepWithTypeAndScope so that I can share most of that command code, if you want to see an example of doing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79659/new/

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

clayborg added a comment. Why not just fix qLaunchSuccess by passing the string through a "escape_string(...)" function? Any packet that can return a string with unknown content should be escaped correctly. Adding a new packet doesn't really fix the problem in older debugserver/lldb-server

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

mib created this revision. mib added reviewers: JDevlieghere, teemperor. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This patch introduces the `shell` command in lldb. It allows the user to run shell builtins and binaries on the host without putting lldb in the

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda added a comment. In D79614#2027861 , @clayborg wrote: > Why not just fix qLaunchSuccess by passing the string through a > "escape_string(...)" function? Any packet that can return a string with > unknown content should be escaped correctly.

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda added a comment. In D79614#2027861 , @clayborg wrote: > Why not just fix qLaunchSuccess by passing the string through a > "escape_string(...)" function? Any packet that can return a string with > unknown content should be escaped correctly.

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

djtodoro accepted this revision. djtodoro added a comment. > It'd be nice to have a skipUnlessEntryValuesSupportedArch decorator, but I > don't think that has to be folded into this change. OK. I agree. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79607: [lldb/test][Darwin] Ask dyld where the real python is

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79607/new/ https://reviews.llvm.org/D79607

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 262818. Geod24 added a comment. Added Shell test A shell test was added using LLVM IR. The test has to run the generated binary, as there is currently a (likely) bug that leads to types being printed differently before and after 'run' is issued. Repository:

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

paolosev added a comment. Comment at: lldb/source/Plugins/Process/wasm/WasmProcess.cpp:71-76 + if (vm_addr < 0x1) { +if (WasmReadMemory(0 /*frame_index*/, vm_addr, buf, size)) { + return size; +} +return 0; + } else clayborg wrote: