[Lldb-commits] [PATCH] D83876: [lldb] Clean orphaned modules in Debugger::Destroy

teemperor added a comment. In D83876#2153709 , @jingham wrote: > We certainly don't want to clear the shared module cache when the Debugger or > the SBDebugger is destroyed. Most IDE's that use LLDB as a library use a > debugger per debugging session,

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aprantl added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:353 + if (debug_info < 1024) { +sprintf(debug_info_size, " (%lluKB)", debug_info); + } else if (debug_info < 1024*1024) { clayborg wrote: > Use the PRIu64 macro

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli updated this revision to Diff 278292. bbli added a comment. Modified stderr output instead of concatenating the stderr and stdout output strings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/new/ https://reviews.llvm.org/D83425

[Lldb-commits] [lldb] 3c22996 - [LLDB] Disable lldb-vscode test_terminate_commands test on Arm

Author: Muhammad Omair Javaid Date: 2020-07-16T03:33:52+05:00 New Revision: 3c2299612945caf75d5c3678ced0693ebd291819 URL: https://github.com/llvm/llvm-project/commit/3c2299612945caf75d5c3678ced0693ebd291819 DIFF:

[Lldb-commits] [lldb] 8b85f68 - [lldb/Test] Remove custom tearDownHooks from GDB Remote tests

Author: Jonas Devlieghere Date: 2020-07-15T13:18:06-07:00 New Revision: 8b85f68ee2ddd983c027adbda9567f06d25b3c51 URL: https://github.com/llvm/llvm-project/commit/8b85f68ee2ddd983c027adbda9567f06d25b3c51 DIFF:

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

shafik added a comment. @labath why do we need two copies of `use_lldb_suite.py`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83840/new/ https://reviews.llvm.org/D83840 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D83904: [lldb] Unify sleep and time outs in GDB remote testcases

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, teemperor. Reduce sleep and time outs in GDB remote testcases to one default value for each. Stop passing these values around and always use the default instead. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss updated this revision to Diff 278331. friss added a comment. Herald added a subscriber: mgorny. - Rebase on top of D83512 - Change the ObjectFileMachO pieces to rewrite offsets to look like a standard Mach-o image instead of adding a bunch of conditionals

[Lldb-commits] [lldb] c14e11b - [lldb/Test] Skip async process connect tests with reproducers

Author: Jonas Devlieghere Date: 2020-07-15T15:39:44-07:00 New Revision: c14e11b0bb269e3744d5858b13a6df244308f25f URL: https://github.com/llvm/llvm-project/commit/c14e11b0bb269e3744d5858b13a6df244308f25f DIFF:

[Lldb-commits] [lldb] b0ad73a - Add missing include

Author: Adrian Prantl Date: 2020-07-15T15:38:40-07:00 New Revision: b0ad73a2a0809188dd407ee2f92f71146759f279 URL: https://github.com/llvm/llvm-project/commit/b0ad73a2a0809188dd407ee2f92f71146759f279 DIFF: https://github.com/llvm/llvm-project/commit/b0ad73a2a0809188dd407ee2f92f71146759f279.diff

[Lldb-commits] [PATCH] D83900: [intel-pt] Fix building due to CMake + python changes

wallace created this revision. wallace added reviewers: clayborg, aadsm. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Python is now handled in CMake with different variables, thus the intel plugin needs a corresponding update. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

mstorsjo added a comment. In D83881#2153687 , @amccarth wrote: > Yes, getting rid of this hack looks like a good idea. If it was actually > necessary, there should have been a test on it, and the comments should have > been clearer. Well in general,

[Lldb-commits] [lldb] 44b43a5 - [lldb][NFC] Add 'override' where missing in source/ and tools/

Author: Logan Smith Date: 2020-07-15T11:34:47-07:00 New Revision: 44b43a52dc17135e43824e826862c8b35081cac0 URL: https://github.com/llvm/llvm-project/commit/44b43a52dc17135e43824e826862c8b35081cac0 DIFF: https://github.com/llvm/llvm-project/commit/44b43a52dc17135e43824e826862c8b35081cac0.diff

[Lldb-commits] [PATCH] D83847: [lldb][NFC] Add 'override' where missing in source/ and tools/

This revision was automatically updated to reflect the committed changes. Closed by commit rG44b43a52dc17: [lldb][NFC] Add override where missing in source/ and tools/ (authored by logan-5). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83847/new/

[Lldb-commits] [PATCH] D83900: [intel-pt] Fix building due to CMake + python changes

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. If this is what everyone else is doing already, then this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83900/new/

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin created this revision. jarin added a reviewer: teemperor. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. Template specializations are not handled in many of the TypeSystemClang methods. For example, GetNumChildren does not handle the TemplateSpecialization type class,

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Heh I fixed the same thing back in 67f6d842fab6 for `scripts/use_lldb_suite.py`, but of course I forgot to update this copy... The idea is good, just please make sure both files end up using

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 278113. omjavaid added a comment. This update address issues highlighted in last iteration and also minimizes the use of SVE_PT macros by using RegisterInfo.byte_size and byte_offset where possible. @labath What do you think ? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

labath added a comment. hmm... I have a lot thoughts here.. - `setsid` is overkill. If you want to create process group, create a process group (`setpgid`), not a session. - this solution does not seem very windows-friendly. In fact, I'd be surprised if it works there at all. - going for

[Lldb-commits] [lldb] 001c78d - [lldb][formatters] Add support for printing NSConstantDate and fix distantPast value

Author: Raphael Isemann Date: 2020-07-15T10:28:10+02:00 New Revision: 001c78de35cc0637eb58b3d855bc9897acccdc64 URL: https://github.com/llvm/llvm-project/commit/001c78de35cc0637eb58b3d855bc9897acccdc64 DIFF:

[Lldb-commits] [PATCH] D83217: [lldb][formatters] Add support for printing NSConstantDate and fix distantPast value

This revision was automatically updated to reflect the committed changes. Closed by commit rG001c78de35cc: [lldb][formatters] Add support for printing NSConstantDate and fix distantPast… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This could cause that `RemoveWrappingTypes` goes into an infinite loop under some situations. Usually this function is reserved for types that are always 'sugar', but

[Lldb-commits] [lldb] f819d25 - [lldb] Delete useless assertion

Author: Pavel Labath Date: 2020-07-15T15:42:53+02:00 New Revision: f819d257982e6c3f1fb57de4252b46bdfaa9415a URL: https://github.com/llvm/llvm-project/commit/f819d257982e6c3f1fb57de4252b46bdfaa9415a DIFF: https://github.com/llvm/llvm-project/commit/f819d257982e6c3f1fb57de4252b46bdfaa9415a.diff

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin updated this revision to Diff 278173. jarin marked 3 inline comments as done. jarin added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org/D83858 Files:

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

labath added a comment. In D83425#2151003 , @bbli wrote: > Yeah so in this pic, F12338615: original.png > , you can see in the code that both > stdout and stderr point to PIPE, and what gets printed out is the >

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin added a comment. In D83858#2152772 , @teemperor wrote: > This could cause that `RemoveWrappingTypes` goes into an infinite loop under > some situations. Usually this function is reserved for types that are always > 'sugar', but

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 278127. omjavaid added a comment. Updated and re-based after changes in core file patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llvm.org/D79699 Files:

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

labath added a comment. In D82064#2152807 , @omjavaid wrote: > Updated after incorporating review comments. > > @rovka I gave your idea a thought about moving included scripts to > lldb/utils. IMO these scripts have no relationship with LLDB and no such

[Lldb-commits] [lldb] 313fca6 - [lldb/test] Remove JOIN_CMD from Makefile.rules

Author: Pavel Labath Date: 2020-07-15T16:03:45+02:00 New Revision: 313fca6520b43d95abb73e7c78a252a60ee4cf48 URL: https://github.com/llvm/llvm-project/commit/313fca6520b43d95abb73e7c78a252a60ee4cf48 DIFF: https://github.com/llvm/llvm-project/commit/313fca6520b43d95abb73e7c78a252a60ee4cf48.diff

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin updated this revision to Diff 278200. jarin added a comment. Undo the infinite loop detection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org/D83858 Files:

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

labath created this revision. labath added reviewers: amccarth, markmentovai. Herald added a project: LLDB. This code (recently responsible for a unaligned access sanitizer failure) claims that the string table offset zero should result in an empty string. I cannot find any mention of this

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere abandoned this revision. JDevlieghere added a comment. In D83815#2152688 , @labath wrote: > hmm... I have a lot thoughts here.. > > - `setsid` is overkill. If you want to create process group, create a process > group (`setpgid`), not a

[Lldb-commits] [PATCH] D83767: [lldb] Use the basename of the Python test for the log name instead of the class name

JDevlieghere added a comment. In D83767#2153236 , @teemperor wrote: > Well, on Windows the file name is for some reason always > "lldbsuite.test.lldbtest" so I reverted this for now. Open for suggestions. I'm on board with Pavel's suggestion of getting

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

labath added a comment. In D83815#2153438 , @JDevlieghere wrote: > In D83815#2152688 , @labath wrote: > > > > > > Given that we were already creating a process group on fork, I'll keep the > change on line 902

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere added a comment. In D83815#2153459 , @labath wrote: > In D83815#2153438 , @JDevlieghere > wrote: > > > In D83815#2152688 , @labath wrote: > > > > > > > > > > >

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

rupprecht added a comment. In D83840#2152706 , @labath wrote: > Heh I fixed the same thing back in 67f6d842fab6 for > `scripts/use_lldb_suite.py`, but of course I forgot to update this copy... > The idea is good, just please make sure both files end up

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf3f100fcbf9: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D83840?vs=278042=278219#toc

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 278124. omjavaid added a comment. Minor fix removing GetRegNumP0 which is no longer needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files:

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid updated this revision to Diff 278128. omjavaid added a comment. Updated after incorporating review comments. @rovka I gave your idea a thought about moving included scripts to lldb/utils. IMO these scripts have no relationship with LLDB and no such precedent exist where we uploaded

[Lldb-commits] [PATCH] D83767: [lldb] Use the basename of the Python test for the log name instead of the class name

This revision was automatically updated to reflect the committed changes. Closed by commit rG29aab9b5c748: [lldb] Use the basename of the Python test for the log name instead of the… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] 29aab9b - [lldb] Use the basename of the Python test for the log name instead of the class name

Author: Raphael Isemann Date: 2020-07-15T13:54:43+02:00 New Revision: 29aab9b5c748b28b231e2ca0f9b95453638ade1a URL: https://github.com/llvm/llvm-project/commit/29aab9b5c748b28b231e2ca0f9b95453638ade1a DIFF:

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added a comment. At this point, I think I (finally) have a good understanding of both how this patch works and interacts with the rest of the world. I have one more batch of comments, but hopefully none are too controversial, and I really do hope this is the last iteration.

[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

kwk added a comment. LGTM but a test would indeed be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83180/new/ https://reviews.llvm.org/D83180 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D83388: [lldb] Make expect_expr fall back to the dummy target if no target is selected

This revision was automatically updated to reflect the committed changes. Closed by commit rG10fd550d308d: [lldb] Make expect_expr fall back to the dummy target if no target is selected (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] 10fd550 - [lldb] Make expect_expr fall back to the dummy target if no target is selected

Author: Raphael Isemann Date: 2020-07-15T13:56:00+02:00 New Revision: 10fd550d308d5dbcf7a3068f1f76d5f0f1a56661 URL: https://github.com/llvm/llvm-project/commit/10fd550d308d5dbcf7a3068f1f76d5f0f1a56661 DIFF:

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

teemperor accepted this revision. teemperor added a comment. I think your comment got broken by Phabricator. I actually think the old code was fine. It's a generic bug that also applies to `Decltype` (which is already implemented), so someone just has to fix the whole function in a follow up

[Lldb-commits] [lldb] 9c1c6a3 - Revert "[lldb] Use the basename of the Python test for the log name instead of the class name"

Author: Raphael Isemann Date: 2020-07-15T16:26:37+02:00 New Revision: 9c1c6a3fcca840b75a0ae818ac4e24e7460c397b URL: https://github.com/llvm/llvm-project/commit/9c1c6a3fcca840b75a0ae818ac4e24e7460c397b DIFF:

[Lldb-commits] [PATCH] D83767: [lldb] Use the basename of the Python test for the log name instead of the class name

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Well, on Windows the file name is for some reason always "lldbsuite.test.lldbtest" so I reverted this for now. Open for suggestions. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D83876: [lldb] Clean orphaned modules in Debugger::Destroy

teemperor created this revision. teemperor added reviewers: JDevlieghere, labath, LLDB. Right now the only places in the SB API where lldb:: ModuleSP instances are destroyed are in SBDebugger::MemoryPressureDetected (where it's just attempted but not guaranteed) and in SBDebugger::DeleteTarget.

[Lldb-commits] [PATCH] D83876: [lldb] Clean orphaned modules in Debugger::Destroy

teemperor planned changes to this revision. teemperor added a comment. I'm actually thinking that this maybe should go into the SBDebugger::Destroy functions. This way we also get all lldb::ModuleSP instances that are freed by the Debugger destructor. Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D83876: [lldb] Clean orphaned modules in Debugger::Destroy

labath added a reviewer: jingham. labath added a comment. I have no opinion on this. Jim may have one... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83876/new/ https://reviews.llvm.org/D83876 ___ lldb-commits

[Lldb-commits] [lldb] 700dd17 - [lldb/Test] Remove support for forking a subprocess from the test suite.

Author: Jonas Devlieghere Date: 2020-07-15T08:57:54-07:00 New Revision: 700dd17399bdcf2c580121e52b20e5768663dfe5 URL: https://github.com/llvm/llvm-project/commit/700dd17399bdcf2c580121e52b20e5768663dfe5 DIFF:

[Lldb-commits] [lldb] cf3f100 - [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

Author: Jordan Rupprecht Date: 2020-07-15T09:16:30-07:00 New Revision: cf3f100fcbf94af499501140590b322b4985c1a3 URL: https://github.com/llvm/llvm-project/commit/cf3f100fcbf94af499501140590b322b4985c1a3 DIFF:

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

amccarth added a comment. Yes, getting rid of this hack looks like a good idea. If it was actually necessary, there should have been a test on it, and the comments should have been clearer. See my inline comment, though. It looks like this might back out only part of the change.

[Lldb-commits] [PATCH] D83876: [lldb] Clean orphaned modules in Debugger::Destroy

jingham requested changes to this revision. jingham added a comment. We certainly don't want to clear the shared module cache when the Debugger or the SBDebugger is destroyed. Most IDE's that use LLDB as a library use a debugger per debugging session, and destroy the debugger when the

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. The rewrite of the ObjectFileMachO parts is very nice. LGTM. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:462 + +typedef unsigned char

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. Ok, I have revised the patch with the code from the first pic. I also moved the `decode` back to the `format_build_error` since it was there to begin with(not sure how much of a difference it makes). Also while we finalize this patch, is there another fix I can get