Re: [Lldb-commits] [lldb] a06c28d - Temporarily revert "[test] Exit with an error if no tests are run."

If it helps, all the failing tests are pexpect tests which are always disabled on Windows (like, they don't even exist from the test runners POV I believe). So I guess that's accidentially triggering that error. - Raphael > On 4 Aug 2020, at 03:39, Jordan Rupprecht via lldb-commits > wrote:

[Lldb-commits] [lldb] daa1c6d - [lldb] fix typo

Author: Luboš Luňák Date: 2020-08-04T12:05:57+02:00 New Revision: daa1c6d9d126ea1666463c44930f00df83f3acd6 URL: https://github.com/llvm/llvm-project/commit/daa1c6d9d126ea1666463c44930f00df83f3acd6 DIFF: https://github.com/llvm/llvm-project/commit/daa1c6d9d126ea1666463c44930f00df83f3acd6.diff

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added a comment. In D85145#2192716 , @teemperor wrote: > I wonder if there is a reasonable way to test this. From what I understand > these attributes aren't in any output buffer that we could expect (e.g., with > a pexpect test). I'm not sure.

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D85145#2191658 , @llunak wrote: > In D85145#2191421 , @teemperor wrote: > >> Btw, the

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to inherit TCC permissions from parent.

JDevlieghere updated this revision to Diff 283057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85237/new/ https://reviews.llvm.org/D85237 Files: lldb/include/lldb/Target/Target.h lldb/include/lldb/lldb-enumerations.h lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to disable TCC

friss added a comment. The logic of the patch itself looks fine, but the names, description and commit message are off. A process cannot disable TCC, it's always active. What your patch decides is whether the inferior is responsible for its own TCC permissions. If you don't make the inferior

[Lldb-commits] [PATCH] D85107: Add a test for 'b' (toggle breakpoint)

clayborg added a comment. lldb/test/API is for testing the public LLDB API functions that are exported as lldb::SB*. Not sure this belongs here. There was another patch that was moving things around as well where I commented with the same issue. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

clayborg added a comment. lldb/test/API is usually for testing the lldb::SB* interfaces IIRC. So not sure this move makes sense? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85106/new/ https://reviews.llvm.org/D85106

[Lldb-commits] [lldb] ba3d84d - [lldb/Test] Skip tests that try to get the remote environment

Author: Jonas Devlieghere Date: 2020-08-04T14:01:57-07:00 New Revision: ba3d84d82b750296c11e843365aa85962a561ad4 URL: https://github.com/llvm/llvm-project/commit/ba3d84d82b750296c11e843365aa85962a561ad4 DIFF:

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:486 + if (!string.consume_front("[")) { +llvm::errs() << "Missing '[' in color escape sequence.\n"; +continue; So what will happen if we actually get these

[Lldb-commits] [PATCH] D85243: [WIP] Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl created this revision. aprantl added reviewers: friss, jasonmolenda, teemperor, vsk. Herald added a subscriber: mgorny. aprantl requested review of this revision. The implementation of these classes was copied & pasted from the iPhone simulator plugin with only a handful of configuration

[Lldb-commits] [lldb] e8b7eda - [lldb/Test] Add @skipIfRemote decorator to TestProcessList.py

Author: Jonas Devlieghere Date: 2020-08-04T14:40:07-07:00 New Revision: e8b7edafc3dd0ab85903eebdfdb3bb7cc2d66743 URL: https://github.com/llvm/llvm-project/commit/e8b7edafc3dd0ab85903eebdfdb3bb7cc2d66743 DIFF:

[Lldb-commits] [PATCH] D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/

clayborg added a comment. I am not a cmake expert. Might be a good idea to check the git log for people with more cmake expertise? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85219/new/ https://reviews.llvm.org/D85219

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to inherit TCC permissions from parent.

JDevlieghere updated this revision to Diff 283054. JDevlieghere retitled this revision from "[lldb] Add an option to disable TCC" to "[lldb] Add an option to inherit TCC permissions from parent.". JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Make it clear that

[Lldb-commits] [lldb] 7e9bab6 - Fix debugserver's qProcessInfo reporting of maccatalyst binaries

Author: Adrian Prantl Date: 2020-08-04T16:42:14-07:00 New Revision: 7e9bab6ad51af1cab0c7457e4323166af3ac797c URL: https://github.com/llvm/llvm-project/commit/7e9bab6ad51af1cab0c7457e4323166af3ac797c DIFF: https://github.com/llvm/llvm-project/commit/7e9bab6ad51af1cab0c7457e4323166af3ac797c.diff

[Lldb-commits] [PATCH] D84576: Fix debugserver's qProcessInfo reporting of maccatalyst binaries

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7e9bab6ad51a: Fix debugservers qProcessInfo reporting of maccatalyst binaries (authored by aprantl). Herald added a

[Lldb-commits] [PATCH] D85258: [test] Use realpath consistently for test root file paths.

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. LLDB tests assume that tests are in the test tree (the `LLDB_TEST_SRC` env variable, configured by

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, if other tests are in there, I am fine with this move. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85106/new/ https://reviews.llvm.org/D85106

[Lldb-commits] [PATCH] D85107: Add a test for 'b' (toggle breakpoint)

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds like it is ok for tests to be here, looks good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85107/new/ https://reviews.llvm.org/D85107

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

jingham created this revision. jingham added a reviewer: friss. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jingham requested review of this revision. Herald added a subscriber: JDevlieghere. There are some platforms (the xnu kernel being one) where trying to run just

[Lldb-commits] [PATCH] D85248: [test] Support git commit version ids for clang.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85248/new/ https://reviews.llvm.org/D85248

[Lldb-commits] [PATCH] D85243: [WIP] Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

vsk added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:313 +#if defined(__APPLE__) + // Only accept "unknown" for the vendor if the host is Apple and it + // "unknown" wasn't specified (it was just returned because it was

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:438-450 +va_list args; +va_start(args, format); +int size = vsnprintf(nullptr, 0, format, args); +va_end(args); +if (size <= 0) + return; +++size; // for \0

[Lldb-commits] [lldb] e7af986 - [lldb-vscode ]Add Syntax Highlighting to Disassembly View

Author: Yifan Shen Date: 2020-08-04T13:31:44-07:00 New Revision: e7af98680ad52ffc6d308ef63667ac6fb4bb16a7 URL: https://github.com/llvm/llvm-project/commit/e7af98680ad52ffc6d308ef63667ac6fb4bb16a7 DIFF: https://github.com/llvm/llvm-project/commit/e7af98680ad52ffc6d308ef63667ac6fb4bb16a7.diff

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7af98680ad5: [lldb-vscode ]Add Syntax Highlighting to Disassembly View (authored by aelitashen, committed by Walter Erquinigo walterme...@fb.com).

[Lldb-commits] [lldb] bb33f92 - [lldb/Test] Add missing stdio.h includes

Author: Jonas Devlieghere Date: 2020-08-04T13:08:14-07:00 New Revision: bb33f925a673f3bb9793d2157c9d3d46d9ad7f25 URL: https://github.com/llvm/llvm-project/commit/bb33f925a673f3bb9793d2157c9d3d46d9ad7f25 DIFF:

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to inherit TCC permissions from parent.

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85237/new/ https://reviews.llvm.org/D85237 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 4c9ed3e - [lldb/testsuite] Skip 'frame diagnose' tests based on architecture

Author: Fred Riss Date: 2020-08-04T17:45:55-07:00 New Revision: 4c9ed3ed3d2fc7622acf5fc0d80ad20b44cf376a URL: https://github.com/llvm/llvm-project/commit/4c9ed3ed3d2fc7622acf5fc0d80ad20b44cf376a DIFF: https://github.com/llvm/llvm-project/commit/4c9ed3ed3d2fc7622acf5fc0d80ad20b44cf376a.diff

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

JDevlieghere updated this revision to Diff 283100. JDevlieghere added a comment. Address Jim's offline feedback about `GetProcessLaunchInfo` including the executable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85235/new/ https://reviews.llvm.org/D85235 Files:

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85235/new/ https://reviews.llvm.org/D85235 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D85248: [test] Support git commit version ids for clang.

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. `getCompilerVersion` assumes that `clang --version` prints out a string like `version [0-9\.]+`. If clang

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

jingham added a comment. In D85106#2194840 , @clayborg wrote: > lldb/test/API is usually for testing the lldb::SB* interfaces IIRC. So not > sure this move makes sense? It's really for any test that wants to use the lldbtest test harness. There are

[Lldb-commits] [PATCH] D85258: [test] Use realpath consistently for test root file paths.

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:499 # /abs/path/to/packages/group/subdir/mytest.py -> group/subdir -rel_prefix = test_file[len(os.environ["LLDB_TEST_SRC"]) + 1:] -return

[Lldb-commits] [PATCH] D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I suppose this makes sense. Testing it on some more systems might be good but I guess buildbot will take care of that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

JDevlieghere updated this revision to Diff 283001. JDevlieghere added a comment. Test a few more cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85235/new/ https://reviews.llvm.org/D85235 Files: lldb/source/API/SBTarget.cpp lldb/test/API/python_api/target/TestTargetAPI.py

[Lldb-commits] [PATCH] D85175: [test] Use abspath instead of realpath sometimes

This revision was automatically updated to reflect the committed changes. Closed by commit rG817b3a6fe3a4: [test] Use abspath instead of realpath sometimes (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85175/new/

[Lldb-commits] [lldb] 817b3a6 - [test] Use abspath instead of realpath sometimes

Author: Jordan Rupprecht Date: 2020-08-04T08:20:50-07:00 New Revision: 817b3a6fe3a4452eb61a2503c8beaa7267ca0351 URL: https://github.com/llvm/llvm-project/commit/817b3a6fe3a4452eb61a2503c8beaa7267ca0351 DIFF:

[Lldb-commits] [PATCH] D85241: [intel-pt] Disable/Enable tracing to guarantee the trace is correct

wallace updated this revision to Diff 283009. wallace added a comment. remove an empty line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85241/new/ https://reviews.llvm.org/D85241 Files: lldb/source/Plugins/Process/Linux/ProcessorTrace.cpp

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 282961. gedatsu217 added a comment. Add test. Delete gray character if autosuggestion has the only one character. (e.g. "b") (Editline::TabCommand) Simplify the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/

[Lldb-commits] [PATCH] D85241: [intel-pt] Disable/Enable tracing to guarantee the trace is correct

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. As mentioned in the comment inside the code, the Intel documentation states

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. @teemperor I understand what you say just now. Indeed, your method is more efficient than mine. I'm fixing the code now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001

[Lldb-commits] [PATCH] D85217: [lldb] Upstream macOS TCC code

JDevlieghere created this revision. JDevlieghere added reviewers: mib, jasonmolenda. JDevlieghere added a project: LLDB. JDevlieghere requested review of this revision. Upstream the code for dealing with TCC introduced in macOS Mojave. This will make the debuggee instead of the debugger

[Lldb-commits] [lldb] 041c7b8 - [lldb/Host] Upstream macOS TCC code

Author: Jonas Devlieghere Date: 2020-08-04T09:23:54-07:00 New Revision: 041c7b84a4b925476d1e21ed302786033bb6035f URL: https://github.com/llvm/llvm-project/commit/041c7b84a4b925476d1e21ed302786033bb6035f DIFF:

[Lldb-commits] [PATCH] D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/

llunak created this revision. llunak added a reviewer: clayborg. Herald added a subscriber: mgorny. llunak requested review of this revision. My openSUSE 15.2 has /usr/include/curses.h as a symlink to /usr/include/ncurses/curses.h , but there's no such symlink for panel.h . Prefer using

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to disable TCC

JDevlieghere created this revision. JDevlieghere added reviewers: mib, friss, jasonmolenda. JDevlieghere added a project: LLDB. JDevlieghere requested review of this revision. Add an option to not present the TCC dialog on behalf of the inferior. The motivation is the scenario of running the

Re: [Lldb-commits] [lldb] a06c28d - Temporarily revert "[test] Exit with an error if no tests are run."

Thanks, that explains it! Namely this part: if sys.platform.startswith('win32'): # llvm.org/pr22274: need a pexpect replacement for windows class PExpectTest(object): pass else: import pexpect class PExpectTest(TestBase): For this change to reland, I'll need to make it

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

simoncook added a comment. Herald added a subscriber: JDevlieghere. Thanks for looking at this @luismarques We had planned to put more effort into this patch, but time got in the way for quite a lot, but I'm glad it's working; thanks for the rebase I'll update this to match shortly. And it's

[Lldb-commits] [lldb] 31ec6e9 - [test] Fix another realpath->abspath.

Author: Jordan Rupprecht Date: 2020-08-04T11:06:31-07:00 New Revision: 31ec6e969d601eb4fbee7bd4be3d03d23b5b3c11 URL: https://github.com/llvm/llvm-project/commit/31ec6e969d601eb4fbee7bd4be3d03d23b5b3c11 DIFF:

[Lldb-commits] [PATCH] D85217: [lldb] Upstream macOS TCC code

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85217/new/ https://reviews.llvm.org/D85217 ___ lldb-commits

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

JDevlieghere updated this revision to Diff 282990. JDevlieghere added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85235/new/ https://reviews.llvm.org/D85235 Files: lldb/source/API/SBTarget.cpp lldb/test/API/python_api/target/TestTargetAPI.py Index:

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere added a project: LLDB. JDevlieghere requested review of this revision. Currently `SBTarget::LaunchSimple` creates a new `LaunchInfo` which means it ignores any target properties that have been set. Instead,

[Lldb-commits] [PATCH] D85217: [lldb] Upstream macOS TCC code

This revision was automatically updated to reflect the committed changes. Closed by commit rG041c7b84a4b9: [lldb/Host] Upstream macOS TCC code (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D85217?vs=282939=282943#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak updated this revision to Diff 282865. llunak added a comment. Updated according to comments. I find some of the StringRef APIs flawed though: consume_front() returns true on success, but consumeInteger() returns false; consume_front() modifies the object, but drop_front() doesn't.