[Lldb-commits] [lldb] 3a50ed8 - [lldb] FixFileSystem::GetExternalPath for VFS API change

Author: Jonas Devlieghere Date: 2021-01-22T15:04:17-08:00 New Revision: 3a50ed84f4823fb0e7b385cc22fef12435dfd376 URL: https://github.com/llvm/llvm-project/commit/3a50ed84f4823fb0e7b385cc22fef12435dfd376 DIFF:

[Lldb-commits] [lldb] ad25bdc - Change static buffer to be BSS instead of DATA in HandlePacket_qSpeedTest

Author: Jason Molenda Date: 2021-01-22T16:14:24-08:00 New Revision: ad25bdcb8e4e9459886062d3855a5971af758731 URL: https://github.com/llvm/llvm-project/commit/ad25bdcb8e4e9459886062d3855a5971af758731 DIFF: https://github.com/llvm/llvm-project/commit/ad25bdcb8e4e9459886062d3855a5971af758731.diff

[Lldb-commits] [PATCH] D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

dblaikie added a comment. In D94064#2485222 , @labath wrote: > In D94064#2483578 , @dblaikie wrote: > >> In D94064#2481925 , @labath wrote: >> >>> I don't think that simply

[Lldb-commits] [PATCH] D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

dblaikie updated this revision to Diff 318654. dblaikie added a comment. Retrieve the lowest address in the address ranges, rather than just hardcoding 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94064/new/ https://reviews.llvm.org/D94064

[Lldb-commits] [PATCH] D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

dblaikie updated this revision to Diff 318711. dblaikie added a comment. Include some more details about/in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94064/new/ https://reviews.llvm.org/D94064 Files:

[Lldb-commits] [PATCH] D94811: [lldb] Fix fallthrough with strictly virtual working directory.

JDevlieghere abandoned this revision. JDevlieghere added a comment. Superseded by D95188 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94811/new/ https://reviews.llvm.org/D94811 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, this is how I should have done it originally. Thanks! I had one suggestion for making the test more compact which you can do or not as you please. Other than the LGTM.

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

djtodoro updated this revision to Diff 318464. djtodoro added a comment. nfc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93939/new/ https://reviews.llvm.org/D93939 Files: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

mstorsjo added a comment. In D67954#2515028 , @mgorny wrote: > Is there a specific reason you've only covered x0..x7 in the test? No, only for keeping the test short and cohesive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

labath added a comment. There's still one "opportunistic" snippet in `GDBRemoteRegisterContext.cpp`, around line 404. Did you forget about that, or is there something special about that case? (if so, then what?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 added a comment. @labath, you were absolutely correct! It was simply a matter of saving and restoring the terminal struct on the `terminalHasColors` function in the `Process.inc` file (I really should've tried that before). I'm currently recompiling and will re-run the tests

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

labath added a comment. The fact that the test suite passes is not too surprising since we have very few core file tests. However, I agree that we should just remove this zero filling completely. Regarding the test, would it be possible to reuse one of the existing core files? (The reason we

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

labath added a comment. Can you be more specific about what is the nature and cause of this breakage? Could it maybe be the fact that the `set_curterm(nullptr)` call (inside `terminalHasColors(fd)`) leaves terminfo with no "current" terminal, (whereas before the call it contained the "current"

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath added a comment. In D94888#2511675 , @rupprecht wrote: > In D94888#2506140 , @labath wrote: > >> I am pretty sure they were. This flag is needed to use (system) libc++ with >> gcc, and this was happening at

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

labath added a comment. In D95165#2515232 , @augusto2112 wrote: > @labath, you were absolutely correct! It was simply a matter of saving and > restoring the terminal struct on the `terminalHasColors` function in the > `Process.inc` file (I really

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added a comment. @labath sorry for the repeated messages. I believe this is ready to be merged, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https://reviews.llvm.org/D94672

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On 19/01/2021 23:23, David Blaikie wrote: On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath wrote: Yeah - I have mixed feelings about debugger testing here - it is nice to have end-to-end tests which makes for handy debugger testing (though I guess in theory, debuginfo-tests is the place for

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added a comment. Jim, thanks for the pointers! I think we are getting close to the issue. After doing what you asked, I found out the following: - I set up the state of the lldb debugging the program that will exec right before it execs - Then I do "continue" - ThreadPlan::WillResume

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

If you are just loading an object file and the looking at the line table or something like that, would a UnitTest be more suitable? Jim > On Jan 22, 2021, at 5:37 AM, Pavel Labath wrote: > > On 19/01/2021 23:23, David Blaikie wrote: >> On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath wrote: >>

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

Excellent, thanks for persisting on this! I think your second idea sounds less error prone than having to figure out whether the cache is trustworthy at a particular point. Maybe even better than triggering off a stop event is to clear the caches before we do whatever might make the threads

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay updated this revision to Diff 318546. MaskRay added a comment. Drop fancy check in dotest.py (restore the previous behavior) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888 Files:

[Lldb-commits] [lldb] dc057e8 - [LLDB] Fix how ObjCBOOLSummaryProvider deals with BOOL

Author: Shafik Yaghmour Date: 2021-01-22T10:05:24-08:00 New Revision: dc057e87f6c18c24d17c7cae97ebe95f78b6d934 URL: https://github.com/llvm/llvm-project/commit/dc057e87f6c18c24d17c7cae97ebe95f78b6d934 DIFF:

[Lldb-commits] [PATCH] D94937: [lldb/Lua] add initial Lua typemaps

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/bindings/lua/lua-typemaps.swig:7 + +// In 5.3 and beyond the VM supports integers, so we need to remap +// SWIG's internal handling of

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

labath created this revision. labath added reviewers: JDevlieghere, stella.stamenova. Herald added a subscriber: mgorny. labath requested review of this revision. Herald added a project: LLDB. Replace the dotest command line options and various cmake variables, which are used for passing the

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

labath added a comment. I should add, this also ensures one does not need to introduce a similar amount of cruft for each new llvm tool that he wants to use in the tests. Comment at: lldb/test/API/CMakeLists.txt:59 set(LLDB_TEST_COMPILER "${LLDB_DEFAULT_TEST_COMPILER}" CACHE

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

JDevlieghere added inline comments. Comment at: lldb/test/API/CMakeLists.txt:59 set(LLDB_TEST_COMPILER "${LLDB_DEFAULT_TEST_COMPILER}" CACHE PATH "C Compiler to use for building LLDB test inferiors") -set(LLDB_TEST_DSYMUTIL "${LLDB_DEFAULT_TEST_DSYMUTIL}" CACHE PATH "dsymutil

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

stella.stamenova added inline comments. Comment at: lldb/utils/lldb-dotest/CMakeLists.txt:87 set(LLDB_LIBS_DIR_CONFIGURED "${LLDB_LIBS_DIR}") + set(LLVM_TOOLS_DIR_CONFIGURED "${LLVM_TOOLS_DIR_CONFIGURED}") I think here you just want to set it to

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace updated this revision to Diff 318640. wallace added a comment. Herald added a subscriber: emaste. Updated based on @jingham's idea, and added an independent test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/