[Lldb-commits] [PATCH] D128366: [lldb] Make Module::LookupInfo::Prune language-agnostic

labath added a comment. In D128366#3605484 , @bulbazord wrote: > In D128366#3603943 , @labath wrote: > >> Could we move this pruning elsewhere? These values come from the symbol file >> plugins anyway, and they

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. @jingham Sorry for spamming. But I am not sure if you have received my previous messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304

[Lldb-commits] [lldb] 6879391 - [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

Author: Jonas Devlieghere Date: 2022-06-24T09:46:26-07:00 New Revision: 6879391908cab68e8d43a0097fa8c9cd3b86eff9 URL: https://github.com/llvm/llvm-project/commit/6879391908cab68e8d43a0097fa8c9cd3b86eff9 DIFF:

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

This revision was automatically updated to reflect the committed changes. Closed by commit rG6879391908ca: [lldb] Replace Host::SystemLog with Debugger::Report{Error,Warning} (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D128366: [lldb] Make Module::LookupInfo::Prune language-agnostic

bulbazord added a comment. In D128366#3608051 , @labath wrote: > In D128366#3605484 , @bulbazord > wrote: > >> In D128366#3603943 , @labath wrote: >> >>> Could we move

[Lldb-commits] [lldb] 87a3293 - [lldb] Move Host::SystemLog out of !defined(_WIN32)

Author: Jonas Devlieghere Date: 2022-06-24T11:18:31-07:00 New Revision: 87a32939611ab2972acc7a8e796f8d9e571a6f3a URL: https://github.com/llvm/llvm-project/commit/87a32939611ab2972acc7a8e796f8d9e571a6f3a DIFF:

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yeah, the pre-exit event makes this somewhat tricky. Let's stick with this then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127667/new/ https://reviews.llvm.org/D127667

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 439814. zequanwu marked an inline comment as done. zequanwu added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files:

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Host/common/Host.cpp:110 +#if !defined(__APPLE__) +void Host::SystemLog(const std::string ) { + fprintf(stderr, "%s", message.c_str()); labath wrote: >

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere added a comment. @labath Any chance I can nerd-snipe you into adding support for syslog (or whatever the modern equivalent is) on linux? :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128321/new/ https://reviews.llvm.org/D128321

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Thank you. In D50304#3608740 , @jingham wrote: > In D50304#3592849 , @RamNalamothu > wrote: > >> In D50304#3586710 , @jingham wrote: >> >>>

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa57b62deef37: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers (authored by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current way ot traversing the cursor is a bit uncommon and it can't

[Lldb-commits] [lldb] a57b62d - [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

Author: Venkata Ramanaiah Nalamothu Date: 2022-06-25T00:01:04+05:30 New Revision: a57b62deef37c7f2ec31bca3bf9173a6206bfb9b URL: https://github.com/llvm/llvm-project/commit/a57b62deef37c7f2ec31bca3bf9173a6206bfb9b DIFF:

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1196 + if (!bool(m_extensions_supported & +

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

jj10306 requested changes to this revision. jj10306 added a comment. Thanks for working on this  Looks good overall, just left some minor comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:64 /// Low level traversal: -/// Unlike the \a TraceCursor::Next() API,

Re: [Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

Why is it desirable to have the debugger not see signals sent to the process? Jim > On Jun 24, 2022, at 1:06 AM, Alessandro Arzilli via Phabricator via > lldb-commits wrote: > > aarzilli created this revision. > aarzilli added reviewers: jasonmolenda, clayborg. > aarzilli added a project:

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

jingham accepted this revision. jingham added a comment. In D50304#3592849 , @RamNalamothu wrote: > In D50304#3586710 , @jingham wrote: > >> For some reason I'm not getting mail notifications for review changes,

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

aarzilli added a comment. In D128504#3608530 , @jingham wrote: > Why is it desirable to have the debugger not see signals sent to the process? > > Jim Regardless of this patch, it is always possible to send signals directly to the target process. This

[Lldb-commits] [lldb] 5a08280 - [lldb] Fix flakiness in shell tests that mixed stderr and stdout

Author: Jonas Devlieghere Date: 2022-06-24T10:53:15-07:00 New Revision: 5a08280659125b6196e1ca83d5d9d6ba412674fe URL: https://github.com/llvm/llvm-project/commit/5a08280659125b6196e1ca83d5d9d6ba412674fe DIFF:

[Lldb-commits] [lldb] 1e5d526 - [lldb] Add SystemLogHandler for emitting log messages to the system log

Author: Jonas Devlieghere Date: 2022-06-24T10:53:15-07:00 New Revision: 1e5d5261e2b6637011a65c929828ca8cb0ab8e2e URL: https://github.com/llvm/llvm-project/commit/1e5d5261e2b6637011a65c929828ca8cb0ab8e2e DIFF:

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e5d5261e2b6: [lldb] Add SystemLogHandler for emitting log messages to the system log (authored by JDevlieghere). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

cmtice added a comment. Just FYI, this commit appears to cause lldb//test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py to fail. The error I'm seeing is: Traceback (most recent call last): File

[Lldb-commits] [PATCH] D128484: [NFC][lldb][trace] Rename trace session to trace bundle

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8dcd0ba26a9: [NFC][lldb][trace] Rename trace session to trace bundle (authored by Walter Erquinigo wall...@fb.com). Changed prior to commit: https://reviews.llvm.org/D128484?vs=439582=439783#toc

[Lldb-commits] [lldb] b8dcd0b - [NFC][lldb][trace] Rename trace session to trace bundle

Author: Walter Erquinigo Date: 2022-06-24T08:41:33-07:00 New Revision: b8dcd0ba26a90166cc76e6d1db23b88656610b2e URL: https://github.com/llvm/llvm-project/commit/b8dcd0ba26a90166cc76e6d1db23b88656610b2e DIFF:

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

labath added a comment. In D128410#3604927 , @alvinhochun wrote: > It may be possible to stuff a pointer to an `EXCEPTION_RECORD` into another > `EXCEPTION_RECORD` and use `RtlRaiseException` to generate the exception, but > you'll have to test how it

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

labath added a comment. In D128268#3604555 , @mstorsjo wrote: > In D128268#3604081 , @labath wrote: > >>> If we'd just set this to the baseline, i386, would that have any effect for >>> how lldb e.g. is able to

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

labath added a comment. This isn't turning out as clean as I had hoped it would, but I think it's a step in the right direction. Jonas, do you want to say anything about this? Comment at: lldb/include/lldb/Expression/DWARFExpressionList.h:54 + const DWARFExpression * +

[Lldb-commits] [PATCH] D128484: [NFC][lldb][trace] Rename trace session to trace bundle

wallace added inline comments. Comment at: lldb/include/lldb/Core/PluginManager.h:346 - static TraceCreateInstanceForSessionFile + static TraceCreateInstanceForBundle GetTraceCreateCallback(llvm::StringRef plugin_name); jj10306 wrote: > nit: `FromBundle`

[Lldb-commits] [PATCH] D128361: [lldb] [test] Move part of fork tests to common helper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1829e0ec58b: [lldb] [test] Move part of fork tests to common helper (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] 630da0e - [lldb] [llgs] Include PID in QC response in multiprocess mode

Author: Michał Górny Date: 2022-06-24T17:20:24+02:00 New Revision: 630da0e309ef4764465dcaf559676633e948f5c0 URL: https://github.com/llvm/llvm-project/commit/630da0e309ef4764465dcaf559676633e948f5c0 DIFF: https://github.com/llvm/llvm-project/commit/630da0e309ef4764465dcaf559676633e948f5c0.diff

[Lldb-commits] [PATCH] D127862: [lldb] [llgs] Support resuming one process with PID!=current via vCont

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3422793e064: [lldb] [llgs] Support resuming one process with PID!=current via vCont (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e827e51 - [lldb] [llgs] Implement the 'T' packet

Author: Michał Górny Date: 2022-06-24T17:20:24+02:00 New Revision: e827e5186fb6991bc749eaaddf13f8a53ebb63c2 URL: https://github.com/llvm/llvm-project/commit/e827e5186fb6991bc749eaaddf13f8a53ebb63c2 DIFF: https://github.com/llvm/llvm-project/commit/e827e5186fb6991bc749eaaddf13f8a53ebb63c2.diff

[Lldb-commits] [lldb] 4b485fc - [lldb] [llgs] Introduce an AppendThreadIDToResponse() helper

Author: Michał Górny Date: 2022-06-24T17:20:24+02:00 New Revision: 4b485fc0ea4acf065c7992a5c9a1223f5565544e URL: https://github.com/llvm/llvm-project/commit/4b485fc0ea4acf065c7992a5c9a1223f5565544e DIFF: https://github.com/llvm/llvm-project/commit/4b485fc0ea4acf065c7992a5c9a1223f5565544e.diff

[Lldb-commits] [lldb] c18784b - [lldb] [llgs] Implement the vKill packet

Author: Michał Górny Date: 2022-06-24T17:20:23+02:00 New Revision: c18784ba330ac0f57e6ec433cfa8317349c445ff URL: https://github.com/llvm/llvm-project/commit/c18784ba330ac0f57e6ec433cfa8317349c445ff DIFF: https://github.com/llvm/llvm-project/commit/c18784ba330ac0f57e6ec433cfa8317349c445ff.diff

[Lldb-commits] [lldb] 3266b11 - [lldb] [llgs] Add test for resuming via c in multiprocess scenarios

Author: Michał Górny Date: 2022-06-24T17:20:23+02:00 New Revision: 3266b117147db73d1c42668c1033b59a36d8a2f3 URL: https://github.com/llvm/llvm-project/commit/3266b117147db73d1c42668c1033b59a36d8a2f3 DIFF: https://github.com/llvm/llvm-project/commit/3266b117147db73d1c42668c1033b59a36d8a2f3.diff

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc18784ba330a: [lldb] [llgs] Implement the vKill packet (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] a342279 - [lldb] [llgs] Support resuming one process with PID!=current via vCont

Author: Michał Górny Date: 2022-06-24T17:20:23+02:00 New Revision: a3422793e0643fa849ff178d87fc706c81b734b7 URL: https://github.com/llvm/llvm-project/commit/a3422793e0643fa849ff178d87fc706c81b734b7 DIFF: https://github.com/llvm/llvm-project/commit/a3422793e0643fa849ff178d87fc706c81b734b7.diff

[Lldb-commits] [lldb] 0481d8e - [lldb] [llgs] Add a test for multiprocess memory read/write

Author: Michał Górny Date: 2022-06-24T17:20:24+02:00 New Revision: 0481d8efa92f4508e847046b748c17ace1813272 URL: https://github.com/llvm/llvm-project/commit/0481d8efa92f4508e847046b748c17ace1813272 DIFF: https://github.com/llvm/llvm-project/commit/0481d8efa92f4508e847046b748c17ace1813272.diff

[Lldb-commits] [lldb] c1829e0 - [lldb] [test] Move part of fork tests to common helper

Author: Michał Górny Date: 2022-06-24T17:20:25+02:00 New Revision: c1829e0ec58bd974e65639de0b9cbab736bb624f URL: https://github.com/llvm/llvm-project/commit/c1829e0ec58bd974e65639de0b9cbab736bb624f DIFF: https://github.com/llvm/llvm-project/commit/c1829e0ec58bd974e65639de0b9cbab736bb624f.diff

[Lldb-commits] [PATCH] D128150: [lldb] [llgs] Add a test for multiprocess memory read/write

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0481d8efa92f: [lldb] [llgs] Add a test for multiprocess memory read/write (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG75757c86c695: [lldb] [llgs] Support multiprocess in qfThreadInfo (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128153: [lldb] [llgs] Add a test for multiprocess register read/write

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14d67073359a: [lldb] [llgs] Add a test for multiprocess register read/write (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] 75757c8 - [lldb] [llgs] Support multiprocess in qfThreadInfo

Author: Michał Górny Date: 2022-06-24T17:20:24+02:00 New Revision: 75757c86c695a6b4695458343637b3c4fe86def6 URL: https://github.com/llvm/llvm-project/commit/75757c86c695a6b4695458343637b3c4fe86def6 DIFF: https://github.com/llvm/llvm-project/commit/75757c86c695a6b4695458343637b3c4fe86def6.diff

[Lldb-commits] [PATCH] D127755: [lldb] [llgs] Add test for resuming via c in multiprocess scenarios

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3266b117147d: [lldb] [llgs] Add test for resuming via c in multiprocess scenarios (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 14d6707 - [lldb] [llgs] Add a test for multiprocess register read/write

Author: Michał Górny Date: 2022-06-24T17:20:24+02:00 New Revision: 14d67073359a86f1d2ae9e140f0b29aa4e63a3af URL: https://github.com/llvm/llvm-project/commit/14d67073359a86f1d2ae9e140f0b29aa4e63a3af DIFF: https://github.com/llvm/llvm-project/commit/14d67073359a86f1d2ae9e140f0b29aa4e63a3af.diff

[Lldb-commits] [PATCH] D128170: [lldb] [llgs] Implement the 'T' packet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe827e5186fb6: [lldb] [llgs] Implement the T packet (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D128324: [lldb] [llgs] Introduce an AppendThreadIDToResponse() helper

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b485fc0ea4a: [lldb] [llgs] Introduce an AppendThreadIDToResponse() helper (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e8fe7e9 - [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

Author: Michał Górny Date: 2022-06-24T17:20:23+02:00 New Revision: e8fe7e930a45764cbb88d9c3fa91ef7dc1ebcc97 URL: https://github.com/llvm/llvm-project/commit/e8fe7e930a45764cbb88d9c3fa91ef7dc1ebcc97 DIFF: https://github.com/llvm/llvm-project/commit/e8fe7e930a45764cbb88d9c3fa91ef7dc1ebcc97.diff

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8fe7e930a45: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128156: [lldb] [llgs] Include PID in QC response in multiprocess mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG630da0e309ef: [lldb] [llgs] Include PID in QC response in multiprocess mode (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D128321#3607935 , @labath wrote: > In D128321#3605592 , @JDevlieghere > wrote: > >> I also considered that, but that just delays

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. @cmtice, are you sure the failure is caused by/related with this patch? This is a pure lldb-vscode change which is not used by normal lldb. Also, no mention of code in this patch in the error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] be265d2 - [lldb] Add support for specifying a log handler

Author: Jonas Devlieghere Date: 2022-06-24T18:24:00-07:00 New Revision: be265d25ca5e300a3af45a5f85fc6e4b107148e5 URL: https://github.com/llvm/llvm-project/commit/be265d25ca5e300a3af45a5f85fc6e4b107148e5 DIFF:

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe265d25ca5e: [lldb] Add support for specifying a log handler (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere updated this revision to Diff 439866. JDevlieghere added a comment. Add `eLogHandlerDefault = eLogHandlerStream`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128323/new/ https://reviews.llvm.org/D128323 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere updated this revision to Diff 439874. JDevlieghere added a comment. Improve help and error message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128323/new/ https://reviews.llvm.org/D128323 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

mib added inline comments. Comment at: lldb/source/Commands/CommandObjectLog.cpp:167 buffer_size.Clear(); + handler = eLogHandlerStream; log_options = 0; labath wrote: > mib wrote: > > clayborg wrote: > > > Do we want to define a

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. will take a complete look over the weekend, but wanted to point out the conflict with @persona0220's diff asap Comment at:

[Lldb-commits] [PATCH] D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo

cmtice added a comment. Herald added a subscriber: JDevlieghere. Just FYI, this commit appears to cause lldb//test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py to fail. The error I'm seeing is: Traceback (most recent call last): File

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So we either need to track categories for each buffered log message in the circular buffer so that if the user specifies a category within a channel to dump with "log dump lldb

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

cmtice added a comment. I apologize; I was looking at several commits, and I accidentally added my comment to the wrong one. No, this commit is not the one that caused my problem (I am very sorry about the confusion). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo

mgorny added a comment. Thanks for the notice. I was pretty sure it failed to me prior to my changes but it is possible that I read the output wrong, so I'm going to check it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128152/new/

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Add a log dump command to dump the circular log buffer. This also adds a test for the circular log handler.

[Lldb-commits] [PATCH] D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed

srhines added a comment. In D128453#3607129 , @labath wrote: > In D128453#3606296 , @JDevlieghere > wrote: > >> This is great, it both guarantees consistently and enforces command objects >> registering their

[Lldb-commits] [PATCH] D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo

mgorny added a comment. I'm sorry, it is indeed my fault. I'm going to try to fix it shortly, and if I don't manage to figure it out, I'm going to revert this and the commits depending on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

mstorsjo added a comment. In D128410#3608190 , @labath wrote: > In D128410#3604927 , @alvinhochun > wrote: > >> It may be possible to stuff a pointer to an `EXCEPTION_RECORD` into another >> `EXCEPTION_RECORD`

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128557/new/ https://reviews.llvm.org/D128557 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

clayborg added a comment. Seems to make sense to me, but I will let Jason Molenda give the final OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128504/new/ https://reviews.llvm.org/D128504 ___

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

JDevlieghere updated this revision to Diff 439921. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128557/new/ https://reviews.llvm.org/D128557 Files: lldb/include/lldb/Host/Host.h lldb/include/lldb/Utility/Log.h lldb/source/Commands/CommandObjectLog.cpp

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Thanks for pointing that out. I blindly copied the categories logic from `Log::Disable` which uses it when computing the flags. I've omitted it for now because I think it would be weird to set the circular buffer size

[Lldb-commits] [PATCH] D128484: [NFC][lldb][trace] Rename trace session to trace bundle

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. lgtm - thanks for doing this renaming  Comment at: lldb/include/lldb/Core/PluginManager.h:346 - static TraceCreateInstanceForSessionFile + static

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D128321#3605592 , @JDevlieghere wrote: > I also considered that, but that just delays the problem until I want to > enable this handler for the

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

labath added inline comments. Comment at: lldb/source/Host/common/Host.cpp:110 +#if !defined(__APPLE__) +void Host::SystemLog(const std::string ) { + fprintf(stderr, "%s", message.c_str()); labath wrote: > Why std::string? I'd expect StringRef (as that's what

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectLog.cpp:167 buffer_size.Clear(); + handler = eLogHandlerStream; log_options = 0; mib

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

aarzilli created this revision. aarzilli added reviewers: jasonmolenda, clayborg. aarzilli added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. aarzilli requested review of this revision. Herald added a subscriber: lldb-commits. Change POSIX spawn launch

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

omjavaid added a comment. In D128221#3598132 , @DavidSpickett wrote: > Are there public docs for these numbers? There is no public doc but I have copied these mappings from https://github.com/microsoft/microsoft-pdb which was opensourced by microsoft.

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

labath added a comment. It should be sufficient to replace the %clang line with the appropriate ld.lld equivalent, and replace REQUIRES: system-linux with REQUIRES: lld. Also it test/Shell/SymbolFile/DWARF would be a better place for this test (and it also includes some tests that you can take

[Lldb-commits] [PATCH] D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed

labath added a subscriber: srhines. labath added a comment. In D128453#3606296 , @JDevlieghere wrote: > This is great, it both guarantees consistently and enforces command objects > registering their arguments. LGTM. > > For the RenderScript plugin, I

[Lldb-commits] [lldb] 91d61c1 - [LLDB] Mark TestExprsChar Xfail for Windows/AArch64

Author: Muhammad Omair Javaid Date: 2022-06-24T13:59:22+04:00 New Revision: 91d61c1431c2ec46fa7a243db1643154580ab043 URL: https://github.com/llvm/llvm-project/commit/91d61c1431c2ec46fa7a243db1643154580ab043 DIFF: