Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

dblaikie added a subscriber: dblaikie. Comment at: test/lang/cpp/incomplete-types/Makefile:8 @@ +7,3 @@ + +ifneq (,$(findstring clang,$(CC))) + CFLAGS_LIMIT += -flimit-debug-info In case it's interesting, you can get similarly problematic DWARF by using a

Re: [Lldb-commits] Buildbot numbers for week of 11/22/2015 - 11/28/2015

Thanks for tracking these results, Galina I think it might be better to send these to the -dev lists, rather than the -commits lists, but I'm not sure what other people think on that. On Mon, Nov 30, 2015 at 4:17 PM, Galina Kistanova via cfe-commits < cfe-comm...@lists.llvm.org> wrote: > Hello

Re: [Lldb-commits] Buildbot numbers for week of 11/22/2015 - 11/28/2015

On Mon, Nov 30, 2015 at 5:00 PM, Galina Kistanova wrote: > Hi David, > > Thank you for the useful suggestions, I will work on these. > > >I guess the entries with no entry in the failed column have zero failures? > Yes. > > perf-x86_64-penryn-O3-polly-before-vectorizer

Re: [Lldb-commits] [PATCH] D24369: [support] copying JSON parser/writer from lldb

On Fri, Sep 9, 2016 at 7:31 PM Mike Aizatsky wrote: > aizatsky abandoned this revision. > > > Comment at: include/llvm/Support/JSON.h:207 > @@ +206,3 @@ > +private: > + typedef std::map Map; > + typedef Map::iterator Iterator; >

[Lldb-commits] [lldb] r291250 - Revert "Fixes for Clang API changes to use std::shared_ptr"

Author: dblaikie Date: Fri Jan 6 11:47:15 2017 New Revision: 291250 URL: http://llvm.org/viewvc/llvm-project?rev=291250=rev Log: Revert "Fixes for Clang API changes to use std::shared_ptr" The original Clang change caused a memory leak detected by asan. Reverting while I investigate. This

[Lldb-commits] [lldb] r291271 - Reapply "Fixes for Clang API changes to use std::shared_ptr"

Author: dblaikie Date: Fri Jan 6 13:49:05 2017 New Revision: 291271 URL: http://llvm.org/viewvc/llvm-project?rev=291271=rev Log: Reapply "Fixes for Clang API changes to use std::shared_ptr" Aleksey Shlyapnikov found the memory leak I introduced, recommitted the Clang change with a fix for this.

[Lldb-commits] [lldb] r291204 - Revert part of cleanup to fix a build break

Author: dblaikie Date: Thu Jan 5 19:42:56 2017 New Revision: 291204 URL: http://llvm.org/viewvc/llvm-project?rev=291204=rev Log: Revert part of cleanup to fix a build break Wasn't sure I could include ErrorHandling.h here, and evidently I wasn't building this part (must've made the change using

Re: [Lldb-commits] [lldb] r291198 - Make lldb -Werror clean for -Wstring-conversion

gt; llvm_unreachable("GetMax32 > unhandled case!"); ^ > /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp:144:5: > error: use of undeclared identifier 'llvm_unreachable' > llvm_unreachable("GetMax64 unhandled case!"); ^ 2 err

[Lldb-commits] [lldb] r291198 - Make lldb -Werror clean for -Wstring-conversion

Author: dblaikie Date: Thu Jan 5 18:38:06 2017 New Revision: 291198 URL: http://llvm.org/viewvc/llvm-project?rev=291198=rev Log: Make lldb -Werror clean for -Wstring-conversion Also found/fixed one bug identified by this warning in RenderScriptx86ABIFixups.cpp where a string literal was being

[Lldb-commits] [lldb] r291199 - Fix -Wunused-function warning by preprocessor conditionalizing the function the same way as the caller

Author: dblaikie Date: Thu Jan 5 18:38:10 2017 New Revision: 291199 URL: http://llvm.org/viewvc/llvm-project?rev=291199=rev Log: Fix -Wunused-function warning by preprocessor conditionalizing the function the same way as the caller Modified:

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

On Fri, Jul 21, 2017 at 4:05 PM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg accepted this revision. > clayborg added a comment. > > Looks like there already is a test case that was failing as Jim mentioned. > Accepting based on that. > Ah, I was thinking more a

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

On Fri, Jul 21, 2017 at 6:14 PM Jim Ingham wrote: > Not at present, but you presumably know more about this than I do. Part > of the point of Greg's extracting the DWARF parser from lldb and making it > into it's own library in llvm was precisely so that somebody could then >

Re: [Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

Any chance of using unique_ptr or other RAII/etc ownership to make this API safer by default? On Mon, Jan 22, 2018 at 10:58 AM Raphael Isemann via Phabricator via llvm-commits wrote: > This revision was not accepted when it landed; it landed in state "Needs >

Re: [Lldb-commits] [PATCH] D51208: [DWARF] Fix dwarf5-index-is-used.cpp

On Tue, Aug 28, 2018 at 7:33 AM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > In https://reviews.llvm.org/D51208#1214743, @dblaikie wrote: > > > >> But if LLDB has different performance characteristics, or the default > should be different for

Re: [Lldb-commits] [PATCH] D49309: No longer pass a StringRef to the Python API

If the implementation of a function requires a string - it should probably accept string (not a StringRef) as a parameter - to avoid back-and-forth conversions in cases where the caller already has a string to use. On Fri, Jul 13, 2018 at 12:43 PM Stella Stamenova via Phabricator via

Re: [Lldb-commits] [PATCH] D56458: Fix unused private field warning.

Might be better to only define the variable if HAVE_LIBCOMPRESSION is defined? On Wed, Jan 9, 2019 at 8:58 AM Raphael Isemann via Phabricator via llvm-commits wrote: > This revision was not accepted when it landed; it landed in state "Needs > Review". > This revision was automatically updated

Re: [Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

On Tue, Jun 4, 2019 at 4:15 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > In D62634#1527575 , @dblaikie > wrote: > > > > 1. We need to figure out whether there's a bug in clang and fix it. + > @dblaikie

[Lldb-commits] [lldb] 208a11a - Reapply "llvm-dwarfdump: Report errors when failing to parse loclist/debug_loc entries""

Author: David Blaikie Date: 2020-04-14T14:44:32-07:00 New Revision: 208a11ab3a7be7c3e5d3fae9dd4affdb01a0ed1f URL: https://github.com/llvm/llvm-project/commit/208a11ab3a7be7c3e5d3fae9dd4affdb01a0ed1f DIFF: https://github.com/llvm/llvm-project/commit/208a11ab3a7be7c3e5d3fae9dd4affdb01a0ed1f.diff

[Lldb-commits] [lldb] 8036cf7 - llvm-dwarfdump: Skip tombstoned address ranges

Author: David Blaikie Date: 2020-10-04T13:43:29-07:00 New Revision: 8036cf7f5402ea7fc8564a9a2beae512c324bf3d URL: https://github.com/llvm/llvm-project/commit/8036cf7f5402ea7fc8564a9a2beae512c324bf3d DIFF: https://github.com/llvm/llvm-project/commit/8036cf7f5402ea7fc8564a9a2beae512c324bf3d.diff

[Lldb-commits] [lldb] f7a49d2 - [WIP][DebugInfo] Lazily parse debug_loclist offsets

Author: David Blaikie Date: 2020-08-18T10:49:39-07:00 New Revision: f7a49d2aa691266497c4baa35f29ba0167b39d23 URL: https://github.com/llvm/llvm-project/commit/f7a49d2aa691266497c4baa35f29ba0167b39d23 DIFF: https://github.com/llvm/llvm-project/commit/f7a49d2aa691266497c4baa35f29ba0167b39d23.diff

[Lldb-commits] [lldb] 0b05732 - fix lldb for recent libDebugInfoDWARF API change

Author: David Blaikie Date: 2020-10-23T19:20:38-07:00 New Revision: 0b057320453b90bb409f55f74386b6841546d48a URL: https://github.com/llvm/llvm-project/commit/0b057320453b90bb409f55f74386b6841546d48a DIFF: https://github.com/llvm/llvm-project/commit/0b057320453b90bb409f55f74386b6841546d48a.diff

[Lldb-commits] [lldb] fdb45f5 - lldb fix for b198de67e0bab462217db50814b1434796fa7caf (PCH/modular codegen refactor)

Author: David Blaikie Date: 2020-07-22T13:12:00-07:00 New Revision: fdb45f54b6c0de00ba3bfa5dd157161ebb12799d URL: https://github.com/llvm/llvm-project/commit/fdb45f54b6c0de00ba3bfa5dd157161ebb12799d DIFF: https://github.com/llvm/llvm-project/commit/fdb45f54b6c0de00ba3bfa5dd157161ebb12799d.diff

[Lldb-commits] [lldb] 274afac - lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

Author: David Blaikie Date: 2021-01-07T14:28:03-08:00 New Revision: 274afac9a17f43e5396a0d6c7a0741702596a7bd URL: https://github.com/llvm/llvm-project/commit/274afac9a17f43e5396a0d6c7a0741702596a7bd DIFF: https://github.com/llvm/llvm-project/commit/274afac9a17f43e5396a0d6c7a0741702596a7bd.diff

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Thu, Jan 7, 2021 at 3:37 PM Jim Ingham via lldb-commits wrote: > > > > > On Jan 7, 2021, at 2:29 PM, David Blaikie via Phabricator via lldb-commits > > wrote: > > > > dblaikie added a comment. > > > > In D94063#2485271 , @labath wrote: > > > >> In

[Lldb-commits] [lldb] 696775d - Fix subprogram_ranges.test by explicitly using lld

Author: David Blaikie Date: 2021-01-07T19:53:17-08:00 New Revision: 696775d96ecd20aacb7935541995a5554bb32ba8 URL: https://github.com/llvm/llvm-project/commit/696775d96ecd20aacb7935541995a5554bb32ba8 DIFF: https://github.com/llvm/llvm-project/commit/696775d96ecd20aacb7935541995a5554bb32ba8.diff

[Lldb-commits] [lldb] 2ff36e7 - lldb subprogram_ranges.test - remove dependence on temp file name

Author: David Blaikie Date: 2021-01-07T20:04:22-08:00 New Revision: 2ff36e79291486b489ae26418daa1b123473b405 URL: https://github.com/llvm/llvm-project/commit/2ff36e79291486b489ae26418daa1b123473b405 DIFF: https://github.com/llvm/llvm-project/commit/2ff36e79291486b489ae26418daa1b123473b405.diff

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

Thanks for all the context - so sounds like mostly based on (3) the recommendation would be for this to be an API test (is there a way to test the line table directly? good place for reference on the SB API options - I looked at a few tests and they seemed quite different (

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

"But because their source lines are outside the function source range" Not sure I understand that - the DWARF doesn't describe a function source range, right? Only the line a function starts on. And a function can have code from source lines in many files/offsets that are unrelated to the

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Mon, Jan 25, 2021 at 10:39 AM Jim Ingham wrote: > lldb creates a single line table out of the debug_line input and the > inlined_subroutine info from the debug_info. For instance, if you have a > nested set of inlines that all have the same start address, they cannot be > represented in the

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > > > > > On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > > > > On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: > >> > >> If you set a breakpoint on source lines with no line table entries, lldb > >> slides the actual match forward to

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

On Tue, Jan 19, 2021 at 2:55 PM Jim Ingham wrote: > > > > > On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: > > > > On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > >> > >> > >> > >>> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > >>> > >>> On Fri, Jan 15, 2021 at 6:22 PM Jim

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

new compiler > > debug output bugs as well. So unless you have a good reason to use a > > .s file, you shouldn't. > > On 11/01/2021 02:37, David Blaikie via lldb-commits wrote: > > Thanks for all the context - so sounds like mostly based on (3) the > > recommen

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Thu, Jan 14, 2021 at 2:56 PM Jim Ingham wrote: > > How were you setting the breakpoint in the case where it was failing from the > command line? The breakpoint you are examining in the test in your patches > is a "source regular expression" breakpoint. That would be "break set -p". > If

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

Thanks for the pointers! So I tried writing an API-type test for this line table/breakpoint behavior (it doesn't seem like it's entirely/just the line table (for one thing, the DWARF change is purely in the subprogram DIE, not in the line table)) and I can't seem to figure it out. The attached

[Lldb-commits] [lldb] 78d41a1 - lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

Author: David Blaikie Date: 2021-01-24T18:39:06-08:00 New Revision: 78d41a1295d9d40c37758230d0218c61eaffad88 URL: https://github.com/llvm/llvm-project/commit/78d41a1295d9d40c37758230d0218c61eaffad88 DIFF: https://github.com/llvm/llvm-project/commit/78d41a1295d9d40c37758230d0218c61eaffad88.diff

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Fri, Jan 22, 2021 at 5:37 AM Pavel Labath wrote: > On 19/01/2021 23:23, David Blaikie wrote: > > On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath wrote: > > Yeah - I have mixed feelings about debugger testing here - it is nice > > to have end-to-end tests which makes for handy debugger testing >

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Fri, Jan 22, 2021 at 9:42 AM Jim Ingham wrote: > If you are just loading an object file and the looking at the line table > or something like that, would a UnitTest be more suitable? > Maybe, though for what it's worth, this isn't an issue with the line table (well, not the .debug_line

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: > > If you set a breakpoint on source lines with no line table entries, lldb > slides the actual match forward to the nearest line table entry to the given > line number. That's necessary for instance because if you lay out your > function

[Lldb-commits] [lldb] c5d56fe - NFC: .clang-tidy: Inherit configs from parents to improve maintainability

Author: David Blaikie Date: 2021-06-08T08:25:59-07:00 New Revision: c5d56fec502f36a0c994835ca23bc93a6c682d95 URL: https://github.com/llvm/llvm-project/commit/c5d56fec502f36a0c994835ca23bc93a6c682d95 DIFF: https://github.com/llvm/llvm-project/commit/c5d56fec502f36a0c994835ca23bc93a6c682d95.diff

[Lldb-commits] [lldb] 6dc2a6a - Remove some unnecessary explicit defaulted copy ctors to cleanup -Wdeprecated-copy

Author: David Blaikie Date: 2021-05-10T14:31:11-07:00 New Revision: 6dc2a6a8c9a0e4f8b46a0ba05430b77229789b8e URL: https://github.com/llvm/llvm-project/commit/6dc2a6a8c9a0e4f8b46a0ba05430b77229789b8e DIFF: https://github.com/llvm/llvm-project/commit/6dc2a6a8c9a0e4f8b46a0ba05430b77229789b8e.diff

Re: [Lldb-commits] [lldb] a3a9528 - [lldb] X-FAIL TestCPPStaticMembers on Windows

Might be worth a bug report and CC'ing some Windows-LLDB type folks on that for notice. On Tue, May 25, 2021 at 4:11 AM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Raphael Isemann > Date: 2021-05-25T13:10:19+02:00 > New Revision:

[Lldb-commits] [lldb] 1def257 - PR51018: Remove explicit conversions from SmallString to StringRef to future-proof against C++23

Author: David Blaikie Date: 2021-07-08T13:37:57-07:00 New Revision: 1def2579e10dd84405465f403e8c31acebff0c97 URL: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97 DIFF: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97.diff

Re: [Lldb-commits] [lldb] 5a63045 - [LLDB] Fix `Wunused-result` warning

Might be worth making an "execution override" object that has a dtor to do the cleanup? On Mon, Feb 8, 2021 at 9:10 AM Frederik Gossen via lldb-commits wrote: > > > Author: Frederik Gossen > Date: 2021-02-08T18:10:08+01:00 > New Revision: 5a63045fe78834937785ed5081052e083a98077f > > URL: >

Re: [Lldb-commits] [lldb] e76b866 - Revert "[lldb] Make the API, Shell and Unit tests independent lit test suites"

Would be great if you could include some detail in the commit message (or, in this case, in a follow-up reply) about why the patch was reverted, thanks! On Fri, Mar 19, 2021 at 5:57 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Jonas Devlieghere > Date:

Re: [Lldb-commits] [lldb] 54d03a4 - [lldb/Interpreter][NFC] Replace default constructors/destructors bodies with "=default"

Any chance of removing some of these entirely, when they're the default (like the first class in this patch, `CommandHistory` - a default ctor (assuming it has no other ctors) and dtor are implicit, and don't need to be written out)? On Sun, Feb 28, 2021 at 8:24 AM Tatyana Krasnukha via

Re: [Lldb-commits] [lldb] 8cdcd41 - [lldb/Interpreter][NFC] Remove explicit default initialization of members and base classes

Nice cleanup! On Sun, Feb 28, 2021 at 8:24 AM Tatyana Krasnukha via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Tatyana Krasnukha > Date: 2021-02-28T19:23:18+03:00 > New Revision: 8cdcd41e384b4901cd796f7be58c461647e54d18 > > URL: >

[Lldb-commits] [lldb] e913a75 - Fix a warning about named return value not being moved-from.

Author: David Blaikie Date: 2021-03-01T09:25:26-08:00 New Revision: e913a754143f227b4aea5f695a2dcd2349101886 URL: https://github.com/llvm/llvm-project/commit/e913a754143f227b4aea5f695a2dcd2349101886 DIFF: https://github.com/llvm/llvm-project/commit/e913a754143f227b4aea5f695a2dcd2349101886.diff

[Lldb-commits] [lldb] 776be16 - Fix virtual-dtor warning a different way, since a virtual dtor is not required for this use case.

Author: David Blaikie Date: 2021-03-01T09:25:26-08:00 New Revision: 776be16ba0532dbb3d66cc104d15a7f13a154e3f URL: https://github.com/llvm/llvm-project/commit/776be16ba0532dbb3d66cc104d15a7f13a154e3f DIFF: https://github.com/llvm/llvm-project/commit/776be16ba0532dbb3d66cc104d15a7f13a154e3f.diff

Re: [Lldb-commits] [lldb] 3dc24bc - [LLDB] Re-land: Use path relative to binary for finding .dwo files.

For future reference it'd be good to include some details in a recommit including the original commit hash, the revert hash, the reason for the revert and what's changed in this commit to address that problem. For others reading along, according to the phab review this test hit a bug in lldb and

[Lldb-commits] [lldb] 3784fc4 - Remove set-but-unused variable

Author: David Blaikie Date: 2021-08-26T16:58:47-07:00 New Revision: 3784fc493eb254bbed422f0bc83f01bee94a8195 URL: https://github.com/llvm/llvm-project/commit/3784fc493eb254bbed422f0bc83f01bee94a8195 DIFF: https://github.com/llvm/llvm-project/commit/3784fc493eb254bbed422f0bc83f01bee94a8195.diff

[Lldb-commits] [lldb] 40e971a - nullptr printing - update for a change to clang type printing that now uses "std::nullptr_t"

Author: David Blaikie Date: 2021-09-21T11:50:24-07:00 New Revision: 40e971a21052a8638933037615e3c681e193f3fc URL: https://github.com/llvm/llvm-project/commit/40e971a21052a8638933037615e3c681e193f3fc DIFF: https://github.com/llvm/llvm-project/commit/40e971a21052a8638933037615e3c681e193f3fc.diff

[Lldb-commits] [lldb] d723ad5 - Enable libc++ in the build for libcxx initializerlist pretty printers

Author: David Blaikie Date: 2021-10-21T11:35:59-07:00 New Revision: d723ad5bcf7133c3f3950ebb63edf4ddfee56581 URL: https://github.com/llvm/llvm-project/commit/d723ad5bcf7133c3f3950ebb63edf4ddfee56581 DIFF: https://github.com/llvm/llvm-project/commit/d723ad5bcf7133c3f3950ebb63edf4ddfee56581.diff

[Lldb-commits] [lldb] 64f002c - Follow-up fixes for aee49255074fd4ef38d97e6e70cbfbf2f9fd0fa7

Author: David Blaikie Date: 2021-10-21T13:00:56-07:00 New Revision: 64f002c6d36d674a924c6116ec0b2d731cc3981c URL: https://github.com/llvm/llvm-project/commit/64f002c6d36d674a924c6116ec0b2d731cc3981c DIFF: https://github.com/llvm/llvm-project/commit/64f002c6d36d674a924c6116ec0b2d731cc3981c.diff

[Lldb-commits] [lldb] f6a561c - DebugInfo: Use clang's preferred names for integer types

Author: David Blaikie Date: 2021-10-06T16:02:34-07:00 New Revision: f6a561c4d6754b13165a49990e8365d819f64c86 URL: https://github.com/llvm/llvm-project/commit/f6a561c4d6754b13165a49990e8365d819f64c86 DIFF: https://github.com/llvm/llvm-project/commit/f6a561c4d6754b13165a49990e8365d819f64c86.diff

Re: [Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

Maybe this isn't the right fix - msbit and lsbit probably shouldn't be printed if to_integer returns false in the diagnostic on line 195. If that diagnostic didn't use the variables, then I don't think this'd warn? On Mon, Sep 27, 2021 at 12:38 AM Krasimir Georgiev via lldb-commits <

Re: [Lldb-commits] [lldb] 6438a52 - Revert "[clang] retain type sugar in auto / template argument deduction"

Thanks for the details! On Sun, Nov 14, 2021 at 3:39 PM Matheus Izvekov wrote: > Oops, my bad! > > The reason for reverting this is that this is a recent commit, and > there are reports of breakage building libANGLE which have not been > investigated. > > See https://reviews.llvm.org/D110216

Re: [Lldb-commits] [lldb] 6438a52 - Revert "[clang] retain type sugar in auto / template argument deduction"

On Sun, Nov 14, 2021 at 3:30 PM Matheus Izvekov via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Matheus Izvekov > Date: 2021-11-15T00:29:05+01:00 > New Revision: 6438a52df1c7f36952b6126ff7b978861b76ad45 > > URL: >

[Lldb-commits] [lldb] e6b3233 - Cleanup a few more PR36048 skips

Author: David Blaikie Date: 2021-10-29T14:10:42-07:00 New Revision: e6b323379e3195ba98bacc9216fe38025bda6104 URL: https://github.com/llvm/llvm-project/commit/e6b323379e3195ba98bacc9216fe38025bda6104 DIFF: https://github.com/llvm/llvm-project/commit/e6b323379e3195ba98bacc9216fe38025bda6104.diff

Re: [Lldb-commits] [lldb] 71cfce8 - [lldb] Fix TestCompressedVectors after array type name change

Thanks for the fix! (is there a buildbot email I should've got (or did and failed to understand) about this?) On Fri, Oct 22, 2021 at 1:16 AM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Raphael Isemann > Date: 2021-10-22T10:15:53+02:00 > New Revision:

Re: [Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

Any chance of test coverage? On Mon, Dec 13, 2021 at 4:58 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Jonas Devlieghere > Date: 2021-12-13T16:58:39-08:00 > New Revision: 58473d84e0c7796de5dcfd3153e5d5cc8ad034b3 > > URL: >

[Lldb-commits] [lldb] 8b280df - Rough guess at fixing lldb tests to handle Clang defaulting to DWARFv5

Author: David Blaikie Date: 2022-01-23T21:24:25-08:00 New Revision: 8b280df504b97a13d06a929fbc85348903456fdd URL: https://github.com/llvm/llvm-project/commit/8b280df504b97a13d06a929fbc85348903456fdd DIFF: https://github.com/llvm/llvm-project/commit/8b280df504b97a13d06a929fbc85348903456fdd.diff

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

@@ -129,8 +129,19 @@ void DebugNamesDWARFIndex::GetGlobalVariables( DWARFUnit , llvm::function_ref callback) { uint64_t cu_offset = cu.GetOffset(); bool found_entry_for_cu = false; - for (const DebugNames::NameIndex : *m_debug_names_up) { -for

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

@@ -129,8 +129,19 @@ void DebugNamesDWARFIndex::GetGlobalVariables( DWARFUnit , llvm::function_ref callback) { uint64_t cu_offset = cu.GetOffset(); bool found_entry_for_cu = false; - for (const DebugNames::NameIndex : *m_debug_names_up) { -for

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

@@ -0,0 +1,87 @@ +// RUN: %clangxx -target arm64-apple-macosx11.0.0 -g %s -emit-llvm -S -o - | FileCheck --check-prefixes=CHECK %s + +enum class Enum : int { + VAL = -1 +}; + +struct Empty {}; + +constexpr auto func() { return 25; } + +struct Foo { +static constexpr int

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

https://github.com/dwblaikie approved this pull request. Few minor issues, but looks good to me. (you metnioned somewhere an lldb issue I think with this patch when the value is removed from the static member declaration inside the class? If that's a problem - probably hold off on committing

[Lldb-commits] [lldb] [clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

dwblaikie wrote: > That's true, if defined in a header, we'll emit a DW_TAG_variable for the > constant in each compile unit the header is included in. GCC does do the > right thing and only emit the definition DIE in a single CU. We should > probably do the same. Though not sure at which

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

dwblaikie wrote: > 2) always put DW_AT_const_value in DW_TAG_member. My understanding is that this is not possible. Dependent initializer expressions can't be evaluated in all cases - we're only allowed to evaluate them in the places the language allows us to, otherwise we might produce the

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

@@ -67,15 +67,15 @@ int C::a = 4; // CHECK-NOT:size: // CHECK-NOT:align: // CHECK-NOT:offset: -// CHECK-SAME: flags: DIFlagStaticMember, -// CHECK-SAME: extraData: i1 true) +// CHECK-SAME: flags:

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

@@ -5883,6 +5907,18 @@ void CGDebugInfo::finalize() { DBuilder.replaceTemporary(std::move(FwdDecl), cast(Repl)); } + for (auto const *VD : StaticDataMemberDefinitionsToEmit) { +assert(VD->isStaticDataMember()); + +if (auto It = DeclCache.find(VD); It !=

[Lldb-commits] [lldb] [clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

dwblaikie wrote: size report sounds generally OK - but there's a bunch of what look like unrelated or strange results in there, perhaps they weren't compared at exactly the same version? (like why did the apple_names size go down? How did the .text and .debuG_line size change at all? )

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

@@ -0,0 +1,87 @@ +// RUN: %clangxx -target arm64-apple-macosx11.0.0 -g %s -emit-llvm -S -o - | FileCheck --check-prefixes=CHECK %s + +enum class Enum : int { + VAL = -1 +}; + +struct Empty {}; + +constexpr auto func() { return 25; } + +struct Foo { +static constexpr int

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

dwblaikie wrote: > Should not we remove constant initializer from the type definition if we have > a DW_TAG_variable with a DW_AT_const_value now? Yep, +1 to this. This is where the type normalization benefit would come from - no longer having this const value on the member declaration, but

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

dwblaikie wrote: > Summing the size of all *.o files in my local debug Clang build increased by > 0.7% with this patch That's a bit significant. Any chance you could get a per-section breakdown/growth on that? (& exact flags - is this with compressed debug info, for instance? Or not?) I use

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

dwblaikie wrote: > > > Should not we remove constant initializer from the type definition if we > > > have a DW_TAG_variable with a DW_AT_const_value now? > > > > > > Yep, +1 to this. This is where the type normalization benefit would come > > from - no longer having this const value on the

[Lldb-commits] [lldb] [lldb][NFCI] Remove duplicated code in DWARFParser (PR #69531)

@@ -73,137 +69,18 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor , m_tag = abbrevDecl->getTag(); m_has_children = abbrevDecl->hasChildren(); // Skip all data in the .debug_info or .debug_types for the attributes - dw_form_t form; for (const auto :

[Lldb-commits] [lldb] [lldb-vscode] Display a more descriptive summary for containers and pointers (PR #65514)

@@ -132,6 +132,84 @@ std::vector GetStrings(const llvm::json::Object *obj, return strs; } +/// Create a short summary for a container that contains the summary of its +/// first children, so that the user can get a glimpse of its contents at a +/// glance. +static

[Lldb-commits] [lldb] [lldb-vscode] Display a more descriptive summary for containers and pointers (PR #65514)

@@ -132,6 +132,84 @@ std::vector GetStrings(const llvm::json::Object *obj, return strs; } +/// Create a short summary for a container that contains the summary of its +/// first children, so that the user can get a glimpse of its contents at a +/// glance. +static

[Lldb-commits] [lldb] [lldb-vscode] Display a more descriptive summary for containers and pointers (PR #65514)

@@ -132,6 +132,84 @@ std::vector GetStrings(const llvm::json::Object *obj, return strs; } +/// Create a short summary for a container that contains the summary of its +/// first children, so that the user can get a glimpse of its contents at a +/// glance. +static

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

dwblaikie wrote: (aside: isn't the SBAPI meant to be the thing to use if you want to script stuff, rather than having formatted output/scraping that? - but sounds like the output has converged on a table rather than JSON anyway? So maybe a moot point) Re: errors, OSO (what does that stand for

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

dwblaikie wrote: > N_SO is the stab moniker for a source file, and N_OSO is the object file > associated with that source file (N_SO was in Sun's implementation, we made > up N_OSO). Most nm''s leave off the N_ when they print stabs, so then this > became just OSO... > We don't do DWO on

[Lldb-commits] [lldb] [lldb][NFCI] Remove duplicated code in DWARFParser (PR #69531)

@@ -73,137 +69,18 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor , m_tag = abbrevDecl->getTag(); m_has_children = abbrevDecl->hasChildren(); // Skip all data in the .debug_info or .debug_types for the attributes - dw_form_t form; for (const auto :

[Lldb-commits] [lldb] [lldb][NFCI] Remove duplicated code in DWARFParser (PR #69531)

https://github.com/dwblaikie approved this pull request. https://github.com/llvm/llvm-project/pull/69531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 72d9390 - Add a little extra test coverage for simple template names

Author: David Blaikie Date: 2022-07-08T00:12:29Z New Revision: 72d9390778966d4f87ec4b1de63c107b2fd46b9a URL: https://github.com/llvm/llvm-project/commit/72d9390778966d4f87ec4b1de63c107b2fd46b9a DIFF: https://github.com/llvm/llvm-project/commit/72d9390778966d4f87ec4b1de63c107b2fd46b9a.diff

[Lldb-commits] [lldb] 65cac0e - Use StringRef to avoid unnecessary copies into std::strings

Author: David Blaikie Date: 2022-07-07T19:50:12Z New Revision: 65cac0ed9266e3551663358de677161ce25a25bf URL: https://github.com/llvm/llvm-project/commit/65cac0ed9266e3551663358de677161ce25a25bf DIFF: https://github.com/llvm/llvm-project/commit/65cac0ed9266e3551663358de677161ce25a25bf.diff

[Lldb-commits] [lldb] 856ebe9 - Retrieve as StringRef since that's how it'll be used

Author: David Blaikie Date: 2022-07-07T20:13:36Z New Revision: 856ebe9e8247698095a66f98647ee5d7cb12f337 URL: https://github.com/llvm/llvm-project/commit/856ebe9e8247698095a66f98647ee5d7cb12f337 DIFF: https://github.com/llvm/llvm-project/commit/856ebe9e8247698095a66f98647ee5d7cb12f337.diff

[Lldb-commits] [lldb] 6edbde1 - Simplify some AsCString usage that was also explicitly handling default

Author: David Blaikie Date: 2022-07-07T20:27:05Z New Revision: 6edbde100132f5dc025bed64059d9fb770abd19e URL: https://github.com/llvm/llvm-project/commit/6edbde100132f5dc025bed64059d9fb770abd19e DIFF: https://github.com/llvm/llvm-project/commit/6edbde100132f5dc025bed64059d9fb770abd19e.diff

[Lldb-commits] [lldb] b92c334 - Remove dead code: TypeMap::RemoveMismatchedTypes(TypeClass type_class)

Author: David Blaikie Date: 2022-07-07T20:46:14Z New Revision: b92c33495aeda7d7fa7f5d3f518c59cc5785fd9f URL: https://github.com/llvm/llvm-project/commit/b92c33495aeda7d7fa7f5d3f518c59cc5785fd9f DIFF: https://github.com/llvm/llvm-project/commit/b92c33495aeda7d7fa7f5d3f518c59cc5785fd9f.diff

[Lldb-commits] [lldb] 40501f1 - buildbot-based-debugging a Microsoft lldb test XPASS

Author: David Blaikie Date: 2022-10-04T21:38:33Z New Revision: 40501f1b4139e472094ac0d4102923d2730515a1 URL: https://github.com/llvm/llvm-project/commit/40501f1b4139e472094ac0d4102923d2730515a1 DIFF: https://github.com/llvm/llvm-project/commit/40501f1b4139e472094ac0d4102923d2730515a1.diff

[Lldb-commits] [lldb] 9fc6565 - fold assert-only variable into assert to address non-assert -Wunused-variable

Author: David Blaikie Date: 2022-08-17T04:10:59Z New Revision: 9fc65658f5e5a0af5821f4945d78a9f6b8fd368f URL: https://github.com/llvm/llvm-project/commit/9fc65658f5e5a0af5821f4945d78a9f6b8fd368f DIFF: https://github.com/llvm/llvm-project/commit/9fc65658f5e5a0af5821f4945d78a9f6b8fd368f.diff

[Lldb-commits] [lldb] ed7be0d - lldb: Fix cross-cu-reference test to explicitly request that feature

Author: David Blaikie Date: 2023-06-01T00:35:39Z New Revision: ed7be0d4d17b5d1470587643cd5c55157414bb9c URL: https://github.com/llvm/llvm-project/commit/ed7be0d4d17b5d1470587643cd5c55157414bb9c DIFF: https://github.com/llvm/llvm-project/commit/ed7be0d4d17b5d1470587643cd5c55157414bb9c.diff

[Lldb-commits] [lldb] 4e429fd - Few linter fixes

Author: David Blaikie Date: 2023-07-31T18:52:57Z New Revision: 4e429fd2a72511bc3c0a20e1b12f735863e615df URL: https://github.com/llvm/llvm-project/commit/4e429fd2a72511bc3c0a20e1b12f735863e615df DIFF: https://github.com/llvm/llvm-project/commit/4e429fd2a72511bc3c0a20e1b12f735863e615df.diff

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

@@ -5401,6 +5409,8 @@ std::string CGDebugInfo::GetName(const Decl *D, bool Qualified) const { // feasible some day. return TA.getAsIntegral().getBitWidth() <= 64 && IsReconstitutableType(TA.getIntegralType()); + case

[Lldb-commits] [lldb] Add more ways to find the .dwp file. (PR #81067)

dwblaikie wrote: FWIW, I think we should be opinionated (& consistent with whatever gdb does, if it has some precedent here - if it is less opinionated, then maybe we have to be accepting) when it comes to whether x.debug goes with x.dwp or x.debug.dwp - we shouldn't support both unless

[Lldb-commits] [lldb] Add more ways to find the .dwp file. (PR #81067)

dwblaikie wrote: > If the DWO ID is just a hash of the file path or something that isn't > guaranteed to be unique with each new build, then we need the UUID in the > .dwp file. Nah, the DWO ID, as per spec, is a semantic hash of the DWARF contents. It should change, generally, if any part

[Lldb-commits] [lldb] [lldb] Add more ways to find the .dwp file. (PR #81067)

dwblaikie wrote: > > > I am fine with telling people what to do and giving them a golden path to > > > what is easiest for our debuggers. And I will suggest to everyone that > > > they use `.debug` and `.dwp`, but if we want to only support this, this > > > leaves the downloading of the

[Lldb-commits] [lldb] [lldb] Add more ways to find the .dwp file. (PR #81067)

dwblaikie wrote: > > > If the client strips the debug info first into "a.out.debug" and then > > > runs llvm-dwp, they will end up with a "a.out.debug.dwp". We have clients > > > that are doing this already and we want to support them. > > > > > > OK, could we fix llvm-dwp to match the

[Lldb-commits] [lldb] [lldb] Add more ways to find the .dwp file. (PR #81067)

dwblaikie wrote: > I am fine with telling people what to do and giving them a golden path to > what is easiest for our debuggers. And I will suggest to everyone that they > use `.debug` and `.dwp`, but if we want to only support this, this leaves the > downloading of the `.debug` file

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

dwblaikie wrote: > I will aim to land this sometime tomorrow if there are no further objections Per the documentation ( https://llvm.org/docs/CodeReview.html#code-review-workflow ), please don't do this. Once it's sent for review, please wait for approval (ping as needed, etc) before

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

dwblaikie wrote: > > > I will aim to land this sometime tomorrow if there are no further > > > objections > > > > > > Per the documentation ( > > https://llvm.org/docs/CodeReview.html#code-review-workflow ), please don't > > do this. Once it's sent for review, please wait for approval (ping

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

@@ -5401,6 +5409,8 @@ std::string CGDebugInfo::GetName(const Decl *D, bool Qualified) const { // feasible some day. return TA.getAsIntegral().getBitWidth() <= 64 && IsReconstitutableType(TA.getIntegralType()); + case

  1   2   >