Alright, I'll bite and ask...
What is so special about the Android bot? Every so often, I'll see it reject a
piece of syntax that other compilers gleefully handle
> On Oct 5, 2016, at 10:58 AM, Zachary Turner via lldb-commits
> wrote:
>
> Author: zturner
> Date: Wed Oct 5 12:58:46 2016
> New
Author: enrico
Date: Wed Oct 5 17:04:43 2016
New Revision: 283396
URL: http://llvm.org/viewvc/llvm-project?rev=283396&view=rev
Log:
Fixes for libc++ std::unordered_map data formatter against trunk
Fixes rdar://28237467
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxUnorderedM
granata.enrico added a comment.
I see you already got a bunch of feedback on specific items. The overall idea
looks good to me. I'll try to delve a little deeper in the code ASAP (I was out
for a couple days and have some backlog...), but should be good to go assuming
you address the feedback y
granata.enrico added a comment.
I see you already got a bunch of feedback on specific items. The overall idea
looks good to me. I'll try to delve a little deeper in the code ASAP (I was out
for a couple days and have some backlog...), but should be good to go assuming
you address the feedback y
Author: enrico
Date: Thu Oct 20 17:05:21 2016
New Revision: 284787
URL: http://llvm.org/viewvc/llvm-project?rev=284787&view=rev
Log:
This debugging message has been left in the code for years, until one day it
randomly hit on some corrupted memory
It is misleading to users in its current form, a
Author: enrico
Date: Thu Oct 20 17:10:07 2016
New Revision: 284788
URL: http://llvm.org/viewvc/llvm-project?rev=284788&view=rev
Log:
frame.script became script.frame a while ago; fix up the docs
Modified:
lldb/trunk/www/formats.html
Modified: lldb/trunk/www/formats.html
URL:
http://llvm.org
Author: enrico
Date: Fri Oct 21 13:03:55 2016
New Revision: 284847
URL: http://llvm.org/viewvc/llvm-project?rev=284847&view=rev
Log:
I hadn't fixed all the instances of the old marker for scripted format strings;
do so now
Modified:
lldb/trunk/www/formats.html
Modified: lldb/trunk/www/form
Author: enrico
Date: Wed Oct 26 13:12:52 2016
New Revision: 285216
URL: http://llvm.org/viewvc/llvm-project?rev=285216&view=rev
Log:
Actually use = delete to mark constructors and operators we want to not exist.
Just declaring them as private works, but it can confuse certain tools as it
doesn't
Author: enrico
Date: Wed Oct 26 14:17:49 2016
New Revision: 285226
URL: http://llvm.org/viewvc/llvm-project?rev=285226&view=rev
Log:
Fix an issue where frame variable -s would not show the scope even
though the user asked for it
Part of rdar://28434047
Added:
lldb/trunk/packages/Python/ll
Author: enrico
Date: Thu Oct 27 13:44:45 2016
New Revision: 285332
URL: http://llvm.org/viewvc/llvm-project?rev=285332&view=rev
Log:
Add support for "type lookup" to find C and C++ types
This is an important first step in closing the functionality gap between "type
lookup" and "images lookup -t"
Author: enrico
Date: Mon Oct 31 12:00:54 2016
New Revision: 285596
URL: http://llvm.org/viewvc/llvm-project?rev=285596&view=rev
Log:
Add the new minidump plugin files to the Xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
Author: enrico
Date: Mon Oct 31 12:12:16 2016
New Revision: 285599
URL: http://llvm.org/viewvc/llvm-project?rev=285599&view=rev
Log:
Remove a couple of old TODOs and don't make a new ConstString each time; none
of this is super-critical since it applies to older versions of macOS (or OSX,
I gues
Author: enrico
Date: Tue Nov 1 13:50:49 2016
New Revision: 285727
URL: http://llvm.org/viewvc/llvm-project?rev=285727&view=rev
Log:
Implement a general type scavenger that can dig types from debug info + a
filtering mechanism to accept/reject results thusly obtained
Implement the C++ type looku
Author: enrico
Date: Tue Nov 1 15:17:14 2016
New Revision: 285736
URL: http://llvm.org/viewvc/llvm-project?rev=285736&view=rev
Log:
Add helpers for the notion of a type scavenger that is "either this or that"
source, and one that is "both this and that" source
Use the helper to rewrite the ObjC
Author: enrico
Date: Thu Nov 3 12:25:27 2016
New Revision: 285941
URL: http://llvm.org/viewvc/llvm-project?rev=285941&view=rev
Log:
Add support to the ObjC type scavenger for finding types via debug info
Modified:
lldb/trunk/include/lldb/Target/Language.h
lldb/trunk/packages/Python/lld
Author: enrico
Date: Thu Nov 3 12:33:11 2016
New Revision: 285943
URL: http://llvm.org/viewvc/llvm-project?rev=285943&view=rev
Log:
Add RenderScriptScriptGroup to the Xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
Author: enrico
Date: Fri Nov 4 13:15:39 2016
New Revision: 286003
URL: http://llvm.org/viewvc/llvm-project?rev=286003&view=rev
Log:
Preliminary plumbing work to make 'parray' able to take offset and stride
options
Modified:
lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptions.h
Author: enrico
Date: Mon Nov 7 10:25:01 2016
New Revision: 286116
URL: http://llvm.org/viewvc/llvm-project?rev=286116&view=rev
Log:
Fix an issue where LLDB would hang trying to launch tvOS simulator binaries
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
Author: enrico
Date: Mon Nov 7 17:32:20 2016
New Revision: 286176
URL: http://llvm.org/viewvc/llvm-project?rev=286176&view=rev
Log:
Simplify the PrintableRepresentationSpecialCases code; we never used the
ePrintableRepresentationSpecialCasesOnly value and with enum classes the names
doesn't nee
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
Make what you will of my suggestion above, but in general the reasoning looks
good
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:1
granata.enrico added a comment.
Makes sense. Feel free to commit.
Repository:
rL LLVM
https://reviews.llvm.org/D26403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: enrico
Date: Sun Nov 13 15:30:54 2016
New Revision: 286782
URL: http://llvm.org/viewvc/llvm-project?rev=286782&view=rev
Log:
I am leaving Apple in a few weeks; switch over to my personal email address
Modified:
lldb/trunk/CODE_OWNERS.txt
Modified: lldb/trunk/CODE_OWNERS.txt
URL:
ht
I will gladly let Todd run tests on your diff, but I just thought I'd
explain what is going on there
In Cocoa, some NSURL objects are represented as "sub-URLs", e.g. you can
start from www.apple.com and represent www.apple.com/macos as
NSURL(base="www.apple.com", next="/macos")
This can be r
granata.enrico added a reviewer: beanz.
granata.enrico added a comment.
Chris, can you take a look at this? I am far from a CMake expert
https://reviews.llvm.org/D26757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
granata.enrico added inline comments.
Comment at: scripts/Python/prepare_binding_Python.py:229
stderr=subprocess.PIPE,
-shell=True)
+)
# Wait for SWIG process to terminate
This worries me a little bit.. Are we sure we are not in any way
I tend to agree with Jim's point. I have sometimes put in things that
look like "dead/vestigial code", which I am actually either planning to
use later on, or actively using somewhere else. This is a quite
realistic scenario due to Swift support for LLDB existing in an entirely
separate univers
Author: enrico
Date: Fri Nov 18 17:18:11 2016
New Revision: 287397
URL: http://llvm.org/viewvc/llvm-project?rev=287397&view=rev
Log:
Removing myself from CODE_OWNERS, and distributing those duties among other
members of the community
That's All, Folks
Modified:
lldb/trunk/CODE_OWNERS.txt
Author: enrico
Date: Wed Sep 30 18:12:22 2015
New Revision: 248960
URL: http://llvm.org/viewvc/llvm-project?rev=248960&view=rev
Log:
Introudce a IsTopLevelFunction() API on Language and Function
This is meant to support languages that have a scripting mode with top-level
code that acts as global
Author: enrico
Date: Thu Oct 1 13:16:18 2015
New Revision: 249047
URL: http://llvm.org/viewvc/llvm-project?rev=249047&view=rev
Log:
Add a 'type lookup' command. This command is meant to look up type information
by name in a language-specific way.
Currently, it only supports Objective-C - C++ ty
The way I understand this from talking with Sean about it is that the
persistent variables for each type system will need to generate non-conflicting
names
In your example,
(lldb) expr -l c — 1
$1 = 1
(lldb) expr -l go — 2
$G1 = 2
(lldb) expr -l go — $1
Identifier ‘$1’ not recognized (or whatev
I way to represent this kind of
concept)
> would be ideal.
>
> On Thu, Oct 1, 2015 at 11:17 AM Enrico Granata via lldb-commits
> mailto:lldb-commits@lists.llvm.org>> wrote:
> Author: enrico
> Date: Thu Oct 1 13:16:18 2015
> New Revision: 249047
>
> URL: http
and appropriate methods added to SBTarget
>
> There currently is no SB API component to this. It is a purely command-line
> facility.
> If you feel it would be useful to have SB API for this, it will need to be
> designed (e.g. “type lookup” is allowed to transact in
granata.enrico requested changes to this revision.
granata.enrico added a comment.
This revision now requires changes to proceed.
Sorry, I didn't realize you were still waiting on me to land this patch.
I have a few extra comments before this is ready to land.
Comment at: inclu
Author: enrico
Date: Thu Oct 1 20:23:11 2015
New Revision: 249117
URL: http://llvm.org/viewvc/llvm-project?rev=249117&view=rev
Log:
Teach 'type lookup' to pull types from clang modules; also add a test case
Added:
lldb/trunk/test/functionalities/type_lookup/
lldb/trunk/test/functionalit
granata.enrico accepted this revision.
granata.enrico added a comment.
I am not deeply involved in MI internals, so I am going to assume you ran the
test suite, and that you actually verified that types without summaries still
work
In general, once you opt into data formatters, you get a lot mo
granata.enrico added a comment.
I Thought I had marked it as good to go.
My bad if I have not.
- Enrico
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
I Thought I had marked it as good to go.
My bad if I have not.
- Enrico
Sent from my iPhone
> On Oct 2, 2015, at 1:12 PM, Dawn Perchik wrote:
>
> dawn added a comment.
>
> This patch is good to commit now right? It's not marked "accepted" for some
> reason.
>
>
> http://reviews.llvm.org/D
Author: enrico
Date: Fri Oct 2 15:59:58 2015
New Revision: 249185
URL: http://llvm.org/viewvc/llvm-project?rev=249185&view=rev
Log:
Add hooks that enable NSSet, NSDictionary and NSString formatting to apply to
other types beyond the well-known ones
This is meant to support languages that can do
Author: enrico
Date: Fri Oct 2 16:14:38 2015
New Revision: 249189
URL: http://llvm.org/viewvc/llvm-project?rev=249189&view=rev
Log:
Fix the CMake build
Modified:
lldb/trunk/source/Plugins/Language/ObjC/CMakeLists.txt
Modified: lldb/trunk/source/Plugins/Language/ObjC/CMakeLists.txt
URL:
htt
Author: enrico
Date: Fri Oct 2 17:53:32 2015
New Revision: 249210
URL: http://llvm.org/viewvc/llvm-project?rev=249210&view=rev
Log:
Do not attempt to join the remote paths if none exist
Modified:
lldb/trunk/test/lldbtest.py
Modified: lldb/trunk/test/lldbtest.py
URL:
http://llvm.org/viewvc/
Author: enrico
Date: Mon Oct 5 20:02:47 2015
New Revision: 249366
URL: http://llvm.org/viewvc/llvm-project?rev=249366&view=rev
Log:
Introduce a FormattersMatchData class which contains all the information that
data formatters need in one place, and also allows for lazy computation of
expensive
Author: enrico
Date: Tue Oct 6 12:55:14 2015
New Revision: 249433
URL: http://llvm.org/viewvc/llvm-project?rev=249433&view=rev
Log:
Create a logging category that is specific to data formatters activity
Modified:
lldb/trunk/include/lldb/Core/Logging.h
lldb/trunk/source/Core/FormatEntity
Author: enrico
Date: Tue Oct 6 20:41:23 2015
New Revision: 249503
URL: http://llvm.org/viewvc/llvm-project?rev=249503&view=rev
Log:
Introduce a variant of GetSummaryAsCString() that takes a LanguageType
argument, and use it when crafting summaries by running selectors
This is the first in a ser
Author: enrico
Date: Tue Oct 6 21:06:48 2015
New Revision: 249506
URL: http://llvm.org/viewvc/llvm-project?rev=249506&view=rev
Log:
Enable the StringPrinter to have prefixes that are strings instead of just a
single character; and also introduce a comparable suffix mechanism
Modified:
lldb
Author: enrico
Date: Tue Oct 6 21:36:35 2015
New Revision: 249507
URL: http://llvm.org/viewvc/llvm-project?rev=249507&view=rev
Log:
Route the preferred-display-language mechanism to the ValueObjectPrinter and
actually fill in a few gaps for dynamic and synthetic values to be able to
adopt this
st that does not rely on a particular language? That would
>> improve the test coverage of this functionality.
>>
>>> On Tue, Oct 6, 2015 at 7:38 PM Enrico Granata via lldb-commits
>>> wrote:
>>> Author: enrico
>>> Date: Tue Oct 6 21:36:35
Author: enrico
Date: Wed Oct 7 13:36:53 2015
New Revision: 249587
URL: http://llvm.org/viewvc/llvm-project?rev=249587&view=rev
Log:
This is the work I was building up to with my patches yesterday
Introduce the notion of Language-based formatter prefix/suffix
This is meant for languages that shar
granata.enrico requested changes to this revision.
granata.enrico added a comment.
This revision now requires changes to proceed.
Truth be told, I find this notation (numeric value + printable character) to be
heavy and somewhat redundant
I would be happier with a model where printable character
granata.enrico added a comment.
The consistency argument is not entirely unfair.
I would claim that Unicode is a more complex beast than plain ASCII, so it
makes sense to go the extra mile in giving you details in that case, compared
to the simpler char case.
If the only reason you're pursuing
> On Oct 12, 2015, at 12:00 PM, Jim Ingham via lldb-commits
> wrote:
>
> Author: jingham
> Date: Mon Oct 12 14:00:28 2015
> New Revision: 250081
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250081&view=rev
> Log:
> Fix test for change in a summary string (objects -> elements).
>
> Modifie
granata.enrico added a comment.
Why are you removing the loop detection?
As for the size capping, yes, if you remove the loop detection it will be less
of a problem because downstream commands (e.g. frame variable) will actually
cap how many elements get fetched unless the user overrides that d
granata.enrico added a comment.
Possibility number 3 (and the true reason why the check is there): if you stop
at a place where the variable is not fully initialized/being torn down, and as
a result, something is pointing back inside the list. For a list traversal,
that is a deadly outcome.
Th
granata.enrico added a comment.
Removing the size limit would be acceptable, yes
It is a remnant of a time when LLDB lacked ways to actually cap data at the
command-line level and the Xcode UI did not do lazy fetching of values
Given that these things now work properly, the ability to generate
granata.enrico added a comment.
Currently I don't think SBTypeSummary allows for defining formatters backed by
a CXXFunctionSummaryFormat
It would, however, be a great addition to our API. Is it a change you're
interested in working on?
If so, the easy part is going to be introducing LLVM-style
granata.enrico added a comment.
We are not supposed to be inheriting from SB classes, much less introduce
virtual-ness to them (Greg can go in detail about the reasons, the tl;dr is
that it has the potential to be ABI-breaking)
The way one would do that is to have a typedef akin to (and after f
granata.enrico added a comment.
Admittedly way simpler than my original idea. +1
Having the RTTI support so that these SBTypeSummary objects can actually be
used for anything other than mere creation would be nice.
However, I can fill that gap myself later.
Comment at: source/
granata.enrico added inline comments.
Comment at: source/API/SBTypeSummary.cpp:155
@@ +154,3 @@
+ new CXXFunctionSummaryFormat(options,
+ [cb] (ValueObject& valobj, Stream& stm, const
TypeSummaryOptions& opt) -> bool {
+
granata.enrico added a subscriber: granata.enrico.
granata.enrico added a comment.
Is there any reason why we need a special command here?
Are these allocations not bound to any user-visible variable, such that one
could get the same result by using our existing data inspection commands
(expres
granata.enrico added inline comments.
Comment at: source/API/SBTypeSummary.cpp:155
@@ +154,3 @@
+ new CXXFunctionSummaryFormat(options,
+ [cb] (ValueObject& valobj, Stream& stm, const
TypeSummaryOptions& opt) -> bool {
+
granata.enrico added a comment.
So, if you do the explicit constructor change and handle the case of a nullptr
Callback I think it should be good to go. Looking forward to it!
Comment at: source/API/SBTypeSummary.cpp:157
@@ +156,3 @@
+SBStream stream
Author: enrico
Date: Wed Oct 14 17:44:30 2015
New Revision: 250339
URL: http://llvm.org/viewvc/llvm-project?rev=250339&view=rev
Log:
Fix a problem where LLDB could sometimes try to get the size of an Objective-C
type without passing an appropriate ExecutionContext
Modified:
lldb/trunk/inclu
Author: enrico
Date: Wed Oct 14 17:44:50 2015
New Revision: 250340
URL: http://llvm.org/viewvc/llvm-project?rev=250340&view=rev
Log:
Fix a couple issues where trying to print a type would cause LLDB to crash
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/
Author: enrico
Date: Wed Oct 14 17:45:04 2015
New Revision: 250341
URL: http://llvm.org/viewvc/llvm-project?rev=250341&view=rev
Log:
Add a data formatter for __NSArray0, the type of empty arrays
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSArray.cpp
lldb/trunk/source/Plugins/Langua
granata.enrico accepted this revision.
granata.enrico added a comment.
Looks fine to me
Repository:
rL LLVM
http://reviews.llvm.org/D13577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
Fine to get it in
http://reviews.llvm.org/D13657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
granata.enrico added a comment.
What do you plan to use this has_child_at_index call for?
My concern is that it adds complication to the synthetic child provider
interface. Yes, I understand it is optional, but it seems like yet another
thing in the "any children?" realm that I would rather muc
granata.enrico added a comment.
Is it possible to ask for concrete examples?
As in, for example, do you plan to change ValueObjectPrinter to use this API in
some way?
Or do you have any specific synthetic providers that you would like to use this
API in?
http://reviews.llvm.org/D13778
granata.enrico requested changes to this revision.
granata.enrico added a comment.
This revision now requires changes to proceed.
If so, why do you need this to be exposed as a call that LLDB knows about?
You are free to provide any methods you want in your synthetic child providers.
Adding them
granata.enrico added a comment.
So, if I understand this correctly, this HasChildAtIndex() API returns a
three-state int:
1 == yes I do
0 == no I do not
-1 == maybe, can't tell
When would you ever run into the -1 case? It seems you're mostly using it as an
invalid marker. Would 0 not be a bett
granata.enrico added a comment.
One alternative would be to have the num_children method on the synthetic
provider itself be able to take an optional argument that is the max_count.
That is, instead of defining
def num_children(self):
..
You would instead define
def num_children(self,
granata.enrico added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:37
@@ +36,3 @@
+return false;
+stream.Printf("%d %s", (int)value.GetValueAsSigned(), value.GetValue());
+return true;
I would definitely not stop the revision for
granata.enrico added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:835
@@ +834,3 @@
+
+if (!MI_add_summary(miCategory, "char", MI_char_summary_provider,
+lldb::eTypeOptionHideValue |
lldb::eTypeOptionSkipPointers))
e
Author: enrico
Date: Fri Oct 16 17:51:56 2015
New Revision: 250567
URL: http://llvm.org/viewvc/llvm-project?rev=250567&view=rev
Log:
Move TypeSummaryImpl over to LLVM-style RTTI for subclassing
Modified:
lldb/trunk/include/lldb/DataFormatters/TypeSummary.h
lldb/trunk/source/API/SBTypeSum
Author: enrico
Date: Fri Oct 16 18:42:04 2015
New Revision: 250581
URL: http://llvm.org/viewvc/llvm-project?rev=250581&view=rev
Log:
Handle eFormatVectorOfFloat16
Modified:
lldb/trunk/source/Commands/CommandObjectMemory.cpp
Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp
URL:
Author: enrico
Date: Fri Oct 16 20:05:50 2015
New Revision: 250599
URL: http://llvm.org/viewvc/llvm-project?rev=250599&view=rev
Log:
Teach an old pony a few new tricks.
ValueObjectPrinter can now mask out pointer values during a printout; also, it
supports helper functions to print declarations
granata.enrico added inline comments.
Comment at: include/lldb/API/SBValue.h:372
@@ +371,3 @@
+bool
+IsIntegerType(bool& is_signed);
+
Greg pointed me to SBType::GetBasicType() - this will return to you one of
```
eBasicTypeSignedChar,
eBa
Author: enrico
Date: Mon Oct 19 15:40:50 2015
New Revision: 250734
URL: http://llvm.org/viewvc/llvm-project?rev=250734&view=rev
Log:
Teach the lldbinline test cases to run in DWO mode
Modified:
lldb/trunk/test/lldbinline.py
Modified: lldb/trunk/test/lldbinline.py
URL:
http://llvm.org/viewv
Author: enrico
Date: Mon Oct 19 17:04:25 2015
New Revision: 250744
URL: http://llvm.org/viewvc/llvm-project?rev=250744&view=rev
Log:
Let Language plugins vend a default DeclPrintingHelper in case a custom one is
not specified for the specific invocation
Added:
lldb/trunk/include/lldb/DataFo
Author: enrico
Date: Mon Oct 19 17:53:34 2015
New Revision: 250750
URL: http://llvm.org/viewvc/llvm-project?rev=250750&view=rev
Log:
Add a flakey category for flakey tests
Modified:
lldb/trunk/test/dotest.py
Modified: lldb/trunk/test/dotest.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/t
granata.enrico added inline comments.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:104
@@ +103,3 @@
+size_t m_len;
+std::vector m_children;
+};
This worries me a little bit
Imagine I have one of these slices with a million elements, and
Author: enrico
Date: Mon Oct 19 19:13:19 2015
New Revision: 250767
URL: http://llvm.org/viewvc/llvm-project?rev=250767&view=rev
Log:
Introduce the concept of a type that is meaningless without dynamic resolution,
which are essentially placeholder types meant to appease a language's type
system b
Author: enrico
Date: Mon Oct 19 23:50:09 2015
New Revision: 250798
URL: http://llvm.org/viewvc/llvm-project?rev=250798&view=rev
Log:
Rationalization of includes in the data formatters code
Modified:
lldb/trunk/include/lldb/DataFormatters/CXXFunctionPointer.h
lldb/trunk/include/lldb/DataFo
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
That looks reasonable. Of course, I assume you ran the test suite on OS X,
including your new evil test!
http://reviews.llvm.org/D13902
granata.enrico accepted this revision.
granata.enrico added a comment.
Looks reasonable
http://reviews.llvm.org/D13836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ases proclaim their failure, which however tells us nothing of
value as the issue is simply “libc++ not available” vs. “data formatters broken”
That is an ability I would strongly like to preserve
>
> On 18 September 2015 at 21:12, Enrico Granata via lldb-commits
> wrote:
>>
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
Looks fine
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
Looks good to me
http://reviews.llvm.org/D13964
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
Author: enrico
Date: Fri Oct 23 19:15:57 2015
New Revision: 251161
URL: http://llvm.org/viewvc/llvm-project?rev=251161&view=rev
Log:
Lower the depth of the recursion in this test since it would on occasion
timeout and add noise to test runs
Modified:
lldb/trunk/test/functionalities/recursion
Author: enrico
Date: Mon Oct 26 18:39:12 2015
New Revision: 251368
URL: http://llvm.org/viewvc/llvm-project?rev=251368&view=rev
Log:
Change TestTypeCompletion to not rely on std::string
On some combination of platform and c++ library, this dependency was causing
the test to fail for reasons tang
Author: enrico
Date: Mon Oct 26 20:10:35 2015
New Revision: 251376
URL: http://llvm.org/viewvc/llvm-project?rev=251376&view=rev
Log:
Add calls to the SB API to access the multi-language formatter category feature
Modified:
lldb/trunk/include/lldb/API/SBTypeCategory.h
lldb/trunk/scripts/in
Author: enrico
Date: Mon Oct 26 20:17:28 2015
New Revision: 251377
URL: http://llvm.org/viewvc/llvm-project?rev=251377&view=rev
Log:
Minor cleanup of SBTypeSummary::CreateWithCallback to take an optional
description argument
Modified:
lldb/trunk/include/lldb/API/SBTypeSummary.h
lldb/trun
Author: enrico
Date: Wed Oct 28 17:08:09 2015
New Revision: 251559
URL: http://llvm.org/viewvc/llvm-project?rev=251559&view=rev
Log:
Skip this test is the test suite is running in a mode where it has no
WindowServer access
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/rdar-1
Author: enrico
Date: Wed Oct 28 18:36:44 2015
New Revision: 251581
URL: http://llvm.org/viewvc/llvm-project?rev=251581&view=rev
Log:
Remove an unused local variable
Modified:
lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp
Modified: lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp
U
Author: enrico
Date: Thu Oct 29 13:58:13 2015
New Revision: 251642
URL: http://llvm.org/viewvc/llvm-project?rev=251642&view=rev
Log:
Add an 'internal' kind of summary to support one-off subclasses of
TypeSummaryImpl
Modified:
lldb/trunk/include/lldb/DataFormatters/TypeSummary.h
lldb/trun
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
I think it's OK to land this, yes
I would still like to think about ways that we can avoid using hardcoded
formatters here, but it seems non-trivial and I don't know enough abo
Author: enrico
Date: Thu Oct 29 17:18:05 2015
New Revision: 251660
URL: http://llvm.org/viewvc/llvm-project?rev=251660&view=rev
Log:
Add a --language (-l) option to the formatter delete commands in order to allow
removing formatters from language categories
This is slightly harder to test becaus
Author: enrico
Date: Thu Oct 29 17:29:06 2015
New Revision: 251663
URL: http://llvm.org/viewvc/llvm-project?rev=251663&view=rev
Log:
Do not accept nullptr descriptions as valid summaries to be printed
Modified:
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
Modified: lldb/trunk/source/Plu
Author: enrico
Date: Thu Oct 29 18:40:24 2015
New Revision: 251668
URL: http://llvm.org/viewvc/llvm-project?rev=251668&view=rev
Log:
Add a --offset option to memory read that allows one to specify, given a type,
how many sizeof(type) bytes to speak before starting to read memory
Modified:
l
Author: enrico
Date: Thu Oct 29 18:53:34 2015
New Revision: 251670
URL: http://llvm.org/viewvc/llvm-project?rev=251670&view=rev
Log:
Remove two #if0ed regions of code that we were using for an experiment but
don't really want
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLa
Author: enrico
Date: Thu Oct 29 20:09:54 2015
New Revision: 251678
URL: http://llvm.org/viewvc/llvm-project?rev=251678&view=rev
Log:
Some test cases that need the lldbExec path were failing because lldbExec was
turning out to be None even though it was being validly set by dotest.py
It turns out
1 - 100 of 425 matches
Mail list logo
