[Lldb-commits] [lldb] r345086 - Remove unused variable.

Author: echristo Date: Tue Oct 23 14:55:41 2018 New Revision: 345086 URL: http://llvm.org/viewvc/llvm-project?rev=345086&view=rev Log: Remove unused variable. Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/Nativ

[Lldb-commits] [lldb] r346294 - Add a break to avoid an unannotated fall-through.

Author: echristo Date: Tue Nov 6 21:17:31 2018 New Revision: 346294 URL: http://llvm.org/viewvc/llvm-project?rev=346294&view=rev Log: Add a break to avoid an unannotated fall-through. Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/MSVCUndecoratedNameParser.cpp Modified: lldb/trunk/

[Lldb-commits] [lldb] r336884 - Remove unused variable m_header as it hasn't been used since it was

Author: echristo Date: Wed Jul 11 20:52:45 2018 New Revision: 336884 URL: http://llvm.org/viewvc/llvm-project?rev=336884&view=rev Log: Remove unused variable m_header as it hasn't been used since it was added in 2016. Modified: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp

[Lldb-commits] [lldb] r336885 - Remove the unused m_signal member variable, but leave the code that gets it out of the json.

Author: echristo Date: Wed Jul 11 20:52:46 2018 New Revision: 336885 URL: http://llvm.org/viewvc/llvm-project?rev=336885&view=rev Log: Remove the unused m_signal member variable, but leave the code that gets it out of the json. Modified: lldb/trunk/unittests/tools/lldb-server/tests/MessageOb

[Lldb-commits] [lldb] r338458 - Use UnknownVendor rather than UnknownArch since they're in two different enums

Author: echristo Date: Tue Jul 31 16:53:23 2018 New Revision: 338458 URL: http://llvm.org/viewvc/llvm-project?rev=338458&view=rev Log: Use UnknownVendor rather than UnknownArch since they're in two different enums and we're switching on vendor and not arch. Modified: lldb/trunk/source/Plugins

[Lldb-commits] [lldb] r338460 - Android is an environment and we were comparing the android triple

Author: echristo Date: Tue Jul 31 16:53:24 2018 New Revision: 338460 URL: http://llvm.org/viewvc/llvm-project?rev=338460&view=rev Log: Android is an environment and we were comparing the android triple against the OS rather than the environment. Also update other uses of OS when we meant environme

[Lldb-commits] [lldb] r338459 - Tidy up comment.

Author: echristo Date: Tue Jul 31 16:53:24 2018 New Revision: 338459 URL: http://llvm.org/viewvc/llvm-project?rev=338459&view=rev Log: Tidy up comment. Modified: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp Modified: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroi

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

Yep yep yep. On Tue, Mar 12, 2019 at 1:24 PM Adrian Prantl via Phabricator wrote: > > aprantl added a comment. > > In D59235#1426716 , @JDevlieghere > wrote: > > > Agreed, and we've been doing this for new patches for a while now. However, > > I very str

[Lldb-commits] [lldb] 3ccd454 - Fix unused variable, format, and format string warnings.

Author: Eric Christopher Date: 2020-04-03T17:58:59-07:00 New Revision: 3ccd454c102b069d2230a18cfe16b84a5f005fc8 URL: https://github.com/llvm/llvm-project/commit/3ccd454c102b069d2230a18cfe16b84a5f005fc8 DIFF: https://github.com/llvm/llvm-project/commit/3ccd454c102b069d2230a18cfe16b84a5f005fc8.di

[Lldb-commits] [lldb] ff1658b - Fix -Wdeprecated-copy warning in XcodeSDK.

Author: Eric Christopher Date: 2020-04-08T15:12:53-07:00 New Revision: ff1658b167c835ca55f554a3ad5aac444a6f9c9c URL: https://github.com/llvm/llvm-project/commit/ff1658b167c835ca55f554a3ad5aac444a6f9c9c DIFF: https://github.com/llvm/llvm-project/commit/ff1658b167c835ca55f554a3ad5aac444a6f9c9c.di

[Lldb-commits] [lldb] 3a75466 - Temporarily Revert "Reland [lldb] Unify type name matching in FormattersContainer"

Author: Eric Christopher Date: 2020-07-23T00:47:05-07:00 New Revision: 3a75466f41be12a8cdcff7ff786d55a319e6c2df URL: https://github.com/llvm/llvm-project/commit/3a75466f41be12a8cdcff7ff786d55a319e6c2df DIFF: https://github.com/llvm/llvm-project/commit/3a75466f41be12a8cdcff7ff786d55a319e6c2df.di

Re: [Lldb-commits] [lldb] 074b121 - Reland [lldb] Unify type name matching in FormattersContainer

Hi Raphael, I've temporarily reverted this again with hopefully a better explanation here: echristo@athyra ~/s/llvm-project> git push To github.com:llvm/llvm-project.git 55c0f12a869..3a75466f41b master -> master One review thought: If you don't want people using the default constructor for T

[Lldb-commits] [lldb] 4b14ef3 - Temporarily Revert "Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)"

Author: Eric Christopher Date: 2020-07-25T18:42:04-07:00 New Revision: 4b14ef33e81c01632e848e7a67ccc6b11fb4c595 URL: https://github.com/llvm/llvm-project/commit/4b14ef33e81c01632e848e7a67ccc6b11fb4c595 DIFF: https://github.com/llvm/llvm-project/commit/4b14ef33e81c01632e848e7a67ccc6b11fb4c595.di

Re: [Lldb-commits] [lldb] 1d9b860 - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

Hi Adrian, I'm really sorry, but I've just reverted this. I'm not sure what's up, but it's causing massive test failures in lldb on linux. Happy to help sync up with you. echristo@athyra ~/s/llvm-project> git push To github.com:llvm/llvm-project.git 18975762c19..4b14ef33e81 master -> master

Re: [Lldb-commits] [lldb] 1d9b860 - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

No problem, thanks! :) On Mon, Jul 27, 2020, 9:26 AM Adrian Prantl wrote: > Thanks, Eric! Sorry for not paying attention after landing this. > > -- adrian > > On Jul 25, 2020, at 6:43 PM, Eric Christopher wrote: > > Hi Adrian, > > I'm really sorry, but I've just reverted this. I'm not sure what

Re: [Lldb-commits] [lldb] 1d9b860 - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

Thanks Pavel :) On Mon, Jul 27, 2020, 11:35 AM Pavel Labath wrote: > On 27/07/2020 19:03, Adrian Prantl via lldb-commits wrote: > > Do you happen to have a link to a bot with the failures? Or can you send > > me the output in case it's an internal bot? > > > > thanks, > > adrian > > > > This sho

[Lldb-commits] [lldb] b529c52 - Add override to fix -Winconsistent-missing-override warning.

Author: Eric Christopher Date: 2020-08-09T22:12:10-07:00 New Revision: b529c5270c99e0ca18e3cbd9a5f50eb0970e560a URL: https://github.com/llvm/llvm-project/commit/b529c5270c99e0ca18e3cbd9a5f50eb0970e560a DIFF: https://github.com/llvm/llvm-project/commit/b529c5270c99e0ca18e3cbd9a5f50eb0970e560a.di

[Lldb-commits] [lldb] c140322 - Use zu rather than llu format specifier for size_t (-Wformat warning fix).

Author: Eric Christopher Date: 2020-09-16T19:28:05-07:00 New Revision: c140322819806cb292e079d62f2e9dbab697c08c URL: https://github.com/llvm/llvm-project/commit/c140322819806cb292e079d62f2e9dbab697c08c DIFF: https://github.com/llvm/llvm-project/commit/c140322819806cb292e079d62f2e9dbab697c08c.di

Re: [Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

Tagging in Teresa as well for the thinlto parts. On Wed, May 8, 2019 at 12:43 PM Nico Weber via Phabricator wrote: > > thakis added a comment. > > That problem only seems to happen when (thin) lto is enabled. > > > Repository: > rL LLVM > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

Unlikely. I'm in the middle of getting some, but that's still going to be a few months I think. And yes, we should probably just revert for now. I can unless someone beats me to it. Thanks! On Thu, May 16, 2019 at 2:29 PM Nico Weber via Phabricator wrote: > > thakis added a comment. > > This b

Re: [Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

For now I think the compelling argument on revert is: - this breaks currently working thinlto builds whether or not this has uncovered a latent problem in thinlto, the linking strategy used, or something else I think we should revert until we can take a look and decide where the problems are and

Re: [Lldb-commits] [lldb] 079e664 - [lldb] Re-enable TestPlatformProcessConnect on macos

+Jordan Rupprecht Interesting, we were using this internally to point to an lldb-server to test. I've disabled some tests at the moment, but I'm not sure it isn't entirely useful functionality :) -eric On Tue, Jan 19, 2021 at 5:01 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org>

Re: [Lldb-commits] [lldb] 079e664 - [lldb] Re-enable TestPlatformProcessConnect on macos

On Wed, Jan 20, 2021 at 2:51 PM Pavel Labath wrote: > On 20/01/2021 04:35, Eric Christopher wrote: > > +Jordan Rupprecht > > > > Interesting, we were using this internally to point to an lldb-server to > > test. I've disabled some tests at the moment, but I'm not sur

[Lldb-commits] [lldb] 6a9edce - Fix a dangling-gsl warning and avoid transitively including string.

Author: Eric Christopher Date: 2020-04-24T16:03:17-07:00 New Revision: 6a9edce25778e6c131914ab2e6c3f8528785a8df URL: https://github.com/llvm/llvm-project/commit/6a9edce25778e6c131914ab2e6c3f8528785a8df DIFF: https://github.com/llvm/llvm-project/commit/6a9edce25778e6c131914ab2e6c3f8528785a8df.di

[Lldb-commits] [lldb] 4d40d66 - Fix up a clang-tidy nit about using empty rather than size == 0.

Author: Eric Christopher Date: 2020-04-27T15:22:44-07:00 New Revision: 4d40d6640238a8d304c39603a4938de85301fcba URL: https://github.com/llvm/llvm-project/commit/4d40d6640238a8d304c39603a4938de85301fcba DIFF: https://github.com/llvm/llvm-project/commit/4d40d6640238a8d304c39603a4938de85301fcba.di

[Lldb-commits] [lldb] cd7cb1f - Update lldb for rG10658691951f to avoid Werror messages around

Author: Eric Christopher Date: 2020-05-11T13:45:21-07:00 New Revision: cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459 URL: https://github.com/llvm/llvm-project/commit/cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459 DIFF: https://github.com/llvm/llvm-project/commit/cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459.di

[Lldb-commits] [lldb] 8d7796c - Fix a few clang-tidy warnings about auto * and const auto.

Author: Eric Christopher Date: 2020-05-11T15:33:17-07:00 New Revision: 8d7796cf9427a0c361a5831e4371ff030b98dfac URL: https://github.com/llvm/llvm-project/commit/8d7796cf9427a0c361a5831e4371ff030b98dfac DIFF: https://github.com/llvm/llvm-project/commit/8d7796cf9427a0c361a5831e4371ff030b98dfac.di

[Lldb-commits] [lldb] 15ee8a3 - Silence warnings around int/float conversions.

Author: Eric Christopher Date: 2020-05-19T10:56:18-07:00 New Revision: 15ee8a3a58223b48afbe33cb60084f864ef20889 URL: https://github.com/llvm/llvm-project/commit/15ee8a3a58223b48afbe33cb60084f864ef20889 DIFF: https://github.com/llvm/llvm-project/commit/15ee8a3a58223b48afbe33cb60084f864ef20889.di

Re: [Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

Agreed. Something is off here. My change was only to silence a few warnings, but they're definitely highlighting a conversion issue. What's up with NSDate conversions here. Does the API have a way to convert from time_t? On Wed, May 20, 2020, 2:07 AM Pavel Labath via Phabricator via lldb-commits

[Lldb-commits] [lldb] 7510aed - Handle eExpressionThreadVanished in error switch to handle

Author: Eric Christopher Date: 2020-05-22T13:43:10-07:00 New Revision: 7510aede627267819d9693381ad6c16dccfa0d17 URL: https://github.com/llvm/llvm-project/commit/7510aede627267819d9693381ad6c16dccfa0d17 DIFF: https://github.com/llvm/llvm-project/commit/7510aede627267819d9693381ad6c16dccfa0d17.di

[Lldb-commits] [lldb] 713538b - Be more specific about auto * vs auto for po alias.

Author: Eric Christopher Date: 2020-05-26T11:59:09-07:00 New Revision: 713538b629e45e6236b5d60fd6b64d7b8669cd00 URL: https://github.com/llvm/llvm-project/commit/713538b629e45e6236b5d60fd6b64d7b8669cd00 DIFF: https://github.com/llvm/llvm-project/commit/713538b629e45e6236b5d60fd6b64d7b8669cd00.di

[Lldb-commits] [lldb] 50939c0 - Add SveBFloat16 to type switch.

Author: Eric Christopher Date: 2020-06-18T12:39:03-07:00 New Revision: 50939c0a67619b77d085bfafb2cedda413d57b7a URL: https://github.com/llvm/llvm-project/commit/50939c0a67619b77d085bfafb2cedda413d57b7a DIFF: https://github.com/llvm/llvm-project/commit/50939c0a67619b77d085bfafb2cedda413d57b7a.di

[Lldb-commits] [lldb] efb328f - As part of using inclusive language with the llvm project,

Author: Eric Christopher Date: 2020-06-19T14:48:48-07:00 New Revision: efb328f674ca67081818bbac45dda3f3452fc44b URL: https://github.com/llvm/llvm-project/commit/efb328f674ca67081818bbac45dda3f3452fc44b DIFF: https://github.com/llvm/llvm-project/commit/efb328f674ca67081818bbac45dda3f3452fc44b.di

[Lldb-commits] [lldb] 2db1d75 - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T14:51:04-07:00 New Revision: 2db1d75396fe3700530e3703f8c951a53cff00ee URL: https://github.com/llvm/llvm-project/commit/2db1d75396fe3700530e3703f8c951a53cff00ee DIFF: https://github.com/llvm/llvm-project/commit/2db1d75396fe3700530e3703f8c951a53cff00ee.di

[Lldb-commits] [lldb] 10b4354 - Temporarily Revert "[lldb][NFC] Add more test for builtin formats"

Author: Eric Christopher Date: 2020-06-20T14:21:42-07:00 New Revision: 10b43541360efb35a1d33e9cf1e93023ebd69b15 URL: https://github.com/llvm/llvm-project/commit/10b43541360efb35a1d33e9cf1e93023ebd69b15 DIFF: https://github.com/llvm/llvm-project/commit/10b43541360efb35a1d33e9cf1e93023ebd69b15.di

Re: [Lldb-commits] [lldb] 90c1af1 - [lldb][NFC] Add more test for builtin formats

This is failing on some of the debian buildbots so I've temporarily reverted it here: commit 10b43541360efb35a1d33e9cf1e93023ebd69b15 (HEAD -> master, origin/master, origin/HEAD) Author: Eric Christopher Date: Sat Jun 20 14:21:42 2020 Temporarily Revert "[lldb][NFC] Add more test for built

Re: [Lldb-commits] [lldb] 90c1af1 - [lldb][NFC] Add more test for builtin formats

No problem at all, happens to all of us :) -eric On Sun, Jun 21, 2020 at 12:56 AM Raphael “Teemperor” Isemann < teempe...@gmail.com> wrote: > Sorry for that, it seems I overlooked those failure mails. Thanks! > > On 20 Jun 2020, at 23:22, Eric Christopher wrote: > > This is failing on some of t

[Lldb-commits] [lldb] 368eb77 - Fix a -Wunused-variable warning.

Author: Eric Christopher Date: 2020-07-14T12:40:56-07:00 New Revision: 368eb7712f9f19f93f3e318d8b16e732436fb9c4 URL: https://github.com/llvm/llvm-project/commit/368eb7712f9f19f93f3e318d8b16e732436fb9c4 DIFF: https://github.com/llvm/llvm-project/commit/368eb7712f9f19f93f3e318d8b16e732436fb9c4.di

[Lldb-commits] [lldb] 5312139 - Add a default copy-assignment or copy-constructor for -Wdeprecated-copy warnings.

Author: Eric Christopher Date: 2019-12-04T20:35:32-08:00 New Revision: 5312139f779f9f18cc5fa1c4ce5e5c5c1e854e90 URL: https://github.com/llvm/llvm-project/commit/5312139f779f9f18cc5fa1c4ce5e5c5c1e854e90 DIFF: https://github.com/llvm/llvm-project/commit/5312139f779f9f18cc5fa1c4ce5e5c5c1e854e90.di

[Lldb-commits] [lldb] 53acf06 - Fix a -Wsign-compare error around wchar_t vs unsigned int.

Author: Eric Christopher Date: 2019-12-10T11:18:57-08:00 New Revision: 53acf0663f80e1be99bae28769c6b658fff0e097 URL: https://github.com/llvm/llvm-project/commit/53acf0663f80e1be99bae28769c6b658fff0e097 DIFF: https://github.com/llvm/llvm-project/commit/53acf0663f80e1be99bae28769c6b658fff0e097.di

Re: [Lldb-commits] [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes

Hi Jonas, This appears to be causing crashes in a release asserts build: #3 0x7efe57b613a0 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x123a0) #4 0x7efe54178d00 llvm::raw_ostream::operator<<(llvm::StringRef) sources/llvm-project/llvm/include/llvm/Support/raw_ostream.h:190:7 #5

[Lldb-commits] [lldb] c9e0b35 - Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes

Author: Eric Christopher Date: 2019-12-10T12:29:46-08:00 New Revision: c9e0b354e2749ce7ab553974692cb35c8651a869 URL: https://github.com/llvm/llvm-project/commit/c9e0b354e2749ce7ab553974692cb35c8651a869 DIFF: https://github.com/llvm/llvm-project/commit/c9e0b354e2749ce7ab553974692cb35c8651a869.di

Re: [Lldb-commits] [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes

For now I've gone ahead and reverted thusly: echristo@athyra ~/r/llvm-project> git push To github.com:llvm/llvm-project.git a2602bdd731..c9e0b354e27 master -> master Sorry for the very quick turnaround. -eric On Tue, Dec 10, 2019 at 12:21 PM Eric Christopher wrote: > Hi Jonas, > > This ap

[Lldb-commits] [lldb] 1d41d1b - Revert "Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes"

Author: Eric Christopher Date: 2019-12-10T15:04:45-08:00 New Revision: 1d41d1bcdfd70cf8f77bb32e2617392395c299a4 URL: https://github.com/llvm/llvm-project/commit/1d41d1bcdfd70cf8f77bb32e2617392395c299a4 DIFF: https://github.com/llvm/llvm-project/commit/1d41d1bcdfd70cf8f77bb32e2617392395c299a4.di