Eugene.Zelenko added a comment.
Please run Clang-format over new code.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:12
+
+#include
+#include
STL headers should be after application's headers.
Comment at: source/Pl
Eugene.Zelenko added a comment.
There are same problems with formatting as in https://reviews.llvm.org/D25726.
Also test case main() has wrong indentation.
https://reviews.llvm.org/D25734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Eugene.Zelenko added a comment.
There are same problems with formatting as in https://reviews.llvm.org/D25726.
Also test case main() has wrong indentation.
https://reviews.llvm.org/D25733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Eugene.Zelenko added a comment.
Headers orders is still not correct.
https://reviews.llvm.org/D25734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Eugene.Zelenko added a comment.
Headers orders is still not correct.
Repository:
rL LLVM
https://reviews.llvm.org/D25733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, zturner.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Build problem happens because of errno.
Repository:
rL LLVM
https://reviews.llvm.org/D26171
Author: eugenezelenko
Date: Tue Nov 1 12:11:10 2016
New Revision: 285710
URL: http://llvm.org/viewvc/llvm-project?rev=285710&view=rev
Log:
Fix RHEL 6 build with missing cerrno and some other Include What You Use
warnings.
Differential revision: https://reviews.llvm.org/D26171
Modified:
lld
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is second attempt based on current code.
I checked this patch on my own build on RH
Eugene.Zelenko added a comment.
I make whitespaces more consistent.
Space between function names and round bracket is consistent with Clang-format
settings for LLDB.
Repository:
rL LLVM
http://reviews.llvm.org/D13574
___
lldb-commits mailing li
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is second attempt based on current code.
I checked this patch on my own build on RH
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is second attempt based on current code.
I checked this patch on my own build on RH
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Herald added a subscriber: dsanders.
This is second attempt based on current code.
I che
Author: eugenezelenko
Date: Thu Oct 15 19:17:35 2015
New Revision: 250476
URL: http://llvm.org/viewvc/llvm-project?rev=250476&view=rev
Log:
Test commit. Part of:
[LLDB] Fix Clang-tidy misc-use-override warnings in remaining files in include;
other minor fixes.
Differential Revision: http://revi
Author: eugenezelenko
Date: Thu Oct 15 20:11:37 2015
New Revision: 250485
URL: http://llvm.org/viewvc/llvm-project?rev=250485&view=rev
Log:
[LLDB] Fix Clang-tidy misc-use-override warnings in remaining files in include;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13681
Mo
Author: eugenezelenko
Date: Fri Oct 16 13:49:42 2015
New Revision: 250538
URL: http://llvm.org/viewvc/llvm-project?rev=250538&view=rev
Log:
[LLDB] Fix Clang-tidy modernize-use-override warnings in source/Plugins/ABI;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13684
Modif
Eugene.Zelenko added a comment.
Ping. Please review this patch, since these files is largest source of
modernize-use-override warnings warnings in LLDB code.
Repository:
rL LLVM
http://reviews.llvm.org/D13602
___
lldb-commits mailing list
lldb-c
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Herald added a subscriber: emaste.
I checked this patch on my own build on RHEL 6.
Repos
Author: eugenezelenko
Date: Fri Oct 16 19:19:57 2015
New Revision: 250593
URL: http://llvm.org/viewvc/llvm-project?rev=250593&view=rev
Log:
[LLDB] Fix Clang-tidy modernize-use-override warnings in some headers in
source/Plugins/Process/Utility; other minor fixes.
Differential Revision: http://re
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
Author: eugenezelenko
Date: Mon Oct 19 13:52:10 2015
New Revision: 250721
URL: http://llvm.org/viewvc/llvm-project?rev=250721&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13840
Mo
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
Author: eugenezelenko
Date: Mon Oct 19 20:10:59 2015
New Revision: 250789
URL: http://llvm.org/viewvc/llvm-project?rev=250789&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in source/Plugins/Language;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13876
Modifie
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10
@@ +9,3 @@
+
+#include
+
Please add include section comments. Same for other sections.
Comment at: source/Plugins/Language/Go/G
Eugene.Zelenko added inline comments.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:1
@@ +1,2 @@
+//===-- GoFormatterFunctions.h*- C++
-*-===//
+//
Such comments should be 80 characters long.
C
Eugene.Zelenko added a comment.
I think will be good idea to format code with Clang-format.
See also http://reviews.llvm.org/rL250789 I just committed with similar
cleanups for other languages.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
__
Eugene.Zelenko added inline comments.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:107
@@ +106,3 @@
+
+} // anonymous namespace
+
One space should be enough.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
___
Eugene.Zelenko added inline comments.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10
@@ +9,3 @@
+
+#include
+
ribrdb wrote:
> Eugene.Zelenko wrote:
> > Please add include section comments. Same for other sections.
> Which sections? I've seen a
Eugene.Zelenko added a comment.
Did you format code with Clang-format? Spaces/no spaces between function names
and arguments are inconsistent.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:29
@@ +28,3 @@
+
+#include "clang/AST/ASTContext.h"
+
Th
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
Author: eugenezelenko
Date: Tue Oct 20 20:03:30 2015
New Revision: 250872
URL: http://llvm.org/viewvc/llvm-project?rev=250872&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13916
Mo
Author: eugenezelenko
Date: Tue Oct 20 20:42:15 2015
New Revision: 250874
URL: http://llvm.org/viewvc/llvm-project?rev=250874&view=rev
Log:
Revert r250872 in source/Plugins/Disassembler to fix MSVC builds failures.
Modified:
lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
Hi, Zachary!
On Tue, Oct 20, 2015 at 8:25 PM, Zachary Turner wrote:
> You can probably put this CL back in, just make sure you #include the
> appropriate file from LLVM in the header file.
Actually I only changed order of headers and forward declarations.
Unfortunately I don't have access to MS
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
Author: eugenezelenko
Date: Wed Oct 21 13:46:17 2015
New Revision: 250925
URL: http://llvm.org/viewvc/llvm-project?rev=250925&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13951
Mo
Author: eugenezelenko
Date: Wed Oct 21 15:03:58 2015
New Revision: 250937
URL: http://llvm.org/viewvc/llvm-project?rev=250937&view=rev
Log:
Revert r250925 in source/Plugins/OperatingSystem/Go to fix MSVC builds failures.
Modified:
lldb/trunk/source/Plugins/OperatingSystem/Go/OperatingSystemGo
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
Author: eugenezelenko
Date: Wed Oct 21 19:45:41 2015
New Revision: 250966
URL: http://llvm.org/viewvc/llvm-project?rev=250966&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in
source/Plugins/LanguageRuntime; other minor fixes.
Differential Revision: http://reviews.llv
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Looks like MSVC build failure didn't relate to my changes, since I didn't
remove lldb/Ex
Author: eugenezelenko
Date: Thu Oct 22 12:01:20 2015
New Revision: 251031
URL: http://llvm.org/viewvc/llvm-project?rev=251031&view=rev
Log:
Attempt to fix MSVC builds after rL250966.
Differential Revision: http://reviews.llvm.org/D13968
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/Ob
Author: eugenezelenko
Date: Thu Oct 22 14:59:21 2015
New Revision: 251054
URL: http://llvm.org/viewvc/llvm-project?rev=251054&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in
include/lldb/Interpreter and Host; other minor fixes.
Differential Revision: http://reviews.
Author: eugenezelenko
Date: Thu Oct 22 16:24:37 2015
New Revision: 251066
URL: http://llvm.org/viewvc/llvm-project?rev=251066&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in include/lldb/Disassembler and
OperatingSystem; other minor fixes.
Second attempt which should work for MSV
Author: eugenezelenko
Date: Fri Oct 23 11:56:07 2015
New Revision: 251119
URL: http://llvm.org/viewvc/llvm-project?rev=251119&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in
source/Plugins/ObjectContainer and ObjectFile; other minor fixes.
Modified:
lldb/trunk/source/Plugins
Author: eugenezelenko
Date: Fri Oct 23 13:39:37 2015
New Revision: 251134
URL: http://llvm.org/viewvc/llvm-project?rev=251134&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in source/Target; other minor
fixes.
Modified:
lldb/trunk/source/Target/LanguageRuntime.cpp
lldb/trun
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is new Clang-tidy check which I run through LLDB code base, so I think
will be good idea to
Author: eugenezelenko
Date: Fri Oct 23 19:20:14 2015
New Revision: 251162
URL: http://llvm.org/viewvc/llvm-project?rev=251162&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/Interpreter;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D14025
Modifie
Author: eugenezelenko
Date: Fri Oct 23 20:08:35 2015
New Revision: 251167
URL: http://llvm.org/viewvc/llvm-project?rev=251167&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins;
other minor fixes.
Modified:
lldb/trunk/source/Plugins/MemoryHistory/asa
Author: eugenezelenko
Date: Fri Oct 23 20:28:05 2015
New Revision: 251170
URL: http://llvm.org/viewvc/llvm-project?rev=251170&view=rev
Log:
Revert r251167 in source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp to fix
MSVC builds failures.
Modified:
lldb/trunk/source/Plugins/Process/gdb-re
Author: eugenezelenko
Date: Mon Oct 26 12:00:13 2015
New Revision: 251309
URL: http://llvm.org/viewvc/llvm-project?rev=251309&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source; other
minor fixes.
Modified:
lldb/trunk/source/Core/IOHandler.cpp
lldb/trunk
Author: eugenezelenko
Date: Mon Oct 26 19:45:06 2015
New Revision: 251374
URL: http://llvm.org/viewvc/llvm-project?rev=251374&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in
source/Plugins/LanguageRuntime and Platform; other minor fixes.
Modified:
lldb/trunk/source/Plugins/L
Author: eugenezelenko
Date: Tue Oct 27 12:20:33 2015
New Revision: 251416
URL: http://llvm.org/viewvc/llvm-project?rev=251416&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/DataFormatters,
Breakpoint and Utility; other minor fixes.
Modified:
lldb/trunk/include/ll
Author: eugenezelenko
Date: Tue Oct 27 19:18:41 2015
New Revision: 251470
URL: http://llvm.org/viewvc/llvm-project?rev=251470&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in
include/lldb/Core; other minor fixes.
Modified:
lldb/trunk/include/lldb/Core/Address.h
Author: eugenezelenko
Date: Wed Oct 28 15:53:04 2015
New Revision: 251556
URL: http://llvm.org/viewvc/llvm-project?rev=251556&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in
include/lldb/Core; other minor fixes.
Modified:
lldb/trunk/include/lldb/Core/ModuleSpec.h
Author: eugenezelenko
Date: Wed Oct 28 17:11:25 2015
New Revision: 251561
URL: http://llvm.org/viewvc/llvm-project?rev=251561&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in remaining files in
include/lldb/Core; other minor fixes.
Modified:
lldb/trunk/include/lldb/Core/STLUtil
Author: eugenezelenko
Date: Wed Oct 28 19:27:24 2015
New Revision: 251587
URL: http://llvm.org/viewvc/llvm-project?rev=251587&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/Expression and
Host; other minor fixes.
Modified:
lldb/trunk/include/lldb/Expression/Expre
Author: eugenezelenko
Date: Thu Oct 29 15:12:40 2015
New Revision: 251647
URL: http://llvm.org/viewvc/llvm-project?rev=251647&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in
include/lldb/Target; other minor fixes.
Modified:
lldb/trunk/include/lldb/Target/Process.
Author: eugenezelenko
Date: Thu Oct 29 15:33:47 2015
New Revision: 251648
URL: http://llvm.org/viewvc/llvm-project?rev=251648&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in remaining files in
include/lldb/Target; other minor fixes.
Modified:
lldb/trunk/include/lldb/Target/Exe
Author: eugenezelenko
Date: Thu Oct 29 19:04:20 2015
New Revision: 251673
URL: http://llvm.org/viewvc/llvm-project?rev=251673&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/Symbol; other
minor fixes.
Modified:
lldb/trunk/include/lldb/Symbol/Block.h
lldb/trunk
Author: eugenezelenko
Date: Fri Oct 30 13:50:12 2015
New Revision: 251716
URL: http://llvm.org/viewvc/llvm-project?rev=251716&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in source/Breakpoint; other minor
fixes.
Modified:
lldb/trunk/source/Breakpoint/Breakpoint.cpp
lldb/tr
Author: eugenezelenko
Date: Fri Oct 30 19:43:59 2015
New Revision: 251730
URL: http://llvm.org/viewvc/llvm-project?rev=251730&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in include/lldb/Expression,
source/Expression and tools/lldb-mi; other minor fixes.
Modified:
lldb/trunk/
Author: eugenezelenko
Date: Fri Oct 30 20:22:59 2015
New Revision: 251733
URL: http://llvm.org/viewvc/llvm-project?rev=251733&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/API and
source/API; other minor fixes.
Other fixes should reduce number of readability-redunda
Author: eugenezelenko
Date: Fri Nov 6 18:28:50 2015
New Revision: 252374
URL: http://llvm.org/viewvc/llvm-project?rev=252374&view=rev
Log:
Fix some Clang-tidy warnings and formatting in recently added code.
Fixed Clang-tidy warnings:
* modernize-use-override;
* modernize-use-nullptr;
* moderniz
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please also run Clang-tidy modernize checks.
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:895
@@ +894,3 @@
+
+
+void
Unnecessary line.
==
Eugene.Zelenko added a comment.
I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
llvm-config from build directory. I'm not sure how well find_program will work
if path to /bin will be not added to PATH, so probably will be
good idea to allow LLVM_CONFIG to be set in Cmake co
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#298830, @krytarowski wrote:
> In http://reviews.llvm.org/D15067#298701, @Eugene.Zelenko wrote:
>
> > I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
> > llvm-config from build directory. I'm not sure how well
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#299220, @labath wrote:
> In http://reviews.llvm.org/D15067#298902, @Eugene.Zelenko wrote:
>
> > But it's necessary to pass path from CMake command line argument to
> > find_program after PATHS. Another problem if default OS locati
Author: eugenezelenko
Date: Fri Dec 11 13:52:15 2015
New Revision: 255364
URL: http://llvm.org/viewvc/llvm-project?rev=255364&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr
warnings in source/Target/Target.cpp.
Simplify smart pointers checks in condition
+BreakpointResolverSP resolver_sp(new
> BreakpointResolverFileLine(nullptr,
>
> (see the removal of the space after BreakpointResolverFileLine from the
> clang-tidy settings I presume).
>
> Did I misunderstand that?
>
> -Todd
>
> On Fri, Dec 11, 2015 at 11:52 AM
At least clang-format should be applied to all newly added files before commit.
Eugene.
On Fri, Dec 11, 2015 at 2:30 PM, Zachary Turner wrote:
> Back on the topic of clang-format, what would it take to make clang-format a
> regular part of peoples' workflows?
>
> On Fri, Dec 11, 2015 at 2:27 PM
Yes, it's in the .clang-format at LLDB source root.
Eugene.
On Fri, Dec 11, 2015 at 2:37 PM, Todd Fiala wrote:
> Okay, but does the format match the LLDB-modified format with some kind of
> configuration file? We still need to match our guidelines here:
>
> http://lldb.llvm.org/lldb-coding-conv
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: zturner, labath.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
There were unresolved symbols related to coverage.
Repository:
rL LLVM
http://reviews.llvm.org
Eugene.Zelenko added a comment.
Undefined symbols were used in clang::CodeGen::CoverageMappingGen.
Repository:
rL LLVM
http://reviews.llvm.org/D19991
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: eugenezelenko
Date: Fri May 6 12:03:09 2016
New Revision: 268750
URL: http://llvm.org/viewvc/llvm-project?rev=268750&view=rev
Log:
Fix standalone build on RHEL6.
Differential revision: http://reviews.llvm.org/D19991
Modified:
lldb/trunk/cmake/LLDBDependencies.cmake
Modified: lldb/t
Eugene.Zelenko added a comment.
I would like to see implemented my comment about LLVM_CONFIG and find_program().
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#427834, @krytarowski wrote:
> In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote:
>
> > I would like to see implemented my comment about LLVM_CONFIG and
> > find_program().
>
>
> Could you first push this to clang? I
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#428146, @krytarowski wrote:
> @Eugene.Zelenko do you agree with this patch and what @labath wrote?
If CMake works that way, it's what I need :-)
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
Eugene.Zelenko abandoned this revision.
Eugene.Zelenko added a comment.
Obsoleted by http://reviews.llvm.org/D20344.
Repository:
rL LLVM
http://reviews.llvm.org/D18018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, krytarowski, zturner.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Patch also includes fix for CMake 2.8.12.2, see D18018.
Repository:
rL LLVM
http:
Eugene.Zelenko updated this revision to Diff 57648.
Eugene.Zelenko added a comment.
Add comments per Pavel suggestion.
Repository:
rL LLVM
http://reviews.llvm.org/D20344
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalone.cmake
===
Author: eugenezelenko
Date: Wed May 18 17:50:08 2016
New Revision: 269996
URL: http://llvm.org/viewvc/llvm-project?rev=269996&view=rev
Log:
Fix standalone LLDB build, when LLVM/Clang were built with
LLVM_INSTALL_TOOLCHAIN_ONLY=ON.
Fix standalone build with CMake 2.8.12.2.
Differential revision:
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
This change broke standalone build. Looks like check which should set
HAVE_CXX_ATOMICS64_WITHOUT_LIB was not performed.
I build LLDB with LLVM STL which doesn't have libatomic.
Repository:
rL LLVM
http://rev
Eugene.Zelenko added a comment.
I see HAVE_CXX_ATOMICS64_WITHOUT_LIB messages during LLVM Cmake run, but I
don't see such message during LLDB CMake run.
Is this value is supposed to be read form LLVM CMake cache?
Repository:
rL LLVM
http://reviews.llvm.org/D20464
Eugene.Zelenko added a comment.
I run CMake with --trace and is mentioned only in condition added there.
Repository:
rL LLVM
http://reviews.llvm.org/D20464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Eugene.Zelenko added a comment.
As fas as I could judge from log, you built LLDB with LLVM/Clang. But problem
happens when it's necessary to build LLDB separately from LLVM/Clang
(standalone build).
Repository:
rL LLVM
http://reviews.llvm.org/D20464
__
Eugene.Zelenko added a comment.
> Then we need to introduce a 64 bit atomic check in
> cmake/modules/LLDBStandalone.cmake. What do you think?
>
> Thanks
I think this should be right solution.
Repository:
rL LLVM
http://reviews.llvm.org/D20464
_
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Comment at: include/lldb/Host/Editline.h:289
@@ +288,3 @@
+unsigned char
+EndOrAddLineCommand (int ch);
+
Will be good idea to not add space between name and arguments list in new code.
Same for o
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, zturner, nitesh.jain.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This patch include two fixes:
* include CheckAtomic to set HAVE_CXX_ATOMICS64_WITHOU
Eugene.Zelenko updated this revision to Diff 64000.
Eugene.Zelenko added a comment.
Improved description, but in generic terms, since two files are needed.
Repository:
rL LLVM
https://reviews.llvm.org/D22322
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalone.cma
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r275482.
Please mention URL of Differential revision to close it automatically after
commit.
https://reviews.llvm.org/D22284
___
lldb-commits mailing list
lldb-commi
Eugene.Zelenko added a comment.
Sorry, forgot to add "[revision] in commit summary".
https://reviews.llvm.org/D22284
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: eugenezelenko
Date: Fri Jul 15 17:46:15 2016
New Revision: 275641
URL: http://llvm.org/viewvc/llvm-project?rev=275641&view=rev
Log:
Fixes for standalone build:
* include CheckAtomic to set HAVE_CXX_ATOMICS64_WITHOUT_LIB properly
(introduced in r274121)
* hint Clang CMake files for LLVM C
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
I think will be good idea to try to commit these changes before 3.9 branching.
Repository:
rL LLVM
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
ll
Eugene.Zelenko added a comment.
I think will be better to use LLVM_MAIN_SRC_DIR.
https://reviews.llvm.org/D23881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please rebase code on trunk and run Clang-format.
https://reviews.llvm.org/D24251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Eugene.Zelenko added inline comments.
Comment at: source/API/SBSection.cpp:257
@@ +256,3 @@
+SectionSP section_sp(GetSP());
+if (section_sp.get())
+return section_sp->GetPermissions();
You don't need to use get(), because smart pointers have
http:
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, zturner.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Looks like RegisterContextNetBSD_x86_64.cpp should use RegisterInfos_x86_64.h
as much as possible
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please rebase from trunk and run Clang-format.
Repository:
rL LLVM
https://reviews.llvm.org/D22831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r280283.
https://reviews.llvm.org/D23948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r280283.
https://reviews.llvm.org/D23950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r280283.
https://reviews.llvm.org/D23951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r280283.
https://reviews.llvm.org/D23952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
1 - 100 of 178 matches
Mail list logo
