[Lldb-commits] [RFC] Type lookup for template types is broken...

(...At least when using accelerator tables) If you apply the following patch, TestClassTemplateParameterPack.py will start failing: diff --git a/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp

Re: [Lldb-commits] [lldb] r331049 - Always normalize FileSpec paths.

> On Apr 27, 2018, at 11:17 AM, Jim Ingham via lldb-commits > wrote: > > Greg, > > Your new FileSpecTest unit tests are failing in the Xcode build of lldb, e.g.: > >

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

;>> our name lookup works, but from what I managed to learn so far, adding >> an >>> accelerator for "C" seems like a useful thing to do. However, this does >> go >>> beyond what the DWARF 5 spec says we should do (we are only required to >> add &

Re: [Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

> On May 8, 2018, at 1:32 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > One could probably concoct an example (using macros, token pasting and such) > where this would get it wrong, but that's probably not worth supporting. Yeah, I

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

ently add one for "C<12, 16>”? Yes we do, not sure it is actually useful. Fred > > Greg > >> On May 8, 2018, at 8:58 AM, Frédéric Riss via lldb-commits >> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: >> >>

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

> On Jun 21, 2018, at 3:18 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > I am not sure this will actually solve the problems you are seeing. This may > avoid corrupting the internal DenseMap data structures, but it will not make > the algorithm using them

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

> On Jun 21, 2018, at 8:03 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D48393#1139270, @clayborg wrote: > >> In https://reviews.llvm.org/D48393#1138989, @labath wrote: >> >>> I am not sure this will actually solve the problems you

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits > wrote: > > Author: davide > Date: Mon Mar 12 18:40:00 2018 > New Revision: 327356 > > URL: http://llvm.org/viewvc/llvm-project?rev=327356=rev > Log: > [ExpressionParser] Fix crash when evaluating

Re: [Lldb-commits] [lldb] r330066 - [debugserver] Remove dead function call. NFCI.

> On Apr 13, 2018, at 1:47 PM, Davide Italiano via lldb-commits > wrote: > > Author: davide > Date: Fri Apr 13 13:47:25 2018 > New Revision: 330066 > > URL: http://llvm.org/viewvc/llvm-project?rev=330066=rev > Log: > [debugserver] Remove dead function call. NFCI.

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 4:40 PM, Vedant Kumar wrote: > > > >> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator >> wrote: >> >> stella.stamenova added a comment. >> >> In https://reviews.llvm.org/D50478#1262717, @vsk wrote: >> >>> In https://reviews.llvm.org/D50478#1262710,

Re: [Lldb-commits] [PATCH] D61044: Fix infinite recursion when calling C++ template functions

> On Apr 23, 2019, at 3:48 PM, Frederic Riss via Phabricator > wrote: > > friss created this revision. > friss added reviewers: shafik, clayborg, jingham. > Herald added subscribers: kristof.beyls, javed.absar, aprantl. > > When we encounter a templated function in the debug information, we

Re: [Lldb-commits] [lldb] r370848 - [lldb][NFC] Add a simple test for thread_local storage.

> On Sep 4, 2019, at 1:02 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Wed Sep 4 01:02:52 2019 > New Revision: 370848 > > URL: http://llvm.org/viewvc/llvm-project?rev=370848=rev > Log: > [lldb][NFC] Add a simple test for thread_local storage. > > Seems we

Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

I think it would be better to stick the equivalent of skipIfRemote in the Expect base class. > On Dec 10, 2019, at 3:15 PM, Jason Molenda via lldb-commits > wrote: > > > Author: Jason Molenda > Date: 2019-12-10T15:15:25-08:00 > New Revision: b0937be06e44c0cdc1c1aac16b76746150e70154 > > URL:

Re: [Lldb-commits] [lldb] r374335 - [lldb] Make sure import-std-module/sysroot actually passes for the right reasons

> On Oct 10, 2019, at 5:57 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Thu Oct 10 05:57:14 2019 > New Revision: 374335 > > URL: http://llvm.org/viewvc/llvm-project?rev=374335=rev > Log: > [lldb] Make sure import-std-module/sysroot actually passes for the right

Re: [Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

Taking a look > On Oct 8, 2019, at 9:47 AM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > It looks like this broke one of the tests on the Windows LLDB bot: > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9628/steps/test/logs/stdio >

Re: [Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

So I should see this on my machine, but I don’t... > On Oct 8, 2019, at 10:06 AM, Shafik Yaghmour via Phabricator > wrote: > > shafik added a comment. > > See the same break on green dragon as well: >

Re: [Lldb-commits] [lldb] 6990eaf - [lldb/Test] Skip VSCode test on embedded Darwin

> On Feb 19, 2020, at 5:44 PM, Davide Italiano via lldb-commits > wrote: > > > >> On Feb 19, 2020, at 17:34, Jonas Devlieghere via lldb-commits >> wrote: >> >> >> Author: Jonas Devlieghere >> Date: 2020-02-19T17:34:01-08:00 >> New Revision: 6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4 >>

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

The new testing for “inherit-env=false” is failing on Windows. I skipped the test for now. Could it be that it never worked there? (In which case XFail would be a better resolution) Does anyone have easy access to a Windows build to try it out? Thanks, Fred > On Mar 23, 2020, at 7:59 AM, Fred

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

r 24, 2020 at 7:00 AM Pavel Labath <mailto:pa...@labath.sk>> wrote: > On 23/03/2020 17:17, Frédéric Riss via lldb-commits wrote: > > The new testing for “inherit-env=false” is failing on Windows. I skipped > > the test for now. > > > > Could it be that it n