[Lldb-commits] [lldb] r245261 - Remove unintentional ;'s.

2015-08-17 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Aug 17 19:21:24 2015 New Revision: 245261 URL: http://llvm.org/viewvc/llvm-project?rev=245261view=rev Log: Remove unintentional ;'s. Modified: lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp Modified:

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-18 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me. http://reviews.llvm.org/D11947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r245645 - The llvm Triple for an armv6m now comes back as llvm::Triple::thumb.

2015-08-20 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Aug 20 19:13:37 2015 New Revision: 245645 URL: http://llvm.org/viewvc/llvm-project?rev=245645view=rev Log: The llvm Triple for an armv6m now comes back as llvm::Triple::thumb. This was breaking disassembly for arm machines that we force to be thumb mode all the time

[Lldb-commits] [lldb] r245536 - When the target definition is unparseable, print an error message

2015-08-19 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Aug 19 22:05:09 2015 New Revision: 245536 URL: http://llvm.org/viewvc/llvm-project?rev=245536view=rev Log: When the target definition is unparseable, print an error message to the user. e.g. specified via the plugin.process.gdb-remote.target-definition-file setting.

[Lldb-commits] [lldb] r245537 - If the filename specified by plugin.process.gdb-remote.target-definition-file,

2015-08-19 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Aug 19 23:29:46 2015 New Revision: 245537 URL: http://llvm.org/viewvc/llvm-project?rev=245537view=rev Log: If the filename specified by plugin.process.gdb-remote.target-definition-file, doesn't exist, see if it needs tilde expansion before we ignore it completely.

[Lldb-commits] [lldb] r244436 - Feedback from Jim: Change the optimized code warning to be entirely

2015-08-10 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Aug 10 02:55:25 2015 New Revision: 244436 URL: http://llvm.org/viewvc/llvm-project?rev=244436view=rev Log: Feedback from Jim: Change the optimized code warning to be entirely contained within Process so that we won't be duplicating the warning message if other parts of

[Lldb-commits] [lldb] r250981 - Move the launch-as-root xpc service from lldb to xcode, to

2015-10-21 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Oct 21 23:17:26 2015 New Revision: 250981 URL: http://llvm.org/viewvc/llvm-project?rev=250981=rev Log: Move the launch-as-root xpc service from lldb to xcode, to make it easier to run hand-built lldb roots and retain those entitlements. This is currently only used by

[Lldb-commits] [lldb] r251086 - Fix one more place where we were using the old

2015-10-22 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Oct 22 19:59:31 2015 New Revision: 251086 URL: http://llvm.org/viewvc/llvm-project?rev=251086=rev Log: Fix one more place where we were using the old name of the xpc service. Modified: lldb/trunk/source/Host/macosx/Host.mm Modified:

Re: [Lldb-commits] [PATCH] D14036: [debugserver] Fix OSX build for older XCode versions after r251091.

2015-10-23 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks, I was trying to spot problems like this but missed this one. Repository: rL LLVM http://reviews.llvm.org/D14036 ___

Re: [Lldb-commits] [lldb] r251091 - Upstreaming the apple internal changes that accumulated during the

2015-10-23 Thread Jason Molenda via lldb-commits
b.llvm.org: > > http://lab.llvm.org:8080/green/job/lldb_build_test/13571/consoleFull#131781548749ba4694-19c4-4d7e-bec5-911270d8a58c > > -- adrian > >> On Oct 22, 2015, at 7:49 PM, Jason Molenda via lldb-commits >> <lldb-commits@lists.llvm.org> wrote: >> >>

[Lldb-commits] [lldb] r251092 - Remove some tabs that snuck into debugserver-entitlements.plist, etc.

2015-10-22 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Oct 22 21:54:21 2015 New Revision: 251092 URL: http://llvm.org/viewvc/llvm-project?rev=251092=rev Log: Remove some tabs that snuck into debugserver-entitlements.plist, etc. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp

[Lldb-commits] [lldb] r250979 - Change ModuleList::GetSharedModule so that it will reject "stub

2015-10-21 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Oct 21 22:50:28 2015 New Revision: 250979 URL: http://llvm.org/viewvc/llvm-project?rev=250979=rev Log: Change ModuleList::GetSharedModule so that it will reject "stub libraries" altogether. On Mac/iOS, these are libraries which have a UUID and nlist records but no text

[Lldb-commits] [lldb] r251578 - Initialize data_len to 0 in source/Plugins/Platform/Android/AdbClient.cpp

2015-10-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Oct 28 18:23:44 2015 New Revision: 251578 URL: http://llvm.org/viewvc/llvm-project?rev=251578=rev Log: Initialize data_len to 0 in source/Plugins/Platform/Android/AdbClient.cpp Modified: lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp Modified:

[Lldb-commits] [lldb] r251583 - Fix potential null deref; after SymbolContextSpecifier::SymbolContextMatches

2015-10-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Oct 28 18:49:55 2015 New Revision: 251583 URL: http://llvm.org/viewvc/llvm-project?rev=251583=rev Log: Fix potential null deref; after SymbolContextSpecifier::SymbolContextMatches has tested that sc.function is null, it would try to deref sc.function. It should be

[Lldb-commits] [lldb] r251585 - Explicitly cast size_t var to (uint64_t) when printf format is PRIx64.

2015-10-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Oct 28 19:13:42 2015 New Revision: 251585 URL: http://llvm.org/viewvc/llvm-project?rev=251585=rev Log: Explicitly cast size_t var to (uint64_t) when printf format is PRIx64. Modified:

[Lldb-commits] [lldb] r251586 - Xcode suggested enabling a "no common blocks" warning

2015-10-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Oct 28 19:21:14 2015 New Revision: 251586 URL: http://llvm.org/viewvc/llvm-project?rev=251586=rev Log: Xcode suggested enabling a "no common blocks" warning (whatever that is) and wanted to clean up some duplicated entries in the project files. Modified:

[Lldb-commits] [lldb] r251584 - Static analyzer noticed that a null get_pending_items_caller could

2015-10-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Oct 28 19:08:03 2015 New Revision: 251584 URL: http://llvm.org/viewvc/llvm-project?rev=251584=rev Log: Static analyzer noticed that a null get_pending_items_caller could be used. Guard against that. Modified:

[Lldb-commits] [lldb] r252588 - Add support for tvos and watchos to ObjectFileMachO.

2015-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Nov 9 23:21:54 2015 New Revision: 252588 URL: http://llvm.org/viewvc/llvm-project?rev=252588=rev Log: Add support for tvos and watchos to ObjectFileMachO. Add support for the new dyld shared cache format on ios etc devices. Small changes for classifying ObjC metadata

[Lldb-commits] [lldb] r252581 - The MacOSXi386 ABI should be used for watchos simulator debug sessions.

2015-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Nov 9 21:21:59 2015 New Revision: 252581 URL: http://llvm.org/viewvc/llvm-project?rev=252581=rev Log: The MacOSXi386 ABI should be used for watchos simulator debug sessions. Also, add an async error message if the dyld solib loaded callback function can't find an ABI

Re: [Lldb-commits] [PATCH] D14226: Fix to solve Bug 23139 & Bug 23560

2015-11-11 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Hi Abhishek, I apologize for the long delay in reviewing this one, I needed to find a solid 30-45 minute block to review the changes and the current state of the unwinder code

[Lldb-commits] [lldb] r252998 - Add PythonExceptionState.cppto the xocde project file.

2015-11-12 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 12 19:43:49 2015 New Revision: 252998 URL: http://llvm.org/viewvc/llvm-project?rev=252998=rev Log: Add PythonExceptionState.cppto the xocde project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r253004 - Add PythonTestSuite.cpp to project file for lldb-gtest.

2015-11-12 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 12 20:02:30 2015 New Revision: 253004 URL: http://llvm.org/viewvc/llvm-project?rev=253004=rev Log: Add PythonTestSuite.cpp to project file for lldb-gtest. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r252583 - The other half of a change made by Enrico for trying to get a correct

2015-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Nov 9 22:11:37 2015 New Revision: 252583 URL: http://llvm.org/viewvc/llvm-project?rev=252583=rev Log: The other half of a change made by Enrico for trying to get a correct triple for a process. He writes, "Changes to the way setting the triple works on a target so

[Lldb-commits] [lldb] r252584 - Upstream a small change from Greg Clayton for the REPL support:

2015-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Nov 9 22:18:12 2015 New Revision: 252584 URL: http://llvm.org/viewvc/llvm-project?rev=252584=rev Log: Upstream a small change from Greg Clayton for the REPL support: "Modify internal breakpoints so they resolve just like external breakpoints do. This allow you to set

Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.

2015-11-04 Thread Jason Molenda via lldb-commits
You're making a valid point. I was only noting that this is not the first instance where've conditionally compiled mac platform files. J > On Nov 4, 2015, at 6:00 PM, Jim Ingham wrote: > > Why? > > Jim > >> On Nov 4, 2015, at 5:43 PM, Jason Molenda

Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.

2015-11-04 Thread Jason Molenda via lldb-commits
We do the same thing in other MacOSX platform files where they depend on Apple specific libraries. > On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits > wrote: > > Why are we trying to build this at all on Linux? Seems odd to build an empty > file rather

[Lldb-commits] [lldb] r252227 - Add support for the new (added last week) llvm::Triple::WatchOS and ::TvOS

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 17:03:44 2015 New Revision: 252227 URL: http://llvm.org/viewvc/llvm-project?rev=252227=rev Log: Add support for the new (added last week) llvm::Triple::WatchOS and ::TvOS in places where we check for Triple::IOS. They're mostly the same as far as lldb is

[Lldb-commits] [lldb] r252234 - Update for tvos or watchos builds.

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 17:42:18 2015 New Revision: 252234 URL: http://llvm.org/viewvc/llvm-project?rev=252234=rev Log: Update for tvos or watchos builds. Modified: lldb/trunk/scripts/package-clang-headers.py Modified: lldb/trunk/scripts/package-clang-headers.py URL:

[Lldb-commits] [lldb] r252239 - GDBRemoteCommunicationClient::SendEnvironmentPacket should use the hex-encoded

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 17:51:05 2015 New Revision: 252239 URL: http://llvm.org/viewvc/llvm-project?rev=252239=rev Log: GDBRemoteCommunicationClient::SendEnvironmentPacket should use the hex-encoded env packet if the '*' character used for run length encoding is present. Modified:

[Lldb-commits] [lldb] r252233 - One more debug-build assert that addr_size is

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 17:41:49 2015 New Revision: 252233 URL: http://llvm.org/viewvc/llvm-project?rev=252233=rev Log: One more debug-build assert that addr_size is a realistic value. Modified: lldb/trunk/include/lldb/Core/DataExtractor.h Modified:

[Lldb-commits] [lldb] r252228 - Add support for one API used to detect if a process

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 17:04:57 2015 New Revision: 252228 URL: http://llvm.org/viewvc/llvm-project?rev=252228=rev Log: Add support for one API used to detect if a process is running under System Integrity Protection on Mac OS X 10.11. The rootless_allows_task_for_pid() spi (see

[Lldb-commits] [lldb] r252235 - Update the invocation to dsymForUUID (a script plugin used

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 17:44:08 2015 New Revision: 252235 URL: http://llvm.org/viewvc/llvm-project?rev=252235=rev Log: Update the invocation to dsymForUUID (a script plugin used at Apple, called by the DebugSymbols private framework to find a dSYM for a UUID on mac) to include the

[Lldb-commits] [lldb] r252242 - Use Process::IsAlive instead of just checking for eStateExited.

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 17:54:29 2015 New Revision: 252242 URL: http://llvm.org/viewvc/llvm-project?rev=252242=rev Log: Use Process::IsAlive instead of just checking for eStateExited. Two minor tweaks to GetLoadedDynamicLibrariesInfos. Modified:

[Lldb-commits] [lldb] r252225 - Add support for the armv7k ABI which has some small

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 16:51:29 2015 New Revision: 252225 URL: http://llvm.org/viewvc/llvm-project?rev=252225=rev Log: Add support for the armv7k ABI which has some small changes from the normal armv7 ABI used on darwin. Modified:

[Lldb-commits] [lldb] r252245 - Add a warning to TargetList::CreateTargetInternal

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 17:59:30 2015 New Revision: 252245 URL: http://llvm.org/viewvc/llvm-project?rev=252245=rev Log: Add a warning to TargetList::CreateTargetInternal so when it is run on a kext (which won't activate any platform plugins), you'll get a warning message which may be

[Lldb-commits] [lldb] r252252 - Upstream a change to MemoryHistoryASan from Sean:

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 18:43:31 2015 New Revision: 252252 URL: http://llvm.org/viewvc/llvm-project?rev=252252=rev Log: Upstream a change to MemoryHistoryASan from Sean: Author: Sean Callanan Date: Tue Jun 23 13:52:24 2015 -0700 Memory history should not

[Lldb-commits] [lldb] r252254 - Jim thinks we shouldn't bother to pollute the svn repo with these

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 18:55:17 2015 New Revision: 252254 URL: http://llvm.org/viewvc/llvm-project?rev=252254=rev Log: Jim thinks we shouldn't bother to pollute the svn repo with these internal details, so I'll pull it back to just our own branch of the sources. Modified:

[Lldb-commits] [lldb] r252264 - A little more careful handling of platforms and unspecified unknown

2015-11-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 5 19:43:36 2015 New Revision: 252264 URL: http://llvm.org/viewvc/llvm-project?rev=252264=rev Log: A little more careful handling of platforms and unspecified unknown vendors & oses, especially on Apple, to handle the new environment where we have more than macosx

[Lldb-commits] [lldb] r250487 - I've been seeing a problem with xcodebuilds on macosx for

2015-10-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Oct 15 20:27:21 2015 New Revision: 250487 URL: http://llvm.org/viewvc/llvm-project?rev=250487=rev Log: I've been seeing a problem with xcodebuilds on macosx for a few days now where compiler-rt gets an error when trying to run its install step (related to not being able

[Lldb-commits] [lldb] r249755 - Re-commit the (fixed) changes from r248985 which were reverted by Pavel

2015-10-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Oct 8 16:48:35 2015 New Revision: 249755 URL: http://llvm.org/viewvc/llvm-project?rev=249755=rev Log: Re-commit the (fixed) changes from r248985 which were reverted by Pavel when they introduced android testsuite regressions. Pavel has run the testsuite against the

Re: [Lldb-commits] [PATCH] D13578: Allow generic arm ArchSpec to merge with specific arm ArchSpec; allow Cortex M0-7's to always force thumb mode

2015-10-09 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Hi Renato & Tamas, thanks for the feedback. I'm trying to rewrite IsAlwaysThumbInstructions() to use the information that llvm already has, as per Renato's suggestion. The MCSubtargetInfo has a getFeatureBits() method which can indicate ARM::FeatureNoARM. I'm

Re: [Lldb-commits] [PATCH] D12396: Fix lldb build on older OSX versions after svn commit r244716

2015-08-26 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good, thanks, I wasn't sure about whether this API would be available on older releases. Repository: rL LLVM http://reviews.llvm.org/D12396

[Lldb-commits] [lldb] r246530 - A few small comment fixups with terminology "gcc" -> "eh_frame", "gdb" -> "stabs".

2015-08-31 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Sep 1 00:17:01 2015 New Revision: 246530 URL: http://llvm.org/viewvc/llvm-project?rev=246530=rev Log: A few small comment fixups with terminology "gcc" -> "eh_frame", "gdb" -> "stabs". Just noticed these while reading through some code. Modified:

Re: [Lldb-commits] [PATCH] D12699: Change the looping stack detection code

2015-09-08 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I'm fine with this change. On x86, where the CALL instruction pushes the return address on the stack, you can't have two stack frames with the CFA. If we have a loop, I don't

[Lldb-commits] [lldb] r247120 - A change I'm open to reverting if there is disagreement:

2015-09-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Sep 8 22:24:52 2015 New Revision: 247120 URL: http://llvm.org/viewvc/llvm-project?rev=247120=rev Log: A change I'm open to reverting if there is disagreement: When lldb receives a gdb-remote protocol packet that has nonprintable characters, it will print the packet in

[Lldb-commits] [lldb] r247121 - When lldb gets the register definitions from the response of a

2015-09-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Sep 8 22:36:24 2015 New Revision: 247121 URL: http://llvm.org/viewvc/llvm-project?rev=247121=rev Log: When lldb gets the register definitions from the response of a qXfer:features:read:target.xml packet, or via the plugin.process.gdb-remote.target-definition-file

Re: [Lldb-commits] [lldb] r245645 - The llvm Triple for an armv6m now comes back as llvm::Triple::thumb.

2015-09-02 Thread Jason Molenda via lldb-commits
ix as > http://llvm.org/viewvc/llvm-project?rev=246649=rev but please check that > it don't break the original functionality you tried to implement. > > Thanks, > Tamas > > On Fri, Aug 21, 2015 at 1:14 AM Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org>

[Lldb-commits] [lldb] r246834 - Change the (internal to this file only) enum names from gcc_ to

2015-09-03 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Sep 3 22:40:29 2015 New Revision: 246834 URL: http://llvm.org/viewvc/llvm-project?rev=246834=rev Log: Change the (internal to this file only) enum names from gcc_ to ehframe_ & from gdb_ to stabs_ for clarity. Also document the fact that i386 eh_frame on Darwin has

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

2015-09-15 Thread Jason Molenda via lldb-commits
jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. Maybe I'm an outlier here -- but I don't think we should show assembly code, unless specifically requested by the user, when we can't find a source file (but we have source-level debug information). lldb used to

[Lldb-commits] [lldb] r247751 - A partner to the cleanup in r247741, change the variables names in

2015-09-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Sep 15 18:49:57 2015 New Revision: 247751 URL: http://llvm.org/viewvc/llvm-project?rev=247751=rev Log: A partner to the cleanup in r247741, change the variables names in debugserver to match. "gcc" is now "ehframe" and "gdb" is now "debugserver". Because this is

Re: [Lldb-commits] [PATCH] D12791: Complete register kind naming cleanups in lldb -- required touching all register table definitions

2015-09-15 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Ah, those failures were due to Index: gdbremote_testcase.py - gdbremote_testcase.py (revision 247726) +++ gdbremote_testcase.py (working copy) @@ -548,7 +548,7 @@ "encoding", "format", "set", - "gcc", +"ehframe",

Re: [Lldb-commits] [PATCH] D13245: Add support for .ARM.exidx unwind information

2015-09-29 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D13245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13245: Add support for .ARM.exidx unwind information

2015-09-29 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Looks good to me, I don't have anything beyond Pavel's suggestions. I don't know the format of the ARM .exidx .extab unwind info so I don't have any feedback on the parsing of that. I forgot about that code in RegisterContextLLDB::GetFullUnwindPlanForFrame() for

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-30 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. I see, this seems reasonable to me. Repository: rL LLVM http://reviews.llvm.org/D13241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Jason Molenda via lldb-commits
jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. Greg's out this week, he or Jim may want to comment. I was curious about this method IncrementFalseAlarmsAndReviseHitCount, there weren't any calls to it. A little digging shows that the one use of it was removed in

Re: [Lldb-commits] [lldb] r248985 - Fixing a subtle issue on Mac OS X systems with dSYMs (possibly

2015-10-01 Thread Jason Molenda via lldb-commits
gt;>>> exactly the way you need it and just call the one native code method you >>>>> want to test, and verify the outputs. You could make up your own >>>>> ModuleSpec, you could make a mock implementation of `Symbols` that >>>>> delegates

[Lldb-commits] [lldb] r248985 - Fixing a subtle issue on Mac OS X systems with dSYMs (possibly

2015-09-30 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Oct 1 00:37:22 2015 New Revision: 248985 URL: http://llvm.org/viewvc/llvm-project?rev=248985=rev Log: Fixing a subtle issue on Mac OS X systems with dSYMs (possibly introduced by r235737 but I didn't look into it too closely). A dSYM can have a per-UUID plist in it

Re: [Lldb-commits] [lldb] r248985 - Fixing a subtle issue on Mac OS X systems with dSYMs (possibly

2015-10-01 Thread Jason Molenda via lldb-commits
priority for me to push it strongly, but if you think it > would be useful I'm happy to help you figure out how to run them and/or write > a new one. > > On Wed, Sep 30, 2015 at 10:39 PM Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > Author: j

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-26 Thread Jason Molenda via lldb-commits
jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. NB: Greg is out for the next nine days, Enrico for the next five days. http://reviews.llvm.org/D13058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248755 - Remove one of the three spaces after a period in one of the breakpoint

2015-09-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Sep 28 18:02:00 2015 New Revision: 248755 URL: http://llvm.org/viewvc/llvm-project?rev=248755=rev Log: Remove one of the three spaces after a period in one of the breakpoint set help messages. Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp

[Lldb-commits] [lldb] r248343 - A small fixup needed for debugserver to work natively

2015-09-22 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Sep 22 18:25:44 2015 New Revision: 248343 URL: http://llvm.org/viewvc/llvm-project?rev=248343=rev Log: A small fixup needed for debugserver to work natively on iOS devices; fallout from Vince's cleanups made in r237218 back in May. iOS native lldbs will call

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2015-12-02 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Interesting. The routine is 0xf7fd9d70 <+0>: pushl %ecx 0xf7fd9d71 <+1>: pushl %edx 0xf7fd9d72 <+2>: pushl %ebp 0xf7fd9d73 <+3>: movl %esp, %ebp 0xf7fd9d75 <+5>: sysenter [...] 0xf7fd9d7e <+14>: int$0x80 --> 0xf7fd9d80 <+16>: popl %ebp

[Lldb-commits] [lldb] r255093 - Add some additional safety checks to the StructuredData access

2015-12-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Dec 8 22:15:47 2015 New Revision: 255093 URL: http://llvm.org/viewvc/llvm-project?rev=255093=rev Log: Add some additional safety checks to the StructuredData access methods - lldb can still crash pretty easily on corrupt JSON text, and these will help eliminate a bunch

[Lldb-commits] [lldb] r254698 - Add a space char so step logging doesn't print things like

2015-12-03 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Dec 3 20:52:49 2015 New Revision: 254698 URL: http://llvm.org/viewvc/llvm-project?rev=254698=rev Log: Add a space char so step logging doesn't print things like "Stepping out from a.out`bar at a.c:3returning to frame" Modified:

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2015-12-01 Thread Jason Molenda via lldb-commits
Hi Ravitheja, thanks for the logging output. It does look like the assembly profiling is failing for some reason, and with your patch we fall back to using the eh_frame instructions and it succeeds. I'll look at the patch closely tomorrow (I meant to do it tonight but I'm running out of time

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2015-12-01 Thread Jason Molenda via lldb-commits
jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. Hi Ravitheja, thanks for the logging output. It does look like the assembly profiling is failing for some reason, and with your patch we fall back to using the eh_frame instructions and it succeeds. I'll look at the

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2015-12-01 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Just to be clear - the change your proposing may be a good improvement for falling back to another unwind plan when the initial unwind plan fails. But I'm curious why the initial unwind plan (assembly) failed here to begin with. I think lldb should have profiled

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

2015-12-11 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Thanks Jim, I'll fix those issues. With line 0's, I think there are three scenarios of interest (none of this contradicts what you wrote, I'm just spelling it out for myself): 1 We are stepping over a source line and we find a line 0. We want to include that

[Lldb-commits] [lldb] r255590 - When constructing an address range to "step" or "next" through,

2015-12-14 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Dec 14 18:40:30 2015 New Revision: 255590 URL: http://llvm.org/viewvc/llvm-project?rev=255590=rev Log: When constructing an address range to "step" or "next" through, find the largest address range (possibly combining multiple LineEntry's for this line number) that is

[Lldb-commits] [lldb] r255417 - When supplying memory to expedite the unwinds in the T packet,

2015-12-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Dec 11 19:32:09 2015 New Revision: 255417 URL: http://llvm.org/viewvc/llvm-project?rev=255417=rev Log: When supplying memory to expedite the unwinds in the T packet, include two stack frames worth of unwind information instead of just one -- the unwinder is trying to

[Lldb-commits] [lldb] r255421 - Fix the L1 cache search in MemoryCache::Read to use the

2015-12-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Dec 11 21:06:10 2015 New Revision: 255421 URL: http://llvm.org/viewvc/llvm-project?rev=255421=rev Log: Fix the L1 cache search in MemoryCache::Read to use the stl upper_bound method instead of lower_bound - we were failing to find some cached data in the L1 cache

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

2015-12-11 Thread Jason Molenda via lldb-commits
jasonmolenda removed rL LLVM as the repository for this revision. jasonmolenda updated this revision to Diff 42630. jasonmolenda added a comment. Updated patch attached which addresses Jim's feedback. 1. Updated LineEntry.h description of new GetSameLineContiguousAddressRange method to describe

[Lldb-commits] [lldb] r255711 - Add a new "thread-pcs" key-value pair to the T packet response from

2015-12-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Dec 15 17:47:44 2015 New Revision: 255711 URL: http://llvm.org/viewvc/llvm-project?rev=255711=rev Log: Add a new "thread-pcs" key-value pair to the T packet response from debugserver. thread-pcs has a comma separated list of base 16 addresses - the current pc value for

Re: [Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

2016-01-06 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Thanks for the comments. As for calling Clear() on the instruction list manually, I was aping the dtor on ThreadPlanStepRange which reads, // FIXME: The DisassemblerLLVMC has a reference cycle and won't go away if it has any active instructions. // I'll fix

Re: [Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

2016-01-06 Thread Jason Molenda via lldb-commits
jasonmolenda updated this revision to Diff 44189. jasonmolenda added a comment. Updated to address Jim's first round of comments. 1. fix typeo in comment 2. update change argument name from "private_step_out" to "continue_to_next_branch" 3. Change continue_to_next_branch argument to have a

[Lldb-commits] [lldb] r257117 - Performance improvement: Change lldb so that it puts a breakpoint

2016-01-07 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jan 7 18:06:03 2016 New Revision: 257117 URL: http://llvm.org/viewvc/llvm-project?rev=257117=rev Log: Performance improvement: Change lldb so that it puts a breakpoint on the first branch instruction after a function return (or the end of a source line), instead of a

Re: [Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

2016-01-07 Thread Jason Molenda via lldb-commits
jasonmolenda closed this revision. jasonmolenda added a comment. Landed in r257117. Sendinginclude/lldb/Target/Process.h Sendinginclude/lldb/Target/Thread.h Sendinginclude/lldb/Target/ThreadPlanStepOut.h Sendingsource/Target/Process.cpp Sending

[Lldb-commits] [lldb] r257121 - Change the key name for the libdispatch queue serial number from

2016-01-07 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jan 7 18:20:48 2016 New Revision: 257121 URL: http://llvm.org/viewvc/llvm-project?rev=257121=rev Log: Change the key name for the libdispatch queue serial number from "qserial" to "qserialnum" because "qserial" looks a lot like the queue type (either 'serial' or

Re: [Lldb-commits] [lldb] r257117 - Performance improvement: Change lldb so that it puts a breakpoint

2016-01-07 Thread Jason Molenda via lldb-commits
/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10091 > > I am able to reproduce this on my machine. Let me know if you need any > help with anything. > > On Thu, Jan 7, 2016 at 4:06 PM, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> Author

Re: [Lldb-commits] [lldb] r257117 - Performance improvement: Change lldb so that it puts a breakpoint

2016-01-07 Thread Jason Molenda via lldb-commits
elp. > On Jan 7, 2016, at 6:16 PM, Siva Chandra <sivachan...@google.com> wrote: > > This broke TestStepNoDebug, atleast on Linux when inferior is compiled > with GCC: > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10091 > > I am able to reprod

[Lldb-commits] [lldb] r257209 - Add support for the LEAVE x86 instruction to AssemblyParse_x86.

2016-01-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Jan 8 15:13:26 2016 New Revision: 257209 URL: http://llvm.org/viewvc/llvm-project?rev=257209=rev Log: Add support for the LEAVE x86 instruction to AssemblyParse_x86. Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp Modified:

[Lldb-commits] [lldb] r257229 - In the questionmark packet ("T"), print the "threads:" and "thread-pcs:"

2016-01-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Jan 8 17:16:03 2016 New Revision: 257229 URL: http://llvm.org/viewvc/llvm-project?rev=257229=rev Log: In the questionmark packet ("T"), print the "threads:" and "thread-pcs:" keys before we print the libdispatch queues keys (qname, qkind, qserialnum) to make it easier

[Lldb-commits] [lldb] r257210 - Re-apply r257117 (reverted in r257138 temporarily),

2016-01-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Jan 8 15:40:11 2016 New Revision: 257210 URL: http://llvm.org/viewvc/llvm-project?rev=257210=rev Log: Re-apply r257117 (reverted in r257138 temporarily), with the one change that ThreadPlanStepOut::ThreadPlanStepOut will now only advance the return address breakpoint

[Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

2015-12-21 Thread Jason Molenda via lldb-commits
jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a subscriber: lldb-commits. jasonmolenda set the repository for this revision to rL LLVM. Herald added a subscriber: aemerson. When lldb is instruction stepping (or fast-stepping / instruction stepping)

[Lldb-commits] [lldb] r255942 - The lldb side changes to go along with r255711 where a new

2015-12-17 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Dec 17 18:45:35 2015 New Revision: 255942 URL: http://llvm.org/viewvc/llvm-project?rev=255942=rev Log: The lldb side changes to go along with r255711 where a new "thread-pcs" key is added to the T (questionmark) packet in gdb-remote protocol so that lldb doesn't need to

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2015-11-30 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Hi Ravitheja, thanks for putting together a patch, I'm probably the best person to look at this. I'm not sure I understand the failure mode. When built with clang, this vdso routine does not preserve the frame pointer register (rbp), right? If lldb knows the

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

2015-11-30 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Yep, Greg said the patch is good to commit. Repository: rL LLVM http://reviews.llvm.org/D12877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r253538 - I like how PlatformAndroid/PlatformLinux log when their platforms

2015-11-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Nov 18 21:15:37 2015 New Revision: 253538 URL: http://llvm.org/viewvc/llvm-project?rev=253538=rev Log: I like how PlatformAndroid/PlatformLinux log when their platforms try to CreateInstance, and log the results. I copied that for the Mac platforms. Modified:

[Lldb-commits] [lldb] r253763 - Add code to PlatformDarwin and HostInfoMacOSX so they return the

2015-11-20 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 20 22:00:43 2015 New Revision: 253763 URL: http://llvm.org/viewvc/llvm-project?rev=253763=rev Log: Add code to PlatformDarwin and HostInfoMacOSX so they return the correct OS type when running on an apple tv or apple watch. Also, in TargetList::CreateTargetInternal,

[Lldb-commits] [lldb] r257569 - Add a small refinement to the qSymbol:: support in lldb.

2016-01-12 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jan 12 22:08:10 2016 New Revision: 257569 URL: http://llvm.org/viewvc/llvm-project?rev=257569=rev Log: Add a small refinement to the qSymbol:: support in lldb. This is a packet which allows the remote gdb stub to ask for the address of a symbol in the process. lldb

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2016-01-11 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Hi Ravi, sorry for taking so long to get back to you on this. It looks like a reasonable change - let's give it a try. Sometimes with the unwinder, it can be hard to foresee

[Lldb-commits] [lldb] r257453 - Changes to lldb and debugserver to reduce extraneous memory reads

2016-01-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jan 12 01:09:16 2016 New Revision: 257453 URL: http://llvm.org/viewvc/llvm-project?rev=257453=rev Log: Changes to lldb and debugserver to reduce extraneous memory reads at each public stop to improve performance a bit. Most of the information lldb needed was already

[Lldb-commits] [lldb] r271970 - Add support for using armv7 compact unwind information

2016-06-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 6 21:19:54 2016 New Revision: 271970 URL: http://llvm.org/viewvc/llvm-project?rev=271970=rev Log: Add support for using armv7 compact unwind information as an asynchronous unwind plan source. Two small fixes to the compact unwind dumper tool for armv7 encodings.

[Lldb-commits] [lldb] r271774 - Add armv7 compact unwind printing to the compact-unwind-dumper.c tool

2016-06-03 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Jun 3 23:10:15 2016 New Revision: 271774 URL: http://llvm.org/viewvc/llvm-project?rev=271774=rev Log: Add armv7 compact unwind printing to the compact-unwind-dumper.c tool as a prototype for adding armv7 compact unwind reading to lldb. Modified:

[Lldb-commits] [lldb] r270658 - Add support for arm64 compact unwind tables, used on darwin arm64

2016-05-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue May 24 23:20:28 2016 New Revision: 270658 URL: http://llvm.org/viewvc/llvm-project?rev=270658=rev Log: Add support for arm64 compact unwind tables, used on darwin arm64 systems (ios, tvos, watchos). It's a simple format to use now that I have i386/x86_64 supported

[Lldb-commits] [lldb] r270662 - Include in Process.h - Jim's change in r270593 added a std::mutex

2016-05-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed May 25 00:14:16 2016 New Revision: 270662 URL: http://llvm.org/viewvc/llvm-project?rev=270662=rev Log: Include in Process.h - Jim's change in r270593 added a std::mutex ivar and this header is needed for it to compile on linux, judging by the build bots. Modified:

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-14 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Thanks Ravi, I see the problem here and I agree that lldb should use eh_frame to unwind from this function - that's the only way this is going to work. I'm surprised that there is accurate eh_frame instructions for this function, it's great to see it. I'm

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-15 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Regarding the part of the patch where eh_frame is used unconditionally on Linux systems, I'm hesitant to make a change like that (beyond the notes I mentioned earlier about how I'd do it in FuncUnwinders instead of down in RegisterContextLLDB). Modern gcc's put

[Lldb-commits] [lldb] r272635 - Add support to PlatformRemoteiOS, PlatformRemoteAppleWatch, and

2016-06-13 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 13 22:49:13 2016 New Revision: 272635 URL: http://llvm.org/viewvc/llvm-project?rev=272635=rev Log: Add support to PlatformRemoteiOS, PlatformRemoteAppleWatch, and PlatformRemoteAppleTV to check the target.exec-search-paths directories for files after looking in the

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Hi Ravi, sorry for not having time to look at this patch yet - I was out of the office Friday and was catching up on everything today. I'll look at this tomorrow. My initial reactions are to be a little worried. It sounds like you have functions that are

  1   2   3   4   5   >