[Lldb-commits] [PATCH] D46888: [DWARF] Have HashedNameToDIE store a DataExtractor by value

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D46888 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D47014: Fix _NSCFBoolean data formatter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332700: Fix _NSCFBoolean data formatter. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D47014?vs=147312=147449#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

JDevlieghere updated this revision to Diff 147711. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Use absolute path to `lldb-dotest` when `--executable` is passed. https://reviews.llvm.org/D47062 Files: packages/Python/lldbsuite/test/dosep.py

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

JDevlieghere added a comment. Looks good to me, but I'll defer to Greg as I've never actually touched this code myself. https://reviews.llvm.org/D46889 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D47014: Fix _NSCFBoolean data formatter.

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, davide. In r265181 the test for the NSCFBoolean data formatter was removed. Later, in r279353 and r279446 a new implementation was provided for the formatter, which I believe never worked (and this wasn't caught

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

JDevlieghere updated this revision to Diff 147787. JDevlieghere added a comment. Herald added a subscriber: mgorny. Make this work for Windows https://reviews.llvm.org/D47062 Files: packages/Python/lldbsuite/test/dosep.py packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D47133: Enable ProcessMachCore plugin on non-apple platforms

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D46005: [test] Add a utility for dumping all tests in the dotest suite

JDevlieghere added a comment. I've given this some more though as I see valid points and concerns on both sides of the argument. I'm leaning towards running test cases in parallel because it offloads more work to lit at negligible cost (running make and launching the inferior are the biggest

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

JDevlieghere added a comment. I'm going to hold off on this until we have decided what to do for https://reviews.llvm.org/D46005. If we run the test cases as separate lit invocations, then the test format is in a better position to report this information. https://reviews.llvm.org/D47062

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In https://reviews.llvm.org/D47062#1104558, @davide wrote: > Can you commit the whitespace fixes separately? Sure. Comment at: packages/Python/lldbsuite/test/dosep.py:122 print("[%s

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide, aprantl. Rather than trying to figure out what arguments to pass to `dotest.py`, suggest using `lldb-dotest`. Athough this obviously won't work for all invocations (i.e. when you're passing custom arguments to

[Lldb-commits] [PATCH] D47064: Add some apple-tables lookup tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lit/SymbolFile/DWARF/find-basic-function.cpp:17 // RUN: FileCheck --check-prefix=EMPTY %s +// +// RUN: clang %s -g -c -o %t

[Lldb-commits] [PATCH] D46005: [test] Add a utility for dumping all tests in the dotest suite

JDevlieghere added a comment. In https://reviews.llvm.org/D46005#1109693, @zturner wrote: > FWIW, I think the single biggest improvement one could make to the LLDB test > suite runtime is to compile all inferiors up front as part of the CMake step. > If you run the test suite twice every

[Lldb-commits] [PATCH] D47539: [Platform] Accept arbitrary kext variants

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334205: [Platform] Accept arbitrary kext variants (authored by JDevlieghere, committed by ). Herald added a subscriber:

[Lldb-commits] [PATCH] D48114: Add dataformatter for NSDecimalNumber

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham, jasonmolenda. This patch adds a data formatter for NSDecimalNumber. The latter is a Foundation object used for representing and performing arithmetic on base-10 numbers that bridges to Decimal. Repository:

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: source/Utility/FileSpec.cpp:244-246 + // Only update style if explicitly requested. + if (style) +m_style = (*style == Style::native) ? GetNativeStyle() : *style;

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: source/Utility/FileSpec.cpp:244-246 + // Only update style if explicitly requested. + if (style) +m_style = (*style == Style::native) ? GetNativeStyle() : *style;

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

This revision was automatically updated to reflect the committed changes. JDevlieghere marked 11 inline comments as done. Closed by commit rL334615: [FileSpec] Delegate common operations to llvm::sys::path (authored by JDevlieghere, committed by ). Changed prior to commit:

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

JDevlieghere added inline comments. Comment at: source/Utility/FileSpec.cpp:244-246 + // Only update style if explicitly requested. + if (style) +m_style = (*style == Style::native) ? GetNativeStyle() : *style; labath wrote: > JDevlieghere wrote: > >

[Lldb-commits] [PATCH] D48114: Add dataformatter for NSDecimalNumber

This revision was automatically updated to reflect the committed changes. Closed by commit rL334638: [ObjC] Add dataformatter for NSDecimalNumber (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D48114?vs=151096=151217#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

JDevlieghere created this revision. JDevlieghere added reviewers: labath, zturner, clayborg, davide. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. With the recent changes in FileSpec to use LLVM's path style, it is possible to delegate a bunch of common path

[Lldb-commits] [PATCH] D47539: [Platform] Accept arbitrary kext variants

JDevlieghere updated this revision to Diff 149143. JDevlieghere added a comment. Don't use `EnumerateDirectory` https://reviews.llvm.org/D47539 Files: source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h Index:

[Lldb-commits] [PATCH] D47539: [Platform] Accept arbitrary kext variants

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, labath. When loading kexts in `PlatformDarwinKernel`, we use the BundleID as the filename to to create shared modules. In `GetSharedModule` we call `ExamineKextForMatchingUUID` for any BundleID it finds that is a

[Lldb-commits] [PATCH] D47535: [FileSpec] Add support for lambdas to EnumerateDirectory. NFC

JDevlieghere added a comment. In https://reviews.llvm.org/D47535#1116364, @labath wrote: > Actually, I wonder if we shouldn't just deprecate this function altogether. > What was your motivation for this patch? It seems we already have > `llvm::fs::(recursive_)directory_iterator` for this

[Lldb-commits] [PATCH] D47535: [FileSpec] Add support for lambdas to EnumerateDirectory. NFC

JDevlieghere added a comment. In https://reviews.llvm.org/D47535#1116430, @labath wrote: > In https://reviews.llvm.org/D47535#1116392, @JDevlieghere wrote: > > > In https://reviews.llvm.org/D47535#1116364, @labath wrote: > > > > > Actually, I wonder if we shouldn't just deprecate this function

[Lldb-commits] [PATCH] D47535: [FileSpec] Add support for lambdas to EnumerateDirectory. NFC

JDevlieghere added a comment. In https://reviews.llvm.org/D47535#1116274, @labath wrote: > Could we just get rid of the baton version? It's the only way the function is used currently. How about just phasing it out when we touch the relevant code? Repository: rL LLVM

[Lldb-commits] [PATCH] D47539: [Platform] Accept arbitrary kext variants

JDevlieghere added a comment. In https://reviews.llvm.org/D47539#1117114, @jasonmolenda wrote: > LGTM. If we added more knowledge specifically about kext bundle layouts, we > could restrict which files we test to see if they are valid binaries - but > we'd need to parse the Info.plist at the

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:222 +return true; + return GetReferencedDIE(DW_AT_specification) + .GetParent() labath wrote: > clayborg wrote: > > labath wrote: > > > clayborg wrote: > > > >

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

JDevlieghere added a comment. If I correctly understand this change, this might make it possible to apply the `add_test_categories` decorator to an inline test. We had issues with this when introducing the swiftpr category because the methods were part of the inline test class. From the

[Lldb-commits] [PATCH] D47495: Support relative paths with less than two components in DBGSourcePathRemapping

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, clayborg, labath. When reading DBGSourcePathRemapping from a dSYM, we remove the last two path components to make the source lookup more general. However, when dealing with a relative path that has less than 2

[Lldb-commits] [PATCH] D47495: Support relative paths with less than two components in DBGSourcePathRemapping

JDevlieghere updated this revision to Diff 148986. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Address Greg's feedback https://reviews.llvm.org/D47495 Files: source/Utility/FileSpec.cpp Index: source/Utility/FileSpec.cpp

[Lldb-commits] [PATCH] D47495: Support relative paths with less than two components in DBGSourcePathRemapping

JDevlieghere added inline comments. Comment at: include/lldb/Utility/FileSpec.h:535 - void RemoveLastPathComponent(); + void RemoveLastPathComponent(bool keep_dot = false); clayborg wrote: > Why add this? If the path is just "." to begin with, there is

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Pavel, LGTM. https://reviews.llvm.org/D47470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D47495: Support relative paths with less than two components in DBGSourcePathRemapping

JDevlieghere updated this revision to Diff 149083. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Replace custom logic with LLVM's path logic. - Add tests. https://reviews.llvm.org/D47495 Files: include/lldb/Utility/FileSpec.h source/Utility/FileSpec.cpp

[Lldb-commits] [PATCH] D47495: [FileSpec] Re-implmenet removeLastPathComponent

JDevlieghere added inline comments. Comment at: unittests/Utility/FileSpecTest.cpp:342 + EXPECT_FALSE(fs_posix_relative.RemoveLastPathComponent()); + EXPECT_STREQ("foo", fs_posix_relative.GetCString()); + labath wrote: > Is this the behavior you want here? I

[Lldb-commits] [PATCH] D47495: [FileSpec] Re-implmenet removeLastPathComponent

This revision was automatically updated to reflect the committed changes. Closed by commit rL333540: [FileSpec] Re-implmenet removeLastPathComponent (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D47535: [FileSpec] Add support for lambdas to EnumerateDirectory. NFC

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath. Herald added a subscriber: llvm-commits. Support both lambda's and function pointers as arguments to EnumerateDirectory. Repository: rL LLVM https://reviews.llvm.org/D47535 Files:

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM > Can you try inserting something like this instead of the > `ApplyDecoratorsToFunction` line and see if your problems go away? > > @wraps(InlineTest._test) > def

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere added a comment. In https://reviews.llvm.org/D48596#1143666, @clayborg wrote: > The function is looking for the complete objective C type. The code needs to > be modified to return the complete type only if one is found, else just one > of the other incomplete versions is needed,

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, clayborg. When running the test suite with .debug_names a bunch of tests were failing. Part of that is solved by implementing the missing GetCompleteObjCClass in DebugNamesDWARFIndex. Repository: rL LLVM

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:157 +if (entry.tag() != DW_TAG_structure_type && +entry.tag() != DW_TAG_class_type) + continue; aprantl wrote: > Wait.. we accept both

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere updated this revision to Diff 152912. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Feedback Greg https://reviews.llvm.org/D48596 Files: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

This revision was automatically updated to reflect the committed changes. Closed by commit rL335776: [SymbolFile] Implement GetCompleteObjCClass for .debug_names (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D48596?vs=153027=153161#toc

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere updated this revision to Diff 153027. JDevlieghere added a comment. - Add test case for debug_names variant. https://reviews.llvm.org/D48596 Files: packages/Python/lldbsuite/test/lang/objc/forward-decl/TestForwardDecl.py source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

JDevlieghere added a comment. In https://reviews.llvm.org/D48782#1148376, @labath wrote: > Then, for the integration test part, I propose to come up with a more generic > way to specify the kind of debug info to generate. I don't have this fully > thought out yet, but I have been thinking of

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

JDevlieghere added inline comments. Comment at: test/CMakeLists.txt:129 if(LLDB_BUILD_FRAMEWORK) list(APPEND LLDB_TEST_COMMON_ARGS --framework $) endif() We'll have to do the same thing here, but the debugserver is more pressing as it's keeping GreenDragon

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

JDevlieghere added inline comments. Comment at: test/CMakeLists.txt:138 if(CMAKE_HOST_APPLE) - list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH}) + if (DEBUGSERVER_PATH STREQUAL "$") +list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

JDevlieghere created this revision. JDevlieghere added reviewers: stella.stamenova, zturner, davide. Herald added subscribers: jkorous, mgorny. Because we can't expand generator expressions for the lit tests, we need to set the path to the debugserver in the `_STR` variable so it's expanded

[Lldb-commits] [PATCH] D46318: lldb-test symbols: Add ability to do name-based lookup

JDevlieghere added a comment. A few nits/stylistic comments Comment at: tools/lldb-test/lldb-test.cpp:86 +}; +static cl::opt Lookup( +"lookup", cl::desc("Choose lookup type:"), It's a bit unfortunate that these argument names are different from the ones we

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

JDevlieghere updated this revision to Diff 144853. JDevlieghere retitled this revision from "[lit] Make debugserver available to lit test" to "[CMake] Unify and relayer testing". JDevlieghere edited the summary of this revision. JDevlieghere added reviewers: labath, aprantl. JDevlieghere added a

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

JDevlieghere added a comment. @stella.stamenova Would you mind applying this locally and verify if it works for the MSVC generator? It seems to work for the Xcode generator but it's always possible that I missed something. https://reviews.llvm.org/D46334

[Lldb-commits] [PATCH] D46321: Enable AUTOBRIEF in doxygen configuration.

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks Adrian, this is great. Did you run your reflow script over this patch again after this change? https://reviews.llvm.org/D46321 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D46318: lldb-test symbols: Add ability to do name-based lookup

JDevlieghere added inline comments. Comment at: tools/lldb-test/lldb-test.cpp:86 +}; +static cl::opt Lookup( +"lookup", cl::desc("Choose lookup type:"), labath wrote: > JDevlieghere wrote: > > It's a bit unfortunate that these argument names are different

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

JDevlieghere updated this revision to Diff 144893. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. - Address review feedback Stella https://reviews.llvm.org/D46334 Files: CMakeLists.txt lit/CMakeLists.txt lit/Suite/lit.site.cfg.in test/CMakeLists.txt

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

JDevlieghere added inline comments. Comment at: test/CMakeLists.txt:101 ${LLDB_SOURCE_DIR}/test/dotest.py "--no-multiprocess;${LLDB_DOTEST_ARGS}" "Testing LLDB with args: ${LLDB_DOTEST_ARGS}" stella.stamenova wrote: > LLDB_DOTEST_ARGS are passed here,

[Lldb-commits] [PATCH] D46144: Reflow paragraphs in comments.

JDevlieghere accepted this revision. JDevlieghere added a comment.  Comment at: source/Host/common/MainLoop.cpp:158 // ppoll(2) is not supported on older all android versions. Also, older - // versions android (API <= 19) implemented pselect in a non-atomic way, as a -

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

JDevlieghere updated this revision to Diff 145033. JDevlieghere added a comment. Herald added a reviewer: alexshap. update diff pro forma https://reviews.llvm.org/D46334 Files: CMakeLists.txt lit/CMakeLists.txt lit/Suite/lit.site.cfg.in test/CMakeLists.txt test/lldb-dotest.in

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

This revision was automatically updated to reflect the committed changes. Closed by commit rL331463: [CMake] Unify and relayer testing (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D46334?vs=145033=145035#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D46318: lldb-test symbols: Add ability to do name-based lookup

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few more nits but otherwise this LGTM. Comment at: tools/lldb-test/lldb-test.cpp:463 DebuggerLifetime->Terminate(); return 0; labath

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:96-98 +return "-N dwarf %s" % (testdir) else: +return "-N dsym %s" % (testdir) labath wrote: > aprantl wrote: > > labath wrote: > > >

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

JDevlieghere created this revision. JDevlieghere added reviewers: vsk, davide, labath. Herald added a subscriber: llvm-commits. Inlined tests have a test function that is actually an instance method, which requires a slightly different approach when it comes to setting the category attribute. The

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

JDevlieghere closed this revision. JDevlieghere added a comment. Forgot to add the differential to the commit message. Landed in https://reviews.llvm.org/rL324488 Repository: rL LLVM https://reviews.llvm.org/D43024 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

JDevlieghere updated this revision to Diff 133220. JDevlieghere added a comment. The change in r324488 dropped the existing category attribute in for instance methods. This patch corrects that. https://reviews.llvm.org/D43024 Files: lldb/packages/Python/lldbsuite/test/decorators.py Index:

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

JDevlieghere closed this revision. JDevlieghere added a comment. Jup. Sorry for making it so confusing. Because Pavel's reply was here it seemed sensible to update the diff. Landed in https://reviews.llvm.org/rL324492 https://reviews.llvm.org/D43024

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL325568: Handle typeof() expressions (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43471?vs=134965=135025#toc

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham, davide, labath. Before this patch, LLDB was not able to evaluate expressions that resulted in a value with a typeof-type. (lldb) p int i; __typeof__(i) j = 1; j (typeof (i)) $0 = This fixes that. The type is

[Lldb-commits] [PATCH] D43596: Replace HashStringUsingDJB with llvm::djbHash

JDevlieghere added a comment. In https://reviews.llvm.org/D43596#1015848, @clayborg wrote: > No need to add additional dSYM tests, because all dSYM tests will fail if the > hashing isn't correct. Maybe I misunderstand, but https://reviews.llvm.org/D42740 suggested that this never worked (or

[Lldb-commits] [PATCH] D43662: [Utility] Simplify and generalize the CleanUp helper, NFC

JDevlieghere added a comment. I agree with Pavel, I prefer having a slightly more complex constructor if we can make the call sites simpler for the simple common cases, especially since we don't lose any generality by doing so. It's also not an uncommon pattern in C++, e.g. `std::async` does

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134942. JDevlieghere added a comment. Change to lit test https://reviews.llvm.org/D43471 Files: lit/Expr/TestTypeOfExpr.test source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.cpp

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:5264 - case clang::Type::TypeOfExpr: - case clang::Type::TypeOf: case clang::Type::Decltype: case clang::Type::TemplateSpecialization:

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134965. JDevlieghere added a comment. Thanks for the review Jim! I've updated the test accordingly. https://reviews.llvm.org/D43471 Files: lit/Expr/TestTypeOfDeclTypeExpr.test source/Symbol/ClangASTContext.cpp Index:

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134935. JDevlieghere added a comment. Formatting https://reviews.llvm.org/D43471 Files: packages/Python/lldbsuite/test/expression_command/test/TestExprs.py source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.cpp

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere added a comment. In https://reviews.llvm.org/D43471#1012484, @jingham wrote: > The code part of this looks fine. I had a few quibbles with the test, see > inline. Jim, it looks like you're commenting on an older version of the diff. I've since switched to checking this with

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134954. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Do this for decltype too https://reviews.llvm.org/D43471 Files: lit/Expr/TestTypeOfDeclTypeExpr.test source/Symbol/ClangASTContext.cpp Index:

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134955. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Make sure the lit test actually checks the lldb output instead of the # CHECK lines. Without the check-next, CHECK matches the # CHECK lines, as they are printed by

[Lldb-commits] [PATCH] D48450: [DataFormatter] Add CFDictionary data formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rL335271: [DataFormatter] Add CFDictionary data formatter (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D48450?vs=152354=152359#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D48450: [DataFormatter] Add CFDictionary data formatter

JDevlieghere updated this revision to Diff 152354. JDevlieghere added a comment. - Also test CFDictionaryRef https://reviews.llvm.org/D48450 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py

[Lldb-commits] [PATCH] D48450: Support CFDictionary

JDevlieghere created this revision. JDevlieghere added a reviewer: davide. Add data formatter for CFDictionary. Repository: rL LLVM https://reviews.llvm.org/D48450 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py

[Lldb-commits] [PATCH] D48302: Search for kext variants is searching from parent directory when it should not be

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Jason, good catch! Repository: rL LLVM https://reviews.llvm.org/D48302 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D49909: Unit test for Symtab::InitNameIndexes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I agree with Pavel, but I also don't mind having this test in the meantime. LGTM if you add a FIXME with the direction we want to go. https://reviews.llvm.org/D49909

[Lldb-commits] [PATCH] D50159: Add byte counting mechanism to LLDB's Stream class.

JDevlieghere added inline comments. Comment at: include/lldb/Utility/Stream.h:542 int m_indent_level; ///< Indention level. + std::size_t m_bytes_written = 0; /// The bytes this stream has written so far. I believe you need the `<` for Doxygen to

[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Given these numbers I think we can land this patch as is and figure out the IDP stuff on the mailing list and/or a future patch. LGTM. Thanks Stefan!

[Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

JDevlieghere added a comment. This looks really cool :-) I started doing a superficial pass but I have a hard time following what everything is doing. I think it could really help if you added more structure/abstraction. Can you also run clang-format over the new files?

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

JDevlieghere added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:281 llvm::StringRef replace) { - Log *log = GetLogIfAllCategoriesSet(LIBLLDB_LOG_LANGUAGE); - - const size_t max_len = -

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D50587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

JDevlieghere added a comment. Looks good to me, modulo the inline test (or the current comments addressed). Thanks Shafik! https://reviews.llvm.org/D49271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

JDevlieghere added inline comments. Comment at: source/Core/Mangled.cpp:30 #include "llvm/ADT/StringRef.h"// for StringRef +#include "llvm/Demangle/Demangle.h" While you're here I'd remove these redundant comments so this block looks more consistent.

[Lldb-commits] [PATCH] D49377: Move pretty stack trace printer into driver.

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath, zturner. Herald added a reviewer: jfb. We used to have a pretty stack trace printer in SystemInitializerCommon. This was disabled on Apple because we didn't want the library to be setting signal handlers, as this

[Lldb-commits] [PATCH] D49377: Move pretty stack trace printer into driver.

JDevlieghere updated this revision to Diff 155684. JDevlieghere added a comment. Herald added a subscriber: ki.stfu. I've added it to the tools that made sense to me. Let me know if I missed something obvious. https://reviews.llvm.org/D49377 Files:

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM, Thanks! https://reviews.llvm.org/D49271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49377: Move pretty stack trace printer into driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337261: Move pretty stack trace printer into driver. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D49377?vs=155684=155834#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D51604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

JDevlieghere added inline comments. Comment at: source/Utility/LLDBAssert.cpp:23 if (expression) ; else { I guess while we're at it we can turn this into an early return and use LLVM_LIKELY? ``` if (LLVM_LIKELY(expression)) return; ```

[Lldb-commits] [PATCH] D51602: Print the correct error when our DynamicCheckerFunctions fail to install

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB https://reviews.llvm.org/D51602 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham, clayborg. JDevlieghere added a project: LLDB. After landing https://reviews.llvm.org/rL341457, we started seeing a failure on the swift-lldb bots. The change was correct and pretty straightforward, a

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

JDevlieghere updated this revision to Diff 164650. JDevlieghere added a comment. Added a test case. I really didn't know where to put it so I decided on something generic. Hope that's fine. https://reviews.llvm.org/D51730 Files: packages/Python/lldbsuite/test/lang/c/local_variables/Makefile

[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean is enum

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda, LLDB. Herald added subscribers: abidh, emaste. This is an NFC commit to refactor the "load dependent files" parameter from a boolean to an enum value. We want to be able to specify a default, in which case

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL336988: Convert a location information from PDB to a DWARF expression (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, jingham, LLDB. JDevlieghere added a dependency: D51859: [NFC] Turn "load dependent files" boolean into an enum . JDevlieghere edited the summary of this revision. When creating a target, lldb loads all dependent

  1   2   3   4   5   6   7   8   9   10   >