[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL367241: [lldb] Qualify includes of Properties[Enum].inc files. NFC (authored by rupprecht, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

rupprecht added a comment. Committed this for you as r367241, including a rebase past r367238 (which I really hope I didn't mess up -- `ninja check-lldb` passed, at least). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

rupprecht added a comment. FYI, we've root caused some internal lldb asan failures to this patch. I don't have a repro yet (my lldb tests seem to be failing locally for unrelated reasons), but e.g. `Register/x86-64-read.test` is failing to read all the non-general purpose registers: (lldb)

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht updated this revision to Diff 229349. rupprecht marked an inline comment as done. rupprecht added a comment. - Fix test comment - Use `expect` helper from lldbpexpect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70137/new/

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/terminal/TestEditline.py:37-38 + +# Run help for different commands for escape variants to make sure each +# one matches uniquely (the

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2e65447b3cb: [lldb][Editline] Support ctrl+left/right arrow word navigation. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D70137?vs=229349=229373#toc Repository: rG

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht created this revision. rupprecht added reviewers: JDevlieghere, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds several 5C/5D escape codes that allow moving forward/backward words similar to bash command line navigation. On my terminal, `ctrl+v

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht updated this revision to Diff 228972. rupprecht added a comment. - Add a pexpect test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70137/new/ https://reviews.llvm.org/D70137 Files:

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht added a comment. In D70137#1742766 , @JDevlieghere wrote: > This is very nice, thanks! > > Any chance we could test this with a pexpect test? Absolutely. It was waaay more complicated than I expected due to funny escaping somewhere between

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht marked 3 inline comments as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/terminal/TestEditline.py:37-38 + +# Run help for different commands for escape variants to make sure each +# one matches uniquely (the

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

rupprecht created this revision. rupprecht added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. expect() forwards its command to sendline(). This can be problematic if the command already contains a newline: sendline() unconditionally adds a newline

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

rupprecht added a comment. In D70324#1755712 , @davide wrote: > In D70324#1755704 , @labath wrote: > > > [This is probably not the right patch, as the last run on that bot still > > doesn't have this commit.] >

[Lldb-commits] [PATCH] D70517: [lldb][DataFormatters] Support pretty printing std::string when built with -funsigned-char.

This revision was automatically updated to reflect the committed changes. Closed by commit rG506144da04b9: [lldb][DataFormatters] Support pretty printing std::string when built with… (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

rupprecht created this revision. rupprecht added reviewers: JDevlieghere, labath. Herald added subscribers: llvm-commits, lldb-commits, mgorny. Herald added projects: LLDB, LLVM. The lldb tree contains a symlink directory, `lldb/test/API/testcases`, which points to the tests in

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, jfb, arphaman, atanasyan, mgrang, jrtc27, christof, kbarton, krytarowski, arichardson, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jfb.

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This creates a separate LLDB_TEST_SRC var to match the existing LLDB_TEST var. LLDB_TEST points to the test framework, LLDB_TEST_SRC points to

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

rupprecht added a comment. In D71151#1774586 , @labath wrote: > While I'm not opposed to moving "lldbsuite" to some place closer to the > tests, one thing I'd like to get out of this is to have the actual tests > stand out more prominently. Ditto; my

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

rupprecht created this revision. rupprecht added a reviewer: labath. Herald added a reviewer: EricWF. Herald added subscribers: lldb-commits, ldionne. Herald added a project: LLDB. The test logic for running libc++ tests only looks to see if `/usr/include/c++/v1` exists. This adds a fallback for

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

rupprecht added a comment. In D71150#1774575 , @labath wrote: > Hmm... given the lua thread on lldb-dev, maybe we should slow down here, and > consider the potential relationship of these tests and the hypothetical lua > tests that come to be. One of

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG34ef51b5f979: [lldb][dotest] Improve libc++ detection (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71319/new/

[Lldb-commits] [PATCH] D71376: [lldb][dotest] Add `#include ` to libc++ detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG786b6db8e6fd: [lldb][dotest] Add `#include algorithm` to libc++ detection (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71376/new/

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:859 +p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True) +

[Lldb-commits] [PATCH] D71376: [lldb][dotest] Add `#include ` to libc++ detection

rupprecht created this revision. rupprecht added a reviewer: echristo. Herald added a reviewer: EricWF. Herald added subscribers: lldb-commits, ldionne. Herald added a project: LLDB. echristo accepted this revision. This revision is now accepted and ready to land. Speculative fix after

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

rupprecht added a comment. In D70622#1765674 , @JDevlieghere wrote: > No objections to moving the test. Jordan, let me know if you're up for it, > otherwise I'm happy to take care of it. I tried moving it today. The rabbit hole goes deep :D The test

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

rupprecht added a comment. In D70622#1771601 , @rupprecht wrote: > In D70622#1765674 , @JDevlieghere > wrote: > > > No objections to moving the test. Jordan, let me know if you're up for it, > > otherwise I'm

[Lldb-commits] [PATCH] D71099: [lldb][test] Handle .categories lookup for inline tests.

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When creating a test with `lldbinline.MakeInlineTest()`, the reported `inspect.getfile(test.__class__)` is `lldbtest.pyc`, meaning any

[Lldb-commits] [PATCH] D71099: [lldb][test] Handle .categories lookup for inline tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG03a242bd41ee: [lldb][test] Handle .categories lookup for inline tests. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71099/new/

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

rupprecht abandoned this revision. rupprecht added a comment. Officially abandoning this rG0d236d8b4f8aecc258e26ad53755a39d9b76032e - fixes makefiles when separated from `Makefile.rules`

[Lldb-commits] [PATCH] D70517: [lldb][DataFormatters] Support pretty printing std::string when built with -funsigned-char.

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere, shafik. Herald added subscribers: lldb-commits, christof. Herald added a project: LLDB. When built w/ `-funsigned-char`, `std::string` becomes equivalent to `std::basic_string`, causing these formatters to not

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG327a18ca0a00: [lldb][test] Prevent \n in calls to lldbs expect() test helper. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D70324?vs=229593=230157#toc Repository: rG

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

rupprecht added a comment. In D68299#1692503 , @labath wrote: > > FYI, we've root caused some internal lldb asan failures to this patch. I > > don't have a repro yet (my lldb tests seem to be failing locally for > > unrelated reasons) > > This should be

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/__init__.py:32 +# TODO(rupprecht): update the above definition after moving test cases: +# lldb_test_root = os.path.join(lldb_root, "test", "API", "test")

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

rupprecht added a comment. In D71151#1813772 , @labath wrote: > Judging by the direction of the lua patches, it doesn't look like we will > have lua "dotest" tests, so I think it's fine to just put this into API > directly (without the extra "test"

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG25675d4eaab6: [lldb][test][NFC] Create a separate LLDB_TEST_SRC var to allow moving tests. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D71150?vs=232656=243301#toc

[Lldb-commits] [PATCH] D74859: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffa6e1a7e1c: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74859: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere, friss. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb's format string (line one) is: `lldb version $clang_version ($lldb_repo revision $lldb_revision)` When only using $lldb_revision

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG99451b445368: [lldb][test] Remove symlink for API tests. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D71151?vs=232658=243908#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D86818: [lldb/Host] Add missing proc states

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5aa63dd560b: [lldb/Host] Add missing proc states (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht updated this revision to Diff 290799. rupprecht added a comment. - Don't use "localhost" to avoid dns latency. Instead, prefer either 127.0.0.1 or ::1 directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. This is ready for review now after scrubbing out the "localhost" changes I had earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87333

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht updated this revision to Diff 290800. rupprecht added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87333 Files:

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. In D87333#2273506 , @labath wrote: > (Sorry about the delay.) Given the current requirements, I think this patch > is fine (excellent even). > > That said, I'm not sure whether the original motivation for this requirement >

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht updated this revision to Diff 291956. rupprecht marked an inline comment as done. rupprecht added a comment. - Compare directly against the error code instead of hopping through `std::make_error_code()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

rupprecht created this revision. rupprecht added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Register the `faulthandler` module so we can see what lldb tests are doing when they misbehave (e.g. run

[Lldb-commits] [PATCH] D86825: [lldb/Gui] zero-initialize children_stop_id

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7e04b710d2d: [lldb/Gui] zero-initialize children_stop_id (authored by rupprecht). Changed prior to commit:

[Lldb-commits] [PATCH] D86825: [lldb/Gui] zero-initialize children_stop_id

rupprecht marked an inline comment as done. rupprecht added a comment. SG, will land momentarily with the one formatting change. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86825/new/ https://reviews.llvm.org/D86825

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. In D87333#2262241 , @clayborg wrote: > In D87333#2262236 , @rupprecht wrote: > >> In D87333#2262229 , @clayborg wrote: >> >>> FYI: we switched

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. In D87333#2262229 , @clayborg wrote: > FYI: we switched away from "localhost" a long time ago due to issues with > people having a "localhost" entry in their /etc/hosts folder. I assume you mean people *not* having a

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht created this revision. rupprecht added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. When running in an ipv6-only environment where `AF_INET`

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

rupprecht accepted this revision. rupprecht added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:550-551 +# If our lldb supports the -P option, use it to find the python path: +with

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

rupprecht added a comment. In D88840#2313331 , @kastiglione wrote: > About `-P`, the man page for `lldb` and the driver's `Options.td` say it: > >> Prints out the path to the lldb.py file for this version of lldb. > > Should it do just that? If so this

[Lldb-commits] [PATCH] D86752: [lldb/test] Use shorter test case names in TestStandardUnwind

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd895cac0cd: [lldb/test] Use shorter test case names in TestStandardUnwind (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86825: [lldb/Gui] zero-initialize children_stop_id

rupprecht created this revision. Herald added subscribers: lldb-commits, danielkiss. Herald added a project: LLDB. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. This is currently causing msan warnings in the API tests when run under msan, e.g.

[Lldb-commits] [PATCH] D86818: [lldb/Host] Add missing proc states

rupprecht created this revision. Herald added subscribers: lldb-commits, danielkiss. Herald added a project: LLDB. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. The /proc//status parsing is missing a few cases: - Idle - Parked - Dead If we encounter an

[Lldb-commits] [PATCH] D86752: [lldb/test] Use shorter test case names in TestStandardUnwind

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. TestStandardUnwind uses the full absolute path to a set of C/C++ files as the test case name, which in

[Lldb-commits] [PATCH] D86745: [lldb/test] Use @skipIfWindows for PExpectTest

rupprecht created this revision. rupprecht added a reviewer: teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. Annotating `PExpectTest` with `@skipIfWindows` instead of marking it

[Lldb-commits] [PATCH] D88513: [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints.

rupprecht created this revision. rupprecht added reviewers: wallace, clayborg, labath. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Per the DAP spec for SetBreakpoints [1], the way to

[Lldb-commits] [PATCH] D88051: [lldb/test] Clean up version checking.

rupprecht created this revision. rupprecht added reviewers: JDevlieghere, arsenm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: wdng. A few fixes while trying to figure out why tests are being skipped

[Lldb-commits] [PATCH] D88051: [lldb/test] Clean up version checking.

This revision was automatically updated to reflect the committed changes. Closed by commit rG307b7a1d6658: [lldb/test] Clean up version checking. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88051/new/

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht updated this revision to Diff 293887. rupprecht added a comment. - Switch back to using localhost for non-socket uses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87333 Files:

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. In D87333#2274572 , @rupprecht wrote: > In D87333#2273506 , @labath wrote: > >> (Sorry about the delay.) Given the current requirements, I think this patch >> is fine (excellent even).

[Lldb-commits] [PATCH] D88513: [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rupprecht marked an inline comment as done. Closed by commit rGad865d9d10b8: [lldb-vscode] Allow an empty breakpoints field to clear breakpoints. (authored by

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3193e464cbd: [lldb/ipv6] Support running lldb tests in an ipv6-only environment. (authored by rupprecht). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd67581407c1: [lldb/test] Enable faulthandler in dotest (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87637/new/

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. If the test suite is misconfigured when it's run (a bad regexp, wrong test directory, etc.), the test

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadb5c23f8c0d: [test] Exit with an error if no tests are run. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht updated this revision to Diff 282759. rupprecht added a comment. - Use logging.error - Remove trailing stop - Edit message to indicate that matching tests weren't found (user error) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht added a comment. Thanks for the quick review! I have a few more boring changes coming up, but hopefully some interesting ones after that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/ https://reviews.llvm.org/D85169

[Lldb-commits] [PATCH] D85175: [test] Use abspath instead of realpath sometimes

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. In these two cases, use of `os.path.realpath` is problematic: - The name of the compiler is significant

[Lldb-commits] [PATCH] D85258: [test] Use realpath consistently for test root file paths.

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. LLDB tests assume that tests are in the test tree (the `LLDB_TEST_SRC` env variable, configured by

[Lldb-commits] [PATCH] D85248: [test] Support git commit version ids for clang.

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. `getCompilerVersion` assumes that `clang --version` prints out a string like `version [0-9\.]+`. If clang

[Lldb-commits] [PATCH] D85175: [test] Use abspath instead of realpath sometimes

This revision was automatically updated to reflect the committed changes. Closed by commit rG817b3a6fe3a4: [test] Use abspath instead of realpath sometimes (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85175/new/

[Lldb-commits] [PATCH] D85322: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration

rupprecht created this revision. rupprecht added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85322 Files:

[Lldb-commits] [PATCH] D85322: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rGf425c0442c3e: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85258: [test] Use realpath consistently for test root file paths.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:499 # /abs/path/to/packages/group/subdir/mytest.py -> group/subdir -rel_prefix = test_file[len(os.environ["LLDB_TEST_SRC"]) +

[Lldb-commits] [PATCH] D85258: [test] Use realpath consistently for test root file paths.

This revision was automatically updated to reflect the committed changes. rupprecht marked an inline comment as done. Closed by commit rGfcb0d8163a4f: [lldb/test] Use realpath consistently for test root file paths. (authored by rupprecht). Changed prior to commit:

[Lldb-commits] [PATCH] D85248: [test] Support git commit version ids for clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dbac09dd6ec: [lldb/test] Support git commit version ids for clang. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85248/new/

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. use_lldb_suite.py looks for use_lldb_suite_root.py by checking parent directories. If for some reason it doesn't exist, it keeps checking

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

rupprecht added a comment. In D83840#2152706 , @labath wrote: > Heh I fixed the same thing back in 67f6d842fab6 for > `scripts/use_lldb_suite.py`, but of course I forgot to update this copy... > The idea is good, just please make sure both files end up

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf3f100fcbf9: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D83840?vs=278042=278219#toc

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

rupprecht added a comment. Thanks, I'll take a look at that. For SIGTERM (issued by test runners to handle timeouts), the stack trace is printed via `faulthandler.register(signal.SIGTERM, chain=True)`. The `chain=True` //should// cause previous signal handlers registered for SIGTERM to

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

rupprecht added a comment. At head: $ ninja check-lldb-api-commands-apropos-basic [2/3] Running lit suite /home/rupprecht/src/llvm-project/lldb/test/API/commands/apropos/basic FAIL: lldb-api :: commands/apropos/basic/TestApropos.py (1 of 1) TEST 'lldb-api ::

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

rupprecht added a comment. My cmake config appears to be correct. I tried adding this to `CommandInterpreter::HandleCommand`: lldbassert(ENABLE_BACKTRACES && "back traces are not enabled!"); lldbassert(false && "crash!"); Running LLDB directly does what you describe: $ bin/lldb (lldb)

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

rupprecht added a comment. In D87637#2395246 , @teemperor wrote: > I'm late to the party, but I actually don't think this is a good change as it > disables the normal LLDB backtraces. The current test errors we see on Green > Dragon look now like this:

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

rupprecht added a comment. I ran manual tests for this, but I did so by introducing an intentional crash in a place that obviously can't be checked in. Does LLDB have any kind of intentional-crash-for-test mechanism that could be used for a test? Also, I picked `SBDebugger` for this as it

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

rupprecht created this revision. rupprecht added reviewers: teemperor, JDevlieghere, labath, vsk. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. As noticed in D87637 , when LLDB crashes, we only

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

rupprecht added a comment. In D87637#2395603 , @teemperor wrote: > Yeah I don't think this revision is to blame as just disabling the code here > doesn't bring back the backtraces. Doesn't explain what happened to them, but > that's probably on me to

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

rupprecht added a comment. In D94888#2506140 , @labath wrote: > In D94888#2506000 , @MaskRay wrote: > >> In D94888#2505992 , @labath wrote: >> >>> It looks like this is

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. This commit seems to be causing an LLDB crash. I'm still working on gathering info and reducing it, but maybe the crash reason is obvious to you given this stack trace: $ lldb -b -o "b ChromeMain" -o "r" -o "v" -o "p chrome_main_delegate"

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. In D102993#2811337 , @teemperor wrote: > Sure I can take a look, but I don't see the immediate problem when looking at > the backtrace. > > I assume it takes some time to reduce the bug in Chrome? If you could get me > the

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. In D102993#2811902 , @rupprecht wrote: > In D102993#2811337 , @teemperor > wrote: > >> Sure I can take a look, but I don't see the immediate problem when looking >> at the backtrace.

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5e11f460b1: [lldb] Fix RichManglingContext::FromCxxMethodName() leak (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

rupprecht added a comment. In D97786#2693410 , @jingham wrote: > In D97786#2693381 , @cmtice wrote: > >> I had to revert this change because the test case broke the windows builder. >> What's the right way to

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

rupprecht added a comment. LGTM too, thanks for writing this up! Comment at: lldb/docs/resources/test.rst:264 +:: +self.expect("expr 1 - 1", substrs=["0"]) + shafik wrote: > Maybe some more examples with alternatives would be helpful here. Also mentioning

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-79 -if "LLDB_DEBUGSERVER_PATH" in os.environ: -return os.environ["LLDB_DEBUGSERVER_PATH"] -return _get_debug_monitor_from_lldb( -

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

rupprecht accepted this revision. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-79 -if "LLDB_DEBUGSERVER_PATH" in os.environ: -return os.environ["LLDB_DEBUGSERVER_PATH"] -return

[Lldb-commits] [PATCH] D100048: [lldb][Editline] Fix crash when navigating through empty command history.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf49a4440d38a: [lldb][Editline] Fix crash when navigating through empty command history. (authored by rupprecht). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D100048: [lldb][Editline] Fix crash when navigating through empty command history.

rupprecht created this revision. rupprecht added a reviewer: JDevlieghere. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. An empty history entry can happen by entering the expression evaluator an immediately hitting enter: $

[Lldb-commits] [PATCH] D100508: [lldb] Simplify output for skipped categories in dotest.py

rupprecht added a comment. > The motivation for this change is that sometimes engineers misidentify the > output of these messages as the cause for a test failure I have worked on one these checks and *still* gotten confused by the message, so thanks :) Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

rupprecht updated this revision to Diff 338665. rupprecht added a comment. - Refactor cleanup of m_cxx_method_parser Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100795/new/ https://reviews.llvm.org/D100795 Files:

  1   2   3   >