[Lldb-commits] [PATCH] D11899: Fix AArch64 watchpoint handlers in NativeRegisterContextLinux_arm64

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. There were some bugs that needed to be fixed in watchpoint handling code on arm64. Watchpoints were being written to all

Re: [Lldb-commits] [PATCH] D14051: Fix for Arm watchpoint cache corruption in case of ptrace failure

This revision was automatically updated to reflect the committed changes. Closed by commit rL251386: Fix for Arm watchpoint cache corruption in case of ptrace failure (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D14051?vs=38364=38502#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D12522: AArch64 Watchpoints: Make sure we are only setting supported no of debug registers.

omjavaid updated this revision to Diff 37748. omjavaid added a comment. This patch fixes unexpected behaviour of watchpoint code on Nexus 9 (AArch64). http://reviews.llvm.org/D12522 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp Index:

Re: [Lldb-commits] [PATCH] D12522: AArch64 Watchpoints: Make sure we are only setting supported no of debug registers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250700: Fix for random watchpoint testsuite failures on AArch64 targets. (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D12522?vs=37748=37758#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D12328: Error checking correction in AArch64 hardware watchpoint code

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch fixes a few areas where AArch64 hardware watchpoints were not emitting errors correctly. This makes sure any

[Lldb-commits] [PATCH] D15357: Update code to silent some ARM/ARM64 specific compiler warnings

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Following changes remove conditions where an unsigned integer is being tested to be greater or equal to zero. These conditions will

[Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. This patch updates GetAsUnsigned(), GetAsSigned(), and GetAsDouble() JSONNumber functions to add failure check. The previous code was generating compiler warnings for not being

Re: [Lldb-commits] [PATCH] D15357: Update code to silent some ARM/ARM64 specific compiler warnings

omjavaid abandoned this revision. omjavaid added a comment. Let the warnings stay for now. http://reviews.llvm.org/D15357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

omjavaid abandoned this revision. omjavaid added a comment. Correction made upstream by @tberghammer. http://reviews.llvm.org/D15355 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

This revision was automatically updated to reflect the committed changes. Closed by commit rL255499: Add failure paths to a few JSONNumber members (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15355?vs=42706=42712#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D15061: Correction in TestFrames.py test for arm targets in thumb mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL255547: Correction in TestFrames.py test for arm targets in thumb mode (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15061?vs=41359=42765#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D15877: Fix for undefined behavior while updating PC value on arm-linux

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch provides fix for the cases where an expression or jump tries to update the value of PC in thumb mode. As

Re: [Lldb-commits] [PATCH] D15877: Fix for undefined behavior while updating PC value on arm-linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL256847: Fix for undefined behavior while updating PC value on arm-linux (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15877?vs=43941=44015#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

omjavaid created this revision. omjavaid added a reviewer: clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds a new expectedFailureArmLinux which marks arm-linux tests as xfails. Also marked a couple of failing tests to use

Re: [Lldb-commits] [PATCH] D14985: Add 64/128 bit arm neon register definitions on linux

omjavaid added a comment. Some minor typos inline comments. I havnt applied nd tested this patch. Are you able to read these registers, i guess you need to generate neon or vfp code to test all registers properly. There no arm register test to my knowledge currently in testsuite we can put

[Lldb-commits] [PATCH] D15061: Correction in TestFrames.py test for arm targets in thumb mode

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds required correction in TestFrames.py for arm targets in thumb mode. On arm hardware thumb mode is identified by

Re: [Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

omjavaid added a comment. -mthumb and -marm are compiler flags so we can put these into our CXX or CFLAGS if we need to run those configurations. http://reviews.llvm.org/D14823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch disables forcing -marm (A32 instruction set) while running lldb testsuite on arm targets. gcc uses -marm and

Re: [Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

omjavaid added a comment. I agree with you on having multiple configuration options to help identify failures in different configurations. What I mean is that we should keep clarity on architecture that is to use arm or aarch32 for 32bit and aarch64 for 64bit. With that we should run tests in

Re: [Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rL253973: Disable forcing -marm (A32 instruction set) while running testsuite on arm… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D14823?vs=40652=41017#toc Repository: rL

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

omjavaid added a subscriber: omjavaid. omjavaid added a comment. -mthumb will force T32 instruction set while -marm will force A32. Best is not to use any of these flags to let the compiler decide best possible instruction set combination. http://reviews.llvm.org/D14816

Re: [Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

This revision was automatically updated to reflect the committed changes. Closed by commit rL257405: Xfail some Arm-Linux specific failures (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15893?vs=44550=44563#toc Repository: rL LLVM http://reviews.llvm.org/D15893

Re: [Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

omjavaid updated this revision to Diff 44550. omjavaid added a comment. Removed expectedFailureArmLinux and updated expectedFailureLinux decorator to reflect architecture if needed. Marked some triaged failures as xfails on arm with updated expectedFailureLinux decorator. LGTM?

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

omjavaid added a subscriber: omjavaid. omjavaid added a comment. LGTM. I think we should submit this patch as tberghammer explained. http://reviews.llvm.org/D15533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

omjavaid created this revision. omjavaid added reviewers: labath, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, rengolin, aemerson. This patch adds logic to make sure we can install watchpoints at 1,2 and 4 byte alligned addresses. ptrace

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

omjavaid added a comment. In http://reviews.llvm.org/D21280#457196, @labath wrote: > The overall change looks good, but please also add a test which specifically > tests for watchpoints at unaligned addresses. Last time I checked, we all > watchpoint tests were passing (at least on android)

[Lldb-commits] [PATCH] D21164: Improve watchpoint error reporting specially for arm/aarch64 targets

omjavaid created this revision. omjavaid added reviewers: tberghammer, labath. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch takes a few corrective measures to make sure we display meaningful reason against a watchpoint creation failure.

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

omjavaid updated this revision to Diff 60942. omjavaid added a comment. Herald added a subscriber: srhines. I have added a test cases that tests all possibilities supported by current configuration. Tests pass on Nexus 9 and aarch64-linux-gnu (hikey board). LGTM?

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

omjavaid marked 3 inline comments as done. Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_size/TestWatchpointSizes.py:104 @@ +103,3 @@ +self.expect("watchpoint list -v", +substrs = ['hit_count = 2']) +

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL272916: Allow installing watchpoints at less than 8-byte alligned addresses for… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D21280?vs=60942=60987#toc Repository: rL

[Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Arm hard float ABI can use floating point registers for returning structures containing all 4 or 8 byte floating point

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid updated this revision to Diff 47191. omjavaid added a comment. updated diff after incorporating suggested corrections. http://reviews.llvm.org/D16975 Files: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp Index: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid added inline comments. Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:581-591 @@ -580,10 +580,13 @@ { size_t byte_size = compiler_type.GetByteSize(); if (byte_size <= 4) { RegisterValue r0_reg_value;

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid updated this revision to Diff 47198. omjavaid added a comment. Updated adding float_count check. http://reviews.llvm.org/D16975 Files: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp Index: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

omjavaid added a comment. GDB doesnt use bkpt instruction for user debugging for the reason that it interferes with jtag debug probes. I am not sure if LLDB will be ever used with a jtag probe in near future but still a jtag prob might be connected to the same hardware which is using LLDB to

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid added a comment. Is this good to go ? http://reviews.llvm.org/D16975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid added inline comments. Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:658 @@ -582,2 +657,3 @@ + if (byte_size <= 4) { Homogenous types with elements more than 4 will fall through and will be handled by this even in case of

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

This revision was automatically updated to reflect the committed changes. Closed by commit rL260512: Handle floating-point type homogeneous aggregate return values in ABISysV_arm (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D16975?vs=47625=47626#toc Repository:

Re: [Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

This revision was automatically updated to reflect the committed changes. Closed by commit rL259885: Add support to detect arm hard float ABI based binaries for ABISysV_arm (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D16627?vs=46620=47014#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D16772: Fix single stepping over the IT instruction

omjavaid accepted this revision. omjavaid added a comment. Looks good. Was there a test failing in testsuite due to this? http://reviews.llvm.org/D16772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D17501: Fix test for homogeneity in case of aggregate consisting of containerized vector types

This revision was automatically updated to reflect the committed changes. Closed by commit rL261734: Fix test for homogeneity in case of aggregate consisting of containerized… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D17501?vs=48663=48909#toc Repository: rL

[Lldb-commits] [PATCH] D17501: Fix test for homogeneity in case of aggregate consisting of containerized vector types

omjavaid created this revision. omjavaid added a reviewer: clayborg. omjavaid added a subscriber: lldb-commits. Herald added a subscriber: aemerson. This patch ClangASTContext::IsHomogeneousAggregate test for homogeneity in light of Arm procedure call standard definition of a homogeneous

Re: [Lldb-commits] [PATCH] D17501: Fix test for homogeneity in case of aggregate consisting of containerized vector types

omjavaid added a comment. Just to mention this simplifies vector return type handling for ARM. A patch implementing that is following up if this gets approves. http://reviews.llvm.org/D17501 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D17708: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds code to SysV ARM ABI for handling complex and aggregates containing complex return types. It also improves support for

[Lldb-commits] [PATCH] D17716: Add complex and aggregate with vector types return value test cases

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. This patch adds tests to test complex return types and aggregate return types with vector elements. http://reviews.llvm.org/D17716 Files:

Re: [Lldb-commits] [PATCH] D17708: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262218: Add/Improve complex, vector, aggregate types handling for SysV ARM… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D17708?vs=49353=49364#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds logic to detect if underlying binary is using arm hard float abi and use that information while handling

Re: [Lldb-commits] [PATCH] D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend

omjavaid added a reviewer: clayborg. omjavaid added a comment. I dont have a lot of background in this area of the code. Can you kindly take a look. http://reviews.llvm.org/D18059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

omjavaid accepted this revision. omjavaid added a comment. LGTM http://reviews.llvm.org/D18984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

omjavaid added a comment. Seems legit but One cosmetic comment inline. Also have you tested this patch by running LLDB testsuite on arm in both little and big endian modes? Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:157 @@ -149,12 +156,3 @@ { -if

Re: [Lldb-commits] [PATCH] D19252: Handle invalid values of PLT entry size generated by ld + gcc on arm linux targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267405: Handle invalid values of PLT entry size generated by linker (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D19252?vs=54146=54845#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267550: rL267291: Architecture change to thumb on parsing arm.attributes causes… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D19520?vs=54961=54993#toc Repository: rL

[Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

omjavaid created this revision. omjavaid added reviewers: tberghammer, labath. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. rL267291 introduces a lot of regression on arm-linux by fixing module architecture to thumb if it finds thumb32 tag set.

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

omjavaid accepted this revision. omjavaid added a comment. Seems to be causing no regressions on arm-linux. http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

omjavaid added a comment. @sas Ideally it should be thumb-* if an environment is thumb only but lldb right now has some areas where we need to handle this case. Either you put arm-* and leave it for someone else to correct the problems or put thumb-* and fix the issues that come up after that.

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. Please see inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:149 @@ +148,3 @@ +{ +

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

omjavaid added a comment. In case of ELF .arm attributes contains tags providing information on underlying CPU specification used. Thats only for the inferior being debugged but actually knowing which target we are running on, like for example if we want to figure out if we are running on a

[Lldb-commits] [PATCH] D19252: Handle invalid values of PLT entry size generated by ld + gcc on arm linux targets.

omjavaid created this revision. omjavaid added reviewers: tberghammer, rengolin, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, rengolin, aemerson. This patch provides a fix for wrong plt entry size generated for binaries built with gcc and

Re: [Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

omjavaid added a comment. I am going ahead and committing this patch. If it breaks any build please revert it. Repository: rL LLVM https://reviews.llvm.org/D22771 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL276814: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D22771?vs=65397=65612#toc Repository:

[Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

omjavaid created this revision. omjavaid added reviewers: labath, Eugene.Zelenko. omjavaid added a subscriber: lldb-commits. Herald added a subscriber: aemerson. This patch allows correct selection of CMAKE_LIBRARY_ARCHITECTURE instead of previously hard-coded value. All cross builds for 64bit

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid updated this revision to Diff 66258. omjavaid added a comment. Herald added a subscriber: samparker. Sorry about the delay updating this. I lost track of this rev earlier. Have updated diff to use macro already present within Android specific block for all cases. Tested with no

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid updated this revision to Diff 67669. omjavaid added a comment. Herald added a subscriber: srhines. Updated with suggestion incorporated. Here's what I am getting on different inputs: Testing make clean CC=gcc ar objcopy Testing make clean CC=clang ar objcopy Testing make clean

Re: [Lldb-commits] [PATCH] D23395: Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due thumb instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rL278326: Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due… (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D23395?vs=67663=67670#toc Repository: rL

[Lldb-commits] [PATCH] D23395: Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due thumb instructions

omjavaid created this revision. omjavaid added a reviewer: labath. omjavaid added a subscriber: lldb-commits. Herald added subscribers: samparker, rengolin, aemerson. LldbGdbServerTestCase.test_software_breakpoint_set* are failing when breakpoint target address is an thumb16 instruction. Test

Re: [Lldb-commits] [PATCH] D21164: Improve watchpoint error reporting specially for arm/aarch64 targets

omjavaid added inline comments. Comment at: source/Target/Target.cpp:714 @@ -713,2 +713,3 @@ { uint32_t num_current_watchpoints = target->GetWatchpointList().GetSize(); +if (num_supported_hardware_watchpoints == 0) clayborg wrote: > This

Re: [Lldb-commits] [PATCH] D21164: Improve watchpoint error reporting specially for arm/aarch64 targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL273869: Improve watchpoint error reporting specially for arm/aarch64 targets (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D21164?vs=60127=61959#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid removed rL LLVM as the repository for this revision. omjavaid updated this revision to Diff 67228. omjavaid added a comment. I have updated previous patch which handles compiler binaries which have version string appended at the end like gcc-4.9 or clang-3.5. Kindly give it a review

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid reopened this revision. omjavaid added a comment. reopening this for new review. https://reviews.llvm.org/D20386 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid updated this revision to Diff 67229. omjavaid added a comment. Adding context. https://reviews.llvm.org/D20386 Files: packages/Python/lldbsuite/test/make/Makefile.rules Index: packages/Python/lldbsuite/test/make/Makefile.rules

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

This revision was automatically updated to reflect the committed changes. Closed by commit rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D20386?vs=66258=66438#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:304 @@ +303,3 @@ + $(subst $(3),$(1),$(2)), \ + $(if $(findstring ar,$(1)), \ +$(if $(findstring gcc,$(3)), \

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid updated this revision to Diff 68339. omjavaid added a comment. so I have used ?= now with following new changes OBJCOPY ?= $(call replace_cc_with,objcopy) ARCHIVER ?= $(call replace_cc_with,ar) override AR = $(ARCHIVER) https://reviews.llvm.org/D20386 Files:

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

This revision was automatically updated to reflect the committed changes. Closed by commit rL278947: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D20386?vs=68339=68374#toc Repository: rL

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid added a comment. I like your suggestions and I dont think we have any other way but to use preset environment variable to detect what kind of TOOLCHAIN we want to use apart from some standard cases where we have the ability to detect through proposed hack logic. I agree we should

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

omjavaid added a comment. comments inline. Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_size/TestWatchpointSizes.py:43 @@ -42,2 +42,3 @@ """Test to selectively watch different bytes in a 8-byte array.""" -

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

omjavaid updated this revision to Diff 72589. omjavaid added a comment. This is a new version of what seems to me fully implementing functionality we intend to have here. On a second thought nuking ClearHardwareWatchpoint function seems to be the wrong approach here. I spent some time taking

[Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

omjavaid added a comment. @labath Referring to your email on the mailing list. Thanks for helping out with this work. I think we should push this fix, as you suggested this does not fix everything in a holistic way but it corrects the functionality that is currently available right now with

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

omjavaid added a comment. Answers to comments. I will upload a updated patch after corrections and updates. Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c:23 @@ +22,3 @@ +{ +printf("About to write byteArray[%d]

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

omjavaid updated this revision to Diff 71633. omjavaid added a comment. Herald added subscribers: srhines, danalbert, tberghammer. I have added a new test case that tests suggested scnario without changing any previous test cases. Also I have made sure we re validate all watchpoint installed on

[Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

omjavaid created this revision. omjavaid added a reviewer: labath. omjavaid added a subscriber: lldb-commits. Herald added subscribers: samparker, srhines, danalbert, tberghammer, rengolin, aemerson. On ARM Linux targets watchpoints are reported by PTrace before the instruction causing

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

omjavaid updated this revision to Diff 72723. omjavaid added a comment. Give this approach a rethink I dont see a lot of problems with this final implementation unless it fails on other architectures. We are already hacking our way to have these byte selection watchpoints working in existing

[Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

omjavaid updated this revision to Diff 75103. omjavaid added a comment. Sorry I was on Holiday so couldnt get back to this earlier. I ll get back to your comments about GDB packet sequence in a separate thread after collecting further information. I have made the suggested corrections in above

[Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL284706: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate… (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D25057?vs=75103=75272#toc Repository: rL

[Lldb-commits] [lldb] a6c40f5 - Revert "Fix lookup of symbols at the same address with no size vs. size"

Author: Muhammad Omair Javaid Date: 2019-11-12T19:02:17+05:00 New Revision: a6c40f56aed1556a80867209b6846f7eedc4dc78 URL: https://github.com/llvm/llvm-project/commit/a6c40f56aed1556a80867209b6846f7eedc4dc78 DIFF:

[Lldb-commits] [lldb] 7d175cf - [lldb] Xfail TestCallOverriddenMethod.py for aarch64/linux

Author: Muhammad Omair Javaid Date: 2019-12-09T16:38:33+05:00 New Revision: 7d175cf504bceb72a487a83ed9f640011832d46d URL: https://github.com/llvm/llvm-project/commit/7d175cf504bceb72a487a83ed9f640011832d46d DIFF:

[Lldb-commits] [lldb] 0964733 - [lldb] Remove Xfail decorators from steadily passing tests

Author: Muhammad Omair Javaid Date: 2019-12-09T19:08:59+05:00 New Revision: 0964733bae2d0823f7b431ee2b16a3fd1dd993e3 URL: https://github.com/llvm/llvm-project/commit/0964733bae2d0823f7b431ee2b16a3fd1dd993e3 DIFF:

[Lldb-commits] [lldb] 5536c62 - [lldb] Remove xpasses after pr44037 fix committed

Author: Muhammad Omair Javaid Date: 2019-12-13T12:30:58+05:00 New Revision: 5536c62f3c35015802dd59150d422c4ab79db581 URL: https://github.com/llvm/llvm-project/commit/5536c62f3c35015802dd59150d422c4ab79db581 DIFF:

[Lldb-commits] [lldb] b6f9d7b - Cleanup and speedup NativeRegisterContextLinux_arm64

Author: Muhammad Omair Javaid Date: 2019-12-06T22:18:57+05:00 New Revision: b6f9d7b8fb2eb6b78ac93ebd5ea4e36c04469285 URL: https://github.com/llvm/llvm-project/commit/b6f9d7b8fb2eb6b78ac93ebd5ea4e36c04469285 DIFF:

[Lldb-commits] [lldb] 8b8185b - Avoid triple corruption while merging core info

Author: Muhammad Omair Javaid Date: 2019-12-05T13:10:04+05:00 New Revision: 8b8185bb1b456e0ccf7b1ed1f00bc646853ab004 URL: https://github.com/llvm/llvm-project/commit/8b8185bb1b456e0ccf7b1ed1f00bc646853ab004 DIFF:

[Lldb-commits] [lldb] f9f30f2 - [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

Author: Muhammad Omair Javaid Date: 2019-11-14T13:53:58+05:00 New Revision: f9f30f2ecba520fa1ce33ae7c27c807a0e7199be URL: https://github.com/llvm/llvm-project/commit/f9f30f2ecba520fa1ce33ae7c27c807a0e7199be DIFF:

[Lldb-commits] [lldb] 9b95835 - [LLDB] Add core definition for armv8l and armv7l

Author: Muhammad Omair Javaid Date: 2019-11-13T05:40:09+05:00 New Revision: 9b958356983afffaf56788f37bdab9213369fa45 URL: https://github.com/llvm/llvm-project/commit/9b958356983afffaf56788f37bdab9213369fa45 DIFF:

[Lldb-commits] [lldb] eaddbc2 - LLDB AArch64 skip single_step_only_steps_one_instruction* tests

Author: Muhammad Omair Javaid Date: 2020-03-06T14:26:11+05:00 New Revision: eaddbc238d5fcca19432939223c87e4011b66546 URL: https://github.com/llvm/llvm-project/commit/eaddbc238d5fcca19432939223c87e4011b66546 DIFF:

[Lldb-commits] [lldb] fdc122e - Revert "[lldb/lldb-server] Add target.xml support for qXfer request."

Author: Muhammad Omair Javaid Date: 2020-02-18T10:16:52+05:00 New Revision: fdc122e4ed6fd04c31595635d45675ad68d258bd URL: https://github.com/llvm/llvm-project/commit/fdc122e4ed6fd04c31595635d45675ad68d258bd DIFF:

[Lldb-commits] [lldb] af64b31 - Add target.xml support for qXfer request.

Author: Muhammad Omair Javaid Date: 2020-02-20T23:03:54+05:00 New Revision: af64b31959f634031e5ddbcf8df1fab69689bfee URL: https://github.com/llvm/llvm-project/commit/af64b31959f634031e5ddbcf8df1fab69689bfee DIFF:

[Lldb-commits] [lldb] e25e3d7 - [lldb] Silent random xpass on aarch64-linux buildbot

Author: Muhammad Omair Javaid Date: 2019-12-27T17:01:58+05:00 New Revision: e25e3d75850113b90314606207b092c5bd707c4f URL: https://github.com/llvm/llvm-project/commit/e25e3d75850113b90314606207b092c5bd707c4f DIFF:

[Lldb-commits] [lldb] ee4dc98 - [lldb/test] Remove skip arm/aarch64 decorator from instruction counting tests

Author: Muhammad Omair Javaid Date: 2020-03-09T12:54:42+05:00 New Revision: ee4dc980c031d00ba729dfd731808b214e01ee58 URL: https://github.com/llvm/llvm-project/commit/ee4dc980c031d00ba729dfd731808b214e01ee58 DIFF:

[Lldb-commits] [lldb] 2b6ad82 - [lldb/test] Fix arch arm for 32-bit armv7l/armv8l

Author: Muhammad Omair Javaid Date: 2020-03-09T20:32:18+05:00 New Revision: 2b6ad82f8d0b20c6733217fcc6b3a07333287875 URL: https://github.com/llvm/llvm-project/commit/2b6ad82f8d0b20c6733217fcc6b3a07333287875 DIFF:

[Lldb-commits] [lldb] 2a436a0 - Mark TestFixIts.py xfail for LLDB AArch64/Linux

Author: Muhammad Omair Javaid Date: 2020-04-07T17:11:22+05:00 New Revision: 2a436a07ae9749ed4d3f42c0d1e660eb4f7ca6e8 URL: https://github.com/llvm/llvm-project/commit/2a436a07ae9749ed4d3f42c0d1e660eb4f7ca6e8 DIFF:

[Lldb-commits] [lldb] e609fe6 - Revert "[lldb-server] jThreadsInfo returns stack memory"

Author: Muhammad Omair Javaid Date: 2020-04-07T17:11:22+05:00 New Revision: e609fe68b2c59b145c0a5c66bedbee2bff545200 URL: https://github.com/llvm/llvm-project/commit/e609fe68b2c59b145c0a5c66bedbee2bff545200 DIFF:

  1   2   3   >