[Lldb-commits] [PATCH] D29405: Install six.py conditionally

2017-02-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Unfortunately, this prevents six.py being copied into the build directory, so a non-installed lldb will still not work (if you don't have the system six.py). It looks like you will have to pass this flag into finishSwigPythonLLDB.py and check the condition there.

[Lldb-commits] [PATCH] D29405: Install six.py conditionally

2017-02-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Look at top level CmakeLists.txt file you will find an add_custom_target rule that runs it. Repository: rL LLVM https://reviews.llvm.org/D29405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29405: Install six.py conditionally

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good, thank you. Repository: rL LLVM https://reviews.llvm.org/D29405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Per discussion in https://reviews.llvm.org/D28616, having two ways two request logging (log enable lldb XXX verbose && log enable -v lldb XXX) is confusing. This removes the first option and standardizes all code to use the second one. I've added a LLDB_LOGV macro

[Lldb-commits] [PATCH] D29496: Push down more common code into PlatformPOSIX

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294019: Push down more common code into PlatformPOSIX (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29496?vs=86975=86982#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D29496: Push down more common code into PlatformPOSIX

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. - GetFileWithUUID: All platforms except PlatformDarwin had this. However, I see no reason why this code would not apply there as well. - GetProcessInfo, FindProcesses: The implementation was the same in all classes. - GetFullNameForDylib: This code should apply to

[Lldb-commits] [PATCH] D29352: [CMake] Final dependency cleanup patch!

2017-02-01 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. BTW, I just noticed that the Breakpoint change has dos line breaks for some reason. Maybe that could be the cause. I'll try it out tomorrow. https://reviews.llvm.org/D29352 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D29352: [CMake] Final dependency cleanup patch!

2017-02-01 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. the newlines were a red herring. I think the problem is that you forgot to use the LINK_LIBS argument (see comment). This works on linux after applying this change (and fixing ObjectFileELF test dependencies, which you missed because they were added yesterday).

[Lldb-commits] [PATCH] D29514: Change Error::PutToLog to LLDB_LOG_ERROR

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. As for the modules part, I assumed the Log class will end up in the lowest layer also. I intended to move it there after I am done with it, but we can do it sooner if that is stopping you from doing anything. ( I do agree that it makes sense to reverse the dependency

[Lldb-commits] [PATCH] D29514: Change Error::PutToLog to LLDB_LOG_ERROR

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I'm not opposed to this patch, if people really want it, but I don't really see the value of this macro. Why couldn't I write `LLDB_LOG(log, "foo: {0}", error);` instead of `LLDB_LOG_ERROR(log, error, "foo");` Am I missing something? https://reviews.llvm.org/D29514

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: clayborg. labath added a comment. Adding greg in case he has some thoughts on this as well. https://reviews.llvm.org/D29510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Comment at: source/Target/SectionLoadList.cpp:70 bool warn_multiple) { - Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER | -

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 87046. labath added a comment. Herald added a subscriber: mgorny. Add ConstString formatter and use it. https://reviews.llvm.org/D29510 Files: include/lldb/Core/Log.h include/lldb/Core/Logging.h include/lldb/Utility/ConstString.h

[Lldb-commits] [PATCH] D29514: Change Error::PutToLog to LLDB_LOG_ERROR

2017-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good, just make sure it compiles. Comment at: lldb/include/lldb/Core/Log.h:18 #include "lldb/Utility/ConstString.h" +#include "lldb/Utility/Error.h" #include

[Lldb-commits] [PATCH] D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. @emaste: I'd suggest switching freebsd over to this process launcher as well. I think it's the last user of the ProcessLauncherPosix, and it would enable us to get rid of it. Repository: rL LLVM https://reviews.llvm.org/D29347

[Lldb-commits] [PATCH] D29352: [CMake] Final dependency cleanup patch!

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The main code seems to be fine now, but linking of unit tests (check-lldb-unit target) fails now. You'll probably need to explicitly set their dependencies as well before this can be removed. https://reviews.llvm.org/D29352

[Lldb-commits] [PATCH] D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Perfect. Thank you. Comment at: include/lldb/Host/posix/ProcessLauncherPosixFork.h:19 +public: + virtual HostProcess LaunchProcess(const ProcessLaunchInfo _info, +

[Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Looks reasonable. To make sure things stay this way, we should make sure that the Utility unit test has only this module specified as a dependency (I guess after @beanz is done with digging through that). Comment at:

[Lldb-commits] [PATCH] D29333: [CMake] Add accurate dependency specifications

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I like where this is going. I am not sure about a couple of details though. Please see comments. Comment at: source/Breakpoint/CMakeLists.txt:32 +lldbPluginObjCLanguage +LLVMSupport ) Shouldn't this be: `LINK_COMPONENTS

[Lldb-commits] [PATCH] D29266: Synchronize PlatformNetBSD with Linux

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. After looking at this closer, I don't think we will even need a separate class to achieve deduplication. The code is so heavily duplicated (see comments on the first three non-boilerplate functions, I did not look at the rest yet, but I expect the situation to be the

[Lldb-commits] [PATCH] D29333: [CMake] Add accurate dependency specifications

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D29333#661994, @beanz wrote: > In https://reviews.llvm.org/D29333#661979, @labath wrote: > > > I was thinking about that as well. I am not sure if it will work if we > > actually need multiple iterations of the loop to get all the dependencies

[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams

2017-02-06 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added subscribers: mgorny, emaste. This converts LLDB's logging to use llvm streams instead of lldb_private::Stream and friends. The changes are mostly straight-forward and amount to s/lldb_private::Stream/llvm::raw_ostream. The part worth calling out is the

[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams

2017-02-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The log callback gets passed down from the SB API (in the SBDebugger constructor, no less). My best guess is that it is (was?) used to display the debugger log in some IDE window. Comment at: source/Core/StreamCallback.cpp:22

[Lldb-commits] [PATCH] D29352: [CMake] Final dependency cleanup patch!

2017-02-07 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great. https://reviews.llvm.org/D29352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams

2017-02-08 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Ping. Any thoughts on this? https://reviews.llvm.org/D29615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29669: Hardware breakpoints implementation for AArch64 targets

2017-02-07 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Don't be intimidated by the number of comments :) - I think the change looks reasonable as a whole - most of them are just about style and come from the fact you were probably working on the patch while I was refactoring this code. As for tests, what I'd definitely want

[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams

2017-02-08 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thank you for the review. I'll submit this tomorrow. In https://reviews.llvm.org/D29615#670879, @clayborg wrote: > Looks good as long as if we type two log enable commands like: > > (lldb) log enable -f /tmp/a.txt lldb process > (lldb) log enable -f /tmp/a.txt lldb

[Lldb-commits] [PATCH] D29667: Synchronize PlatformFreeBSD with Linux

2017-02-07 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. cool https://reviews.llvm.org/D29667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29405: Install six.py copy into subdirectory lldb

2017-02-01 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. It does not seem to work for me. I get this when I run ninja check-lldb in the build directory: Traceback (most recent call last): File "/usr/local/google/home/labath/ll/llvm/tools/lldb/test/dotest.py", line 6, in import lldbsuite.test File

[Lldb-commits] [PATCH] D29126: [cmake] Remove VERSION property from executable targets

2017-02-01 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293803: [cmake] Remove VERSION property from executable targets (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29126?vs=85751=86685#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D29406: Unify PlatformPOSIX::ResolveExecutable

2017-02-01 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:163 + // Resolve any executable within a bundle on MacOSX + Host::ResolveExecutableInBundle(resolved_module_spec.GetFileSpec()); + This is the bit that was only

[Lldb-commits] [PATCH] D29406: Unify PlatformPOSIX::ResolveExecutable

2017-02-01 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. various platforms very using nearly identical code for this method. As far as I can tell there was nothing platform-specific about the differences, but rather it looked like it was caused by tiny tweaks being made to individual copies without affecting the overall

[Lldb-commits] [PATCH] D29406: Unify PlatformPOSIX::ResolveExecutable

2017-02-02 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293910: Unify PlatformPOSIX::ResolveExecutable (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29406?vs=86672=86846#toc Repository: rL LLVM https://reviews.llvm.org/D29406

[Lldb-commits] [PATCH] D29347: Add ProcessLauncherNetBSD to spawn a tracee

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This is also copying a lot of code only to make tiny changes to it. Please put the Linux process launcher into the posix folder (I suggest naming it ProcessLauncherPosixFork). Ifdef

[Lldb-commits] [PATCH] D29095: Open ELF core dumps with more than 64K sections

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293714: Open ELF core dumps with more than 64K sections (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29095?vs=86148=86507#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D29095: Open ELF core dumps with more than 64K sections

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Sorry, I have been a bit busy. I've committed this in now. Thank you for the patch. Repository: rL LLVM https://reviews.llvm.org/D29095 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29352: [CMake] Final dependency cleanup patch!

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I'll give this a spin on linux now. https://reviews.llvm.org/D29352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29352: [CMake] Final dependency cleanup patch!

2017-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. When linking liblldb.so: /usr/bin/ld.gold: error: cannot find -llldbPluginDynamicLoaderDarwinKernel https://reviews.llvm.org/D29352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D28858: Replace getcwd with the llvm equivalent

2017-01-23 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292795: Replace getcwd with the llvm equivalent (authored by labath). Changed prior to commit: https://reviews.llvm.org/D28858?vs=84828=85399#toc Repository: rL LLVM https://reviews.llvm.org/D28858

[Lldb-commits] [PATCH] D28858: Replace getcwd with the llvm equivalent

2017-01-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Any objections to this, Zach? https://reviews.llvm.org/D28858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29036: Add format_provider for lldb::StateType

2017-01-24 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292920: Add format_provider for lldb::StateType (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29036?vs=85419=85559#toc Repository: rL LLVM https://reviews.llvm.org/D29036

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

2017-01-30 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. > Interesting. Passing to what? I thought it means we shouldn't pass > non-trivial types through variadic arguments (... expression), and in this > case we don't do it because CMIUtilString is the type of the parameter > vFormating which

[Lldb-commits] [PATCH] D29266: Synchronize PlatformNetBSD with Linux

2017-01-30 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. How much of the code is now actually different between the two classes? If the only changes are of the s/linux/netbsd type, then we should just create a new base class for the two,

[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

2017-01-30 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I am glad we could come closer to the cause of the problem. At one point we should have a common base class for all core tests, so that we don't have to do this manually (and also avoid doing

[Lldb-commits] [PATCH] D29126: [cmake] Remove VERSION property from executable targets

2017-01-25 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added a subscriber: ki.stfu. Currently, in the default configuration, the "install" target will install all llvm executables unversioned, except for three lldb tools which will be installed versioned (with a non-versioned symlink). This rectifies that

[Lldb-commits] [PATCH] D29126: [cmake] Remove VERSION property from executable targets

2017-01-25 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. @sylvestre.ledru, I know that debian installs all llvm tools versioned, but I have no idea through which mechanism. I am guessing it must be something different than this, as this is lldb-specific. Do you know if you would be impacted by this?

[Lldb-commits] [PATCH] D28945: Add completed_plan_stack to LLDB ThreadStateCheckpoint

2017-01-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thank you both for explaining the situation. The "test failure on ubuntu" part threw me off -- I did not realize you were talking about hypothetical failure should a different change go in. I was worried we have some very environment-dependent tests. Looks good from my

[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

2017-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This seems like it's fixing the problem in the wrong place. Also, the assumption that the platform == host_platform is not correct (what about when the test is run on windows?) I

[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

2017-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Ok, I've just checked and this does not happen on windows. It does however happen (GetTriple() returning None) when we try to open the s390x core file (functionalities/postmortem/elf-core/linux-s390x.out). The test suite seems to be handling it fine. The only

[Lldb-commits] [PATCH] D29095: Open ELF core dumps with more than 64K sections

2017-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a subscriber: lldb-commits. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I've added a quick test to demonstrate what I had in mind. > Unfortunately, unlike release_39 branch, I cannot open my core dump, but the > problem

[Lldb-commits] [PATCH] D29126: [cmake] Remove VERSION property from executable targets

2017-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks. I guess I'll give this one more week, and then commit it if noone objects. https://reviews.llvm.org/D29126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29669: Hardware breakpoints implementation for Arm/AArch64 targets

2017-02-21 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I am sorry about the delay - I was busy last week and then this kinda fell off my radar. The change looks good, but I want to make the test more stable - we are running these in CI

[Lldb-commits] [PATCH] D30172: Replace WINLOG_*** macros with LLDB_LOG

2017-02-22 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295822: Replace WINLOG_*** macros with LLDB_LOG (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30172?vs=89130=89342#toc Repository: rL LLVM https://reviews.llvm.org/D30172

[Lldb-commits] [PATCH] D30234: Reformat inferior's main.cpp in lldb-server test

2017-02-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. clang-format did not pick up the correct formatting because we have a `.clang-format` file in `packages/Python/lldbsuite`. This was necessary because a lot of the tests would get broken, as the formatting would break our `// place breakpoint here` annotations (also,

[Lldb-commits] [PATCH] D30172: Replace WINLOG_*** macros with LLDB_LOG

2017-02-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D30172#682789, @amccarth wrote: > Maybe we have too many categories. Thanks. I was thinking about that as well. Currently there is about 110 log statements in the windows log and 8 log categories. Things wouldn't get too noisy even if we

[Lldb-commits] [PATCH] D30250: Switch "posix" to the new log channel registration mechanism

2017-02-22 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. This also removes magic rename code, which caused the channel to be called "linux" when built on a linux machine, and "freebsd" when built on a freebsd one, which seems unnecessary - registering a new channel is sufficiently simple now that if we wish to log

[Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved

2017-02-22 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. The compiled expression is not needed once the location goes away. Also, it holds a reference to the module, which prevents cleanup of the module if somebody holds a reference to the breakpoint object. This fixes the StepOverBreakpoint test on windows, but I am

[Lldb-commits] [PATCH] D30094: Fix a couple of corner cases in NameMatches

2017-02-20 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295651: Fix a couple of corner cases in NameMatches (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30094?vs=5=89102#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30168: Log: Fix race in accessing the stream variable

2017-02-20 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. The code was attempting to copy the shared pointer member in order to guarantee atomicity, but this is not enough. Instead, protect the pointer with a proper read-write mutex. This bug was present here for a long time, but my recent refactors must have altered the

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

2017-02-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Just found this lying on the bottom of my stack. Ed, if you don't object, I'd like to check in it. I think it is quite a safe change, so we probably don't need to do too much testing. https://reviews.llvm.org/D27126 ___

[Lldb-commits] [PATCH] D30172: Replace WINLOG_*** macros with LLDB_LOG

2017-02-20 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. The main difference here is that in the WINLOG macros you can specify log categories per call, whereas here you have to go the usual lldb route of getting a Log* variable first. While this means you have to write at least two statements, it usually means that each

[Lldb-commits] [PATCH] D30094: Fix a couple of corner cases in NameMatches

2017-02-17 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added a subscriber: mgorny. I originally set out to move the NameMatches closer to the relevant function and add some unit tests. However, in the process I've found a couple of bugs in the implementation: - the early exits where not always correct: -

[Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved

2017-02-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. > Note that the breakpoint location's site gets cleared when you disable the > breakpoint or its location, as well as when you delete it. So if you have a > workflow that does: "hit a breakpoint, disable it, hit another, reenable the > first, hit the second" you'll end

[Lldb-commits] [PATCH] D30286: Implement QPassSignals GDB package in lldb-server

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL296101: Implement QPassSignals GDB package in lldb-server (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30286?vs=89575=89623#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30286: Implement QPassSignals GDB package in lldb-server

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great. Thank you. https://reviews.llvm.org/D30286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I am not sure if this is a voting situation, but I agree with what Zachary said above. Since we're already speaking about tests, it looks like the new DataBufferLLVM class could use a unit test or two, just so we get in the habit of writing those.

[Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 89645. labath added a comment. Switch SBBreakpoint to weak_ptr. This diff is pretty big but it amounts to s/m_opaque_sp/m_opaque_wp and inserting a lock at the beginning of every function. Since I had to touch them anyway, I took the opportunity to upgrade the

[Lldb-commits] [PATCH] D29669: Hardware breakpoints implementation for Arm/AArch64 targets

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. lgtm, thanks. Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/main.cpp:30 + + hw_break_mutex.lock(); + I know it's

[Lldb-commits] [PATCH] D30334: Remove the callback-based log channel registration mechanism

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. All the existing channels have beens switched to the new mechanism and this code is now unused. https://reviews.llvm.org/D30334 Files: include/lldb/Core/Log.h source/API/SBCommandReturnObject.cpp source/Core/Log.cpp Index: source/Core/Log.cpp

[Lldb-commits] [PATCH] D30234: Reformat inferior's main.cpp in lldb-server test

2017-02-23 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. In https://reviews.llvm.org/D30234#683880, @eugene wrote: > I have added local .clang-format file. But it didn't change the way main.cpp > was formated. That's fine, I did not expect that to make a difference now. What it will do though,

[Lldb-commits] [PATCH] D30272: Improve data formatter for libstdcpp unique_ptr

2017-02-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Jim's comment definitely makes sense. If we happen to not use pretty-printer for the unique_ptr, it will not behave as a pointer-like object, and it should be formatted as a normal struct (I have no idea how much of a challenge it would be to implement it that way).

[Lldb-commits] [PATCH] D30234: Reformat inferior's main.cpp in lldb-server test

2017-02-23 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295950: Reformat inferior's main.cpp in lldb-server test (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30234?vs=89404=89480#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

2017-02-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I've tried this out on linux. I got it working only after making the following modifications: Comment at: lldb/include/lldb/Core/DataBufferLLVM.h:15 +#include "lldb/Host/FileSpec.h" +#include "llvm/Support/MemoryBuffer.h" + add

[Lldb-commits] [PATCH] D30272: Improve data formatter for libstdcpp unique_ptr

2017-02-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D30272#684610, @tberghammer wrote: > My original plan was to add it to the synthetic child provider but after some > thoughts and experimenting I concluded it doesn't really belongs to there > because it should be responsible for generating

[Lldb-commits] [PATCH] D30250: Switch "posix" to the new log channel registration mechanism

2017-02-23 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295954: Switch "posix" to the new log channel registration mechanism (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30250?vs=89348=89486#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved

2017-02-23 Thread Pavel Labath via Phabricator via lldb-commits
labath planned changes to this revision. labath added a comment. No worries. I'll come back soon with the weak_ptr thingy. https://reviews.llvm.org/D30249 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D30005: Fix compiler warnings for missing switch cases in lldb.

2017-02-17 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295445: Fix compiler warnings for missing switch cases in lldb. (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30005?vs=88604=88876#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone

2017-02-17 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks, I feel more comfortable with this one. Let's give the others a but more time to chime in. If they don't I guess you can submit this. :) https://reviews.llvm.org/D29985

[Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

2017-02-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I think you are still waiting to get the llvm changes sorted out, but this side of it looks fine to me (modulo a couple of nits). Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:414 + +data_sp =

[Lldb-commits] [PATCH] D29932: Fix TestNameLookup for GCC

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. GCC emits also symbols for the __PRETTY_FUNCTION__ virtual variable, which we accidentaly pick up when looking for functions for with "unique_function_name" in the name. This makes the target.FindFunctions call fail, as that symbol is not a function. I also

[Lldb-commits] [PATCH] D29909: Break some more dependencies in lldbUtility

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. looks good https://reviews.llvm.org/D29909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath marked an inline comment as done. labath added a comment. Comment at: source/Core/Log.cpp:72 +if (llvm::StringRef("all").equals_lower(categories[i])) { + flags |= ~0; + continue; zturner wrote: > This is a little clearer if you just say

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 88381. labath added a comment. New version of the patch. I can still see a bit of room for improvement, but I am not sure if I'll manage to do it today, so this should at least enable us to do another round-trip. https://reviews.llvm.org/D29895 Files:

[Lldb-commits] [PATCH] D29964: Finish breaking the dependency from lldbUtility -> Host

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Utility/VASprintf.cpp:18 + va_list args) { + llvm::SmallString<16> error(""); + It doesn't look like you should need to allocate a stack object with the string every time. Can't

[Lldb-commits] [PATCH] D29888: Fix debug build of unit tests

2017-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added a subscriber: mgorny. It turns out listing each library twice is not enough to resolve all references in a debug build on linux - a number of executables fails to link with random symbols missing. Increasing the number to three seems to be enough. The

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I actually did add tests for that. :) I didn't try to be super-exhaustive, but I think they provide reasonable coverage. I'd be happy to add more, if you notice parts that are missing it. https://reviews.llvm.org/D29895

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added a subscriber: aprantl. We currently have two log channel registration mechanisms. One uses a set of function pointers and the other one is based on the PluginManager. The PluginManager dependency is unfortunate, as logging is also used in lldb-server,

[Lldb-commits] [PATCH] D29823: Clean up debug logging

2017-02-13 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294939: Clean up debug logging (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29823?vs=87987=88175#toc Repository: rL LLVM https://reviews.llvm.org/D29823 Files:

[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams

2017-02-10 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294736: Convert Log class to llvm streams (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29615?vs=87349=87978#toc Repository: rL LLVM https://reviews.llvm.org/D29615

[Lldb-commits] [PATCH] D29823: Clean up debug logging

2017-02-10 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. We've had two ways to print a "debug" log message. - Log::GetDebug() was testing a Stream flag which was never set. - Log::Debug() was checking for the presence of "log enable --debug" flag. Given that these two were used very rarely and we already have a

[Lldb-commits] [PATCH] D30005: Fix compiler warnings for missing switch cases in lldb.

2017-02-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a subscriber: lldb-commits. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thank you for the patch. https://reviews.llvm.org/D30005 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone

2017-02-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. It does not seem too controversial, but I am not very confident reviewing lit changes. @beanz, could you take a look at this? Comment at: lit/lit.cfg:124 -debugserver = lit.util.which('debugserver', llvm_tools_dir) -lldb = lit.util.which('lldb',

[Lldb-commits] [PATCH] D29888: Fix debug build of unit tests

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295189: Fix debug build of unit tests (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29888?vs=88177=88544#toc Repository: rL LLVM https://reviews.llvm.org/D29888 Files:

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295190: Refactor log channel registration mechanism (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29895?vs=88395=88545#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D29144: LLDB: fix for TestCallThatThrows.py test fail

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The test added by this batch is failing on windows http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/2499, for a very prosaic reason - we cannot run a "make clean" as something is holding the executable file open. Based on my debugging, it is not a problem

[Lldb-commits] [PATCH] D29036: Add format_provider for lldb::StateType

2017-01-23 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D29036 Files: include/lldb/Core/State.h source/Plugins/Process/Linux/NativeProcessLinux.cpp unittests/Core/CMakeLists.txt unittests/Core/StateTest.cpp Index: unittests/Core/StateTest.cpp

[Lldb-commits] [PATCH] D29036: Add format_provider for lldb::StateType

2017-01-23 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 85419. labath added a comment. In this case, StateAsCString was returning a pointer to a static buffer in a scarily non-thread-safe way. I've changed it to print "unknown" instead and test for that. https://reviews.llvm.org/D29036 Files:

[Lldb-commits] [PATCH] D27459: Add a more succinct logging syntax

2017-01-18 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292360: Add a more succinct logging syntax (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27459?vs=84690=84814#toc Repository: rL LLVM https://reviews.llvm.org/D27459

[Lldb-commits] [PATCH] D27459: Add a more succinct logging syntax

2017-01-18 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Core/Log.cpp:78 + char *text; + vasprintf(, format, args); + message << text; zturner wrote: > dancol wrote: > > I usually implement printf-into-std::string by using `vsnprintf` to figure > > out how many

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

2017-01-19 Thread Pavel Labath via Phabricator via lldb-commits
labath abandoned this revision. labath marked 2 inline comments as done. labath added a comment. The new version of this patch is in https://reviews.llvm.org/D28880. https://reviews.llvm.org/D27289 ___ lldb-commits mailing list

  1   2   3   4   5   6   7   8   9   10   >