labath created this revision.
labath added reviewers: clayborg, ovyalov.
labath added subscribers: lldb-commits, dean.
in case we are logging to stdout, any log lines from the forked child can be
misconstrued to be
inferior output. To avoid this, we disable all logging immediately after
Hi all,
This commit was reverted in r245222 as it was causing failures on the
linux build-bot. It has a number of issues
http://reviews.llvm.org/rL245216 and I would prefer if it were not
merged until these are resolved. And in any case, this doesn't seem
like a critical bug fix suitable for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245272: [LLGS] Avoid misrepresenting log lines as inferior
output (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12083?vs=32298id=32383#toc
Repository:
rL LLVM
Author: labath
Date: Wed Aug 19 08:47:57 2015
New Revision: 245436
URL: http://llvm.org/viewvc/llvm-project?rev=245436view=rev
Log:
On Linux, clear the signal mask of the launched inferior
Summary:
Due to fork()/execve(), the launched inferior inherits the signal mask of its
parent
labath added a comment.
Ok, I see what you mean. I will commit it with the test enabled, and I will
keep an eye out on the buildbots.
http://reviews.llvm.org/D12138
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath updated this revision to Diff 32545.
labath added a comment.
Fix test on android arm - skip single-stepping over some functions
http://reviews.llvm.org/D12104
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.h
Author: labath
Date: Wed Aug 19 10:24:02 2015
New Revision: 245448
URL: http://llvm.org/viewvc/llvm-project?rev=245448view=rev
Log:
Increase timeout in TestCallThatRestarts
the test was failing on android because processing 30 signals involved a lot of
round-trips,
which was not possible in the
Author: labath
Date: Fri Aug 21 05:38:31 2015
New Revision: 245687
URL: http://llvm.org/viewvc/llvm-project?rev=245687view=rev
Log:
Add repro test case for bug #24530
Modified:
lldb/trunk/test/functionalities/signal/raise/TestRaise.py
Modified:
labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
There were a number of issues about the way I have designed this test
originally:
- it relied on single-stepping through large
labath added a comment.
There is a similar issue during thread destruction, although the underlying
reason is a bit different. I have created bug #24551 to track that.
http://reviews.llvm.org/D12280
___
lldb-commits mailing list
Author: labath
Date: Mon Aug 24 08:23:48 2015
New Revision: 245838
URL: http://llvm.org/viewvc/llvm-project?rev=245838view=rev
Log:
Make TestCreateDuringInstructionStep linux-specific
Summary:
There were a number of issues about the way I have designed this test
originally:
- it relied on
Author: labath
Date: Thu Aug 20 04:06:12 2015
New Revision: 245545
URL: http://llvm.org/viewvc/llvm-project?rev=245545view=rev
Log:
[NativeProcessLinux] Fix a bug in instruction-stepping over thread creation
Summary:
There was a bug in NativeProcessLinux, where doing an instruction-level
labath created this revision.
labath added reviewers: ovyalov, tberghammer.
labath added a subscriber: lldb-commits.
NPL used to be peppered with casts of the NativeThreadProtocol objects into
NativeThreadLinux. I
move these closer to the source where we obtain these objects. This way, the
rest
Author: labath
Date: Thu Aug 20 07:12:09 2015
New Revision: 24
URL: http://llvm.org/viewvc/llvm-project?rev=24view=rev
Log:
Increase timeout in TestCallWithTimeout to reduce flakyness
The test was flaky on the android buildbot, because the 10ms test completed
before we got a
chance to
Author: labath
Date: Thu Aug 20 06:37:19 2015
New Revision: 245552
URL: http://llvm.org/viewvc/llvm-project?rev=245552view=rev
Log:
Skip TestCreateDuringInstructionStep on android aarch64
we are unable to step through _M_start_thread due to atomic instruction
sequences.
Modified:
labath added a subscriber: labath.
Comment at: source/Utility/UriParser.cpp:13
@@ -12,4 +12,3 @@
// C Includes
-#include stdlib.h
-#include stdio.h
+#include string.h
ovyalov wrote:
tberghammer wrote:
I think you wanted to include string, not string.h
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245681: [NativeProcessLinux] Reduce the number of casts
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12187?vs=32673id=32805#toc
Repository:
rL LLVM
labath marked an inline comment as done.
labath added a comment.
Passing around pointers (shared or otherwise) encourages people to litter the
code with null pointer checks. For the next cleanup, I would like to move these
checks to a single place and then convert more of these functions to
labath updated this revision to Diff 32526.
labath marked 4 inline comments as done.
labath added a comment.
- Address review comments
http://reviews.llvm.org/D12104
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.h
labath added inline comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1457
@@ -1453,3 +1456,3 @@
-thread_sp = AddThread(pid);
+thread_sp =
std::static_pointer_castNativeThreadLinux(AddThread(pid));
assert (thread_sp.get()
Author: labath
Date: Mon Aug 24 04:22:04 2015
New Revision: 245831
URL: http://llvm.org/viewvc/llvm-project?rev=245831view=rev
Log:
[NativeProcessLinux] Pass around threads by reference
Summary:
Most NPL private functions took (shared) pointers to threads as arguments. This
meant that the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245831: [NativeProcessLinux] Pass around threads by
reference (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12237?vs=32824id=32937#toc
Repository:
rL LLVM
Author: labath
Date: Fri Oct 23 04:17:30 2015
New Revision: 251102
URL: http://llvm.org/viewvc/llvm-project?rev=251102=rev
Log:
Enable the libc++ tests on linux
Summary:
The list of loaded modules which skip_if_library_missing is depending on is not
available on
linux until after we run the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251102: Enable the libc++ tests on linux (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D13985?vs=38129=38221#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13985
Files:
labath added a comment.
test_categories is the name of .py file. :/ How about `add_test_categories` ?
http://reviews.llvm.org/D14020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath accepted this revision.
labath added a comment.
The new version of the patch looks much cleaner than the old one. Thanks.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:641
@@ -669,3 +640,3 @@
{
-if (m_flags.IsClear (got_flag))
+
labath added a subscriber: labath.
Comment at: test/make/Makefile.rules:304
@@ -303,3 +303,3 @@
else
- CXXFLAGS += -stdlib=libc++
+ CXXFLAGS += -stdlib=libc++ -DLLDB_USING_LIBCPP
LDFLAGS +=
Author: labath
Date: Thu Oct 22 04:34:40 2015
New Revision: 251004
URL: http://llvm.org/viewvc/llvm-project?rev=251004=rev
Log:
[AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets
Summary:
This short-circuits the GetObjCVersion function to avoid iterating through
target
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251277: Port the python api decorator to use test categories
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D14020?vs=38235=38383#toc
Repository:
rL LLVM
labath created this revision.
labath added reviewers: tfiala, dawn, ki.stfu, abidh.
labath added a subscriber: lldb-commits.
This change deprecates -m/+m dotest options (the options are still recognized
but they print an
error message pointing to the new options) and adds a new lldb-mi test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251400: Deprecate -m/+m dotest options in favor of test
categories (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D14060?vs=38389=38516#toc
Repository:
rL LLVM
Author: labath
Date: Tue Oct 27 04:23:55 2015
New Revision: 251399
URL: http://llvm.org/viewvc/llvm-project?rev=251399=rev
Log:
Fix race condition in process resume
Summary:
Gdb-remote's async thread sent out the eBroadcastBitRunPacketSent message
*before* actually
sending out the continue
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251399: Fix race condition in process resume (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D14083?vs=38429=38515#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14083
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I like this. (I assume it will work with the tcp-connected devices which have
an ID like `???:port`)
http://reviews.llvm.org/D14101
___
Author: labath
Date: Tue Oct 27 04:34:34 2015
New Revision: 251400
URL: http://llvm.org/viewvc/llvm-project?rev=251400=rev
Log:
Deprecate -m/+m dotest options in favor of test categories
Summary:
This change deprecates -m/+m dotest options (the options are still recognized
but they print an
Author: labath
Date: Thu Oct 29 08:44:09 2015
New Revision: 251626
URL: http://llvm.org/viewvc/llvm-project?rev=251626=rev
Log:
Fix flakyness in TestChangeProcessGroup
The test was verifying that the pid of the child is not equal to its process
group by searching for text substrings. This failed
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
Thanks for the patch. Looks good, but we need to make sure things continue to
work on non-linux systems...
Comment at: tools/lldb/source/Host/common/File.cpp:301
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good.
argdumper should probably go to /usr/libexec, but then I guess we won't be able
to find it, so that's a different story...
http://reviews.llvm.org/D14169
labath added a comment.
We have XFAILed MI tests that were failing on our linux build bot. Atm, I am
seeing expected passes, so I might try enabling them soon...
However, these tests are not remote-ready, so we have to skip them on the
android built bots.
http://reviews.llvm.org/D14060
Author: labath
Date: Mon Oct 26 11:25:28 2015
New Revision: 251301
URL: http://llvm.org/viewvc/llvm-project?rev=251301=rev
Log:
[lldb-server] Send PC of every thread along in the stop-reply packet
This avoids the need to query the PC for private resume operations (public
resumes have the PC
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Gdb-remote's async thread sent out the eBroadcastBitRunPacketSent message
*before* actually
sending out the continue packet. Since it's this message the actually triggers
the public state
labath created this revision.
labath added reviewers: tberghammer, tfiala, granata.enrico, zturner.
labath added a subscriber: lldb-commits.
Per discussions on the mailing list, I have implemented a decorator which
annotates individual
test methods with categories. I have used this framework to
labath added a subscriber: labath.
labath added a comment.
I don't think we should bump the version over a trivial issue like this. cmake
2.8 is still the default on alot of systems.
Wouldn't a well placed quote work also? Like,
`FOO="${BAR}" codesign --force --end`
Or just putting the command
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13940
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: labath
Date: Wed Oct 21 07:56:37 2015
New Revision: 250896
URL: http://llvm.org/viewvc/llvm-project?rev=250896=rev
Log:
Clean up more .dwo files after the tests run
Modified:
lldb/trunk/test/lang/cpp/incomplete-types/Makefile
lldb/trunk/test/make/Makefile.rules
Author: labath
Date: Fri Nov 13 05:56:09 2015
New Revision: 253034
URL: http://llvm.org/viewvc/llvm-project?rev=253034=rev
Log:
Re-add XFAILs to two tests
these decorators were two of many removed in r253026. Unlike others, these
tests still seem to be
failing...
Modified:
Author: labath
Date: Mon Nov 16 05:11:10 2015
New Revision: 253197
URL: http://llvm.org/viewvc/llvm-project?rev=253197=rev
Log:
Revert "Add a "not_in()" function you can apply to the list type arguments to
expectedFailureAll to reverse"
This reverts commit r253106.
Modified:
Author: labath
Date: Thu Oct 29 22:52:27 2015
New Revision: 251684
URL: http://llvm.org/viewvc/llvm-project?rev=251684=rev
Log:
Make new dotest.py executable
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py (contents, props
changed)
Modified:
BTW, is lldb/test/dotest.py here to stay? I thought it was there just to
avoid breaking anybody who runs dotest directly (instead of ninja
check-lldb), and therefore we will remove it once everybody gets a chance
to migrate (I have already changed our buildbots to not use it).
Is that correct or
It doesn't matter to me which dotest to run, I just want to know what is
the "right way". Due to enrico's patch, I couldn't run one dotest, so I
switched to another one. Now, with your patch, the other way is also
broken. Could you also go through with the other part of your change
(reverting
Author: labath
Date: Fri Oct 30 09:08:19 2015
New Revision: 251699
URL: http://llvm.org/viewvc/llvm-project?rev=251699=rev
Log:
Mark another TestEvents test as flaky on linux
I don't think anything has changed recently - the test was always flaky, but
only very rarely. Still, it is causing noise
labath created this revision.
labath added reviewers: clayborg, jingham.
labath added a subscriber: lldb-commits.
The code which was preventing the usage of the OS plugin while detach is in
progress also prevented us to update the thread list correctly. This resulted
in an empty thread list,
Author: labath
Date: Mon Nov 2 14:54:25 2015
New Revision: 251830
URL: http://llvm.org/viewvc/llvm-project?rev=251830=rev
Log:
[dosep] Fix-up callers of process_dir, after it got its argument removed
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dosep.py
Modified:
Author: labath
Date: Mon Nov 2 17:41:44 2015
New Revision: 251863
URL: http://llvm.org/viewvc/llvm-project?rev=251863=rev
Log:
Revert "Make new dotest.py executable"
This was a misunderstanding on my part. The new dotest.py is not meant to be
executed directly.
Modified:
age__ = lldbsuite.test
>>> Inside unittest2.loadTestsFromName : __package__ = unittest2
>>> Inside TestMultithreaded.py : __package__ = None
>>>
>>> Restoring the link by writing
>>>
>>> __package__ = "lldbsuite.test"
>>>
>&g
Author: labath
Date: Mon Nov 2 19:39:03 2015
New Revision: 251880
URL: http://llvm.org/viewvc/llvm-project?rev=251880=rev
Log:
Fix usage of removed decorator in TestExpressions
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/expressions/TestExpressions.py
Modified:
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
From what I can tell, it should just work. I assume you've done the obvious
checks, like deliberately failing a test and seeing it registers as failed,
etc. I think we should just commit it,
labath added a comment.
(The upstream unittest does not seem to have the bugnumber feature. I am
assuming the intention here is to make this upstream compatible, in hope of
moving over there at some point.)
http://reviews.llvm.org/D14406
___
Author: labath
Date: Tue Nov 3 10:05:18 2015
New Revision: 251932
URL: http://llvm.org/viewvc/llvm-project?rev=251932=rev
Log:
Fix race during process detach
Summary:
The code which was preventing the usage of the OS plugin while detach is in
progress also prevented us to update the thread list
labath added a subscriber: labath.
labath added a comment.
If the registers are not present, wouldn't it be better to *not* include them
in qRegisterInfo response in the first place?
Repository:
rL LLVM
http://reviews.llvm.org/D13859
___
labath added a comment.
This looks much better, I just have a couple of small remarks.
Comment at: include/lldb/Target/UnixSignals.h:116
@@ -114,1 +115,3 @@
+ const char *description,
+ const char *alias = NULL);
nullptr
Author: labath
Date: Thu Oct 15 09:44:29 2015
New Revision: 250409
URL: http://llvm.org/viewvc/llvm-project?rev=250409=rev
Log:
Fix temporary directory computation on linux (pr25147)
On linux, the environment variables for temp directories that lldb checks for
are generally not
defined, and the
Author: labath
Date: Thu Oct 15 09:46:46 2015
New Revision: 250412
URL: http://llvm.org/viewvc/llvm-project?rev=250412=rev
Log:
Revert "Fix temporary directory computation on linux (pr25147)"
I actually did not want to commit this without review, but I mistyped. :/
Modified:
labath added inline comments.
Comment at: source/Host/posix/DomainSocket.cpp:74
@@ +73,3 @@
+FileSystem::Unlink(FileSpec{name, true});
+
+Error error;
If we're going to use unique names, then this won't be necessary (and I would
much rather see a random
labath added a subscriber: labath.
labath added a comment.
Not really my area, but couldn't the needed functionality be implemented on top
of GetChildAtIndex(). I mean, if GetChildAtIndex(50) returns a valid SBValue,
then the container has at least 50 elements, right?
Then
labath added a comment.
Zachary, I don't think using std::async is a good idea because it provides a
very different threading model than the one we want here. Let me demonstrate
that with an example:
#include
#include
#include
#include
#include
using namespace std;
Author: labath
Date: Fri Oct 16 04:32:05 2015
New Revision: 250502
URL: http://llvm.org/viewvc/llvm-project?rev=250502=rev
Log:
Fix temporary directory computation on linux (pr25147)
Summary:
On linux, the environment variables for temp directories that lldb checks for
are generally not
labath created this revision.
labath added reviewers: clayborg, tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
ADB packets have a fixed size of 4k. This means the size of memory reads does
not affect speed
too much (as long as it
labath added a comment.
How big of an error does it have to be for that to happen? Is that something we
would consider an "lldb bug"/"data formatter bug" or it can be caused by
something out of our control, like missing debug info on one of the children?
http://reviews.llvm.org/D13778
labath updated this revision to Diff 37776.
labath added a comment.
Adress review comments.
http://reviews.llvm.org/D13812
Files:
include/lldb/Target/Platform.h
source/Plugins/Platform/Android/PlatformAndroid.cpp
source/Plugins/Platform/Android/PlatformAndroid.h
labath added a comment.
New version of the patch. I agree that it looks better like this.
I have put the setting logic in the process constructor, rather than doing it
lazily - if anyone was observing the setting value, it would seem strange that
the value of setting changed suddenly after the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250814: Increase default memory cache line size for android
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13812?vs=37776=37845#toc
Repository:
rL LLVM
labath added a comment.
I think this should go in a little bit deeper, i.e., inside the
NativeRegisterContextLinux_mips, or whatever is the right class for you. I
think this is better for several reasons:
- if the register is physically not present, the register context should not
report it
Author: labath
Date: Tue Oct 20 05:33:17 2015
New Revision: 250814
URL: http://llvm.org/viewvc/llvm-project?rev=250814=rev
Log:
Increase default memory cache line size for android
Summary:
ADB packets have a maximum size of 4k. This means the size of memory reads does
not affect speed
too much
labath added a comment.
Good catch. fixed and committed.
Repository:
rL LLVM
http://reviews.llvm.org/D13812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
> When such an error occurs, it is unlikely to be an lldb bug, or
> data-formatter bug. One can come up with a data structure for which reading a
> child element would require complete debug info, but reading the # of child
> elements need not require complete debug
Hi Enrico,
Could you explain what was the motivation behind this change?
I am asking because, I have just learned that this commit has caused
all libc++ tests to be skipped on linux*, silently decreasing test
coverage on linux. I would like to replace this with some other
mechanism, which is not
labath created this revision.
labath added a reviewer: granata.enrico.
labath added subscribers: sivachandra, lldb-commits.
Loop detection code is being called before every element access. Although it
tries to cache some
of the data by remembering the loop-free initial segment, every time it
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250890: [DataFormatters] Make libc++ list loop detection
linear (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13902?vs=37891=37981#toc
Repository:
rL LLVM
Author: labath
Date: Wed Oct 21 05:17:21 2015
New Revision: 250890
URL: http://llvm.org/viewvc/llvm-project?rev=250890=rev
Log:
[DataFormatters] Make libc++ list loop detection linear
Summary:
Loop detection code is being called before every element access. Although it
tries to cache some
of
labath added a subscriber: labath.
labath added a comment.
Hi,
you seem to have an out-of-bounds access here:
/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:1629:5:
warning: array index 3 is past the end of the array (which contains 3
elements)
labath updated this revision to Diff 37340.
labath added a comment.
The new functionality gets picked up by the client and automatically used
everywhere, so I'm not
really worried about testing it. A more important issue would be making sure
that the legacy read
packet does not rot as it is now
Author: labath
Date: Wed Oct 14 06:50:37 2015
New Revision: 250290
URL: http://llvm.org/viewvc/llvm-project?rev=250290=rev
Log:
Revert "RenderScript command for printing allocation contents"
This commit breaks TestDataFormatterSmartArray on all buildbots.
Modified:
labath added a comment.
Hi,
I have reverted this as all the bots were getting red. In the test, variable
was getting printed as `[{},{},{},{},{},{},{}]` instead of
`{78.5},{77.25},{78},{76.125},{76.75},{76.875},{77}`. Please resubmit once the
issue is resolved.
Repository:
rL LLVM
labath updated this revision to Diff 37341.
labath added a comment.
Remove files which slipped in...
http://reviews.llvm.org/D13695
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
Author: labath
Date: Wed Oct 14 07:59:37 2015
New Revision: 250295
URL: http://llvm.org/viewvc/llvm-project?rev=250295=rev
Log:
lldb-server: add support for binary memory reads
Summary:
This commit adds support for binary memory reads ($x) to lldb-server. It also
removes the "0x"
prefix from
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13581
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
> RHEL 7 is already doing this - most of lib is 64-bit. All of lib64 is
> 64-bit. They already use both (~600 MB in lib, ~1GB in lib64 on a stock
> system). I have also built custom
Author: labath
Date: Mon Oct 12 08:42:16 2015
New Revision: 250038
URL: http://llvm.org/viewvc/llvm-project?rev=250038=rev
Log:
dotest.py: Remove useless AttributeError catches
Summary:
Test decorators were ignoring AttributeError exceptions. These were introduced
three years ago,
and copied to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250038: dotest.py: Remove useless AttributeError catches
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13583?vs=36933=37102#toc
Repository:
rL LLVM
labath added a comment.
In http://reviews.llvm.org/D13625#264862, @tfiala wrote:
> In http://reviews.llvm.org/D13625#264786, @labath wrote:
>
> > Could you submit the change with full context next time? It makes review
> > much easier.
>
>
> Tell me the diff line you want. I'm doing the same
labath added a comment.
In http://reviews.llvm.org/D13625#264888, @tfiala wrote:
> > Tell me the diff line you want. I'm doing the same type of diffs I have
> > submitted for years. I'll adjust my process.
>
>
> Are you wanting something like this (assuming done with git diff)?
> git diff
Author: labath
Date: Mon Oct 12 12:43:03 2015
New Revision: 250069
URL: http://llvm.org/viewvc/llvm-project?rev=250069=rev
Log:
TestAttachResume is still flaky on linux. mark it as such
Modified:
lldb/trunk/test/functionalities/attach_resume/TestAttachResume.py
Modified:
Author: labath
Date: Fri Oct 9 06:15:50 2015
New Revision: 249823
URL: http://llvm.org/viewvc/llvm-project?rev=249823=rev
Log:
Rename one of the TestGoASTContexts
Added:
lldb/trunk/test/lang/go/runtime/TestGoLanguageRuntime
- copied, changed from r249819,
labath created this revision.
labath added reviewers: tberghammer, zturner.
labath added subscribers: lldb-commits, iancottrell.
Log files produced by dotest have names derived from the test name, and this
produces errors in
case we have multiple tests with the same name. Additionally, it's good
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249828: dotest.py: Fail if we detect multiple tests with the
same name (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13588?vs=36939=36941#toc
Repository:
rL LLVM
Author: labath
Date: Fri Nov 13 07:37:53 2015
New Revision: 253042
URL: http://llvm.org/viewvc/llvm-project?rev=253042=rev
Log:
Re-XFAIL two more tests I missed
Modified:
lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
Modified:
labath added a subscriber: labath.
labath requested changes to this revision.
labath added a reviewer: labath.
labath added a comment.
This revision now requires changes to proceed.
I don't approve of automagic dependencies. With this patch it won't be possible
to force curses usage. Even if you
labath added a comment.
A bit late to the party, but anyway... I would change the detection logic here:
Instead of `ALLOW_STATIC_BINDINGS`, have `USE_STATIC_BINDINGS`. If it's set,
don't even bother checking for swig's presence and use the static bindings. If
it's not set, then detect swig, and
labath added a comment.
In http://reviews.llvm.org/D12416#235166, @tfiala wrote:
instead of making another layer on top of that (it's bad enough we have
dosep and dotest already).
The existence of those two is at least partly due to the organic nature in
which they developed.
I
1 - 100 of 3047 matches
Mail list logo
