[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd853bd7a4e86: [lldb/Lua] add support for multiline scripted breakpoints (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0d7406ae800: [LLDB/Lua] add support for one-liner breakpoint callback (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 308029. tammela marked 3 inline comments as done. tammela added a comment. Addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files:

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added inline comments. Comment at: lldb/bindings/lua/lua-wrapper.swig:21-22 +{ + lldb::SBFrame sb_frame(stop_frame_sp); + lldb::SBBreakpointLocation sb_bp_loc(bp_loc_sp); + labath wrote: > What's up with the copying? Is it to ensure the callback does

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. The code that calls into the ScriptInterpreter was not considering the case that it receives a Lua interpreter.

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela added a comment. In D92249#2422205 , @labath wrote: > In D92249#2421639 , @JDevlieghere > wrote: > >> It appears there are many similar calls in this file, can you update those >> as well? > > If there

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 308319. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files: lldb/bindings/lua/lua-swigsafecast.swig

[Lldb-commits] [PATCH] D92729: [LLDB] fix error message for one-line breakpoint scripts

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB is ignoring compilation errors for one-line breakpoint scripts. This patch fixes the issues and now the error message of the ScriptInterpreter is

[Lldb-commits] [PATCH] D92729: [LLDB] fix error message for one-line breakpoint scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG280ae10774ab: [LLDB] fix error message for one-line breakpoint scripts (authored by tammela). Changed prior to commit:

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 307440. tammela added a comment. Remove unnecessary wrappers/checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files: lldb/bindings/lua/lua-swigsafecast.swig

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela marked an inline comment as done. tammela added a comment. In D91508#2413582 , @labath wrote: > Right. That's why I'd like to have good wrappers, which make it easy to do > the right thing, and hard to do the wrong one. > > I don't think we're

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added a comment. > I'm not sure what you mean by that. Can you elaborate? Sure, it's was just a nod to your previous comment about that running callbacks (C++ lambdas) inside a `pcall` is a dangerous API. Although possible, it requires that the developer be very cautious about implicit

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 307202. tammela added a comment. Redesign of the API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files: lldb/bindings/lua/lua-swigsafecast.swig

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd055e3a0eb4e: [LLDB/Python] Fix segfault on Python scripted entrypoints (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela updated this revision to Diff 308608. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92249/new/ https://reviews.llvm.org/D92249 Files:

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 1 - Partial Statements The interpreter loop runs every line it receives, so partial Lua statements are not being handled properly. This is a problem

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela updated this revision to Diff 312942. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93481/new/ https://reviews.llvm.org/D93481 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:62 +case eIOHandlerWatchpoint: + break; +case eIOHandlerBreakpoint: JDevlieghere wrote: > Shouldn't this be the same for break- and

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adds support for running a Lua function when a breakpoint is hit. Example: breakpoint command add -s lua -F abc The above runs the Lua function

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err);

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 305427. tammela added a comment. Clean up includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files: lldb/bindings/lua/lua-swigsafecast.swig

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:60-78 +static int runCallback(lua_State *L) { + LuaCallback *callback = static_cast(lua_touserdata(L, -1)); + return (*callback)(L); +} + +llvm::Error Lua::Run(LuaCallback ) { +

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:60-78 +static int runCallback(lua_State *L) { + LuaCallback *callback = static_cast(lua_touserdata(L, -1)); + return (*callback)(L); +} + +llvm::Error Lua::Run(LuaCallback ) { +

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added a comment. In D91508#2400222 , @JDevlieghere wrote: > In D91508#2396392 , @tammela wrote: > >> @JDevlieghere >> >> When writing this patch I noticed that there is no mechanism in-place to >> remove

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 305874. tammela marked 4 inline comments as done and an inline comment as not done. tammela added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:200 + Debugger = target->GetDebugger(); + ScriptInterpreterLua *lua_interpreter = + static_cast(debugger.GetScriptInterpreter()); labath wrote:

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. These callbacks are set using the following: breakpoint command add -s lua -o "print('hello world!')" The

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added a comment. @JDevlieghere When writing this patch I noticed that there is no mechanism in-place to remove the Python/Lua function when the breakpoint is removed or when the callback function is replaced. The class that sets the callback provides `ClearCallback()` but it never

[Lldb-commits] [PATCH] D90556: [LLDB][NFC] treat Lua error codes in a more explicit manner

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b9fa3b705c8: [LLDB][NFC] treat Lua error codes in a more explicit manner (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D90556: [LLDB][NFC] treat Lua error codes in a more explicit manner

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. This patch is a minor suggestion to not rely on the fact that the `LUA_OK` macro is 0. This assumption could

[Lldb-commits] [PATCH] D90557: [LLDB/Lua] call lua_close() on Lua dtor

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. This patch calls `lua_close()` on Lua dtor. This guarantees that the Lua GC finalizers are honored, aside from

[Lldb-commits] [PATCH] D90557: [LLDB/Lua] call lua_close() on Lua dtor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d7d6f276c6d: [LLDB/Lua] call lua_close() on Lua dtor (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. This patch changes the implementation of Lua's `print()` function to respect `io.stdout`. The original

[Lldb-commits] [PATCH] D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

tammela updated this revision to Diff 303088. tammela added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90787/new/ https://reviews.llvm.org/D90787 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

[Lldb-commits] [PATCH] D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca17571051d4: [LLDB-lua] modify Luas print to respect io.stdout (authored by tammela). Changed prior to commit:

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela updated this revision to Diff 313870. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93481/new/ https://reviews.llvm.org/D93481 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err);

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela added inline comments. Comment at: lldb/test/Shell/ScriptInterpreter/Lua/breakpoint_function_callback.test:15 +r +# CHECK: +breakpoint command add -s lua -o "abc(frame, bp_loc, ...)" JDevlieghere wrote: > Can we unpack the SBStructuredData and check

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2511222 , @JDevlieghere wrote: > I replied before I actually tried to understand what your'e trying to > achieve, and it's still not entirely clear to me. I think what you need is > something similar like

[Lldb-commits] [PATCH] D94937: [lldb/Lua] add initial Lua typemaps

This revision was automatically updated to reflect the committed changes. Closed by commit rG5997e8987f68: [lldb/Lua] add initial Lua typemaps (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG532e4203c5be: [lldb/Lua] add support for Lua function breakpoint (authored by tammela). Changed prior to commit:

[Lldb-commits] [PATCH] D94937: [lldb/Lua] add initial Lua typemaps

tammela updated this revision to Diff 318300. tammela added a comment. Typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/ https://reviews.llvm.org/D94937 Files: lldb/bindings/lua/lua-typemaps.swig Index:

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela updated this revision to Diff 318298. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/ https://reviews.llvm.org/D94937 Files: lldb/bindings/lua/lua-typemaps.swig Index:

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2505676 , @JDevlieghere wrote: > We guarantee that the SB API is ABI stable so you cannot change the signature > of existing functions. Would an overload do the trick? If overloaded with `const char

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela added inline comments. Comment at: lldb/bindings/lua/lua-wrapper.swig:25-29 + auto extra_args = [&]() -> llvm::Optional { + if (extra_args_impl == nullptr) + return {}; + return lldb::SBStructuredData(extra_args_impl); + } ();

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela updated this revision to Diff 317395. tammela added a comment. Addressing comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93649/new/ https://reviews.llvm.org/D93649 Files: lldb/bindings/lua/lua-swigsafecast.swig

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela added a comment. @JDevlieghere Addressed all your comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93649/new/ https://reviews.llvm.org/D93649 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela updated this revision to Diff 318775. tammela added a comment. Rebasing and unwrapping the SBStructuredData test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93649/new/ https://reviews.llvm.org/D93649 Files:

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch changes the GetStringValue method on the SBStructuredData class to return a `const char *`. This change allows the use of the method on the

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela updated this revision to Diff 317439. tammela added a comment. Removing spurious line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/ https://reviews.llvm.org/D94937 Files: lldb/bindings/interface/SBStructuredData.i

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2505676 , @JDevlieghere wrote: > We guarantee that the SB API is ABI stable so you cannot change the signature > of existing functions. Would an overload do the trick? Hmmm, that's tricky. I will see if I can come up

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93649/new/ https://reviews.llvm.org/D93649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93481/new/ https://reviews.llvm.org/D93481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

tammela accepted this revision. tammela added a comment. This revision is now accepted and ready to land. I tested locally and it seems fine! Thanks. Comment at: lldb/test/Shell/ScriptInterpreter/Lua/watchpoint_callback.test:23 +c +# CHECK: conditional watchpoint +#

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81ba283131c: [lldb/lua] Add scripted watchpoints for Lua (authored by Siger Yang sigerye...@gmail.com, committed by tammela). Changed prior to

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

tammela added a comment. Clang format complained a bit, please fix those. Comment at: lldb/test/Shell/ScriptInterpreter/Lua/watchpoint_callback.test:15 +# CHECK: val=nil +# CHECK: Process {{[0-9]+}} exited More tests cases would be nice Repository: rG LLVM

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

tammela added a comment. I think we are getting there, just some more details Comment at: lldb/docs/use/scripting-example.rst:822 +The complete code for the Dictionary program (with case-conversion bug), the +DFS function and other Python script examples (tree_utils.py) used

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

tammela accepted this revision. tammela added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104281/new/ https://reviews.llvm.org/D104281 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

tammela accepted this revision. tammela added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/new/ https://reviews.llvm.org/D108515

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela requested changes to this revision. tammela added a comment. This revision now requires changes to proceed. Missing test cases! Either a script that test it all, individual unit tests or a combination of both. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela added inline comments. Comment at: lldb/bindings/lua/lua-typemaps.swig:198 + size_t size = lua_rawlen(L, $input); + $1 = (char **)malloc((size + 1) * sizeof(char *)); + int i = 0, j = 0; This seems it could leak. Are you sure it doesn't?

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

tammela added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) mstorsjo wrote: > siger-young wrote: > > mstorsjo

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela added a comment. Trying to run the tests in my system failed with the following: Comment at: lldb/CMakeLists.txt:60-68 + execute_process( + COMMAND ${Lua_EXECUTABLE} + -e "for w in string.gmatch(package.cpath, ';?([^;]+);?') do \ + if

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela added a comment. Hi Siger, We are almost there. I encourage you to continue working on this patch. I have been busy the past weeks, but I will try to review ASAP once you address my comments. Comment at: lldb/bindings/lua/lua-typemaps.swig:219-221

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

tammela added inline comments. Comment at: lldb/docs/use/scripting-reference.rst:572 +Create a new lldb command +- So I'm guessing some sections are still missing some updates because the Lua functionality is not there yet right? If

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

tammela requested changes to this revision. tammela added a comment. This revision now requires changes to proceed. @siger-young Are these still relevant to the code that was landed recently? For this one, please wait @JDevlieghere's review. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela added a comment. Just one last thing and I think we are done! Thanks for your work. Comment at: lldb/test/API/lua_api/lua_lldb_test.lua:3 +EXPORT_ASSERT_TO_GLOBALS = true +require('luaunit') + Could we not use an external dependency? For instance in

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela added inline comments. Comment at: lldb/test/API/lua_api/lua_lldb_test.lua:3 +EXPORT_ASSERT_TO_GLOBALS = true +require('luaunit') + siger-young wrote: > tammela wrote: > > Could we not use an external dependency? > > For instance in my setup it fails

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela accepted this revision. tammela added a comment. LGTM. You will have to rebase to main. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090 ___