[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor added a comment. I generated a report for the remaining cyclic dependencies in the `lldb` module here . Note that I'll provide a modulemap for the `source/` headers in another patch, so this is out of scope for this

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor created this revision. teemperor added a reviewer: aprantl. This patch adds a modulemap which allows compiling the lldb headers into C++ modules (for example in builds with LLVM_ENABLE_MODULES=On). Even though most of the affected code has been cleaned up to work with the more strict

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor updated this revision to Diff 151827. teemperor added a comment. - Added test case https://reviews.llvm.org/D48303 Files: packages/Python/lldbsuite/test/expression_command/xvalue/Makefile packages/Python/lldbsuite/test/expression_command/xvalue/TestXValuePrinting.py

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor created this revision. If we have an xvalue here, we will always hit the `err_typecheck_invalid_lvalue_addrof` error in 'Sema::CheckAddressOfOperand' when trying to take the address of the result. This patch uses the fallback code path where we store the result in a local variable

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor planned changes to this revision. teemperor added a comment. - Needs a test https://reviews.llvm.org/D48303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor updated this revision to Diff 151828. teemperor added a comment. - Removed now unnecessary brackets. https://reviews.llvm.org/D48303 Files: packages/Python/lldbsuite/test/expression_command/xvalue/Makefile

[Lldb-commits] [PATCH] D48096: Disable warnings for the generated LLDB wrapper source

This revision was automatically updated to reflect the committed changes. Closed by commit rL334557: Disable warnings for the generated LLDB wrapper source (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151077. teemperor added a comment. - The regex that removes the modules cache now actually removes the whole flag + path. - Fixed more typos. https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap source/Host/CMakeLists.txt

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151004. teemperor retitled this revision from "Add modulemap to lldb include directory" to "Add modules support for lldb headers in include/". teemperor edited the summary of this revision. teemperor added a comment. This revision is now accepted and ready

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor added inline comments. Comment at: include/lldb/module.modulemap:66 +// This big module is necessary to work around the cyclic dependencies +// between its submodules. +module lldb { teemperor wrote: > bruno wrote: > > Will this trick be enough for

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151023. teemperor added a comment. - Obj-C -> Obj-C++ https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap source/Host/CMakeLists.txt source/Host/common/Terminal.cpp source/Host/macosx/Host.mm

[Lldb-commits] [PATCH] D47411: Mute some compiler warnings in the generated python wrapper code.

teemperor abandoned this revision. teemperor added a comment. It seems people are also in favor of completely disabling the warnings, so that patch will replace this one. https://reviews.llvm.org/D47411 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D47996: Added modulemap for lldb-mi

teemperor edited subscribers, added: lldb-commits; removed: cfe-commits. teemperor added a comment. - Fixed mailing list subscriber. https://reviews.llvm.org/D47996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D48096: Disable warnings for the generated LLDB wrapper source

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added a subscriber: mgorny. This source files emits all kind of compiler warnings on different platforms. As the source code in the file is generated and we therefore can't actually fix the warnings, we might as well

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151025. teemperor marked an inline comment as done. teemperor added a comment. - Fixed a typo. https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap source/Host/CMakeLists.txt source/Host/common/Terminal.cpp

[Lldb-commits] [PATCH] D47996: Added modulemap for lldb-mi

This revision was automatically updated to reflect the committed changes. Closed by commit rL334549: Added modulemap for lldb-mi (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47996?vs=150663=151033#toc

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151181. teemperor added a comment. - Finally found the one and only way to spell "Objective-C++" https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap source/Host/CMakeLists.txt source/Host/common/Terminal.cpp

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor planned changes to this revision. teemperor added a comment. It seems the compilation fails on OS X with this modulemap (or any modulemap). The reason seems to be that on OS X we compile Obj-C++ as part of lldb which assumes that Clang/LLVM is valid Obj-C++. However, the Obj-C parsing

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor added a comment. @aprantl It's good for build times and more importantly it's consistent with the way Clang/LLVM are naming/organizing their modules. But I actually don't have a strong opinion on how the modules are named/organized. @bruno Breaking up the lldb module in the future is

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor updated this revision to Diff 150604. teemperor added a comment. - Removed some inconsistent white space. https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap Index: include/lldb/module.modulemap ===

[Lldb-commits] [PATCH] D48339: Refactor ClangUserExpression::Parse [NFC]

teemperor created this revision. This patch splits out functionality from the `Parse` method into different methods. This benefits the code completion work (which should reuse those methods) and makes the code a bit more readable. Note that this patch is as minimal as possible. Some of the

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor updated this revision to Diff 151967. teemperor added a comment. - Generalized test case a bit more and no longer checking only for 0. https://reviews.llvm.org/D48303 Files: packages/Python/lldbsuite/test/expression_command/xvalue/Makefile

[Lldb-commits] [PATCH] D48337: Refactor OnExit utility class in ClangUserExpression

teemperor created this revision. OnExit ensures we call `ResetDeclMap` before this method ends. However, we also have a few manual calls to ResetDeclMap in there that are actually unnecessary because of this (calling the method multiple times has no effect). This patch also moves the class out

[Lldb-commits] [PATCH] D48337: Refactor OnExit utility class in ClangUserExpression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL335078: Refactor OnExit utility class in ClangUserExpression (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D47923: Added missing include to LoadedModuleInfoList.h

teemperor created this revision. https://reviews.llvm.org/D47923 Files: include/lldb/Core/LoadedModuleInfoList.h Index: include/lldb/Core/LoadedModuleInfoList.h === --- include/lldb/Core/LoadedModuleInfoList.h +++

[Lldb-commits] [PATCH] D47923: Added missing include to LoadedModuleInfoList.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334259: Added missing include to LoadedModuleInfoList.h (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL43: Dont include headers from inside a namespace in MIUtilSingletonHelper.h (authored by teemperor, committed by ).

[Lldb-commits] [PATCH] D47411: Mute some compiler warnings in the generated python wrapper code.

teemperor created this revision. teemperor added a reviewer: zturner. Herald added a subscriber: mgorny. With SWIG 3.0.12 I get the following compiler warnings when compiling LLDB: tools/lldb/scripts/LLDBWrapPython.cpp:23699:52: warning: format string is not a string literal (potentially

[Lldb-commits] [PATCH] D47409: Forward declare DumpValueObjectOptions in ValueObject.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL42: Forward declare DumpValueObjectOptions in ValueObject.h (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D47412: Add missing includes to some LLDB headers.

teemperor created this revision. Herald added a subscriber: ki.stfu. When compiling with modules, these missing includes cause the build to fail (as the header can't be compiled into a module). https://reviews.llvm.org/D47412 Files:

[Lldb-commits] [PATCH] D47409: Forward declare DumpValueObjectOptions in ValueObject.h

teemperor created this revision. This resolves unnecessary the header dependency from Core to DataFormatters. Patch is necessary for the introduction of C++ modules to the LLDB build system. https://reviews.llvm.org/D47409 Files: include/lldb/Core/ValueObject.h source/Core/ValueObject.cpp

[Lldb-commits] [PATCH] D47412: Add missing includes to some LLDB headers.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL45: Add missing includes to some LLDB headers. (authored by teemperor, committed by ). Herald added a subscriber:

[Lldb-commits] [PATCH] D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h

teemperor created this revision. Herald added a subscriber: ki.stfu. https://reviews.llvm.org/D47410 Files: tools/lldb-mi/MIUtilSingletonHelper.h Index: tools/lldb-mi/MIUtilSingletonHelper.h === ---

[Lldb-commits] [PATCH] D47418: Fix memory leak in SubsPrimitiveParmItanium

teemperor created this revision. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. FastDemangle gives us a C-string that we own (which is allocated in SymbolDemangler::GetDemangledCopy). As we are not deleting the string, we leak memory whenever we call

[Lldb-commits] [PATCH] D47418: Fix memory leak in SubsPrimitiveParmItanium

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL53: Fix memory leak in SubsPrimitiveParmItanium (authored by teemperor, committed by ). Herald added a subscriber:

[Lldb-commits] [PATCH] D48796: Refactoring for for the internal command line completion API (NFC)

teemperor created this revision. teemperor added reviewers: davide, jingham, labath. Herald added a subscriber: mgorny. This patch refactors the internal completion API. It now takes (as far as possible) a single CompletionRequest object instead o half a dozen in/out/in-out parameters. The

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor updated this revision to Diff 153126. teemperor added a comment. - We now also handle the case where a guarded mutex is manually unlocked from a nested call. - Refactoring based on review comments. https://reviews.llvm.org/D48463 Files: include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D48659: Allow specifying an exit code for the 'quit' command

teemperor created this revision. teemperor added a reviewer: davide. This patch adds the possibility to specify an exit code when calling quit. We accept any int, even though it depends on the user what happens if the int is out of the range of what the operating system supports as exit codes.

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor marked 2 inline comments as done. teemperor added a comment. @labath Thanks for the explanation! Well in theory we could poke more holes in our guard from some nested function, but this only fixes the deadlock symptom. PrintAsync would still be blocking whenever the mutex is hold by

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor updated this revision to Diff 153129. teemperor edited the summary of this revision. teemperor added a comment. - Fixed that we only pass a nullptr as a debugger to the real editline object (which now fixes the deadlock in the code completion patch). https://reviews.llvm.org/D48463

[Lldb-commits] [PATCH] D48665: Added test case for: r334978 - Fixed file completion for paths that start with '~'

teemperor created this revision. teemperor added a reviewer: labath. https://reviews.llvm.org/D48665 Files: unittests/Interpreter/TestCompletion.cpp Index: unittests/Interpreter/TestCompletion.cpp === ---

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor added a reviewer: labath. teemperor added a subscriber: labath. teemperor added a comment. Adding Pavel because he wrote the PrintAsync code. Also @labath: Can you tell me what variables/functionality the `m_output_mutex` in Editline.cpp is supposed to shield? I don't see any

[Lldb-commits] [PATCH] D48796: Refactoring for for the internal command line completion API (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL336146: Refactoring for for the internal command line completion API (NFC) (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D48796: Refactoring for for the internal command line completion API (NFC)

teemperor added a comment. @jingham Just trying to keep this patch as minimal/NFC as possible because we can't revert it once the expr completion patch is merged. I'll open reviews for all these other refactorings once this is in. https://reviews.llvm.org/D48796

[Lldb-commits] [PATCH] D48855: Fixed compilation failure after the code completion refactor patch

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336149: Fixed compilation failure after the code completion refactor patch (authored by teemperor, committed by ). Herald

[Lldb-commits] [PATCH] D48855: Fixed compilation failure after the code completion refactor patch

teemperor created this revision. https://reviews.llvm.org/D48855 Files: include/lldb/Interpreter/CommandObject.h include/lldb/Utility/CompletionRequest.h Index: include/lldb/Utility/CompletionRequest.h === ---

[Lldb-commits] [PATCH] D48858: FIx XCode project files for lldb

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336154: FIx XCode project files for lldb (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D48858: FIx XCode project files for lldb

teemperor created this revision. Herald added a subscriber: srhines. Fixes the XCode builds that started failing when i added CompletionRequest.cpp/.h. The patch is so large because XCode decided to write the lines back in its own order, but essentially we only added on e file.

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/expr_completion/TestExprCompletion.py:177-215 +def generate_random_expr(self, run_index): +""" +Generates a random expression. run_index seeds the rng, so +

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor planned changes to this revision. teemperor added a comment. Actually, because both @labath and @jingham requested refactoring to get rid of the `--` search (even though Phabricator couldn't parse Jim's comment), I'll first also refactor this one. Thanks for the feedback!

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor updated this revision to Diff 153748. teemperor marked 13 inline comments as done. teemperor added a comment. - Addresses the problems pointed out by Adrian and Pavel (Thanks!) - Now using the completion API patch to get rid of the code that rebuilds the command line string from the

[Lldb-commits] [PATCH] D42338: Fix unrepresentable float value in ScalarTest

teemperor created this revision. teemperor added a reviewer: uweigand. float can't represent the given value in the literal, so we get this UB error: `runtime error: 1.23457e+48 is outside the range of representable values of type 'float'`. The test seems to not rely on this specific value, so

[Lldb-commits] [PATCH] D42339: Fix uninitialized variable in GoParser

teemperor created this revision. teemperor added a reviewer: ribrdb. teemperor edited the summary of this revision. `m_last_tok` isn't initialized anywhere before it's used the first time (most likely in the `GoParser::Rule::error` method), which causes most of the GoParser tests to fail with

[Lldb-commits] [PATCH] D42336: Fix memory leaks in TestArm64InstEmulation

teemperor created this revision. teemperor added a reviewer: jasonmolenda. Herald added subscribers: kristof.beyls, javed.absar, aemerson. We never delete the created instances, so those test fail with the memory sanitizer. https://reviews.llvm.org/D42336 Files:

[Lldb-commits] [PATCH] D42340: [modules] Fix missing includes/typo in LLDB's includes. [NFC]

teemperor created this revision. teemperor added a reviewer: aprantl. This patch adds missing includes to the LLDB headers inside `include/` as a first step of building LLDB's source with C++ modules. Includes in lldb seem to be commented if the reason for the include is not obvious (`// for

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

teemperor created this revision. teemperor added a reviewer: dvlahovski. We never delete the allocated RegisterContext objects, causing those tests to fail with enabled memory sanitizer. https://reviews.llvm.org/D42347 Files: unittests/Process/minidump/MinidumpParserTest.cpp Index:

[Lldb-commits] [PATCH] D42340: [modules] Fix missing includes/typo in LLDB's includes. [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL323064: [modules] Fix missing includes/typo in LLDBs includes. [NFC] (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42345: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex

teemperor created this revision. This fixes a clang warning. https://reviews.llvm.org/D42345 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Index: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp === ---

[Lldb-commits] [PATCH] D42346: Fix use after free in DiskFilesOrDirectories

teemperor created this revision. teemperor added a reviewer: zturner. We copy the local variable `Resolved` into `Storage` to keep it around. However, we then still let the `SearchDir` ref point to `Resolved` which then is used to access the already freed memory later on. With this patch we

[Lldb-commits] [PATCH] D42348: Prevent unaligned memory read in parseMinidumpString

teemperor created this revision. teemperor added reviewers: dvlahovski, zturner. It's possible to hit an unaligned memory read when reading `source_length` as the `data` array is only aligned with 2 bytes (it's actually a UTF16 array). This patch memcpy's `source_length` into a local variable

[Lldb-commits] [PATCH] D42346: Fix use after free in DiskFilesOrDirectories

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323082: Fix use after free in DiskFilesOrDirectories (authored by teemperor, committed by ). Herald added a subscriber:

[Lldb-commits] [PATCH] D42345: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rL323075: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42336: Fix memory leaks in TestArm64InstEmulation

This revision was automatically updated to reflect the committed changes. Closed by commit rL323076: Fix memory leaks in TestArm64InstEmulation (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42338: Fix unrepresentable float value in ScalarTest

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323081: Fix unrepresentable float value in ScalarTest (authored by teemperor, committed by ). Herald added a subscriber:

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

This revision was automatically updated to reflect the committed changes. Closed by commit rL323085: Fix memory leaks in MinidumpParserTest (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

teemperor updated this revision to Diff 130846. teemperor added a comment. - Using make_unique now. https://reviews.llvm.org/D42347 Files: unittests/Process/minidump/MinidumpParserTest.cpp Index: unittests/Process/minidump/MinidumpParserTest.cpp

[Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

teemperor created this revision. We can't use unique_ptr's here because we use those variables as `out` parameters to some functions. Discovered by the memory sanitizer. https://reviews.llvm.org/D42386 Files: unittests/Symbol/TestClangASTContext.cpp Index:

[Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323138: Fix memory leak in TestClangASTContext.TestRecordHasFields (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D42348: Prevent unaligned memory read in parseMinidumpString

This revision was automatically updated to reflect the committed changes. Closed by commit rL323181: Prevent unaligned memory read in parseMinidumpString (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42409: Fix memory leaks in GoParser

teemperor created this revision. teemperor added reviewers: labath, davide. The GoParser is leaking memory in the tests due to not freeing allocated nodes when encountering some parsing errors. With this patch all GoParser tests are passing with enabled memory sanitizers/ubsan.

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor added a comment. Note that there are two parent revisions. One is just refactoring because I needed to reuse some of the parsing setup code. The other patch (the AsyncPrint one) fixes a deadlock that affected this patch. The deadlock can be reproduces by starting lldb, going to a

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor created this revision. While working on the `expr` completion, I've encountered the issue that sometimes lldb deadlocks when doing input/output. The underlying cause for this is that we seem to expect that we can always call `Debugger::PrintAsync` from any point of lldb and that this

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor updated this revision to Diff 152402. teemperor added a comment. - Small code style adjustment. https://reviews.llvm.org/D48463 Files: include/lldb/Core/Debugger.h source/Core/Debugger.cpp source/Core/IOHandler.cpp Index: source/Core/IOHandler.cpp

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor added subscribers: friss, jingham. teemperor added a comment. Not sure who should review this, but maybe Fred or Jim know :) https://reviews.llvm.org/D48463 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor created this revision. teemperor added a reviewer: jingham. Herald added subscribers: JDevlieghere, aprantl. This patch adds initial code completion support for the `expr` command. We now have a completion handler in the expression CommandObject that essentially just attempts to parse

[Lldb-commits] [PATCH] D49949: Add missing boundary checks to variable completion.

teemperor created this revision. Stopgap patch to at least stop all the crashes I get from this code. https://reviews.llvm.org/D49949 Files: packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py packages/Python/lldbsuite/test/functionalities/completion/main.cpp

[Lldb-commits] [PATCH] D49947: Add the actually calculated completions to COMPLETION_MSG

teemperor created this revision. Otherwise this assertion message is not very useful to whoever is reading the log. https://reviews.llvm.org/D49947 Files: packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py packages/Python/lldbsuite/test/lldbtest.py Index:

[Lldb-commits] [PATCH] D49947: Add the actually calculated completions to COMPLETION_MSG

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338179: Add the actually calculated completions to COMPLETION_MSG (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D49949: Add missing boundary checks to variable completion.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338177: Add missing boundary checks to variable completion. (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D49949: Add missing boundary checks to variable completion.

teemperor updated this revision to Diff 157803. teemperor added a comment. - Fixed formatting. https://reviews.llvm.org/D49949 Files: packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py packages/Python/lldbsuite/test/functionalities/completion/main.cpp

[Lldb-commits] [PATCH] D49947: Add the actually calculated completions to COMPLETION_MSG

teemperor updated this revision to Diff 157806. teemperor added a comment. - FIxed formatting. https://reviews.llvm.org/D49947 Files: packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py packages/Python/lldbsuite/test/lldbtest.py Index:

[Lldb-commits] [PATCH] D50159: Add byte counting mechanism to LLDB's Stream class.

teemperor updated this revision to Diff 158777. teemperor added a comment. - Fixing some of the merge conflicts. - Fixed doxygen comment. Thanks for the reviews! https://reviews.llvm.org/D50159 Files: include/lldb/Core/StreamAsynchronousIO.h include/lldb/Core/StreamBuffer.h

[Lldb-commits] [PATCH] D50192: Fix: ClangHighlighter.cpp should not be in CopyFiles, but in lldb-core targets

teemperor added a reviewer: t.p.northover. teemperor added a comment. This was changed by https://reviews.llvm.org/rLLDB338712 so I think Tim probably knows better what's going on here. https://reviews.llvm.org/D50192 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D50159: Add byte counting mechanism to LLDB's Stream class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL338733: Add byte counting mechanism to LLDBs Stream class. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50225: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID

teemperor created this revision. teemperor added a reviewer: vsk. Instead of iterating over our vector of functions, we might as well use a map here to directly get the function we need. Thanks to Vedant for pointing this out. Repository: rLLDB LLDB https://reviews.llvm.org/D50225 Files:

[Lldb-commits] [PATCH] D49750: Add support for ARM and ARM64 breakpad generated minidump files.

teemperor added a comment. I don't see this mentioned here yet, so: This patch also seems to introduce a few hundred warnings with -Wextended-offsetof (which is enabled by default on the macOS builds):

[Lldb-commits] [PATCH] D50162: Replace LLDB's LEB128 implementation with the one from LLVM

teemperor updated this revision to Diff 158930. teemperor added a reviewer: labath. teemperor added a comment. - Fixed compilation errors after changes in parent revision. https://reviews.llvm.org/D50162 Files: source/Utility/Stream.cpp Index: source/Utility/Stream.cpp

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

teemperor updated this revision to Diff 158926. teemperor added a reviewer: labath. teemperor added a comment. - Renamed m_forward_to to m_target. - Added a getter to allow external code to use the raw_ostream API. - Renamed m_forward to m_forwarder. @labath Thanks, fixed the problems you

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

This revision was automatically updated to reflect the committed changes. Closed by commit rL338901: Add raw_ostream wrapper to the Stream class (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50015: Remove unnecessary newlines from break command help text.

teemperor created this revision. We usually don't have trailing newlines in the short help strings. This just adds unnecessary extra lines when printing the help text of these commands. https://reviews.llvm.org/D50015 Files: source/Interpreter/CommandInterpreter.cpp Index:

[Lldb-commits] [PATCH] D50027: Added initial unit test for LLDB's Stream class.

teemperor created this revision. Herald added a subscriber: mgorny. This adds an initial small unit test for LLDB's Stream class, which should at least cover most of the functions in the Stream class. StreamString is always in big endian mode, so that's the only stream byte order path this test

[Lldb-commits] [PATCH] D50025: Don't ignore byte_order in Stream::PutMaxHex64

teemperor added a comment. Yeah, on a second thought I should just strip out the parts of the unit test that found this bug and commit them alongside this. https://reviews.llvm.org/D50025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D50026: Remove Stream::UnitTest

teemperor created this revision. No one is using this method, and it also doesn't really make a lot of sense to have it around. https://reviews.llvm.org/D50026 Files: include/lldb/Utility/Stream.h source/Utility/Stream.cpp Index: source/Utility/Stream.cpp

[Lldb-commits] [PATCH] D50025: Don't ignore byte_order in Stream::PutMaxHex64

teemperor updated this revision to Diff 158126. teemperor edited the summary of this revision. teemperor added a comment. - Reverse patch dependencies that we can add the unit test here (but also means this has to wait until the StreamTest is in). https://reviews.llvm.org/D50025 Files:

[Lldb-commits] [PATCH] D50015: Remove unnecessary newlines from break command help text.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338311: Remove unnecessary newlines from break command help text. (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D50025: Don't ignore byte_order in Stream::PutMaxHex64

teemperor created this revision. Note: We don't have a unittest for Stream yet, so the regression test for this will be added with the upcoming Stream unit test. https://reviews.llvm.org/D50025 Files: source/Utility/Stream.cpp Index: source/Utility/Stream.cpp

[Lldb-commits] [PATCH] D50027: Added initial unit test for LLDB's Stream class.

teemperor updated this revision to Diff 158127. teemperor added a comment. - Removed MaxHex64 test (which moved to the child revision to be in the same commit as the related bug). https://reviews.llvm.org/D50027 Files: unittests/Utility/CMakeLists.txt unittests/Utility/StreamTest.cpp

[Lldb-commits] [PATCH] D50026: Remove Stream::UnitTest

This revision was automatically updated to reflect the committed changes. Closed by commit rL338345: Remove Stream::UnitTest (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50026?vs=158120=158151#toc

[Lldb-commits] [PATCH] D49831: Don't print two errors for unknown commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rL338040: Dont print two errors for unknown commands. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D49866: Fix duplicate suggestions after an ambiguous command

teemperor created this revision. So far lldb is printing this when it finds an ambiguous command: (lldb) g Ambiguous command 'g'. Possible matches: gdb-remote gui gdb-remote gui The duplicates come from the fact that we call the same query twice with

  1   2   3   4   5   6   7   8   9   10   >