[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

2019-05-04 Thread Raul Tambre via Phabricator via lldb-commits
tambre created this revision. tambre added a reviewer: zturner. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython. CPython 3.8 has added a SyntaxWarning for

[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

2020-04-03 Thread Raul Tambre via Phabricator via lldb-commits
tambre added a comment. In D61548#1960310 , @JDevlieghere wrote: > Why did you abandon this? It's been lingering for a long time, so I wanted to get it off my dashboard. The patch also requires updating as the file has moved. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Raul Tambre via Phabricator via lldb-commits
tambre updated this revision to Diff 315847. tambre added a comment. Don't modify third-party checked-in libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 Files: clang/CMakeLists.txt

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Raul Tambre via Phabricator via lldb-commits
tambre marked an inline comment as done. tambre added inline comments. Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3 - -project (benchmark) - ldionne wrote: > I don't think we want to change this. It's a third-party project (which is >

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Raul Tambre via Phabricator via lldb-commits
tambre created this revision. tambre added a reviewer: phosek. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, lebedev.ri,

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Raul Tambre via Phabricator via lldb-commits
tambre added a reviewer: ldionne. tambre added a comment. ldionne: for libc++ review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-27 Thread Raul Tambre via Phabricator via lldb-commits
tambre marked an inline comment as done. tambre added a comment. ldionne: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-27 Thread Raul Tambre via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG480643a95cd1: [CMake] Remove dead code setting policies to NEW (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/