[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

SouraVX added a comment. Since `bbc` based test can't be added here, would you mind adding a unit-test here ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87389/new/ https://reviews.llvm.org/D87389 ___

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX created this revision. SouraVX added reviewers: JDevlieghere, clayborg, labath. SouraVX added a project: LLDB. Herald added subscribers: lldb-commits, aprantl. Herald added a reviewer: jdoerfert. This patch adds support for DWARFv5 new forms: DW_MACRO_define_strx, DW_MACRO_undef_strx.

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX marked an inline comment as done. SouraVX added inline comments. Comment at: lldb/test/Shell/Commands/Inputs/dwarf5-macro.s:1 + .text + .file "test.c" This file is generated via clang/llvm with macro section support. -- will upstream that p

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX updated this revision to Diff 237909. SouraVX added a comment. Thank you everyone, for taking out time and reviewing this. Addressed @clayborg review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72597/new/ https://reviews.llvm.org/D72597 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX marked 4 inline comments as done. SouraVX added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp:62 +const DWARFDataExtractor &debug_str_offset_data, const DWARFDataExtractor &debug_str_data, const bool offset_is_64_bit,

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX added a comment. In D72597#1819164 , @labath wrote: > I have a high-level question/comment. Are you planning to implement > debug_macro reading in llvm-dwarfdump? Even if you aren't, I am expecting > that you will be asked to do that as a part of