[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

ted created this revision. ted added reviewers: jingham, LLDB. Herald added a subscriber: lldb-commits. An address breakpoint of the form "b 0x1000" won't resolve if it's created while the process isn't running. This patch deletes Address::SectionWasDeleted, renames Address::SectionWasDeletedPri

[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

ted added a comment. Yes, I'll add a new test to TestAddressBreakpoints.py. Repository: rLLDB LLDB https://reviews.llvm.org/D51816 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

ted updated this revision to Diff 164533. ted added a comment. Added a test to TestAddressBreakpoints.py that sets an address breakpoint before launch, launches, and checks to see if the breakpoint was hit. https://reviews.llvm.org/D51816 Files: include/lldb/Core/Address.h packages/Python

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

ted added a comment. Another issue: auto context = symbol.getRawSymbol().getName(); auto context_size = context.rfind("::"); ... auto from = 0; while (from < context_size) { context_size is size_t (from std::string::rfind), but on clang 5.01, "auto from = 0" makes from an int. The

[Lldb-commits] [PATCH] D41533: Advanced guessing of rendezvous breakpoint

ted added a comment. Thanks for adding me, Pavel. Hexagon running Linux uses this plugin. These changes lgtm. Standalone Hexagon uses its own dyld plugin; I need to look at it and see if I want to pull any of these ideas into it. https://reviews.llvm.org/D41533

[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

ted added a comment. Traditionally, remote gdbservers handle memory operations that overlap a software breakpoint. Writes get the new value saved off, and reads get the breakpoint opcode replaced by the saved value. https://reviews.llvm.org/D39967 ___

[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

ted added a comment. In https://reviews.llvm.org/D39967#1017754, @labath wrote: > I believe lldb-server does not work around breakpoint opcodes during writing > (it does for reading), but that can be fixed, of course. It should. If it doesn't, then a write over a breakpoint would clobber it.

[Lldb-commits] [PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

ted added a comment. @JDevlieghere I'm seeing the same issue as @alberto_magni . The Visual Studio cmake generator gives errors. We're reverting it internally, but it needs to be fixed or reverted ASAP. The issue could be this set of code from test/CMakeLists.txt: configure_file( ${CMAK

[Lldb-commits] [PATCH] D37154: lldb-mi: -var-update can hang when traversing complex types with pointers

ted created this revision. -var-update calls CMICmdCmdVarUpdate::ExamineSBValueForChange to check if a varObj has been updated. It checks that the varObj is updated, then recurses on all of its children. If a child is a pointer pointing back to a parent node, this will result in an infinite loo

[Lldb-commits] [PATCH] D37154: lldb-mi: -var-update can hang when traversing complex types with pointers

ted updated this revision to Diff 113310. ted added reviewers: clayborg, abidh. ted removed a subscriber: abidh. ted added a comment. Added check for reference types, as Greg suggested. Simplified change. https://reviews.llvm.org/D37154 Files: tools/lldb-mi/MICmdCmdVar.cpp Index: tools/lld

[Lldb-commits] [PATCH] D37154: lldb-mi: -var-update can hang when traversing complex types with pointers

ted updated this revision to Diff 113317. ted marked an inline comment as done. ted added a comment. Updated with Greg's suggestion. Removed second call to GetValueDidChange() because it's handled at the top of the recursive call. This way we get 1 extra call to ExamineSBValueForChange() on a c

[Lldb-commits] [PATCH] D37154: lldb-mi: -var-update can hang when traversing complex types with pointers

ted added a comment. We want to go down into a pointer if it's the original parent, but not into a child that's a pointer. To avoid skipping children of a top-level pointer/reference, I think we need to do the type check in the loop. https://reviews.llvm.org/D37154 _

[Lldb-commits] [PATCH] D37533: Fix lldb-mi test data_read_memory_bytes_global

ted added a comment. Tested with clang 3.8 on top-of-tree lldb-mi on Ubuntu 14. https://reviews.llvm.org/D37533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D37533: Fix lldb-mi test data_read_memory_bytes_global

ted created this revision. Herald added a subscriber: aprantl. Test was skipped because -data-evaluate-expression was thought to not work on globals. This is not the case - the issue was clang removes debug info for globals in cpp files that are not used. Add a reference to the globals in questio

[Lldb-commits] [PATCH] D39215: Default to using in-tree clang for building test executables

ted added a comment. We build lldb, clang and tools for Hexagon only, and call them hexagon-lldb, hexagon-clang, etc. The test infrastructure is smart enough to pick up hexagon-lldb-mi if we tell it to run with hexagon-lldb using --executable; will it be smart enough to run an in-tree hexagon-c

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

ted added a comment. FYI, @jingham , this is also an issue with DYLD plugins, if the file in the link map starts with ".". Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57552/new/ https://reviews.llvm.org/D57552 _

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

ted added a comment. Herald added a project: LLDB. @sgraenitz I've found an issue with this patch, using the Visual Studio 2015 generator. In scripts/CMakeLists.txt the old code (for Windows): if (CMAKE_CONFIGURATION_TYPES) set(SWIG_PYTHON_DIR ${CMAKE_BINARY_DIR}/\${CMAKE_INSTALL_CONFIG_

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

ted added a comment. In D57552#1381046 , @jingham wrote: > In D57552#1380782 , @ted wrote: > > > FYI, @jingham , this is also an issue with DYLD plugins, if the file in the > > link map starts with ".". "image sear

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

ted added a comment. In D57552#1381126 , @jingham wrote: > That sounds like it will have to be fixed somewhere else, and not part of > this patch then. Can you file a bug to get that fixed? Yeah, it's on my todo list. Which keeps growing! CHANGES SIN

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

ted added a comment. This doesn't look correct to me - it looks like there are 1 too many #endifs. I think the one at line 179 should be removed - it should have been replaced by the #else that is at line 180. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5971

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

ted added a comment. llvm/tools/lldb/tools/driver/Driver.cpp:495:12: error: comparison of integers of different signs: 'ssize_t' (aka 'long') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare] if (nrwr != commands_size) { ^ ~ 1 error generated. Repository:

[Lldb-commits] [PATCH] D27380: [lldb] Update the check for Linux or FreeBSD in SymbolFileDWARF::FindFunctions.

ted added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2590 +(arch.GetTriple().isOSBinFormatELF() || arch.GetMachine() == llvm::Triple::hexagon)) { SymbolContextList temp_sc_list; clayborg w

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

This revision was automatically updated to reflect the committed changes. Closed by commit rGded1bad64af0: Fix mixed disassembly showing source lines for "line 0" (authored by ted). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D112931?vs=383810&id=539606#toc R

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

ted created this revision. ted added reviewers: clayborg, jingham. Herald added a project: All. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. llvm::MCInstPrinter has an option, controlled by setPrintBranchImmAsAddress, to print branch

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted created this revision. Herald added a project: All. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Get the path to qemu in the following order: 1. From the property platform.plugin.qemu-user.emulator-path 2. If that property is no

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted added a comment. In D155117#4505538 , @labath wrote: > I am wondering if we actually need the second step (the architecture setting) > here. The main reason it exists is the usage in `GetSupportedArchitectures` > (which is called before a target is

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

ted added a comment. In D155107#4504667 , @jasonmolenda wrote: > Isn't it better to print branches within a function as an offset, given that > our disassembly format by default lists the offset of each instruction. So > instead of looking for a 6-dig

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted added a comment. As for the GetSupportedArchitectures case, downstream I left in the code that checks the property, but changed the return {}; to return {ArchSpec(llvm::Triple("riscv32-unknown-linux")), ArchSpec(llvm::Triple("riscv64-unknown-linux"))}; I don't think we want that

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

ted added a comment. In D155107#4511967 , @clayborg wrote: > Looks like other disassemblers already show full addresses for the branches > and calls (at least arm64 does from my output above), so not sure why RISCV > would require this setting, but x86_

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

ted added a comment. In D155107#4534020 , @clayborg wrote: > So Ted, can you verify that nothing is missing in RISCV since this is already > the way it works for x86/x86_64 and arm32/arm64? I am thinking like Jason is > where I wonder if something isn't

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted added a comment. In D155117#4521393 , @labath wrote: > In D155117#4510512 , @ted wrote: > >> In D155117#4505538 , @labath wrote: >> >>> I am wondering if we actually n

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

This revision was automatically updated to reflect the committed changes. Closed by commit rG523110d654a2: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress (authored by ted). Changed prior to commit: https://reviews.llvm.org/D155107?vs=539679&id=552465#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe88462cd6aa: Platform qemu-user: Build path to qemu automatically if not specified (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155117/n

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted created this revision. Herald added subscribers: luke, sunshaoce, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, jo

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added a subscriber: labath. ted added a comment. With this change, I'm able to debug RISC-V 32 and 64 bit applications using Linux user space QEMU, using @labath 's QemuUser platform. Simple expression parsing with the IR Interpreter is working. Complex expression parsing with JIT is not te

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added reviewers: jasonmolenda, labath, asb, lewis-revill, compnerd, simoncook, jrtc27, JDevlieghere, aprantl, sven, kasper81, tzb99. ted added a comment. Adding commenters from https://reviews.llvm.org/D62732 as reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added a comment. In D159101#4625539 , @DavidSpickett wrote: > Also could you provide a list of things you have tested with qemu. So I can > get an idea of how sure we can be any of this works / be a test plan, albeit > manual for anyone updating th

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted marked 13 inline comments as done. ted added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:107 +static size_t word_size = 4U; +static size_t reg_size = word_size; + DavidSpickett wrote: > What's the reason to do this this way? I

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 554505. ted added a comment. Updated with David Spickett's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159101/new/ https://reviews.llvm.org/D159101 Files: lldb/source/Plugins/ABI/CMakeLists.txt lldb

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added a comment. In D159101#4627705 , @DavidSpickett wrote: > I have some vague idea that maybe we could put a hack in the test suite to > use the qemu-user platform instead of lldb-server. To at least give it a go, > but I haven't tried it myself

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added a comment. In D159101#4627705 , @DavidSpickett wrote: > Great. Could you include that in the commit message? Seems like we get a lot > of questions about how mature risc-v support is, so we can point to this as a > milestone for that. Will d

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 555155. ted marked an inline comment as done. ted added a comment. Implement Jason Molenda's request to use an ivar instead of static variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159101/new/ https://rev

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added a comment. @DavidSpickett update on testing: I'm running tests. I found an issue in the IR Interpreter when calling class methods. Somehow a 32 bit pointer gets the upper 32 bits in the 64 bit uint it's stored in set to 0x, which causes an assert. The assert should probably be

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557049. ted added a comment. Fix crash when there was no process. Remove bugs in function call setup when using IR interpreter. Change flag tests to use lldb_private::Flags for flags testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:133 +ABISysV_riscv::CreateInstance(ProcessSP process_sp, const ArchSpec &arch) { + if (process_sp) { +process_sp->SetCanInterpretFunctionCalls(true); DavidSpickett wrote:

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557321. ted added a comment. Remove disabling JIT and enabling IR Interpreter function calls, as requested by Jason Molenda. Added default unwind plan as suggested by Jason Molenda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557322. ted marked 3 inline comments as done. ted added a comment. Change "word_size = m_is_rv64 ? 8 : 4" to "word_size = reg_size" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159101/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557323. ted marked 4 inline comments as done. ted added a comment. Fix comment about "a" registers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159101/new/ https://reviews.llvm.org/D159101 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG847de9c33277: [RISC-V] Add RISC-V ABI plugin (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D159550: Remove unused #include

ted created this revision. Herald added subscribers: luke, sunshaoce, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a proje

[Lldb-commits] [PATCH] D159550: Remove unused #include

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb14153490134: Remove unused #include (authored by ted). Herald adde

[Lldb-commits] [PATCH] D159550: Remove unused #include

ted added a subscriber: jasonmolenda. ted added a comment. Remove unused #include pointed out by @jasonmolenda in D159101 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159550/new/ https://reviews.llvm.org/D159550

[Lldb-commits] [PATCH] D109633: [lldb-vscode] Fix focus thread when previous thread exits

ted created this revision. ted added a reviewer: clayborg. ted added a project: LLDB. Herald added a subscriber: JDevlieghere. ted requested review of this revision. The thread that Visual Studio Code displays on a stop is called the focus thread. When the previous focus thread exits and we stop

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

ted added a comment. I created the original bug because a change made LLDB stop working on address breakpoints if they were created before the program is run. Setting a breakpoint on an address is a typical case with embedded applications, especially if you want to debug startup code. I took t

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

ted added a comment. In D109738#3000608 , @jingham wrote: > BTW, do you know what change made this stop working? https://github.com/llvm-mirror/lldb/commit/43793406 in the old multirepo. In the monorepo, it's https://github.com/llvm/llvm-project/commit/

[Lldb-commits] [PATCH] D109633: [lldb-vscode] Fix focus thread when previous thread exits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17589538aaef: [lldb-vscode] Fix focus thread when previous thread exits (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted created this revision. ted added a reviewer: clayborg. ted requested review of this revision. Herald added a project: LLDB. If the remote gdbserver's qfThreadInfo reply has a trailing comma, GDBRemoteCommunicationClient::GetCurrentProcessAndThreadIDs will return an empty vector of thread ids.

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted added a comment. I agree about the test. I'll work on one. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2911-2912 +// if ids is empty, this is an error +if (ids.size() == 0) + return {}; +

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted added a comment. I've got a test written. It doesn't crash like the debugger in the wild does, but it does give a tid of 0 for each thread I ask about. So I can assert if the threads don't have the correct tid. With the patch, the test passes (gets the tids correctly) Without the patch and

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted updated this revision to Diff 374049. ted added a comment. [lldb] Handle malformed qfThreadInfo reply Add requested test. Refine handling of malformed reply with no valid threads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted updated this revision to Diff 374233. ted added a comment. Remove unneeded prints from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https://reviews.llvm.org/D109937 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCom

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted marked an inline comment as done. ted added a comment. Prints were there for my debugging. They don't serve a purpose, so I've removed them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https://reviews.llvm.org/D109937 __

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

This revision was automatically updated to reflect the committed changes. Closed by commit rG953ddded1aa2: [lldb] Handle malformed qfThreadInfo reply (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

ted added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); labath wrote: > omjavaid wrote: > > labath wrote: > > > mgorny wrote: > > >

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

ted added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:82 + llvm::iterator_range Registers() { +return llvm::iterator_range(m_regs); + } mgorny wrote: > labath wrote: > > Could this return const iterators? It seems we already

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

ted added a comment. In D109738#3052624 , @jingham wrote: > That is clearly wrong: an address is never enough to restore a breakpoint > from one session to the next even if you can turn ASLR off. After all, the > breakpoint could be in a dlopened libra

[Lldb-commits] [PATCH] D112834: [lldb-vscode] Fix coredump load source mapping for first file

ted created this revision. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SetSourceMapFromArguments is called after the core is loaded. This means that the source file for the crashing code won't have the source map applied. Move the c

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted created this revision. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. "line 0" in a DWARF linetable means something that doesn't have associated source. The code for mixed disassembly has a comment indicating that "line 0" should b

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted updated this revision to Diff 383810. ted added a comment. Fix test to exit lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112931/new/ https://reviews.llvm.org/D112931 Files: lldb/source/Core/Disassembler.cpp lldb/test/Shell/Commands/c

[Lldb-commits] [PATCH] D112834: [lldb-vscode] Fix coredump load source mapping for first file

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c05c52de217: [lldb-vscode] Fix coredump load source mapping for first file (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112834/new/ htt

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; clayborg wrote: > are we guaranteed to get some debug info with line zero

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; labath wrote: > ted wrote: > > clayborg wrote: > > > are we guaranteed to

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; labath wrote: > ted wrote: > > labath wrote: > > > ted wrote: > > > > clay

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

ted added a comment. @jasonmolenda I discovered the same issue in another way - create a python command and load it with "command script import". Here is test.py: def __lldb_init_module(debugger, dict): debugger.HandleCommand( 'command script add -f test.test test') prin

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted added a comment. @jasonmolenda friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112931/new/ https://reviews.llvm.org/D112931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D106832: [lldb] [gdb-remote client] Avoid zero padding PID/TID in H packet

ted accepted this revision. ted added a comment. This revision is now accepted and ready to land. LGTM. Thanks Michał! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106832/new/ https://reviews.llvm.org/D106832 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fd818c5a9c5: Don't fail step out if remote server doesn't implement qMemoryRegionInfo (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513

[Lldb-commits] [PATCH] D84966: Remove special Hexagon packet traversal code

ted created this revision. ted added reviewers: clayborg, jingham, labath. Herald added a project: LLDB. ted requested review of this revision. Herald added a subscriber: JDevlieghere. On Hexagon, breakpoints need to be on the first instruction of a packet. When the LLVM disassembler for Hexagon r

[Lldb-commits] [PATCH] D84966: Remove special Hexagon packet traversal code

ted updated this revision to Diff 282640. ted added a comment. Fixed formatting flagged by Lint: Pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84966/new/ https://reviews.llvm.org/D84966 Files: lldb/include/lldb/Core/Disassembler

[Lldb-commits] [PATCH] D84966: Remove special Hexagon packet traversal code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3169d920ccd1: Remove special Hexagon packet traversal code (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

ted added a comment. Hi Paulo, @clayborg asked me to look at this, because I've worked with systems that have multiple address spaces. I was thinking, instead of a WebAssembly specific memory read, we should implement an optional generic memory read and write with memory space support. So inst

[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

ted added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69119/new/ https://reviews.llvm.org/D69119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

ted added a comment. I've got another failure case for this. If the remote gdbserver doesn't implement qMemoryRegionInfo or qXfer:memory-map:read, thread step-out will fail. error: Could not create return address breakpoint. Return address (0x5bc0) permissions not found. That comes from this c

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

ted added a comment. In D71372#1811594 , @labath wrote: > In D71372#1810687 , @ted wrote: > > > I've got another failure case for this. If the remote gdbserver doesn't > > implement qMemoryRegionInfo or qXfer:memor

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

ted created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ted added reviewers: labath, jingham, clayborg. The return address validation in D71372 will fail if the memory permissions can't be determined. Many embedded stubs

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

ted added a comment. In D71372#1813703 , @labath wrote: > In D71372#1813142 , @ted wrote: > > > In D71372#1811594 , @labath wrote: > > > > > In D71372#1810687

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG04488c485a88: Don't fail step out if remote server doesn't implement qMemoryRegionInfo (authored by ted). Repository:

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

ted added a comment. Wow @jingham you posted your comment and I landed the patch at the same time! I'll remove the m_constructor_errors.Printf line as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513/new/ https://reviews.llvm.org/D72

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

ted updated this revision to Diff 240985. ted added a comment. Removed the code that sets m_constructor_errors when GetLoadAddressPermissions returns False, as requested by @jingham . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513/new/ https://reviews.llvm.org/D72513 Files: lld

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

ted added a comment. @jingham friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513/new/ https://reviews.llvm.org/D72513 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l