[Lldb-commits] [lldb] r293660 - Add a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-01-31 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Tue Jan 31 12:02:54 2017 New Revision: 293660 URL: http://llvm.org/viewvc/llvm-project?rev=293660=rev Log: Add a command to access and manipulate the Intel(R) MPX Boundary Tables. Summary: The Boundary Table Entries are stored in the application memory and allow to

[Lldb-commits] [lldb] r280668 - Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-05 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Mon Sep 5 12:43:10 2016 New Revision: 280668 URL: http://llvm.org/viewvc/llvm-project?rev=280668=rev Log: Intel(R) Memory Protection Extensions (Intel(R) MPX) support. Summary: The Intel(R) Memory Protection Extensions (Intel(R) MPX) associates pointers to bounds,

Re: [Lldb-commits] [PATCH] D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-05 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280668: Intel(R) Memory Protection Extensions (Intel(R) MPX) support. (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D24187?vs=70152=70342#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-06 Thread Valentina Giusti via lldb-commits
valentinagiusti created this revision. valentinagiusti added a subscriber: lldb-commits. Signed-off-by: Valentina Giusti https://reviews.llvm.org/D24255 Files: packages/Python/lldbsuite/test/functionalities/register/Makefile

Re: [Lldb-commits] [PATCH] D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-06 Thread Valentina Giusti via lldb-commits
valentinagiusti added a comment. Thanks for the review! You can find my replies inline. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/TestMPXRegisters.py:27 @@ +26,3 @@ + +@skipIfiOSSimulator +@skipIf(compiler="clang")

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-06 Thread Valentina Giusti via lldb-commits
valentinagiusti added a comment. Hi, inline there are my other replies. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5 @@ +4,3 @@ + +ifeq "$(ARCH)" "i386" + CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-07 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 70507. valentinagiusti added a comment. Improved TestMPXRegisters.py and Makefile according to review. https://reviews.llvm.org/D24255 Files: packages/Python/lldbsuite/test/functionalities/register/Makefile

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-08 Thread Valentina Giusti via lldb-commits
valentinagiusti added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:7 @@ +6,2 @@ + +include $(LEVEL)/Makefile.rules Np, thanks for the review and explanations ;)

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-08 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 70695. valentinagiusti added a comment. Improved MPX test Makefile and removed workaround for unnamed register sets, and rebased according to the new coding style. https://reviews.llvm.org/D24255 Files:

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-08 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280942: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support. (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D24255?vs=70695=70698#toc

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-07 Thread Valentina Giusti via lldb-commits
valentinagiusti marked an inline comment as done. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6 @@ +5,3 @@ +ifeq "$(ARCH)" "i386" + CFLAGS_EXTRAS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32 + LD_EXTRAS +=

Re: [Lldb-commits] [PATCH] D24559: Use Intel CPU flags to determine target supported features.

2016-09-14 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 71371. valentinagiusti added a comment. moved header to the bottom and moved enum into header file https://reviews.llvm.org/D24559 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

Re: [Lldb-commits] [PATCH] D24559: Use Intel CPU flags to determine target supported features.

2016-09-14 Thread Valentina Giusti via lldb-commits
valentinagiusti marked 2 inline comments as done. valentinagiusti added a comment. This fixes the fact that there is no proper check that the kernel or the hardware are actually supporting either AVX or MPX. Before this patch, the code only relied on a "hack" that checks if it's possible to do

Re: [Lldb-commits] [PATCH] D24559: Use Intel CPU flags to determine target supported features.

2016-09-14 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281507: Use Intel CPU flags to determine target supported features. (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D24559?vs=71371=71390#toc Repository: rL LLVM

[Lldb-commits] [lldb] r281507 - Use Intel CPU flags to determine target supported features.

2016-09-14 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Wed Sep 14 12:27:48 2016 New Revision: 281507 URL: http://llvm.org/viewvc/llvm-project?rev=281507=rev Log: Use Intel CPU flags to determine target supported features. Summary: This patch uses the instruction CPUID to verify that FXSAVE, XSAVE, AVX and MPX are

[Lldb-commits] [lldb] r281528 - Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64.

2016-09-14 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Wed Sep 14 15:12:12 2016 New Revision: 281528 URL: http://llvm.org/viewvc/llvm-project?rev=281528=rev Log: Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64. Reviewers: labath, clayborg, zturner Subscribers: lldb-commits Differential

Re: [Lldb-commits] [PATCH] D24578: Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64.

2016-09-14 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281528: Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64. (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D24578?vs=71412=71418#toc Repository:

[Lldb-commits] [lldb] r283548 - Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Fri Oct 7 08:21:59 2016 New Revision: 283548 URL: http://llvm.org/viewvc/llvm-project?rev=283548=rev Log: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474 Differential Revision: https://reviews.llvm.org/D25362 Modified:

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283548: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474 (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D25362?vs=73909=73945#toc Repository:

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283474: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel… (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D25329?vs=73823=73826#toc

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 73823. valentinagiusti added a comment. fixed usage of llvm:raw_string_ostream https://reviews.llvm.org/D25329 Files: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/mpx_bound_violation/Makefile

[Lldb-commits] [lldb] r283474 - Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Thu Oct 6 13:05:12 2016 New Revision: 283474 URL: http://llvm.org/viewvc/llvm-project?rev=283474=rev Log: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX) Summary: This patch adds support for handling the SIGSEGV signal with

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 73811. valentinagiusti added a comment. used llvm:raw_string_ostream instead of std::stringstream https://reviews.llvm.org/D25329 Files: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/mpx_bound_violation/Makefile

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
valentinagiusti created this revision. valentinagiusti added reviewers: zturner, labath. valentinagiusti added subscribers: lldb-commits, emaste. https://reviews.llvm.org/D25362 Files: source/Plugins/Process/POSIX/CrashReason.cpp source/Plugins/Process/POSIX/CrashReason.h Index:

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 73907. valentinagiusti added a comment. applied clang-format https://reviews.llvm.org/D25362 Files: source/Plugins/Process/POSIX/CrashReason.cpp source/Plugins/Process/POSIX/CrashReason.h Index: source/Plugins/Process/POSIX/CrashReason.h

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 73909. valentinagiusti added a comment. cleaned up code https://reviews.llvm.org/D25362 Files: source/Plugins/Process/POSIX/CrashReason.cpp source/Plugins/Process/POSIX/CrashReason.h Index: source/Plugins/Process/POSIX/CrashReason.h

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
valentinagiusti created this revision. valentinagiusti added reviewers: zturner, labath. valentinagiusti added subscribers: emaste, lldb-commits. This patch adds support for handling the SIGSEGV signal with 'si_code == SEGV_BNDERR', which is thrown when a bound violation is caught by the Intel(R)

[Lldb-commits] [PATCH] D25328: Improve test for Intel(R) MPX registers.

2016-10-06 Thread Valentina Giusti via lldb-commits
valentinagiusti created this revision. valentinagiusti added a reviewer: zturner. valentinagiusti added a subscriber: lldb-commits. Let the inferior test code determine if CPU and kernel support Intel(R) MPX and cleanup test script. Signed-off-by: Valentina Giusti

[Lldb-commits] [lldb] r283461 - Improve test for Intel(R) MPX registers.

2016-10-06 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Thu Oct 6 10:49:10 2016 New Revision: 283461 URL: http://llvm.org/viewvc/llvm-project?rev=283461=rev Log: Improve test for Intel(R) MPX registers. Summary: Let the inferior test code determine if CPU and kernel support Intel(R) MPX and cleanup test script.

Re: [Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-21 Thread Valentina Giusti via lldb-commits
valentinagiusti added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805 @@ -827,2 +804,3 @@ + if (m_xstate_type == XStateType::Invalid) { if (const_cast(this)->ReadFPR().Fail()) return false;

Re: [Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-21 Thread Valentina Giusti via lldb-commits
valentinagiusti added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805 @@ -827,2 +804,3 @@ + if (m_xstate_type == XStateType::Invalid) { if (const_cast(this)->ReadFPR().Fail()) return false;

Re: [Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-20 Thread Valentina Giusti via lldb-commits
valentinagiusti marked an inline comment as done. valentinagiusti added a comment. Thanks for your review! Please find my answers inline. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:807 @@ -827,2 +806,3 @@ + if (m_xstate_type ==

Re: [Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-20 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 71949. valentinagiusti added a comment. Removed unnecessary header, corrected switch-case. https://reviews.llvm.org/D24764 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

[Lldb-commits] [lldb] r282072 - Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-21 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Wed Sep 21 08:33:01 2016 New Revision: 282072 URL: http://llvm.org/viewvc/llvm-project?rev=282072=rev Log: Refactor NativeRegisterContextLinux_x86_64 code. This patch refactors the way the XState type is checked and, in order to simplify the code, it removes the

Re: [Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-21 Thread Valentina Giusti via lldb-commits
valentinagiusti added a comment. ok, I will keep it in mind for some further refactoring, thanks! Repository: rL LLVM https://reviews.llvm.org/D24764 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-21 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282072: Refactor NativeRegisterContextLinux_x86_64 code. (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D24764?vs=71949=72036#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-21 Thread Valentina Giusti via lldb-commits
valentinagiusti added a comment. Thechnically it's not correct that I am introducing this issue, because the old code already used a cast. It was done in the old and now not existing method "GetFPRType()", long before I introduced the MPX changes, and then I later moved it into

Re: [Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.

2016-09-21 Thread Valentina Giusti via lldb-commits
valentinagiusti added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805 @@ -827,2 +804,3 @@ + if (m_xstate_type == XStateType::Invalid) { if (const_cast(this)->ReadFPR().Fail()) return false; labath