Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

Rather than all of this ugly error-prone code, can we instead use llvm::sys::fs::root_name to check whether the path contains a drive letter? On Tue, Aug 18, 2015 at 1:52 PM Dawn Perchik via lldb-commits lldb-commits@lists.llvm.org wrote: dawn created this revision. dawn added reviewers:

[Lldb-commits] [lldb] r245338 - [Windows] XFAIL tests that depend on expression name lookup.

Author: zturner Date: Tue Aug 18 15:01:28 2015 New Revision: 245338 URL: http://llvm.org/viewvc/llvm-project?rev=245338view=rev Log: [Windows] XFAIL tests that depend on expression name lookup. Name lookup doesn't work properly with Windows targets. This is most likely due to issues with name

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

Seems reasonable to move that to lldb-dev. On Wed, Aug 19, 2015 at 12:56 PM Dawn Perchik dawn+l...@burble.org wrote: dawn planned changes to this revision. dawn added a comment. In http://reviews.llvm.org/D12115#227613, @abidh wrote: This command uses target modules lookup [...] Good

Re: [Lldb-commits] [PATCH] D12245: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.

zturner added a comment. Can you verify that this does not break local debugging on Windows? http://reviews.llvm.org/D12245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r245749 - XFAIL the last Windows test that calls a function in the target.

Author: zturner Date: Fri Aug 21 17:11:31 2015 New Revision: 245749 URL: http://llvm.org/viewvc/llvm-project?rev=245749view=rev Log: XFAIL the last Windows test that calls a function in the target. Modified: lldb/trunk/test/lang/cpp/static_methods/TestCPPStaticMethods.py Modified:

[Lldb-commits] [lldb] r245751 - XFAIL pthreads test on Windows.

Author: zturner Date: Fri Aug 21 17:11:50 2015 New Revision: 245751 URL: http://llvm.org/viewvc/llvm-project?rev=245751view=rev Log: XFAIL pthreads test on Windows. This test needs to be ported to c++ threads. Modified:

Re: [Lldb-commits] [PATCH] D12252: Reorg code to allow Windows Process Plugins to share some common code.

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Looks good. I'm guessing that at some point the RegisterContext and ExceptionRecord stuff will be moved to Common? http://reviews.llvm.org/D12252

[Lldb-commits] [lldb] r245747 - XFAIL Tests that require C++ exceptions on Windows.

Author: zturner Date: Fri Aug 21 17:11:09 2015 New Revision: 245747 URL: http://llvm.org/viewvc/llvm-project?rev=245747view=rev Log: XFAIL Tests that require C++ exceptions on Windows. clang-cl does not yet support C++ exceptions, so these tests will not even compile. Re-enabling these tests is

[Lldb-commits] [lldb] r245750 - Fix TestPaths on Windows.

Author: zturner Date: Fri Aug 21 17:11:40 2015 New Revision: 245750 URL: http://llvm.org/viewvc/llvm-project?rev=245750view=rev Log: Fix TestPaths on Windows. Modified: lldb/trunk/test/functionalities/paths/TestPaths.py Modified: lldb/trunk/test/functionalities/paths/TestPaths.py URL:

Re: [Lldb-commits] [PATCH] D12245: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.

By the way, I'm actively working on getting the test suite completely running on a buildbot, but I need to get down to a green baseline first. Still a few weeks out, but hopefully this type of thing will be caught automatically in the future. On Fri, Aug 21, 2015 at 5:00 PM Zachary Turner

Re: [Lldb-commits] [PATCH] D12245: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.

Hi Stephane, I'm sorry but I had to revert this change. When I tested it locally, I did it without running the full test suite, but when I did run the full test suite it showed about 15-20 new test failures. I should have caught this earlier by running the full test suite, so sorry about that.

Re: [Lldb-commits] [PATCH] D12206: Inline fake snprintf to avoid linkage issues on Windows.

looks good, can you add a comment to explain why it's inlined though. On Thu, Aug 20, 2015 at 12:14 PM Chaoren Lin chaor...@google.com wrote: chaoren created this revision. chaoren added a reviewer: zturner. chaoren added a subscriber: lldb-commits. dllexport doesn't work if linking against

[Lldb-commits] [lldb] r245629 - XFAIL breakpoint tests on Windows

Author: zturner Date: Thu Aug 20 17:09:08 2015 New Revision: 245629 URL: http://llvm.org/viewvc/llvm-project?rev=245629view=rev Log: XFAIL breakpoint tests on Windows llvm.org/pr24528 tracks fixing this test. Modified:

[Lldb-commits] [lldb] r245626 - [ProcessWindows] Fix rare crash on shutdown.

Author: zturner Date: Thu Aug 20 17:08:38 2015 New Revision: 245626 URL: http://llvm.org/viewvc/llvm-project?rev=245626view=rev Log: [ProcessWindows] Fix rare crash on shutdown. There might be an underlying race condition here that should be figured out, but this at least prevents the crash for

[Lldb-commits] [lldb] r244469 - Allow dosep.py to print dotest.py output on success.

Author: zturner Date: Mon Aug 10 12:46:11 2015 New Revision: 244469 URL: http://llvm.org/viewvc/llvm-project?rev=244469view=rev Log: Allow dosep.py to print dotest.py output on success. Previously all test output was reported by each individual instance of dotest.py. After a recent patch, dosep

Re: [Lldb-commits] [PATCH] D11909: Don't print number of failures and percentage if no tests ran.

lgtm On Mon, Aug 10, 2015 at 9:50 AM Chaoren Lin chaor...@google.com wrote: chaoren created this revision. chaoren added a reviewer: zturner. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D11909 Files: test/dosep.py Index: test/dosep.py

[Lldb-commits] [lldb] r245066 - Update dosep to print unexpected successes at the end.

Author: zturner Date: Fri Aug 14 11:45:32 2015 New Revision: 245066 URL: http://llvm.org/viewvc/llvm-project?rev=245066view=rev Log: Update dosep to print unexpected successes at the end. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL:

[Lldb-commits] [PATCH] D12043: Convert all use of pthreads in test executables to std threads

zturner created this revision. zturner added reviewers: clayborg, jingham. zturner added a subscriber: lldb-commits. This eliminates portability issues among platforms that don't have a pthreads implementation. There was one situation in TestTlsGlobals.py where it seems the intention is to

Re: [Lldb-commits] [PATCH] D12039: Make @skipUnlessArch actually skip instead of XFAIL

zturner added inline comments. Comment at: test/lldbtest.py:943 @@ -947,1 +942,3 @@ +def skipUnlessArch(archlist): +def myImpl(func): chaoren wrote: Is there a reason ``` return unittest2.skipUnless(getArchitecture() in archlist, ...) ``` is not

Re: [Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

You need to use LIBLLDB_API instead of __declspec(export). Otherwise someone linking against liblldb and trying to call this won't work correctly. Check the annotation given to the classes in the SB headers for the exact name of the macro. On Tue, Aug 11, 2015 at 6:23 PM Chaoren Lin

Re: [Lldb-commits] [PATCH] D11843: Make dosep output status by overwriting the same line.

Sorry, will get to this first thing tomorroow On Tue, Aug 11, 2015 at 4:47 PM Chaoren Lin chaor...@google.com wrote: chaoren added a comment. Ping? http://reviews.llvm.org/D11843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

Yea that sounds good too. On Fri, Oct 23, 2015 at 10:12 AM Pavel Labath wrote: > labath added a comment. > > test_categories is the name of .py file. :/ How about > `add_test_categories` ? > > > http://reviews.llvm.org/D14020 > > > >

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

zturner added a comment. Could you call this something less generic than `categories`? The name of the decorator should be descriptive enough to hint that it can only be applied to test methods. `test_categories` even. http://reviews.llvm.org/D14020

[Lldb-commits] [lldb] r251128 - Remove argparse_compat.

Author: zturner Date: Fri Oct 23 12:53:30 2015 New Revision: 251128 URL: http://llvm.org/viewvc/llvm-project?rev=251128=rev Log: Remove argparse_compat. We don't support versions of Python less than 2.7 Removed: lldb/trunk/test/argparse_compat.py Modified: lldb/trunk/test/dotest_args.py

[Lldb-commits] [lldb] r251129 - Python3 - Wrap more statements in calls to list()

Author: zturner Date: Fri Oct 23 12:53:51 2015 New Revision: 251129 URL: http://llvm.org/viewvc/llvm-project?rev=251129=rev Log: Python3 - Wrap more statements in calls to list() Modified: lldb/trunk/test/attic/tester.py lldb/trunk/test/dosep.py lldb/trunk/test/dotest.py

[Lldb-commits] [lldb] r251130 - Disable a compiler warning on MSVC.

Author: zturner Date: Fri Oct 23 12:54:00 2015 New Revision: 251130 URL: http://llvm.org/viewvc/llvm-project?rev=251130=rev Log: Disable a compiler warning on MSVC. This is caused by a bug in MSVC's library implementation. It's fixed in the next version of the compiler, but for now the only way

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

zturner added a subscriber: zturner. Comment at: include/lldb/Core/Timer.h:89 @@ +88,3 @@ + +static thread_local unsigned g_depth; + clayborg wrote: > Not sure if all platforms support thread_local correctly. MacOSX might not. I > also spoke with some

[Lldb-commits] [lldb] r250915 - Use six to portably handle module renames in Python 2 and 3

Author: zturner Date: Wed Oct 21 12:48:52 2015 New Revision: 250915 URL: http://llvm.org/viewvc/llvm-project?rev=250915=rev Log: Use six to portably handle module renames in Python 2 and 3 Modified: lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

zturner added a comment. I think most of the time they are used in a Connection class, but I don't think it's necessarily guaranteed they will always be that way. I can think of at least one use case in the future where we will need to open a socket to a server we don't control and stream some

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

zturner added a comment. I still think implementation should be in Host as well. If the idea is to simplify the creation scheme, then you could create an enum: enum class SocketType { Tcp, Udp, UnixDomain }; and provide a static method on SocketBase like this: class

Re: [Lldb-commits] [PATCH] D14085: Add Socket::Create factory method which uses socket scheme (tcp, unix, ..) to find an appropriate implementation class.

zturner added a comment. Do we need this `GetScheme()` method? And instead of having `Create` take a string, couldn't it just take a `SocketProtocol` instead? It seems like the logic of converting the string to the enum should be done in the `Acceptor` class, as this URI format is defined by

[Lldb-commits] [PATCH] D14131: Preparation for making a Python package out of lldb's Python code

zturner created this revision. zturner added reviewers: clayborg, tfiala. zturner added a subscriber: lldb-commits. See the thread in lldb-dev for context. After this patch, the remaining piece of work is to literally move `lldb/test` to `lldb/packages/Python/lldbsuite/test` and apply 1 or 2

Re: [Lldb-commits] [PATCH] D14131: Preparation for making a Python package out of lldb's Python code

zturner updated this revision to Diff 38600. zturner added a comment. Fixed `lldbsuite` module initialization. I'm having to do this all by eye / memory since this code isn't actually exercised yet until the move actually happens. http://reviews.llvm.org/D14131 Files:

[Lldb-commits] [lldb] r251329 - Python 3: Convert uses of `callable(x)` to `six.callable(x)`.

Author: zturner Date: Mon Oct 26 13:48:24 2015 New Revision: 251329 URL: http://llvm.org/viewvc/llvm-project?rev=251329=rev Log: Python 3: Convert uses of `callable(x)` to `six.callable(x)`. Modified: lldb/trunk/test/dotest.py lldb/trunk/test/lldbcurses.py lldb/trunk/test/lldbtest.py

[Lldb-commits] [lldb] r251328 - Remove use of octal literals.

Author: zturner Date: Mon Oct 26 13:48:14 2015 New Revision: 251328 URL: http://llvm.org/viewvc/llvm-project?rev=251328=rev Log: Remove use of octal literals. Python 3 has a different syntax for octal literals than Python 2 and they are incompatible with each other. Six doesn't provide a

Re: [Lldb-commits] [PATCH] D14136: Refactor Windows process plugin to enable sharing of code between live and post-mortem debugging

zturner added inline comments. Comment at: source/Plugins/Process/Windows/Common/ProcessWindowsForward.h:20 @@ +19,1 @@ +#endif \ No newline at end of file Put a newline here Comment at:

[Lldb-commits] [lldb] r251544 - Try to fix the linux buildbot.

Author: zturner Date: Wed Oct 28 14:18:53 2015 New Revision: 251544 URL: http://llvm.org/viewvc/llvm-project?rev=251544=rev Log: Try to fix the linux buildbot. It's complaining that it doesn't under the "import" command, so I guess I need this hashbang at the beginning so that it knows it's a

Re: [Lldb-commits] [PATCH] D14162: Create Python library `seven` in lldbsuite.support

zturner added inline comments. Comment at: packages/Python/lldbsuite/support/seven.py:12 @@ +11,3 @@ +import subprocess +return (0, subprocess.check_output(command, shell=True)) +except subprocess.CalledProcessError as e: tfiala

[Lldb-commits] [PATCH] D14157: Make dosep correctly invoke the top level script when doing the multiprocessing fork

zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. This patch disables the ability to run `packages/Python/lldbsuite/test/dotest.py` as a standalone script by explicitly erroring out if it detects that to be the case. Then, it fixes up

[Lldb-commits] [PATCH] D14159: Add a Visual Studio solution for LLDB's Python code

zturner created this revision. zturner added a reviewer: amccarth. zturner added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. If you have PTVS [https://github.com/Microsoft/PTVS] installed, you can open this solution in Visual Studio and get an

[Lldb-commits] [PATCH] D14162: Create Python library `seven` in lldbsuite.support

zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. The purpose of this file is to fill in the gaps where `six` is lacking support for some operation that we need. Initially this just provides a replacement for the `commands` module which

Re: [Lldb-commits] [PATCH] D14163: Address another race condition running tests on Windows

zturner added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:1823-1830 @@ -1822,3 +1822,10 @@ -os.rename(src, dst) +try: +os.rename(src, dst) +except: +

[Lldb-commits] [PATCH] D14028: Convert long to int and portably detect integral types

zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. In a few of the examples fixed up here, the distinction between long and int was not important here. As a result, I converted those to use int instead of long everywhere to make the code

[Lldb-commits] [lldb] r251139 - Make uses of unicode literals portable.

Author: zturner Date: Fri Oct 23 14:52:36 2015 New Revision: 251139 URL: http://llvm.org/viewvc/llvm-project?rev=251139=rev Log: Make uses of unicode literals portable. Six provides six.u() which resolves to either u"" or "" depending on Python version, and and six.unichr() which resolves to

[Lldb-commits] [lldb] r251303 - Convert deprecated unittest method names.

Author: zturner Date: Mon Oct 26 11:50:39 2015 New Revision: 251303 URL: http://llvm.org/viewvc/llvm-project?rev=251303=rev Log: Convert deprecated unittest method names. Plural methods were long deprecated, and in Python 3 they are gone. Convert to the actual supported method names. Modified:

[Lldb-commits] [lldb] r251305 - Convert `long` to `int`, and portably detect all integral types.

Author: zturner Date: Mon Oct 26 11:51:09 2015 New Revision: 251305 URL: http://llvm.org/viewvc/llvm-project?rev=251305=rev Log: Convert `long` to `int`, and portably detect all integral types. Modified: lldb/trunk/test/functionalities/abbreviation/TestCommonShortSpellings.py

[Lldb-commits] [lldb] r251308 - Fix tabs and spaces in one of the python files.

Author: zturner Date: Mon Oct 26 11:51:36 2015 New Revision: 251308 URL: http://llvm.org/viewvc/llvm-project?rev=251308=rev Log: Fix tabs and spaces in one of the python files. Modified: lldb/trunk/examples/synthetic/gnu_libstdcpp.py Modified: lldb/trunk/examples/synthetic/gnu_libstdcpp.py

[Lldb-commits] [lldb] r251302 - Fix usages of range() and xrange() for Python 3.

Author: zturner Date: Mon Oct 26 11:49:57 2015 New Revision: 251302 URL: http://llvm.org/viewvc/llvm-project?rev=251302=rev Log: Fix usages of range() and xrange() for Python 3. Modified: lldb/trunk/test/example/TestSequenceFunctions.py

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

On Tue, Oct 20, 2015 at 7:40 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > jingham added a comment. > > The generic parts of this change look fine to me, with a few inlined style > comments. > > I didn't read the Go specific parts of this in detail, I assume you're >

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

zturner added a subscriber: zturner. zturner added a comment. I would have done this last night but I didn't have a machine handy. I'll test it out now and commit if it fixes. And yea, in the future please just commit fixes. Repository: rL LLVM http://reviews.llvm.org/D13968

[Lldb-commits] [lldb] r252765 - Add a `PythonModule` class, and a root-level method for resolving names.

Author: zturner Date: Wed Nov 11 11:59:49 2015 New Revision: 252765 URL: http://llvm.org/viewvc/llvm-project?rev=252765=rev Log: Add a `PythonModule` class, and a root-level method for resolving names. Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp

[Lldb-commits] [lldb] r252764 - Symlink the `six` module during swig generation.

Author: zturner Date: Wed Nov 11 11:59:34 2015 New Revision: 252764 URL: http://llvm.org/viewvc/llvm-project?rev=252764=rev Log: Symlink the `six` module during swig generation. Modified: lldb/trunk/scripts/CMakeLists.txt lldb/trunk/scripts/Python/finishSwigPythonLLDB.py Modified:

[Lldb-commits] [lldb] r252767 - Python 3 - Use six in our embedded Python glue code.

Author: zturner Date: Wed Nov 11 11:59:57 2015 New Revision: 252767 URL: http://llvm.org/viewvc/llvm-project?rev=252767=rev Log: Python 3 - Use six in our embedded Python glue code. Modified: lldb/trunk/scripts/interface/SBData.i lldb/trunk/scripts/lldb.swig Modified:

[Lldb-commits] [PATCH] D14555: Create PythonCallable and PythonTuple wrappers with appropriate unit tests

zturner created this revision. zturner added reviewers: granata.enrico, clayborg. zturner added a subscriber: lldb-commits. zturner added a dependency: D14524: Create a `PythonModule` class and add a root-level method for name lookup. This adds PythonTuple and PythonCallable classes to

Re: [Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

u > crash. When a dotest.py process crashes, the buffered content won't > necessarily get flushed. So the session file may or may not contain the > last thing that happened in that case. > > I think we want it unbuffered where we can. > > -Todd > > On Fri, Nov 6, 2015

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner added inline comments. Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:369-374 @@ +368,8 @@ + +template +T +ResolveNameAs(llvm::StringRef name) const +{ +return ResolveName(name).AsType(); +} +}; I need

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

On Mon, Nov 9, 2015 at 5:22 PM Zachary Turner wrote: > zturner created this revision. > zturner added reviewers: granata.enrico, clayborg, tfiala. > zturner added a subscriber: lldb-commits. > > The goal here is to eventually replace some code in `python-wrapper.swig` > with

Re: [Lldb-commits] [lldb] r252583 - The other half of a change made by Enrico for trying to get a correct

This is really the kind of thing that would be good to write a unit test for. There's a lot of institutional knowledge hidden away in these kinds of deep low level stuff, and a unit test is good documentation for it. I suspect this is almost guaranteed to break at some point in the future

[Lldb-commits] [lldb] r252939 - Finish PyCallable -> PythonCallable conversion.

Author: zturner Date: Thu Nov 12 14:11:02 2015 New Revision: 252939 URL: http://llvm.org/viewvc/llvm-project?rev=252939=rev Log: Finish PyCallable -> PythonCallable conversion. This finishes the effort to port python-wrapper.swig code over to using PythonDataObjects. Also included in this patch

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

The error messages are always different because the error message is printed by the test. I'm going to try to load up the executable for TestStepNoDebug in the debugger and get a disassembly and do the step On Thu, Nov 12, 2015 at 4:01 PM Jim Ingham wrote: > Is the line they

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

Ahh, seems it wasn't just Windows that was affected by this. Makes me feel a little better :) Posting the link to the buildbot failures here so that Jim can get full logs if it helps. http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8391 On Thu, Nov 12, 2015 at 4:37 PM

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

Hi Jim, This breaks about 12 tests on Windows. The patch looks simple, but this isn't really my area, is there anything I can give you to help diagnose what might be wrong? The following tests fail: FAIL: LLDB (suite) :: Test-rdar-9974002.py (Windows zturner-win81 8 6.2.9200 AMD64 Intel64

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

I went ahead and created two logs. One for the working case and one for the non-working case. I'm attaching instead of inlining, let me know if this doesn't work: Might help to diff them. doesnt_work.log Description: Binary data works.log Description: Binary data

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

Here's the log. Disassembly of those two functions was posted earlier. Let me know if you need anything else: ThreadPlanStepRange::SetNextBranchBreakpoint - Setting breakpoint -1 (site 2) to run to address 0x94902e Thread::PushPlan(0x0654FBB0): "Stepping in through line with-debug.c:12.", tid =

[Lldb-commits] [lldb] r252994 - Introduce a `PythonExceptionState` class.

Author: zturner Date: Thu Nov 12 19:24:52 2015 New Revision: 252994 URL: http://llvm.org/viewvc/llvm-project?rev=252994=rev Log: Introduce a `PythonExceptionState` class. This is a helper class which supports a number of features including exception to string formatting with backtrace handling

[Lldb-commits] [lldb] r253002 - Fix a bug in PythonExceptionState and add unittest coverage.

Author: zturner Date: Thu Nov 12 19:50:19 2015 New Revision: 253002 URL: http://llvm.org/viewvc/llvm-project?rev=253002=rev Log: Fix a bug in PythonExceptionState and add unittest coverage. I forgot to reset the restore flag when calling member function `Acquire`. The newly added unittest

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

Thanks! Do you think you could add a test that does specifically that? Set two breakpoints back to back, even in the same function, ane ensure that the second one gets hit. If your theory is right this test will fail on Windows and Linux (and then we'll have to xfail it) but at least we'll have

[Lldb-commits] [lldb] r253054 - Make PythonDataObjects.h work when LLDB_DISABLE_PYTHON=1

Author: zturner Date: Fri Nov 13 11:27:20 2015 New Revision: 253054 URL: http://llvm.org/viewvc/llvm-project?rev=253054=rev Log: Make PythonDataObjects.h work when LLDB_DISABLE_PYTHON=1 Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

the build bots the test is also failing on OSX, but it > might fail from a different reason then on Linux/Windows. > > On Fri, Nov 13, 2015 at 4:10 AM Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Thanks! Do you think you could add a te

[Lldb-commits] [lldb] r253057 - Add `PythonExceptionStateTests.cpp` to lldb-gtest target.

Author: zturner Date: Fri Nov 13 12:10:11 2015 New Revision: 253057 URL: http://llvm.org/viewvc/llvm-project?rev=253057=rev Log: Add `PythonExceptionStateTests.cpp` to lldb-gtest target. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r253092 - Change the null check to an assert.

Author: zturner Date: Fri Nov 13 15:53:03 2015 New Revision: 253092 URL: http://llvm.org/viewvc/llvm-project?rev=253092=rev Log: Change the null check to an assert. Modified: lldb/trunk/source/Target/ThreadList.cpp Modified: lldb/trunk/source/Target/ThreadList.cpp URL:

[Lldb-commits] [lldb] r253073 - Another fix for LLDB_DISABLE_PYTHON=1

Author: zturner Date: Fri Nov 13 14:28:31 2015 New Revision: 253073 URL: http://llvm.org/viewvc/llvm-project?rev=253073=rev Log: Another fix for LLDB_DISABLE_PYTHON=1 Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonExceptionState.cpp Modified:

[Lldb-commits] [lldb] r253086 - Add a null check against the ThreadPlan

Author: zturner Date: Fri Nov 13 15:28:53 2015 New Revision: 253086 URL: http://llvm.org/viewvc/llvm-project?rev=253086=rev Log: Add a null check against the ThreadPlan I'm seeing some cases where the ThreadPlan is null. It could be a sign of a valid race condition, but at least we shouldn't

[Lldb-commits] [lldb] r253085 - Modernize FormatBacktrace() and make portable for Python 3.

Author: zturner Date: Fri Nov 13 15:28:45 2015 New Revision: 253085 URL: http://llvm.org/viewvc/llvm-project?rev=253085=rev Log: Modernize FormatBacktrace() and make portable for Python 3. Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp

[Lldb-commits] [lldb] r253088 - Remove debugging code left in by accident.

Author: zturner Date: Fri Nov 13 15:35:07 2015 New Revision: 253088 URL: http://llvm.org/viewvc/llvm-project?rev=253088=rev Log: Remove debugging code left in by accident. Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonExceptionState.cpp Modified:

Re: [Lldb-commits] [lldb] r253086 - Add a null check against the ThreadPlan

; Jim > > > > On Nov 13, 2015, at 1:28 PM, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > Author: zturner > > Date: Fri Nov 13 15:28:53 2015 > > New Revision: 253086 > > > > URL: http://llvm.org/viewvc/ll

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

zturner added a subscriber: zturner. zturner added a comment. I think the `is None` check should go back inside the `check_list_or_lambda` function. Bringing it outside the function looks identical to me. If `None` is passed to the function, the `callable()` check will fail, and then the

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

zturner added a comment. In http://reviews.llvm.org/D14673#290280, @jingham wrote: > If the problem is that the self of the test object doesn't always have a > debug_info setting, why not just always initialize it to None? Seems weird > to have a general property like this that we don't

[Lldb-commits] [PATCH] D14718: Insert the SWIG version into LLDB's __init__.py

zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. The goal here is to allow us to add expectedFailure / etc decorators based on SWIG version. The end result of this is that patch is that after running SWIG generation you will have a line

[Lldb-commits] [lldb] r253263 - Add the ability to xfail or skip based on swig / python version.

Author: zturner Date: Mon Nov 16 16:40:30 2015 New Revision: 253263 URL: http://llvm.org/viewvc/llvm-project?rev=253263=rev Log: Add the ability to xfail or skip based on swig / python version. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

[Lldb-commits] [lldb] r253262 - Insert the SWIG version into LLDB's __init__.py

Author: zturner Date: Mon Nov 16 16:40:20 2015 New Revision: 253262 URL: http://llvm.org/viewvc/llvm-project?rev=253262=rev Log: Insert the SWIG version into LLDB's __init__.py The goal here is to allow us to add skip / xfail decorators based on SWIG version. Modified:

[Lldb-commits] [lldb] r253261 - Python3 - Fix some issues related to `PythonFile` class.

Author: zturner Date: Mon Nov 16 16:40:12 2015 New Revision: 253261 URL: http://llvm.org/viewvc/llvm-project?rev=253261=rev Log: Python3 - Fix some issues related to `PythonFile` class. Python 3 has lots of new debug asserts, and some of these were firing on PythonFile. Specifically related to

[Lldb-commits] [PATCH] D14726: Add the ability to skip or xfail based on Python and/or SWIG version

zturner created this revision. zturner added reviewers: tfiala, clayborg. zturner added a subscriber: lldb-commits. http://reviews.llvm.org/D14726 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [lldb] r253273 - Python 3 - Skip a certain test for a particular (swig, python) combo.

Author: zturner Date: Mon Nov 16 17:58:20 2015 New Revision: 253273 URL: http://llvm.org/viewvc/llvm-project?rev=253273=rev Log: Python 3 - Skip a certain test for a particular (swig,python) combo. Current versions of SWIG have a bug with Python 3 that causes Python to assert when iterating over

[Lldb-commits] [lldb] r252787 - Create `PythonTuple` and `PythonCallable` wrapper classes.

Author: zturner Date: Wed Nov 11 13:42:27 2015 New Revision: 252787 URL: http://llvm.org/viewvc/llvm-project?rev=252787=rev Log: Create `PythonTuple` and `PythonCallable` wrapper classes. This adds PythonTuple and PythonCallable classes to PythonDataObjects. Additionally, unit tests are provided

[Lldb-commits] [lldb] r252909 - Fix non-Windows build after r252906.

Author: zturner Date: Thu Nov 12 11:01:48 2015 New Revision: 252909 URL: http://llvm.org/viewvc/llvm-project?rev=252909=rev Log: Fix non-Windows build after r252906. Modified: lldb/trunk/scripts/Python/python-wrapper.swig lldb/trunk/scripts/lldb.swig

[Lldb-commits] [lldb] r252906 - Begin converting uses of PyCallable to PythonCallable.

Author: zturner Date: Thu Nov 12 10:23:16 2015 New Revision: 252906 URL: http://llvm.org/viewvc/llvm-project?rev=252906=rev Log: Begin converting uses of PyCallable to PythonCallable. PyCallable is a class that exists solely within the swig wrapper code. PythonCallable is a more generic

Re: [Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

zturner added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py:40 @@ +39,3 @@ +thread = self.process.GetThreadAtIndex(0) +# The crash is in main, so there should be one frame on the stack. +

[Lldb-commits] [lldb] r252788 - Convert python-wrapper.swig to use PythonDataObjects.

Author: zturner Date: Wed Nov 11 13:42:35 2015 New Revision: 252788 URL: http://llvm.org/viewvc/llvm-project?rev=252788=rev Log: Convert python-wrapper.swig to use PythonDataObjects. This only begins to port python-wrapper.swig over. Since this code can be pretty hairy, I plan to do this

[Lldb-commits] [lldb] r252803 - Remove `FindSessionDictionary` and rely on PythonDataObjects.

Author: zturner Date: Wed Nov 11 15:07:29 2015 New Revision: 252803 URL: http://llvm.org/viewvc/llvm-project?rev=252803=rev Log: Remove `FindSessionDictionary` and rely on PythonDataObjects. This had been relegated to a simple forwarding function, so just delete it in preparation of migrating

Re: [Lldb-commits] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

Is there any way to have the step that runs the swig executable not be part of this script? Seems like running swig should be a build step, and running these scripts on the output of swig should be a step that follows On Mon, Nov 16, 2015 at 11:20 PM Todd Fiala via lldb-commits <

[Lldb-commits] [lldb] r252536 - Use PythonDataObjects in swig helper functions.

Author: zturner Date: Mon Nov 9 17:23:52 2015 New Revision: 252536 URL: http://llvm.org/viewvc/llvm-project?rev=252536=rev Log: Use PythonDataObjects in swig helper functions. Relying on manual Python C API calls is error prone, especially when trying to maintain compatibility with Python 2 and

[Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner created this revision. zturner added reviewers: granata.enrico, clayborg, tfiala. zturner added a subscriber: lldb-commits. The goal here is to eventually replace some code in `python-wrapper.swig` with this code. This way it can be properly unit tested and we can easily deal with

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner updated this revision to Diff 39776. zturner added a comment. Fix some indentation http://reviews.llvm.org/D14524 Files: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h

Re: [Lldb-commits] [lldb] r251678 - Some test cases that need the lldbExec path were failing because lldbExec was turning out to be None even though it was being validly set by dotest.py

Wow. That's a weird problem. Thanks for finding it! Would it work if we move the definition of the `lldbtest_config` class into lldbsuite/test/__init__.py? This way the configuration should be part of the global package state of the lldbsuite.test package, which all the tests are already

Re: [Lldb-commits] [lldb] r251886 - Tighten up sys.path, and use absolute imports everywhere.

On Mon, Nov 2, 2015 at 10:27 PM Todd Fiala wrote: > On Mon, Nov 2, 2015 at 10:12 PM, Zachary Turner > wrote: > >> >> Luckily the extra typing only comes at the import site. If you use the >> syntax I suggested in #2 and #3 above (import

Re: [Lldb-commits] [lldb] r251886 - Tighten up sys.path, and use absolute imports everywhere.

Also, one last thing. The reason this is probably wreaking havoc on your stuff internally is because I removed scriptDir from sys.path (diff the changes of dotest.py to see). I think it should stay removed upstream (mucking with sys.path so you can import from a parent directory is a bad thing

Re: [Lldb-commits] [lldb] r251886 - Tighten up sys.path, and use absolute imports everywhere.

On Mon, Nov 2, 2015 at 10:02 PM Todd Fiala wrote: > Do you have a script you used to tweak these? > > (We have a ton of stuff broken internally on this that I need to fix up). > > We're starting to need to do quite a bit of extra typing for the package > structure :-/ >

Re: [Lldb-commits] [lldb] r251678 - Some test cases that need the lldbExec path were failing because lldbExec was turning out to be None even though it was being validly set by dotest.py

;> >>>>> BTW, is lldb/test/dotest.py here to stay? I thought it was there just >>>>> to avoid breaking anybody who runs dotest directly (instead of ninja >>>>> check-lldb), and therefore we will remove it once everybody gets a chance >>>&

Re: [Lldb-commits] [lldb] r251678 - Some test cases that need the lldbExec path were failing because lldbExec was turning out to be None even though it was being validly set by dotest.py

t use it). > > Is that correct or I am misunderstanding something? > > pl > > > On 2 November 2015 at 11:11, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> I looked into this some more, and unfortunately I can't reproduce it.

  1   2   3   4   5   6   7   8   9   10   >