[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

This revision was automatically updated to reflect the committed changes. Closed by commit rL284422: [lldb] Read modules from memory when a local copy is not available (authored by wallace). Changed prior to commit: https://reviews.llvm.org/D24284?vs=72597&id=74895#toc Repository: rL LLVM h

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. This looks fine now. Sorry for the delay, I had forgotten about it. I think you still don't have commit access right? Now would be a good time to request it

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. pingping https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. F2469236: before.txt F2469237: after.txt These are the output from running the tests. Btw, this was failing before because it was reading the export table incorrectly, but I updated it and it shoul

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

That's strange. Are you synced to tip of trunk on clang, llvm, and lldb? Can you paste the output of "ninja -nv check-lldb" and the summary results of "ninja check-lldb"? On Wed, Oct 5, 2016 at 10:11 AM walter erquinigo wrote: > wallace added a comment. > > I've run the tests and it's the same w

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. I've run the tests and it's the same with and without this diff :) https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 72597. wallace added a comment. minor nits https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 72596. wallace added a comment. This time I'm calculating the address of the exports header correctly because it is an RVA address. https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/P

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

Unfortunately this is still crashing for me in every single test. Can I ask how you are running the test suite? I am doing the following from a Windows 10 machine using Visual Studio 15: cmake -G Ninja -DLLDB_TEST_DEBUG_TEST_CRASHES=1 -DPYTHON_HOME=C:\Python35 -DLLDB_TEST_COMPILER=d:\src\llvmbui

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

Oh, I was doing it from linux, I will do it from Windows then... 2016-09-21 8:42 GMT-07:00 Zachary Turner : > If it helps, I can tell you that on line 623 of ObjectFilePECOFF.cpp, the > export_table has number of names == 64, but address of names = 0. So that > seems wrong. > > On Wed, Sep 21, 2

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

If it helps, I can tell you that on line 623 of ObjectFilePECOFF.cpp, the export_table has number of names == 64, but address of names = 0. So that seems wrong. On Wed, Sep 21, 2016 at 8:38 AM Zachary Turner wrote: > Unfortunately this is still crashing for me in every single test. Can I > ask

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71995. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

I rebased it 2016-09-20 15:44 GMT-07:00 walter erquinigo : > wallace updated this revision to Diff 71995. > wallace added a comment. > > rebase > > > https://reviews.llvm.org/D24284 > > Files: > source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp > source/Plugins/ObjectFile/PECOFF/ObjectFil

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

Just a heads up, I put the wrong differential revision in the commit message. Oh well. I submitted the other patch, not this one. Can you rebase this patch on top of the triple / os patch? It doesn't apply cleanly for me. On Tue, Sep 20, 2016 at 1:53 PM Zachary Turner wrote: > This revision

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

This revision was automatically updated to reflect the committed changes. Closed by commit rL282013: [PECOFF] Use the COFF subsystem field when determining the Triple. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D24284?vs=71855&id=71984#toc Repository: rL LLVM h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. I was using this patch as well https://reviews.llvm.org/D24530, which might be the reason why it fails on your side. I'll double check, but I'm pretty sure it's just that https://reviews.llvm.org/D24284 ___ lldb-commits ma

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. When I run ninja check-lldb with this patch, every single test crashes. It's crashing at ObjectFilePECOFF.cpp:583, which does this: const char *symbol_name_cstr = symtab_d

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71855. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71853. wallace added a comment. s/NULL/nullptr/ https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. I'm obliged, your grace https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner accepted this revision. This revision is now accepted and ready to land. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:89 @@ +88,3 @@ + if (!data_sp || !ObjectFilePECOFF::MagicBytesMatch(data_sp)) { +return NULL; + } s/NULL/nullpt

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. ping https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71409. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71407. wallace added a comment. fix pointers https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h ===

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:88 @@ +87,3 @@ + if (data_sp && ObjectFilePECOFF::MagicBytesMatch(data_sp)) { +std::auto_ptr objfile_ap( +new ObjectFilePECOFF(module_sp, data_sp, process_sp, header_addr)

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71265. wallace updated the summary for this revision. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace created this revision. wallace added reviewers: zturner, sas. wallace added a subscriber: LLDB. wallace set the repository for this revision to rL LLVM. wallace added a project: LLDB. When the local lldb doesn't have access to a copy of the modules in the target, e.g. winphone, with this

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner added a comment. Right, I'm just wondering if when you run `ninja check-lldb` before and after this patch, do the results differ at all? Repository: rL LLVM https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner added a comment. Can you rebase on top of tunk and re-upload? Also please use -U99 when generating the diff (assuming you are using git) so we can see context. Repository: rL LLVM https://reviews.llvm.org/D24284 ___ lldb-commits mai