Re: [Lldb-commits] [PATCH] D24853: Fix windows build.It does not like mixed 'enum' and 'enum class'.

2016-09-22 Thread Zachary Turner via lldb-commits 
Fixed in r282226, thanks for the tip.

On Thu, Sep 22, 2016 at 5:15 PM Andrew Ford via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> andrewford added a comment.
>
> BTW, I don't have commit access, would appreciate if someone could submit
> for me assuming this is acceptable :)
>
>
> https://reviews.llvm.org/D24853
>
>
>
> ___
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24853: Fix windows build.It does not like mixed 'enum' and 'enum class'.

2016-09-22 Thread Andrew Ford via lldb-commits 
andrewford added a comment.

BTW, I don't have commit access, would appreciate if someone could submit for 
me assuming this is acceptable :)


https://reviews.llvm.org/D24853



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24853: Fix windows build.It does not like mixed 'enum' and 'enum class'.

2016-09-22 Thread Andrew Ford via lldb-commits 
andrewford created this revision.
andrewford added a reviewer: jingham.
andrewford added a subscriber: lldb-commits.

Change-Id: I611460cf4df58073bda64e16847e5358c3361aa7

https://reviews.llvm.org/D24853

Files:
  include/lldb/Breakpoint/BreakpointOptions.h

Index: include/lldb/Breakpoint/BreakpointOptions.h
===
--- include/lldb/Breakpoint/BreakpointOptions.h
+++ include/lldb/Breakpoint/BreakpointOptions.h
@@ -368,7 +368,7 @@
   };
   static const char *g_option_names[(size_t) OptionNames::LastOptionName];
 
-  static const char *GetKey(enum OptionNames enum_value) {
+  static const char *GetKey(OptionNames enum_value) {
 return g_option_names[(size_t) enum_value];
   }
 


Index: include/lldb/Breakpoint/BreakpointOptions.h
===
--- include/lldb/Breakpoint/BreakpointOptions.h
+++ include/lldb/Breakpoint/BreakpointOptions.h
@@ -368,7 +368,7 @@
   };
   static const char *g_option_names[(size_t) OptionNames::LastOptionName];
 
-  static const char *GetKey(enum OptionNames enum_value) {
+  static const char *GetKey(OptionNames enum_value) {
 return g_option_names[(size_t) enum_value];
   }
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits