[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

mgorny abandoned this revision. mgorny added a comment. Now handled as a followup of https://reviews.llvm.org/D25724. https://reviews.llvm.org/D25668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

mgorny planned changes to this revision. mgorny added a comment. `LLVM_CMAKE_PATH` posted as https://reviews.llvm.org/D25724. https://reviews.llvm.org/D25668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

krytarowski added a comment. This change makes sense for stand-alone builds, but if it's possible to remove branching in this CMake file - please go for it. https://reviews.llvm.org/D25668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

beanz added a comment. Maybe we should define `LLVM_CMAKE_PATH` in llvm's CMakeLists.txt so that we don't need a condition here or in clang where we do the same thing? https://reviews.llvm.org/D25668 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

mgorny created this revision. mgorny added reviewers: beanz, krytarowski. mgorny added a subscriber: lldb-commits. Use LLVM_CMAKE_PATH to spawn GetSVN.cmake rather than the source path when stand-alone build is performed, to remove the unnecessary dependency on LLVM sources and use the installed v