This revision was automatically updated to reflect the committed changes.
Closed by commit rL284893: [Test Suite] Allow overriding codesign identity
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D25714?vs=75057&id=75499#toc
Repository:
rL LLVM
https://reviews.ll
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25714
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
beanz updated this revision to Diff 75057.
beanz added a comment.
Updating to use lldbtest_config.
https://reviews.llvm.org/D25714
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_args.py
packages/Python/lldbsuite/test/lldbtest.py
test/CMakeLists.txt
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:484
+os.environ['LLDB_CODESIGN_IDENTITY'] = args.codesign_identity
+
The function is not really consistent in this aspect, but if you don't really
need this to be in the env
beanz created this revision.
beanz added reviewers: zturner, tfiala.
beanz added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.
Not everyone names their code sign identity "lldb_codesign", so it is nice to
allow this to be overridden.
https://reviews.llvm.org/D25714
Files:
pa
