This revision was automatically updated to reflect the committed changes.
Closed by commit rL284828: Improve the libstdc++ smart pointer formatters
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25726?vs=75300&id=75431#toc
Repository:
rL LLVM
https://reviews.l
tberghammer updated this revision to Diff 75300.
tberghammer marked 5 inline comments as done.
https://reviews.llvm.org/D25726
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/TestDataFormatterStdSmartPtr.py
source/Plugins/Language/C
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:138
+return 3;
+ return UINT32_MAX;
+}
labath wrote:
> I know you just copied it, but this seems wrong (size_t can be 64-bit). Will
> this work if you
granata.enrico added a comment.
I see you already got a bunch of feedback on specific items. The overall idea
looks good to me. I'll try to delve a little deeper in the code ASAP (I was out
for a couple days and have some backlog...), but should be good to go assuming
you address the feedback y
labath added a comment.
Looks good from my side. Enrico, do you want to have a look at this?
A couple tiny comments below. Also, be sure to properly reformat and reorder
the headers.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl
tberghammer added a comment.
In https://reviews.llvm.org/D25726#573127, @Eugene.Zelenko wrote:
> Please run Clang-format over new code.
I run it before upload but it mush have picked up some strange config. Will run
it again before submit. Thanks for noticing it.
https://reviews.llvm.org/D25
Eugene.Zelenko added a comment.
Please run Clang-format over new code.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:12
+
+#include
+#include
STL headers should be after application's headers.
Comment at: source/Pl
tberghammer updated this revision to Diff 75025.
tberghammer added a comment.
Herald added subscribers: mgorny, beanz.
Move the code to a new cpp file
https://reviews.llvm.org/D25726
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/T
tberghammer created this revision.
tberghammer added reviewers: labath, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Improve the libstdc++ smart pointer formatters
- Display the strong/weak count in the summary
- Display the pointed object as a synthetic member
- Create s
