This revision was automatically updated to reflect the committed changes.
Closed by commit rL289211: [LLDB][MIPS] Fix TestWatchpointIter failure
(authored by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D27124?vs=80414&id=80895#toc
Repository:
rL LLVM
https://reviews.llvm
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Great, thanks!
https://reviews.llvm.org/D27124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
nitesh.jain updated this revision to Diff 80414.
nitesh.jain added a comment.
Update diff as per suggestion
https://reviews.llvm.org/D27124
Files:
source/Target/StopInfo.cpp
Index: source/Target/StopInfo.cpp
===
--- source/Targ
jingham added a comment.
This looks fine. Can you add a comment explaining why this is necessary, it
isn't obvious right off the bat?
If this is fixing a test case, then just add a comment and this change is fine.
If the fix is test-suite neutral, then please add a test case.
https://review
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I let Jim OK this patch.
https://reviews.llvm.org/D27124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
nitesh.jain updated the summary for this revision.
nitesh.jain updated this revision to Diff 79864.
nitesh.jain added a comment.
Updated diff as per suggestion.
https://reviews.llvm.org/D27124
Files:
source/Target/StopInfo.cpp
Index: source/Target/StopInfo.cpp
==
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
I agree with Pavel, it looks like you're using a side-effect of the Ephemeral
mode to preserve something you would be better off preserving explicitly.
https://reviews.llvm.org/D2
labath resigned from this revision.
labath removed a reviewer: labath.
labath added a comment.
Jim will be a better person to review this. However, this feels like a hack to
me.
https://reviews.llvm.org/D27124
___
lldb-commits mailing list
lldb-com
omjavaid added a comment.
Although this patch fixes the test case in question but in theory EphemeralMode
watchpoint enable/disable cycles should be independent of step-over watchpoint
enable disable cycle.
On gdb-remote type targets we only update hardware_watch_id when a watchpoint
is hit so
nitesh.jain created this revision.
nitesh.jain added reviewers: clayborg, jingham, labath.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits.
In case of MIPS, the watchpoint exception occur before associated instruction
is executed. When watchpoint hit , we first enable the
10 matches
Mail list logo