[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-12-09 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289211: [LLDB][MIPS] Fix TestWatchpointIter failure (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D27124?vs=80414&id=80895#toc Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-12-06 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Great, thanks! https://reviews.llvm.org/D27124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-12-06 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 80414. nitesh.jain added a comment. Update diff as per suggestion https://reviews.llvm.org/D27124 Files: source/Target/StopInfo.cpp Index: source/Target/StopInfo.cpp === --- source/Targ

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-12-01 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. This looks fine. Can you add a comment explaining why this is necessary, it isn't obvious right off the bat? If this is fixing a test case, then just add a comment and this change is fine. If the fix is test-suite neutral, then please add a test case. https://review

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-12-01 Thread Greg Clayton via Phabricator via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I let Jim OK this patch. https://reviews.llvm.org/D27124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-30 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 79864. nitesh.jain added a comment. Updated diff as per suggestion. https://reviews.llvm.org/D27124 Files: source/Target/StopInfo.cpp Index: source/Target/StopInfo.cpp ==

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-28 Thread Jim Ingham via Phabricator via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I agree with Pavel, it looks like you're using a side-effect of the Ephemeral mode to preserve something you would be better off preserving explicitly. https://reviews.llvm.org/D2

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-25 Thread Pavel Labath via lldb-commits
labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. Jim will be a better person to review this. However, this feels like a hack to me. https://reviews.llvm.org/D27124 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-25 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added a comment. Although this patch fixes the test case in question but in theory EphemeralMode watchpoint enable/disable cycles should be independent of step-over watchpoint enable disable cycle. On gdb-remote type targets we only update hardware_watch_id when a watchpoint is hit so

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-24 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, jingham, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. In case of MIPS, the watchpoint exception occur before associated instruction is executed. When watchpoint hit , we first enable the