[Lldb-commits] [PATCH] D27258: Use Timeout<> in Process::RunThreadPlan

2016-12-01 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL288326: Use Timeout<> in Process::RunThreadPlan (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27258?vs=79737&id=79886#toc Repository: rL LLVM https://reviews.llvm.org/D272

[Lldb-commits] [PATCH] D27258: Use Timeout<> in Process::RunThreadPlan

2016-11-30 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks correct to me as well. Thanks for taking the time to clean this up. Comment at: source/Target/Process.cpp:4926-4928 +diagnostic_manager.PutString(eDiagnosti

[Lldb-commits] [PATCH] D27258: Use Timeout<> in Process::RunThreadPlan

2016-11-30 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added a reviewer: jingham. labath added a subscriber: lldb-commits. Since the function is way too big already, I tried at least to factor out the timeout computation stuff into a separate function. I've tried to make the new code semantically equivalent, and it