jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D27291
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
spyffe updated this revision to Diff 79935.
spyffe added a comment.
Updated to reflect Jim's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D27291
Files:
packages/Python/lldbsuite/test/lang/objc/unicode-string/TestUnicodeString.py
jingham added a comment.
Other than the request for a more logging, this seems fine.
Comment at: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:514-515
+ default:
+ encoding_flags = 0x0600; /* fall back to 0x0600, kCFStringEncodingASCII */
+ }
+ Constant *encoding_arg
spyffe created this revision.
spyffe added a reviewer: jingham.
spyffe added a subscriber: LLDB.
spyffe set the repository for this revision to rL LLVM.
We have a longstanding issue where the expression parser does not handle wide
CFStrings (e.g., `@"凸凹"`) correctly, producing the useless error
