This revision was automatically updated to reflect the committed changes.
Closed by commit rL291949: Fix TestRegisterVariables for linux arm/arm64 gcc
ver > 5 (authored by omjavaid).
Changed prior to commit:
https://reviews.llvm.org/D28666?vs=84257&id=84342#toc
Repository:
rL LLVM
https://r
LGTM.
Jim and I also thought this test was incredibly brittle. You really want
assembly or something that guarantees that variables will be in registers.
On Fri, Jan 13, 2017 at 1:43 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath accepted this revision.
>
> labath ad
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Seems reasonable. Maybe add a comment explaining why is that macro defined.
This test is incredibly brittle. I think we should find a better way to test
the feature, but I don't really have a
omjavaid created this revision.
omjavaid added reviewers: tfiala, labath.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
TestRegisterVariables fails with https://reviews.llvm.org/owners/package/1/
level when using gcc version 5.0 or above on arm/arm64 lin
