This revision was automatically updated to reflect the committed changes.
Closed by commit rL318903: elf-core: Split up parsing code into os-specific
functions (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D40311
Files:
kettenis added a comment.
Looks like a good improvement to me.
https://reviews.llvm.org/D40311
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath updated this revision to Diff 123898.
labath added a comment.
Update comments.
https://reviews.llvm.org/D40311
Files:
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/elf-core/ProcessElfCore.h
source/Plugins/Process/elf-core/ThreadElfCore.cpp
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:735
/// (see ELFNote structure)
/// 3) A Thread Context in a core file usually described by 3 NOTE entries.
///a) NT_PRSTATUS - Register context
krytarowski
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:735
/// (see ELFNote structure)
/// 3) A Thread Context in a core file usually described by 3 NOTE entries.
///a) NT_PRSTATUS - Register context
Can we
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:488
+ELFNote note = ELFNote();
+note.Parse(segment, );
+
clayborg wrote:
> Do we need to check anything after parsing a note here to ensure it parsed?
> Can
labath updated this revision to Diff 123816.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D40311
Files:
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/elf-core/ProcessElfCore.h
source/Plugins/Process/elf-core/ThreadElfCore.cpp
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:488
+ELFNote note = ELFNote();
+note.Parse(segment, );
+
Do we need to check anything after parsing a note here to ensure it parsed? Can
offset end up not
labath created this revision.
We've had a single function responsible for splitting a core segment
into notes, and parsing the notes themselves, bearing in mind variations
between 4 supported OS types. This commit splits that code into 5
pieces:
- (os-independent) code for splitting a segment
