[Lldb-commits] [PATCH] D41069: NPL: Clean up handling of inferior exit

2017-12-18 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320961: NPL: Clean up handling of inferior exit (authored by labath, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41069 Files:

[Lldb-commits] [PATCH] D41069: NPL: Clean up handling of inferior exit

2017-12-11 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D41069#951208, @clayborg wrote: > Is the lldb_private::Process we have an exit status in the class itself. The > first person to set the exit status wins and no one can set it twice. Doesn't > look like what we are doing here. I am not able

[Lldb-commits] [PATCH] D41069: NPL: Clean up handling of inferior exit

2017-12-11 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Is the lldb_private::Process we have an exit status in the class itself. The first person to set the exit status wins and no one can set it twice. Doesn't look like what we are doing here. I am not able to tell what actually fixes things here?

[Lldb-commits] [PATCH] D41069: NPL: Clean up handling of inferior exit

2017-12-11 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. lldb-server was sending the "exit" packet (W??) twice. This happened because it was handling both the pre-exit (PTRACE_EVENT_EXIT) and post-exit (WIFEXITED) as exit events. We had some code which was trying to detect when we've already sent the exit packet, but this