[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

2018-02-05 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324224: Resolve binary symlinks before finding its separate .debug file (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

2018-02-05 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. Looks fine, just a couple of tweaks to the test case. No need to wait for another round of review. Comment at: packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py:17 +

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

2018-02-02 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 132670. jankratochvil marked an inline comment as done. jankratochvil added a comment. Simplify the testcase by: lldbutil.run_to_name_breakpoint https://reviews.llvm.org/D42853 Files: packages/Python/lldbsuite/test/linux/sepdebugsymlink/Makefile

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

2018-02-02 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Can you fix the test case as mentioned inline. If something doesn't work please just ping me and I'll fix it. I'd like to get off propagating this boiler-plate... Comment at:

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

2018-02-02 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Makes sense for me, but make sure Pavel is ok with this as well before committing. https://reviews.llvm.org/D42853 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

2018-02-02 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. Herald added a subscriber: aprantl. I have found LLDB cannot find separate debug info of Fedora /usr/bin/gdb. It is because: lrwxrwxrwx 1 root root 14 Jan 25 20:41 /usr/bin/gdb -> ../libexec/gdb*