[Lldb-commits] [PATCH] D42868: Fix a crash in *NetBSD::Factory::Launch

2018-02-02 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski updated this revision to Diff 132689. Repository: rL LLVM https://reviews.llvm.org/D42868 Files: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Index: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp ==

[Lldb-commits] [PATCH] D42868: Fix a crash in *NetBSD::Factory::Launch

2018-02-02 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:116 static_cast(*thread).SetStoppedBySignal(SIGSTOP); - process_up->SetState(StateType::eStateStopped); Another option is to call: ``` process_up->SetSta

[Lldb-commits] [PATCH] D42868: Fix a crash in *NetBSD::Factory::Launch

2018-02-02 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. (gdb) r Starting program: /public/llvm-build/bin/lldb-server g \*:1234 -- /usr/bin/look [New process 15150] Thread 1 received signal SIGSEGV, Segmentation fault. lldb_private::NativeProcessProtocol::GetCurrentThreadID (this=0x0) at /public/llvm/tools/lld

[Lldb-commits] [PATCH] D42868: Fix a crash in *NetBSD::Factory::Launch

2018-02-02 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski created this revision. krytarowski added reviewers: labath, joerg. Herald added a subscriber: llvm-commits. krytarowski edited the summary of this revision. We cannot call process_up->SetState() inside the NativeProcessNetBSD::Factory::Launch function because it triggers a NULL pointer