asmith updated this revision to Diff 133467.
Repository:
rL LLVM
https://reviews.llvm.org/D42994
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/Makefile
packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/Makefile
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:550
#--
$(DYLIB_OBJECTS) : CFLAGS += -DCOMPILING_LLDB_TEST_DLL
I think Zachary meant only when
asmith updated this revision to Diff 133362.
asmith edited the summary of this revision.
https://reviews.llvm.org/D42994
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/Makefile
asmith updated this revision to Diff 133354.
asmith edited the summary of this revision.
https://reviews.llvm.org/D42994
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/Makefile
labath added a comment.
In https://reviews.llvm.org/D42994#999891, @zturner wrote:
> In the future when you upload diffs can you include context? (i.e. `git diff
> -U99`). It's nice to be able to see the surrounding code when I'm
> looking at a diff.
>
> Is there ever a case where you
zturner added a comment.
In the future when you upload diffs can you include context? (i.e. `git diff
-U99`). It's nice to be able to see the surrounding code when I'm looking
at a diff.
Is there ever a case where you would want to build a shared library without
`-fPIC`? I'm wondering
asmith created this revision.
asmith added reviewers: zturner, lldb-commits.
Herald added a subscriber: llvm-commits.
Update some unit tests that are passing -fPIC on Windows which is not a valid
compiler option. This is another step in making the LLDB unit tests run on
Windows.
Repository:
