This revision was automatically updated to reflect the committed changes.
Closed by commit rL325504: Add SBDebugger::GetBuildConfiguration and use it to
skip an XML test (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
jingham accepted this revision.
jingham added a comment.
Excellent, thanks.
https://reviews.llvm.org/D4
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
Looks good. Self describing and concise.
https://reviews.llvm.org/D4
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath updated this revision to Diff 134564.
labath added a comment.
I've updated the format to include a description of the item. I don't we need to
worry about the expensiveness of this data structure too much, as it should
never be used in a hot loop (the only use case I can think of is queryin
clayborg added inline comments.
Comment at: source/API/SBDebugger.cpp:497
+ auto config_up = llvm::make_unique();
+ config_up->AddBooleanItem("xml", XMLDocument::XMLEnabled());
+
Do we want a more self documenting format of the JSON? Maybe "xml" is a
dictionar
jingham accepted this revision.
jingham added a comment.
Caching this value wouldn't hurt, but the the multi-process runner will mostly
defeat that so it doesn't seem crucial.
The API is fine, the name is pretty obvious, but still some doc wouldn't hurt.
I was wondering if there was a straightf
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Think if we want to cache the configuration in case we start using this a lot
more in the test suite. Doesn't need to be done now.
Comment at: packages/Python/lldbsuite/
labath created this revision.
labath added reviewers: zturner, jingham, clayborg, davide.
This adds a SBDebugger::GetBuildConfiguration static function, which
returns a SBStructuredData describing the the build parameters of
liblldb. Right now, it just contains one entry: whether we were built
wit
