clayborg added a comment.
Pavel: I would vote for the same thing, if the test runs fine, nuke the
directory, if it fails for any reason, leave it around so we can do post
mortem. Might be nice to copy the logs over into the build directory if things
fail so it is really easy to just go into the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325690: Fix a couple of more tests to not create files in
the source tree (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
labath added a comment.
In https://reviews.llvm.org/D43506#1013276, @aprantl wrote:
> Thanks!
>
> By the way, just in case you are motivated :-), one outstanding task is also
> to replace all uses of the `clean` target in the makefiles with simply
> removing the test build directory.
I think
davide added a comment.
LGTM. This is really good work, thanks
https://reviews.llvm.org/D43506
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks!
By the way, just in case you are motivated :-), one outstanding task is also to
replace all uses of the `clean` target in the makefiles with simply removing
the test build directory
labath created this revision.
labath added reviewers: davide, aprantl.
These were not being flaky, but they're still making the tree dirty.
These tests were using lldbutil.append_to_process_working_directory to
derive the file path so I fix them by modifying the function to return
the build direc
